GNU bug report logs - #41849
[PATCH] Add frozen-bubble

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Subject: bug#41849: closed (Re: [bug#41849] [PATCH] Add frozen-bubble)
Date: Wed, 17 Jun 2020 10:06:01 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#41849: [PATCH] Add frozen-bubble

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 41849 <at> debbugs.gnu.org.

-- 
41849: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41849
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 41849-done <at> debbugs.gnu.org
Subject: Re: [bug#41849] [PATCH] Add frozen-bubble
Date: Wed, 17 Jun 2020 12:05:23 +0200

Hello,

Ludovic Courtès <ludo <at> gnu.org> writes:

> Please add a comment stating why we’re pick this revision.

Done.

>> +           (add-after 'unpack 'fix-permissions
>> +             (lambda _ (invoke "chmod" "-R" "+w" "server")))
>
> How about: (for-each make-file-writable
>                      (find-files "servers" "." #:directories? #t))

OK.

I also removed the #:module-build-flags argument in frozen-bubble
package, as it didn't seem to be necessary, and I was not sure why I had
added it in the first place.

> I can’t wait to try it again, so many years later.  :-)

Heh.

Thank you for the review. I pushed the changes.

Regards,
-- 
Nicolas Goaziou

[Message part 3 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add frozen-bubble
Date: Sun, 14 Jun 2020 14:26:41 +0200

[Message part 4 (text/plain, inline)]

Hello,

These three patches add perl-alien-sdl, perl-sdl, and, ultimately,
frozen-bubble.

Feedback welcome,

Regards,
-- 
Nicolas Goaziou

[0001-gnu-Add-perl-alien-sdl.patch (text/x-diff, attachment)]

[0002-gnu-Add-perl-sdl.patch (text/x-diff, attachment)]

[0003-gnu-Add-frozen-bubble.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.