GNU bug report logs - #41845
[PATCH] tests: lint: Add origin patch file name test cases.

Previous Next

Package: guix-patches;

Reported by: Chris Marusich <cmmarusich <at> gmail.com>

Date: Sun, 14 Jun 2020 05:35:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #8 received at 41845 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Chris Marusich <cmmarusich <at> gmail.com>
Cc: 41845 <at> debbugs.gnu.org
Subject: Re: [bug#41845] [PATCH] tests: lint: Add origin patch file name test
 cases.
Date: Sun, 14 Jun 2020 22:45:09 +0200
Hi Chris,

Chris Marusich <cmmarusich <at> gmail.com> skribis:

> From 5fa2156f8561afb87d7f9a63de0243334e9da53b Mon Sep 17 00:00:00 2001
> From: Chris Marusich <cmmarusich <at> gmail.com>
> Date: Sat, 13 Jun 2020 22:09:46 -0700
> Subject: [PATCH] tests: lint: Add origin patch file name test cases.
>
> In particular, "<origin> patches: same file name -> no warnings" would
> have caught the issue which was fixed in commit
> 21887021b9acf60157b1b0a39c16f2ec6498021b.
>
> * tests/lint.scm (patches: file names): Rename this test case...
> ("file patches: different file name -> warning"): ... to this.
> ("file patches: same file name -> no warnings")
> ("<origin> patches: different file name -> warning")
> ("<origin> patches: same file name -> no warnings"): New test cases.

LGTM.  Thanks for taking the time to write these tests!

Ludo’.




This bug report was last modified 4 years and 163 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.