From unknown Wed Jun 18 23:03:30 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#41836 <41836@debbugs.gnu.org> To: bug#41836 <41836@debbugs.gnu.org> Subject: Status: 26.3; Could we stop `help-buffer' from ever signalling errors? Reply-To: bug#41836 <41836@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:03:30 +0000 retitle 41836 26.3; Could we stop `help-buffer' from ever signalling errors? reassign 41836 emacs submitter 41836 Phil Sainty severity 41836 wishlist thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 13 09:29:20 2020 Received: (at submit) by debbugs.gnu.org; 13 Jun 2020 13:29:20 +0000 Received: from localhost ([127.0.0.1]:41077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jk6Do-0000xg-Im for submit@debbugs.gnu.org; Sat, 13 Jun 2020 09:29:20 -0400 Received: from lists.gnu.org ([209.51.188.17]:55184) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jk6Dl-0000xX-Ur for submit@debbugs.gnu.org; Sat, 13 Jun 2020 09:29:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55924) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jk6Dl-00029x-Ou for bug-gnu-emacs@gnu.org; Sat, 13 Jun 2020 09:29:17 -0400 Received: from smtp-1.orcon.net.nz ([60.234.4.34]:41427) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jk6Dk-0008DS-1P for bug-gnu-emacs@gnu.org; Sat, 13 Jun 2020 09:29:17 -0400 Received: from [101.53.216.184] (port=53304 helo=shodan) by smtp-1.orcon.net.nz with esmtpa (Exim 4.90_1) (envelope-from ) id 1jk6Dc-0007uH-FV for bug-gnu-emacs@gnu.org; Sun, 14 Jun 2020 01:29:08 +1200 User-agent: mu4e 1.4.9; emacs 26.3 From: Phil Sainty To: bug-gnu-emacs@gnu.org Subject: 26.3; Could we stop `help-buffer' from ever signalling errors? Date: Sun, 14 Jun 2020 01:29:01 +1200 Message-ID: <871rmj9js2.fsf@orcon.net.nz> MIME-Version: 1.0 Content-Type: text/plain X-GeoIP: NZ Received-SPF: pass client-ip=60.234.4.34; envelope-from=psainty@orcon.net.nz; helo=smtp-1.orcon.net.nz X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/13 09:29:09 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) At present (current master branch included), `help-buffer' returns the following: (buffer-name (if (not help-xref-following) (get-buffer-create "*Help*") (unless (derived-mode-p 'help-mode) (error "Current buffer is not in Help mode")) (current-buffer))) Is there any reason not to change it to this? (buffer-name (if (and help-xref-following (derived-mode-p 'help-mode)) (current-buffer) (get-buffer-create "*Help*"))) That way, even in unexpected situations, we can still show the user some help. My motivation is from wondering whether it was simple to display all of the function and variable symbols displayed by `so-long-commentary' as help buttons. I found that calling `help-make-xrefs' does exactly that, but then trying to use any of the buttons causes the "Current buffer is not in Help mode" error. With the suggested change I get the desirable behaviour of those help buttons popping up a help window with the relevant help. It seems to work beautifully for my use-case, and would surely be equally useful in other similar situations. Is there any good reason to maintain that error? -Phil From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 21 11:05:07 2021 Received: (at 41836) by debbugs.gnu.org; 21 Jan 2021 16:05:07 +0000 Received: from localhost ([127.0.0.1]:59133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l2cSJ-0004x1-FR for submit@debbugs.gnu.org; Thu, 21 Jan 2021 11:05:07 -0500 Received: from quimby.gnus.org ([95.216.78.240]:58998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l2cSH-0004wL-FZ for 41836@debbugs.gnu.org; Thu, 21 Jan 2021 11:05:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=a6//u1peSP0ROHfQbyV+w43mYj//kdJr6VTkyQpb4eE=; b=eiThLIUlX+yjdqn7MFLS2jQht6 rg48KE9PPjYPoI3sNEw2G3Ir3ftF59Acvfqx524qKAFDY411hcSdyerkGF7KUpNrUrsM/V0shZM0A dud2zOGDXT+jfpPdz6XcJmdSDFYbEEgJymuIVmsMO0+fUgQ/wLFIjb7LSQuHCQwDJw+0=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2cS7-0006gk-VG; Thu, 21 Jan 2021 17:04:58 +0100 From: Lars Ingebrigtsen To: Phil Sainty Subject: Re: bug#41836: 26.3; Could we stop `help-buffer' from ever signalling errors? References: <871rmj9js2.fsf@orcon.net.nz> X-Now-Playing: Richard Bone's _Third Noise Principle (Formative North American Electronica 1975-1984) (1)_: "Mambopolis" Date: Thu, 21 Jan 2021 17:04:53 +0100 In-Reply-To: <871rmj9js2.fsf@orcon.net.nz> (Phil Sainty's message of "Sun, 14 Jun 2020 01:29:01 +1200") Message-ID: <87im7q8ee2.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Phil Sainty writes: > My motivation is from wondering whether it was simple to > display all of the function and variable symbols displayed by > `so-long-commentary' as help buttons. I found that calling > `help-make-xre [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41836 Cc: 41836@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Phil Sainty writes: > My motivation is from wondering whether it was simple to > display all of the function and variable symbols displayed by > `so-long-commentary' as help buttons. I found that calling > `help-make-xrefs' does exactly that, but then trying to use any > of the buttons causes the "Current buffer is not in Help mode" > error. > > With the suggested change I get the desirable behaviour of those > help buttons popping up a help window with the relevant help. > It seems to work beautifully for my use-case, and would surely > be equally useful in other similar situations. > > Is there any good reason to maintain that error? Looking at the code, my impression is that `help-make-xrefs' is meant to be used in `help-mode' buffers only, and the `error' call is just a sanity check for that, kinda? Lifting the restriction by removing that `error' would allow other usages. I'm not sure whether they're all taken into account, though. Anybody got an opinion here? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 06 10:12:38 2022 Received: (at 41836) by debbugs.gnu.org; 6 Jun 2022 14:12:38 +0000 Received: from localhost ([127.0.0.1]:36379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyDTB-0003NF-VQ for submit@debbugs.gnu.org; Mon, 06 Jun 2022 10:12:38 -0400 Received: from quimby.gnus.org ([95.216.78.240]:40556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyDT6-0003Md-U7 for 41836@debbugs.gnu.org; Mon, 06 Jun 2022 10:12:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qf1Vs3wXevPgL1izYGB37MaiTo9kGFAuStWEruVebkc=; b=Inzw6tYFJY8Ca9R11JRJdQ7ukM dGM2jPIraLqc+CglrlI7K9pk/hQGOtVL7IoGkAzPsIs6ShhIzQJPYJ91tPn4qcVqrq0MiFVuRHQS9 pkGC+sREvdxJW2Jvd5YNzhvQ+dtpAKJWjnJ1z24oxHhOT48Fj+FJZoAG4dgd5VcqR1PE=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nyDSx-0003kn-TI; Mon, 06 Jun 2022 16:12:26 +0200 From: Lars Ingebrigtsen To: Phil Sainty Subject: Re: bug#41836: 26.3; Could we stop `help-buffer' from ever signalling errors? References: <871rmj9js2.fsf@orcon.net.nz> <87im7q8ee2.fsf@gnus.org> X-Now-Playing: !!-'s _Tuxedomooning: A Tribute_: "In The Name Of Terror (Iraqi Western 2)" Date: Mon, 06 Jun 2022 16:12:23 +0200 In-Reply-To: <87im7q8ee2.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 21 Jan 2021 17:04:53 +0100") Message-ID: <87pmjlubi0.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > Looking at the code, my impression is that `help-make-xrefs' is meant to > be used in `help-mode' buffers only, and the `error' call is just a > sanity check for that, kinda? Lifting the restriction [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41836 Cc: 41836@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen writes: > Looking at the code, my impression is that `help-make-xrefs' is meant to > be used in `help-mode' buffers only, and the `error' call is just a > sanity check for that, kinda? Lifting the restriction by removing that > `error' would allow other usages. I'm not sure whether they're > all taken into account, though. > > Anybody got an opinion here? The explanation for all this was in bug#8147, and Stephen Berman proposed an alternate fix (which Stefan agreed with). But it was never applied, so I did that in Emacs 29, which also solves this bug report, I think. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 06 10:12:41 2022 Received: (at control) by debbugs.gnu.org; 6 Jun 2022 14:12:41 +0000 Received: from localhost ([127.0.0.1]:36381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyDTC-0003NH-5I for submit@debbugs.gnu.org; Mon, 06 Jun 2022 10:12:41 -0400 Received: from quimby.gnus.org ([95.216.78.240]:40572) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyDTA-0003Mi-KX for control@debbugs.gnu.org; Mon, 06 Jun 2022 10:12:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rBu0jiOsO85IKJmZWYJ681K+9Y2MGrT3gONo58ffq6o=; b=OVPaFkt/t0BXuhttkrOznOolOn YeE4LeuTAYBbl6rUqUHBH8oXGqMMcpTrLmufT01EAuhpp0/RaO+FkMaeK4J+REzaW1hjSbxMR8OSW qzS3YHwBGRHrRcDMk6KSkEDOyXef4DsHodhBDXGD/l7G6dGMP+yC1hsmGiR/DdELtCTo=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nyDT2-0003kx-Ou for control@debbugs.gnu.org; Mon, 06 Jun 2022 16:12:30 +0200 Date: Mon, 06 Jun 2022 16:12:28 +0200 Message-Id: <87o7z5ubhv.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #41836 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 41836 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 41836 29.1 quit From unknown Wed Jun 18 23:03:30 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 05 Jul 2022 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator