GNU bug report logs - #41820
[PATCH] file-systems: Add record type <nfs-share> for a file system device.

Previous Next

Full log

View this message in rfc822 format

From: Stefan <stefan-guix <at> vodafonemail.de>
To: Danny Milosavljevic <dannym <at> scratchpost.org>, Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 41820 <at> debbugs.gnu.org
Subject: [bug#41820] [PATCH] file-systems: Add record type <nfs-share> for a file system device.
Date: Fri, 12 Jun 2020 01:43:57 +0200

Hi!

Now that the new record <nfs-share> is working and seeing the amount of changes to make this working, I get the impression that this is unnecessarily complicated.

In the end there will be the "--root=" option for the kernel, which is only a plain string. And most of the device record related functions in the end target to produce a string.

And then there is (device-string->file-system-device) in gnu/build/linux-boot.scm to convert this string back into a device record.

As long as this conversion to and from string is necessary, there is no real benefit in having different record types for (file-system (device …)), it could just be a string. Then there would only be the need for a simple parser function like (device-string->device-type) to determine the type of device to be used in places where the type matters.


Bye

Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.