GNU bug report logs - #41810
28.0.50; [ELPA] adaptive-wrap: Fontify wrap-prefix

Previous Next

Package: emacs;

Reported by: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>

Date: Thu, 11 Jun 2020 16:18:01 UTC

Severity: normal

Tags: fixed, patch

Found in version 28.0.50

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
Cc: 41810 <at> debbugs.gnu.org, Stephen Berman <stephen.berman <at> gmx.net>
Subject: bug#41810: 28.0.50; [ELPA] adaptive-wrap: Fontify wrap-prefix
Date: Thu, 11 Jun 2020 18:42:26 -0400
> The comment's continuation line starts with ";;;;".  I see two problems
> with this:
>
> 1. The padding characters are not propertized, so we get two fontified
>    semicolons, then two unfontified semicolons.

That looks ugly, indeed.  IIRC the reason is that when we extract the
prefix from the buffer, font-lock hasn't applied its `face` text
property yet.

> 2. Visually, this looks sort of cluttered.  I have searched Debbugs and
>    emacs-devel for a rationale for using (substring fcp -1) instead of
>    unconditionally using spaces, but I could not find any.

I think it just seemed like a good idea.  I suspect it's a matter of taste.
Not sure if it's important enough to justify offering both behaviors.

> See second screenshot, taken from emacs -Q -rv, with:

That's ugly, indeed.  Not sure whether the problem really comes from nor
where it should be fixed, but it's clearly a bug.


        Stefan





This bug report was last modified 4 years and 278 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.