GNU bug report logs - #41790
[PATCH] Update emacs-direnv

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#41790: closed ([PATCH] Update emacs-direnv)
Date: Fri, 06 Aug 2021 04:50:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 06 Aug 2021 00:49:52 -0400
with message-id <87sfznjhxr.fsf_-_ <at> gmail.com>
and subject line Re: bug#41790: [PATCH] Update emacs-direnv
has caused the debbugs.gnu.org bug report #41790,
regarding [PATCH] Update emacs-direnv
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
41790: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41790
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] Update emacs-direnv
Date: Wed, 10 Jun 2020 10:12:03 -0500

[Message part 3 (text/plain, inline)]

10:11 kate says: guix refresh -l emacs-direnv
No dependents other than itself: emacs-direnv <at> 2.0.0

[0001-gnu-emacs-direnv-Update-to-2.1.0.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>, 41790-done <at> debbugs.gnu.org,
 Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Subject: Re: bug#41790: [PATCH] Update emacs-direnv
Date: Fri, 06 Aug 2021 00:49:52 -0400

Hello,

Katherine Cox-Buday <cox.katherine.e <at> gmail.com> writes:

[...]

>      (build-system emacs-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'patch-in-direnv
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (let* ((direnv-path (assoc-ref inputs "direnv"))
> +                    (direnv-bin (string-append
> +                                 "\"" direnv-path "/bin/direnv\"")))
> +               (substitute* "direnv.el"
> +                 (("\"direnv\"") direnv-bin))))))))
> +    (inputs
> +     `(("direnv" ,direnv)))
>      (propagated-inputs
>       `(("dash" ,emacs-dash)
>         ("with-editor" ,emacs-with-editor)))

Thanks to Nicolas and Oleg for the thoughtful review.  They had good
comments about was propagation was not the best way to make the package
usable out of the box.  Now that the above does the same but in a
functional way, I think it is a good addition.

I applied the above hunk (the package had already been updated) as
commit 0d72f24ac084acf9d69e147a692e5d8bcb2ea21b.

Thank you!

Closing.

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.