Subject: bug#41790: closed (Re: bug#41790: [PATCH] Update emacs-direnv)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 06 Aug 2021 04:50:02 +0000

Your bug report

#41790: [PATCH] Update emacs-direnv

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
41790: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41790
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#41790: [PATCH] Update emacs-direnv
From: Maxim Cournoyer <[email-masked]>
To: Katherine Cox-Buday <[email-masked]>
Cc: Oleg Pykhalov <[email-masked]>, [email-masked], Nicolas Goaziou <[email-masked]>
Date: Fri, 06 Aug 2021 00:49:52 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

Katherine Cox-Buday <[email-masked]> writes:

[...]

>      (build-system emacs-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'patch-in-direnv
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (let* ((direnv-path (assoc-ref inputs "direnv"))
> +                    (direnv-bin (string-append
> +                                 "\"" direnv-path "/bin/direnv\"")))
> +               (substitute* "direnv.el"
> +                 (("\"direnv\"") direnv-bin))))))))
> +    (inputs
> +     `(("direnv" ,direnv)))
>      (propagated-inputs
>       `(("dash" ,emacs-dash)
>         ("with-editor" ,emacs-with-editor)))

Thanks to Nicolas and Oleg for the thoughtful review.  They had good
comments about was propagation was not the best way to make the package
usable out of the box.  Now that the above does the same but in a
functional way, I think it is a good addition.

I applied the above hunk (the package had already been updated) as
commit 0d72f24ac084acf9d69e147a692e5d8bcb2ea21b.

Thank you!

Closing.

Maxim

Subject: [PATCH] Update emacs-direnv
From: Katherine Cox-Buday <[email-masked]>
To: [email-masked]
Date: Wed, 10 Jun 2020 10:12:03 -0500
List-Id: <debbugs-submit.debbugs.gnu.org>

10:11 kate says: guix refresh -l emacs-direnv
No dependents other than itself: [email-masked]
From 22f556d67d8ec2f548859ecd20239a859d70d102 Mon Sep 17 00:00:00 2001
From: Katherine Cox-Buday <[email-masked]>
Date: Wed, 10 Jun 2020 10:09:48 -0500
Subject: [PATCH] gnu: emacs-direnv: Update to 2.1.0.

* gnu/packages/emacs-xyz.scm (emacs-direnv): Update to 2.1.0 and make direnv a
  propagated-input.
---
 gnu/packages/emacs-xyz.scm | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 946d01cba5..caeee2d828 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -166,6 +166,7 @@
   #:use-module (gnu packages sphinx)
   #:use-module (gnu packages xdisorg)
   #:use-module (gnu packages shells)
+  #:use-module (gnu packages shellutils)
   #:use-module (gnu packages sqlite)
   #:use-module (gnu packages gnupg)
   #:use-module (gnu packages video)
@@ -2020,7 +2021,7 @@ Its features are:
 (define-public emacs-direnv
   (package
     (name "emacs-direnv")
-    (version "2.0.0")
+    (version "2.1.0")
     (source
      (origin
        (method git-fetch)
@@ -2030,11 +2031,13 @@ Its features are:
        (file-name (git-file-name name version))
        (sha256
         (base32
-         "005ibyzsx1fdyrl5iyhqpb1bg83mphzahq7zvw58x00syyqi2z49"))))
+         "0xkqn4604k2imas6azy1www56br8ls4iv9a44pxcd8h94j1fp44d"))))
     (build-system emacs-build-system)
     (propagated-inputs
      `(("dash" ,emacs-dash)
-       ("with-editor" ,emacs-with-editor)))
+       ("with-editor" ,emacs-with-editor)
+       ;; Without the binary, this mode is inoperable.
+       ("direnv" ,direnv)))
     (home-page "https://github.com/wbolster/emacs-direnv")
     (synopsis "Direnv integration for Emacs")
     (description
-- 
2.26.2