From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 10 11:12:27 2020 Received: (at submit) by debbugs.gnu.org; 10 Jun 2020 15:12:27 +0000 Received: from localhost ([127.0.0.1]:35098 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj2Ox-0000un-6r for submit@debbugs.gnu.org; Wed, 10 Jun 2020 11:12:27 -0400 Received: from lists.gnu.org ([209.51.188.17]:50066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj2Ou-0000ud-S1 for submit@debbugs.gnu.org; Wed, 10 Jun 2020 11:12:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38308) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj2Ou-0006HW-Jf for guix-patches@gnu.org; Wed, 10 Jun 2020 11:12:24 -0400 Received: from mail-lj1-x231.google.com ([2a00:1450:4864:20::231]:41049) by eggs.gnu.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jj2Ot-00011w-J1 for guix-patches@gnu.org; Wed, 10 Jun 2020 11:12:24 -0400 Received: by mail-lj1-x231.google.com with SMTP id 9so2931015ljc.8 for ; Wed, 10 Jun 2020 08:12:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=mI+QPVAhkFcFKNVePQ6PMa9j6Y+zI3pEw9+FUmpsyBk=; b=PgMChshWvH2CjOW3czbCRSxO+7AjoSP1THWF1JXMzoIkhPVgWGLi4IBGuXBZT72GJp RilWdw6l9ft9F6AESPL+MlQEnwDnsktVL5001AdocQX97SRwvKE8V/fk4ngSWR6pb93x EkNnRemopGhAQ3slDuNEUCAri6vGAX4FuDW93hLes7lPxSL0QA6khaxIXNH0pJV7KriH 419Vv/G2MmeKph6iVVsf6Sptk7oEHjgZSFsmZqw0sl05aK1hQ9fafXDZfprepwkRhlta 5PcFQ+IZ3hkn5ye3SwNvRG5L7POnmXfoWMsYBNgGu39RER7+ww6zIVtPb6gWRxuBfzWH U7dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=mI+QPVAhkFcFKNVePQ6PMa9j6Y+zI3pEw9+FUmpsyBk=; b=p3buFefgz0xh4KXNrwYtIV6FwFhwZfIIraBLqUm82hiz/BCmcYv6BkRZ6ouT60A3Ck At+wacpZfiFCI5AMHC4tJqMQ8IjdjvJk7vWPky2xavnf622/bphV3tKTyx0bweurRYM7 C1ZsgbrHGmTBIzyqOYE3nfPgQiU+0pOMIV1yReVvJD5BiGgyjlk6ftc6nwRLhG3FeJ/c FdfbCqRueRSr7qNBXGP/YsmB5+nWuv76v4JuSaxw1XDWdgJOhTi9Llc7Uqcjm5l36r1a QGAqkmD9ae/6/UUZZVjZSm1LvUsG6hqPplU8xCGaVyjY9e1kybNRHiPro/NjYbaO5v/9 zc6A== X-Gm-Message-State: AOAM532MrewHge6MTPJJdaW1YQMwcdxcybvQPzwBIgFjmCTYQ8mmM51C FMjLy55FvxTMaCXJwYd3MBIOXm0Z8OLsmHjxG2PPttmi X-Google-Smtp-Source: ABdhPJzLic6D3hXlMm0GxRHmN39/2/fg9TLXK7hoLgmmcI5zaZje4TsNUeBk92QvriG4DjiCyFH3i5hsdIYe+I/xkXk= X-Received: by 2002:a2e:88ca:: with SMTP id a10mr2119435ljk.360.1591801934773; Wed, 10 Jun 2020 08:12:14 -0700 (PDT) MIME-Version: 1.0 From: Katherine Cox-Buday Date: Wed, 10 Jun 2020 10:12:03 -0500 Message-ID: Subject: [PATCH] Update emacs-direnv To: guix-patches@gnu.org Content-Type: multipart/mixed; boundary="000000000000e037ef05a7bc44bc" Received-SPF: pass client-ip=2a00:1450:4864:20::231; envelope-from=cox.katherine.e@gmail.com; helo=mail-lj1-x231.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000e037ef05a7bc44bc Content-Type: text/plain; charset="UTF-8" 10:11 kate says: guix refresh -l emacs-direnv No dependents other than itself: emacs-direnv@2.0.0 --000000000000e037ef05a7bc44bc Content-Type: text/x-patch; charset="US-ASCII"; name="0001-gnu-emacs-direnv-Update-to-2.1.0.patch" Content-Disposition: attachment; filename="0001-gnu-emacs-direnv-Update-to-2.1.0.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kb9hrigf0 RnJvbSAyMmY1NTZkNjdkOGVjMmY1NDg4NTllY2QyMDIzOWE4NTlkNzBkMTAyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLYXRoZXJpbmUgQ294LUJ1ZGF5IDxjb3gua2F0aGVyaW5lLmVA Z21haWwuY29tPgpEYXRlOiBXZWQsIDEwIEp1biAyMDIwIDEwOjA5OjQ4IC0wNTAwClN1YmplY3Q6 IFtQQVRDSF0gZ251OiBlbWFjcy1kaXJlbnY6IFVwZGF0ZSB0byAyLjEuMC4KCiogZ251L3BhY2th Z2VzL2VtYWNzLXh5ei5zY20gKGVtYWNzLWRpcmVudik6IFVwZGF0ZSB0byAyLjEuMCBhbmQgbWFr ZSBkaXJlbnYgYQogIHByb3BhZ2F0ZWQtaW5wdXQuCi0tLQogZ251L3BhY2thZ2VzL2VtYWNzLXh5 ei5zY20gfCA5ICsrKysrKy0tLQogMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgMyBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvZW1hY3MteHl6LnNjbSBiL2du dS9wYWNrYWdlcy9lbWFjcy14eXouc2NtCmluZGV4IDk0NmQwMWNiYTUuLmNhZWVlMmQ4MjggMTAw NjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy9lbWFjcy14eXouc2NtCisrKyBiL2dudS9wYWNrYWdlcy9l bWFjcy14eXouc2NtCkBAIC0xNjYsNiArMTY2LDcgQEAKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFj a2FnZXMgc3BoaW54KQogICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyB4ZGlzb3JnKQogICAj OnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBzaGVsbHMpCisgICM6dXNlLW1vZHVsZSAoZ251IHBh Y2thZ2VzIHNoZWxsdXRpbHMpCiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIHNxbGl0ZSkK ICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgZ251cGcpCiAgICM6dXNlLW1vZHVsZSAoZ251 IHBhY2thZ2VzIHZpZGVvKQpAQCAtMjAyMCw3ICsyMDIxLDcgQEAgSXRzIGZlYXR1cmVzIGFyZToK IChkZWZpbmUtcHVibGljIGVtYWNzLWRpcmVudgogICAocGFja2FnZQogICAgIChuYW1lICJlbWFj cy1kaXJlbnYiKQotICAgICh2ZXJzaW9uICIyLjAuMCIpCisgICAgKHZlcnNpb24gIjIuMS4wIikK ICAgICAoc291cmNlCiAgICAgIChvcmlnaW4KICAgICAgICAobWV0aG9kIGdpdC1mZXRjaCkKQEAg LTIwMzAsMTEgKzIwMzEsMTMgQEAgSXRzIGZlYXR1cmVzIGFyZToKICAgICAgICAoZmlsZS1uYW1l IChnaXQtZmlsZS1uYW1lIG5hbWUgdmVyc2lvbikpCiAgICAgICAgKHNoYTI1NgogICAgICAgICAo YmFzZTMyCi0gICAgICAgICAiMDA1aWJ5enN4MWZkeXJsNWl5aHFwYjFiZzgzbXBoemFocTd6dnc1 OHgwMHN5eXFpMno0OSIpKSkpCisgICAgICAgICAiMHhrcW40NjA0azJpbWFzNmF6eTF3d3c1NmJy OGxzNGl2OWE0NHB4Y2Q4aDk0ajFmcDQ0ZCIpKSkpCiAgICAgKGJ1aWxkLXN5c3RlbSBlbWFjcy1i dWlsZC1zeXN0ZW0pCiAgICAgKHByb3BhZ2F0ZWQtaW5wdXRzCiAgICAgIGAoKCJkYXNoIiAsZW1h Y3MtZGFzaCkKLSAgICAgICAoIndpdGgtZWRpdG9yIiAsZW1hY3Mtd2l0aC1lZGl0b3IpKSkKKyAg ICAgICAoIndpdGgtZWRpdG9yIiAsZW1hY3Mtd2l0aC1lZGl0b3IpCisgICAgICAgOzsgV2l0aG91 dCB0aGUgYmluYXJ5LCB0aGlzIG1vZGUgaXMgaW5vcGVyYWJsZS4KKyAgICAgICAoImRpcmVudiIg LGRpcmVudikpKQogICAgIChob21lLXBhZ2UgImh0dHBzOi8vZ2l0aHViLmNvbS93Ym9sc3Rlci9l bWFjcy1kaXJlbnYiKQogICAgIChzeW5vcHNpcyAiRGlyZW52IGludGVncmF0aW9uIGZvciBFbWFj cyIpCiAgICAgKGRlc2NyaXB0aW9uCi0tIAoyLjI2LjIKCg== --000000000000e037ef05a7bc44bc-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 10 12:11:59 2020 Received: (at 41790) by debbugs.gnu.org; 10 Jun 2020 16:11:59 +0000 Received: from localhost ([127.0.0.1]:35178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj3KZ-0004Zf-Db for submit@debbugs.gnu.org; Wed, 10 Jun 2020 12:11:59 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:45343) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj3KX-0004ZL-F3 for 41790@debbugs.gnu.org; Wed, 10 Jun 2020 12:11:58 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 855114000A; Wed, 10 Jun 2020 16:11:50 +0000 (UTC) From: Nicolas Goaziou To: Katherine Cox-Buday Subject: Re: [bug#41790] [PATCH] Update emacs-direnv References: Date: Wed, 10 Jun 2020 18:11:49 +0200 In-Reply-To: (Katherine Cox-Buday's message of "Wed, 10 Jun 2020 10:12:03 -0500") Message-ID: <871rmmoq7u.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41790 Cc: 41790@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Katherine Cox-Buday writes: > 10:11 kate says: guix refresh -l emacs-direnv > No dependents other than itself: emacs-direnv@2.0.0 > > From 22f556d67d8ec2f548859ecd20239a859d70d102 Mon Sep 17 00:00:00 2001 > From: Katherine Cox-Buday > Date: Wed, 10 Jun 2020 10:09:48 -0500 > Subject: [PATCH] gnu: emacs-direnv: Update to 2.1.0. > > * gnu/packages/emacs-xyz.scm (emacs-direnv): Update to 2.1.0 and make direnv a > propagated-input. Thank you. I wonder if propagating direnv is a good idea, tho. I understand that the Emacs library is not going to be useful if direnv is not available in user's profile. OTOH, installing this package from, e.g., M-x list-packages, wouldn't install direnv either. Moreover, I assume anyone installing this Emacs package would have direnv available already. Considering the rule of thumb is to limit propagated inputs, I suggest to remove direnv. WDYT? Regards, -- Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 10 12:26:20 2020 Received: (at 41790) by debbugs.gnu.org; 10 Jun 2020 16:26:20 +0000 Received: from localhost ([127.0.0.1]:35193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj3YR-0004wn-SW for submit@debbugs.gnu.org; Wed, 10 Jun 2020 12:26:20 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:46368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj3YP-0004wY-QR for 41790@debbugs.gnu.org; Wed, 10 Jun 2020 12:26:18 -0400 Received: by mail-io1-f65.google.com with SMTP id t9so2851642ioj.13 for <41790@debbugs.gnu.org>; Wed, 10 Jun 2020 09:26:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=k9DQRdPe+TYcyHD/7qt/DcOcxbeuAO24x/VywAMRg6E=; b=N1BBqOM5xFT0030K9LmnwVVEoPXq1MZHssFC5il4SgAH5J6EFfR5hDwBfeY5clOmEw wFnDoWGmwv06q4/rkaNa/QzDg5E31XpWs6fOYahrpK3rIoVhIQhta4a5dwdeWNFz3EXS ORc2Xm78X6Gd2/ZkWvGv2iUhRMLj/vCY+d259phu3fklQBZAR9oZQMnHB4KwoV+2nUPj gc8Z8GpUMPa1cJRV8ESIS4KPPHxF5wzyzNrq6TkMQEbYn23CZKxlfmMrBNMK2uwmsHk6 yGdaMd5wBRNptliBcmGCm25h/WY4Okj4cgt45aeS9MxolC6uWnvRZ7NzoMqsetUWcuO0 353Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=k9DQRdPe+TYcyHD/7qt/DcOcxbeuAO24x/VywAMRg6E=; b=R9LB6KmoimrEnKbKrv/VWE4zDGpaE9UCPSj0wKyu9M9rjB/cxe86v1GyUZlBR5fjYh 8CF6X0jdHJaeXyYTo32OwNSu0GrFzyaqUbEi05sBsZGrlA2m4fGOJjD6HxIZl8aUfBKT q0TFENqf0L0xCk9zEbL4aulr2hirH4ATNQQNFU/rxB/wh/q+qKxpp3C/G8tVewNZYIdZ D32vY6qz4OsGyBhzb7XzIspMExoeJomEZ97bIYJYds9N/6iNKuTJx6/AH1kvMXBRmVVF dS9HrzhyX3EQ1hPwHmpvX6xNzL7dNEa4e78haBMKWNTPDQyHBS6BiKXuj9FRsQtPt+ST iyTw== X-Gm-Message-State: AOAM530aiBJJOQXIBzMteol0JmYLsOfJ2nScOGAPI36pu9rqhKSHA6RF wReeOiFi/+wDIqdmv9qWrQwUDb97 X-Google-Smtp-Source: ABdhPJxnQlZTxICm2UCihjyHlcFEYhZO13zWQbts/9Da7UJIwqAhejpSSfqIAgjswgNy2shvqYTIRQ== X-Received: by 2002:a02:2c6:: with SMTP id 189mr3975264jau.115.1591806368674; Wed, 10 Jun 2020 09:26:08 -0700 (PDT) Received: from gazelle-pro (172-221-246-205.res.spectrum.com. [172.221.246.205]) by smtp.gmail.com with ESMTPSA id t63sm187720ill.54.2020.06.10.09.26.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2020 09:26:07 -0700 (PDT) From: Katherine Cox-Buday To: Nicolas Goaziou Subject: Re: [bug#41790] [PATCH] Update emacs-direnv References: <871rmmoq7u.fsf@nicolasgoaziou.fr> Date: Wed, 10 Jun 2020 11:26:06 -0500 In-Reply-To: <871rmmoq7u.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Wed, 10 Jun 2020 18:11:49 +0200") Message-ID: <87pna6zy3l.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41790 Cc: 41790@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Nicolas Goaziou writes: Thank you for the review! > I understand that the Emacs library is not going to be useful if > direnv is not available in user's profile. OTOH, installing this > package from, e.g., M-x list-packages, wouldn't install direnv either. The difference I see is that emacs's package manager is specifically for emacs -- not for a user's system. Guix is a package manager for a user's system which encompasses binaries and native libraries. This is one of the reasons I prefer Guix packages to various language/tool package managers because Guix can handle load paths and dependencies for me. > Moreover, I assume anyone installing this Emacs package would have > direnv available already. I did not, nor did I know that I had to until it wasn't working and I went and read the documentation. > Considering the rule of thumb is to limit propagated inputs, I suggest > to remove direnv. I disagree. If propagated inputs are not for this -- making the package even functional -- what are they for? But! I am open to discussion. -- Katherine From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 10 14:05:23 2020 Received: (at 41790) by debbugs.gnu.org; 10 Jun 2020 18:05:23 +0000 Received: from localhost ([127.0.0.1]:35304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj56I-0007Zl-F6 for submit@debbugs.gnu.org; Wed, 10 Jun 2020 14:05:23 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:40853) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj56G-0007ZT-Gd for 41790@debbugs.gnu.org; Wed, 10 Jun 2020 14:05:21 -0400 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 72F0A240006; Wed, 10 Jun 2020 18:05:13 +0000 (UTC) From: Nicolas Goaziou To: Katherine Cox-Buday Subject: Re: [bug#41790] [PATCH] Update emacs-direnv References: <871rmmoq7u.fsf@nicolasgoaziou.fr> <87pna6zy3l.fsf@gmail.com> Date: Wed, 10 Jun 2020 20:05:12 +0200 In-Reply-To: <87pna6zy3l.fsf@gmail.com> (Katherine Cox-Buday's message of "Wed, 10 Jun 2020 11:26:06 -0500") Message-ID: <87zh9alrtz.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41790 Cc: 41790@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Katherine Cox-Buday writes: > I disagree. If propagated inputs are not for this -- making the package > even functional -- what are they for? IIUC, they are to be used as a last resort, e.g., when the package cannot possibly build without them. Reason is propagated inputs pollute user's profile. E.g., someone may want to use a different direnv, and this propagated input would conflict with their package. In this case, it is reasonable to expect users to install direnv themselves. > But! I am open to discussion. I hear your arguments. I'll let maintainers decide about this, and hopefully clarify what can and cannot be propagated, at least in Emacs packages. This will be useful feedback for future reviews. Meanwhile, you can still provide a patch only bumping emacs-direnv. It is also fine in you prefer to wait. Regards, From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 10 14:31:20 2020 Received: (at 41790) by debbugs.gnu.org; 10 Jun 2020 18:31:20 +0000 Received: from localhost ([127.0.0.1]:35346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj5VQ-0008Gq-AM for submit@debbugs.gnu.org; Wed, 10 Jun 2020 14:31:20 -0400 Received: from mail-il1-f194.google.com ([209.85.166.194]:34745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj5VP-0008Ge-3J for 41790@debbugs.gnu.org; Wed, 10 Jun 2020 14:31:19 -0400 Received: by mail-il1-f194.google.com with SMTP id x18so2972377ilp.1 for <41790@debbugs.gnu.org>; Wed, 10 Jun 2020 11:31:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=/wSwh4PzrSR3tsxAP4Q2cmrzVetqVX7JfWN79H+WLPw=; b=Kvcho6yXH/HDtg4+PIAxwxJURwDKDbYb9HAWpz1Y1K3+ssG5oa9tV4uQUR61cBHJ06 DnjFDo2JmZ3ca8Y7WswqLvI4YMpk0j1Km8dEjPx7X5LgTJ2oXXMXXDBAW+Rx5b9f0fNN crCHsJsovZQHDuU6bBee0AnrfdZaf4rfpxVc/ijiK4N2W1mvzafdOedoTDF+8hN0rNgP HMDT2eER0HmwBWLpY3yAgmTYtRhnLFWgbB6ivxkydNxeoerw0GWBvcx0jf7UCZxFPJ1i R1nLAeMPUz6XAxu+49IWXvxPJDNiCr8AbxCPsmXSyoGfwMuYQu5EBIqXL2UFyWZfh7l0 kobQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=/wSwh4PzrSR3tsxAP4Q2cmrzVetqVX7JfWN79H+WLPw=; b=EQWIdj7nzIv50EUp9EgsYx78uJ3YA8MTopiZ2tWliuCffwXoozn26H8KO57TNl/Mnq ObpiQGElTjjijgMWlkBlXXBcn6GKN8WpPRBCRG79vURU3a1VZm7Tl+SF1l5HZ3sES4nZ Dbx8HyqXfXT2HHZW7RP7pxQ3tXVU3tj8KQ2GXFkecLoceqXeA2HOvZg6yqEK1Vjyoh6O O59sg5I60OIs20jEo39HNb6pdDmuwAQUO0NJEjpuVje6rqS/mJV5Um09HttSwedXK7k+ gjCJyjzDSYqf+niOlqdWb3zintf/pIktV3SaCiG4wapuU3iO4iSTg+XfsN86vFguejJx rFOw== X-Gm-Message-State: AOAM531X4FKQNQ6o1jXvn1SiO1A0kqueKSrIDe8KjBS81MlSZWAYY7Sr aghF0yehSkGDyDUiKyho6b52zYIx X-Google-Smtp-Source: ABdhPJxK5Y7ksFfIMu7y2RLKUuX3TFhYtA6xzXujsogzJcr5nEOeT4yrU+pzQ0PK1TJZV5or/JTRpQ== X-Received: by 2002:a92:dacc:: with SMTP id o12mr4545561ilq.83.1591813873135; Wed, 10 Jun 2020 11:31:13 -0700 (PDT) Received: from gazelle-pro (172-221-246-205.res.spectrum.com. [172.221.246.205]) by smtp.gmail.com with ESMTPSA id b29sm329845ioc.32.2020.06.10.11.31.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2020 11:31:11 -0700 (PDT) From: Katherine Cox-Buday To: Nicolas Goaziou Subject: Re: [bug#41790] [PATCH] Update emacs-direnv References: <871rmmoq7u.fsf@nicolasgoaziou.fr> <87pna6zy3l.fsf@gmail.com> <87zh9alrtz.fsf@nicolasgoaziou.fr> Date: Wed, 10 Jun 2020 13:31:10 -0500 In-Reply-To: <87zh9alrtz.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Wed, 10 Jun 2020 20:05:12 +0200") Message-ID: <87lfkuzsb5.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41790 Cc: 41790@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Nicolas Goaziou writes: > Katherine Cox-Buday writes: > >> I disagree. If propagated inputs are not for this -- making the package >> even functional -- what are they for? > > IIUC, they are to be used as a last resort, e.g., when the package > cannot possibly build without them. I checked the Guix manual for the intended use of propagated inputs since I didn't completely understand how what is in the runtime environment would affect the build environment. I found something which maybe is open to interpretation: "To ensure that libraries written in those languages can find library code they depend on at run time, run-time dependencies must be listed in propagated-inputs rather than inputs." Maybe a binary required to operate is no different than "library code they depend on at run time"? > Reason is propagated inputs pollute user's profile. E.g., someone may > want to use a different direnv, and this propagated input would > conflict with their package. That's another good point I hadn't considered: what if for some reason a user wants a different version of the tool (presumably provided by Guix as well)? > I'll let maintainers decide about this, and hopefully clarify what can > and cannot be propagated, at least in Emacs packages. This will be > useful feedback for future reviews. That's a good idea. I have an opinion, but it is not fully informed. I appreciate the review, conversation, and appeal to authority! > Meanwhile, you can still provide a patch only bumping emacs-direnv. It > is also fine in you prefer to wait. I'll let this one sit. The version bump was a side-effect of me believing the package should also install the tool. -- Katherine From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 10 14:46:36 2020 Received: (at 41790) by debbugs.gnu.org; 10 Jun 2020 18:46:36 +0000 Received: from localhost ([127.0.0.1]:35361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj5kC-0000Ed-CM for submit@debbugs.gnu.org; Wed, 10 Jun 2020 14:46:36 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:38748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj5kA-0000EQ-Kr for 41790@debbugs.gnu.org; Wed, 10 Jun 2020 14:46:35 -0400 Received: by mail-lf1-f66.google.com with SMTP id 202so2066738lfe.5 for <41790@debbugs.gnu.org>; Wed, 10 Jun 2020 11:46:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=+onymPwDfx1Ezi42uZheByhI32OlgTZ0GdFjuPwGwI4=; b=XdRHKa8ZxGvVWV89l3CU0Eyif9X6WLb3Ifpfu+zDd6FisHhKG0F/FKiOsy9ePv59bA xEHRKtH9So9Or0SD4g6gu10ZHcjO4ZwH1DR8nLSnHI6s6SGP6WBwiNN4GOANsA3cqFiT wFCD9DzCZ7i6Pa6GBcp7E/2REFw1Qskxr5S0lvcwUgU4DQtmY4oigwc/vW8Ya9LM2Kpr n7BB31uR4AUeVTh+/C1WSnR0mT8A5SY/NfP34Sq3OD2v4OXXO1CZKuvOzel7VKRb0WRD UH+ZrBSeyLLAh/pXac9rIS76Tt2otTC/joVrrHmdhxDTQK+JC0KPGP9J8Q2B62syYfGo fHxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=+onymPwDfx1Ezi42uZheByhI32OlgTZ0GdFjuPwGwI4=; b=IWX4MwS/ats4qyDTRj678SIsBYLnzQD686GySxu8it9ftOBFVyaOvR6UYIQe2tqp1X CW7sufDjN+BMzhtUZnaTt/J4P+wLJW5YQxP3XdnoYykPP5xmzwo4QCEkhBvs267PFewY Uo0mkqWM5aisbHBQ7WV7XiPm+7gluebWx3PyzOZ5sSF2sh17CqEkRYtUkNvkBgp6DRK1 Im6RpLM1A14YU5KKKHyGWeaPhOfpHFZg6+ozrYT3pxLBEaNXXOnAdsBZMVJIuFHoT6ge BCdXM4jFxzoNoMaijZ5k6bQIenLt1ZkQSFlIcSonv0Zm7kgpSB9S+WaGXwIgXkAWN8lW 9oPg== X-Gm-Message-State: AOAM532UcSE4u+3txS1MmCaQUzv8PiWXMkxejZV0ea54WE4AGvX396kK MaWzPubhTFMeGImW3ZhXqpnQ7kGZu4o= X-Google-Smtp-Source: ABdhPJyfQr8JVgd+5fJ6wASd1z0ck0RdDIOsiJDJEUrBlLPvHX2Tp3t81Gb7//jFIjDo6i/XbGIL7w== X-Received: by 2002:ac2:53a6:: with SMTP id j6mr2367921lfh.73.1591814788001; Wed, 10 Jun 2020 11:46:28 -0700 (PDT) Received: from guixsd (92-100-136-169.dynamic.avangarddsl.ru. [92.100.136.169]) by smtp.gmail.com with ESMTPSA id w25sm122806lfn.42.2020.06.10.11.46.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2020 11:46:23 -0700 (PDT) From: Oleg Pykhalov To: Katherine Cox-Buday Subject: Re: [bug#41790] [PATCH] Update emacs-direnv References: <871rmmoq7u.fsf@nicolasgoaziou.fr> <87pna6zy3l.fsf@gmail.com> Date: Wed, 10 Jun 2020 21:46:19 +0300 In-Reply-To: <87pna6zy3l.fsf@gmail.com> (Katherine Cox-Buday's message of "Wed, 10 Jun 2020 11:26:06 -0500") Message-ID: <87k10e92tg.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41790 Cc: 41790@debbugs.gnu.org, Nicolas Goaziou X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi. Katherine Cox-Buday writes: [=E2=80=A6] > I disagree. If propagated inputs are not for this -- making the package > even functional -- what are they for? > > But! I am open to discussion. Propagated inputs could lead to conflicts in a Guix profile. The simplest example I could remember is - you want upgrade package =E2=80=98A= =E2=80=99 which propagates =E2=80=98direnv=E2=80=99, but you cannot because package = =E2=80=98B=E2=80=99 propagates it too. In this case you need to upgrade both =E2=80=98A=E2=80=99 and =E2= =80=98B=E2=80=99 or delete =E2=80=98A=E2=80=99 (or =E2=80=98B=E2=80=99). Instead we could make the package functional by substituting in /gnu/store/=E2=80=A6-emacs-direnv-=E2=80=A6-checkout/direnv.el file =E2=80= =98direnv--detect=E2=80=99 ("Detect the direnv executable.") procedure which could return a path to =E2=80=98direnv=E2=80=99 binary as a string directly without calling =E2=80= =98executable-find=E2=80=99. WDYT? Oleg. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEcjhxI46s62NFSFhXFn+OpQAa+pwFAl7hKnsACgkQFn+OpQAa +pxIWA/+IQV4CHDpYVEgKnvfIYr5hRsOAU5Ram59F7gZjPv9GRJYXwAXv6e3vvSV Sd/a0ADdHIpOh0McGzPfS0GmaX1Zkj+j7G8bI+rThfUr3ri6G+aaX39z1/CrvSEt YAq5U3tOVPD/xlZtLpNOnFad6+oJGkokI+zbf5od7UnlWkPtBpcs2RaOJR/X2IJz uVpsw+i15sjvSetwtkEv+TAd+IroAq6gFY6URnB9Rrj0FBsSTezVpLDLWdDGAWEF 4SsJAc8DwHWtqMApEzbSr3KgniWdU4RReUcbHh956HYvVPi1kGU/W44M0jyECF9d x954cYAso4vnPMBjecYUq95+Ca9k9Ke8tq1ApWGMbEh7hXNY6Q76X+9r9u6jenz/ PIZIi67VL8pJTKOcQdvrcbWHoKaAv+PeRTgLmSYSupsscE8q5O15moW4BPJPWUIC chbxvjlU3byur903Nj57vzcNZBavQ+68VS8vnsYXb/dd9Njvme6WzjrEf3V20//c Uqt7dgqmmXWnofo9DEWS1efvrAliYZAAFNjtvxxNW6KFImiCSuu9wcqvEUyvfI9S YFJ+iRNPMKC67PDi0ayRgTg1fdXGrYGaEnDXZ/8pkdOeG071FCIVjCNnO8Idd236 ci2Sfy928chQNxTJFq2ZMeoLFVSQex4ALuGbaHbFWd6M+8oiu90= =ATie -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 11 10:44:45 2020 Received: (at 41790) by debbugs.gnu.org; 11 Jun 2020 14:44:46 +0000 Received: from localhost ([127.0.0.1]:37637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jjORh-0004OH-L8 for submit@debbugs.gnu.org; Thu, 11 Jun 2020 10:44:45 -0400 Received: from mail-io1-f68.google.com ([209.85.166.68]:45436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jjORg-0004O3-HL for 41790@debbugs.gnu.org; Thu, 11 Jun 2020 10:44:44 -0400 Received: by mail-io1-f68.google.com with SMTP id y5so6522819iob.12 for <41790@debbugs.gnu.org>; Thu, 11 Jun 2020 07:44:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=9J1Ro+q/AB0heaDGwa8f9LbX6NCpr3gRK6XfQIyiS9U=; b=IIRm0E1w8YSIFv6wNSUp4r60mGL/8LpSGep13wMQ85FXWXUgp3rBs4xUhhgrIlhpp4 D669WfLVnV2+fT3TlPzdeoWhlieHgqvo7mgFglIAlf7r0J6IE0b8j0sMLDm30sQEvzVy 5yIteEdl61UKcFQ3TR5wVXgUZsOIRpbfEqSWvfBLWvXjDbEFNvBbnNHrn5rcnuTakegM /SALkHtax5sZishXpe5erooFZy/jsZwX6v0676n65FFdrD5nEE0X2C+7EBlDQ0litQAp hgYZBRGFMx6ZRyhKFmpd2C93OCb6kCK5ww7EBEJDUs9q37JEGghlAgg1gc0iBRCsZqzo SAsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=9J1Ro+q/AB0heaDGwa8f9LbX6NCpr3gRK6XfQIyiS9U=; b=T9iYfDh3l+KJtr2Qp7HusMawuC02R+1UNvihRyQJ1ixCtzvfMxnH7V/fQiJqCebaSS cFUZKslD4o4Mh8iqEeQ8oT1y+9tpQlXD0SX60zlHuPO2hNRBChLvCwNujEXzIl5OkCle BrotKVq38W7kW8wY5BJT8dgJF0p6V3ytsZgv701lF0tII8blVDftUNqqq0j6/S3mKAY5 hya8Qjr95F7DR/3tex2G6sMywQNBc43eulWxXPzLcUvgEM6I1RAgEZQO4usQ5IWIgAdo y6x7unC8HYf153IJKVlR1l+kEfOtZoG8GPjceGnXSfNWnNX5fdDMeij+e2/sJetY8oY8 EJig== X-Gm-Message-State: AOAM5315mvExLqK1ooIGiCN/OS083XZlNuShBx2I8hbHuDAVyMP/jkc3 KpogjrYNS54uxtD0KnwA7FBq0rdC X-Google-Smtp-Source: ABdhPJz+qooeOsIy9gLH+dMdwjt+Z0yNZ/1TrQ+7CTVJKulKJnkZ02MaSXG4+A4GmVEe+DpU2rqwRw== X-Received: by 2002:a5d:860a:: with SMTP id f10mr8841851iol.11.1591886678438; Thu, 11 Jun 2020 07:44:38 -0700 (PDT) Received: from gazelle-pro (172-221-246-205.res.spectrum.com. [172.221.246.205]) by smtp.gmail.com with ESMTPSA id g15sm1594544ilq.39.2020.06.11.07.44.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2020 07:44:36 -0700 (PDT) From: Katherine Cox-Buday To: Oleg Pykhalov Subject: Re: [bug#41790] [PATCH] Update emacs-direnv References: <871rmmoq7u.fsf@nicolasgoaziou.fr> <87pna6zy3l.fsf@gmail.com> <87k10e92tg.fsf@gmail.com> Date: Thu, 11 Jun 2020 09:44:35 -0500 In-Reply-To: <87k10e92tg.fsf@gmail.com> (Oleg Pykhalov's message of "Wed, 10 Jun 2020 21:46:19 +0300") Message-ID: <87eeql8xws.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41790 Cc: 41790@debbugs.gnu.org, Nicolas Goaziou X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Oleg Pykhalov writes: Heya Oleg, thanks for chiming in. > Propagated inputs could lead to conflicts in a Guix profile. The > simplest example I could remember is - you want upgrade package =E2=80=98= A=E2=80=99 > which propagates =E2=80=98direnv=E2=80=99, but you cannot because package= =E2=80=98B=E2=80=99 propagates > it too. In this case you need to upgrade both =E2=80=98A=E2=80=99 and = =E2=80=98B=E2=80=99 or delete =E2=80=98A=E2=80=99 > (or =E2=80=98B=E2=80=99). Would there be a conflict if they both propagated the same input (in this case the direnv binary)? > Instead we could make the package functional by substituting in > /gnu/store/=E2=80=A6-emacs-direnv-=E2=80=A6-checkout/direnv.el file =E2= =80=98direnv--detect=E2=80=99 > ("Detect the direnv executable.") procedure which could return a path to > =E2=80=98direnv=E2=80=99 binary as a string directly without calling =E2= =80=98executable-find=E2=80=99. > WDYT? In general, I like to keep packages as close to their source as possible, but I'm slowly learning that this is not often the case when packaging things (which is a shame and a risk in my opinion). But all things considered, I think this is probably the right approach here given the feedback I'm getting. Here's a patch which should supersede the previous patch: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-emacs-direnv-Update-to-2.1.0.patch >From 52a5541b8a44c6629f6e2a6d3d47184f2ed5169b Mon Sep 17 00:00:00 2001 From: Katherine Cox-Buday Date: Wed, 10 Jun 2020 10:09:48 -0500 Subject: [PATCH] gnu: emacs-direnv: Update to 2.1.0. * gnu/packages/emacs-xyz.scm (emacs-direnv): Update to 2.1.0 and make direnv a propagated-input. --- gnu/packages/emacs-xyz.scm | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 946d01cba5..6eb5bc9d39 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -166,6 +166,7 @@ #:use-module (gnu packages sphinx) #:use-module (gnu packages xdisorg) #:use-module (gnu packages shells) + #:use-module (gnu packages shellutils) #:use-module (gnu packages sqlite) #:use-module (gnu packages gnupg) #:use-module (gnu packages video) @@ -2020,7 +2021,7 @@ Its features are: (define-public emacs-direnv (package (name "emacs-direnv") - (version "2.0.0") + (version "2.1.0") (source (origin (method git-fetch) @@ -2030,8 +2031,20 @@ Its features are: (file-name (git-file-name name version)) (sha256 (base32 - "005ibyzsx1fdyrl5iyhqpb1bg83mphzahq7zvw58x00syyqi2z49")))) + "0xkqn4604k2imas6azy1www56br8ls4iv9a44pxcd8h94j1fp44d")))) (build-system emacs-build-system) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'patch-in-direnv + (lambda* (#:key inputs #:allow-other-keys) + (let* ((direnv-path (assoc-ref inputs "direnv")) + (direnv-bin (string-append + "\"" direnv-path "/bin/direnv\""))) + (substitute* "direnv.el" + (("\"direnv\"") direnv-bin)))))))) + (inputs + `(("direnv" ,direnv))) (propagated-inputs `(("dash" ,emacs-dash) ("with-editor" ,emacs-with-editor))) -- 2.26.2 --=-=-= Content-Type: text/plain Thank you both for your thoughtful reviews! -- Katherine --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 11 16:03:51 2020 Received: (at 41790) by debbugs.gnu.org; 11 Jun 2020 20:03:51 +0000 Received: from localhost ([127.0.0.1]:38172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jjTQV-0006Zp-Hz for submit@debbugs.gnu.org; Thu, 11 Jun 2020 16:03:51 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:37271) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jjTQT-0006Zb-Bg for 41790@debbugs.gnu.org; Thu, 11 Jun 2020 16:03:49 -0400 Received: by mail-lf1-f67.google.com with SMTP id x22so4213205lfd.4 for <41790@debbugs.gnu.org>; Thu, 11 Jun 2020 13:03:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=QXv3bSYsM8Q+DzWPQBJCc+PZQRHdKbPDXQ128xHHa94=; b=r2wWlsrkmGEB0x3BHfqzm0KrGvLQQP4L2uf6p1Dcy0xa6wwi62doZ6/zFFOWIz4d5Q nCILaGZ5yT0BxeH5uibikWd0OkCiaqxcuxsKxtlXhMYOpWtYXXBNHVyOEKwEFhfEjGOx j5rjgpllWpMf3UE3pP0UoxmNLlNmlBZqqPBWHbR0pQ8l7W7Jo+Mqup7qvUWH2ZnrG2mX gEdgsDqHnjR3tdm68tsMg4F8Qdwq1kHHMRucRM71HXdJbURxOFgcbsmI1EYG2xd7NnkU +E9TwF54Z0L7oGpN2hrCvWH/OyPdsRItDBftDpNrx2A+lUh7QolencBLixusKnT/B5xq 0uxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=QXv3bSYsM8Q+DzWPQBJCc+PZQRHdKbPDXQ128xHHa94=; b=jFnHnucjUzG+8dOo0mnBXljjK+B279Il+naBYbEBH9T4O+yMXUgMwKzfdr7pVQyoGA fJVnf3Zno9u2ZeHjFrDpghILmu+JEYtsEbQ6SKqCkTEUUyIEfn6ZwryIXGLUa5FK6mdX byA96MDXURZsXGG2NS6xlgqSf1jWCsad13DvGS2D1IM+kGFYZJ5wL2axzbkWB/9XmKKX 2zHCA/y+FjdznOKCb2xfLylA/kjtIrgw5rlud7Q6bxj17o+QEYJOA8TRtHcvpOLP1+Fj JjogvXpoqFKieyzAdbX3JDXvwRSBQ85/zXJj8i0rlRvlgbF7o0pYWUYa92Cv74u9CRCx OLow== X-Gm-Message-State: AOAM5313nJbXd8T4NcMKfBQembRktOOoRThiFAmkqZuCS/g+84tV12Wz XeA/9qN/A0qr6gWvhdcTJm72Mnxe X-Google-Smtp-Source: ABdhPJxUUR3+seqlR4ig1sCpx1WsOc4yWFJkwLWtf/yurAmcgwtTbtHm8XgPlf/lZlJrc0h2jL9nPA== X-Received: by 2002:a19:f508:: with SMTP id j8mr4938608lfb.146.1591905822762; Thu, 11 Jun 2020 13:03:42 -0700 (PDT) Received: from guixsd (92-100-136-169.dynamic.avangarddsl.ru. [92.100.136.169]) by smtp.gmail.com with ESMTPSA id y12sm959629ljh.79.2020.06.11.13.03.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2020 13:03:41 -0700 (PDT) From: Oleg Pykhalov To: Katherine Cox-Buday Subject: Re: [bug#41790] [PATCH] Update emacs-direnv References: <871rmmoq7u.fsf@nicolasgoaziou.fr> <87pna6zy3l.fsf@gmail.com> <87k10e92tg.fsf@gmail.com> <87eeql8xws.fsf@gmail.com> Date: Thu, 11 Jun 2020 23:03:37 +0300 In-Reply-To: <87eeql8xws.fsf@gmail.com> (Katherine Cox-Buday's message of "Thu, 11 Jun 2020 09:44:35 -0500") Message-ID: <87sgf174km.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41790 Cc: 41790@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Katherine Cox-Buday writes: >> Propagated inputs could lead to conflicts in a Guix profile. The >> simplest example I could remember is - you want upgrade package =E2=80= =98A=E2=80=99 >> which propagates =E2=80=98direnv=E2=80=99, but you cannot because packag= e =E2=80=98B=E2=80=99 propagates >> it too. In this case you need to upgrade both =E2=80=98A=E2=80=99 and = =E2=80=98B=E2=80=99 or delete =E2=80=98A=E2=80=99 >> (or =E2=80=98B=E2=80=99). > > Would there be a conflict if they both propagated the same input (in > this case the direnv binary)? No conflict for the same input. ;-) > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > index 946d01cba5..6eb5bc9d39 100644 > --- a/gnu/packages/emacs-xyz.scm > +++ b/gnu/packages/emacs-xyz.scm > @@ -166,6 +166,7 @@ > #:use-module (gnu packages sphinx) > #:use-module (gnu packages xdisorg) > #:use-module (gnu packages shells) > + #:use-module (gnu packages shellutils) > #:use-module (gnu packages sqlite) > #:use-module (gnu packages gnupg) > #:use-module (gnu packages video) > @@ -2020,7 +2021,7 @@ Its features are: > (define-public emacs-direnv > (package > (name "emacs-direnv") > - (version "2.0.0") > + (version "2.1.0") > (source > (origin > (method git-fetch) > @@ -2030,8 +2031,20 @@ Its features are: > (file-name (git-file-name name version)) > (sha256 > (base32 > - "005ibyzsx1fdyrl5iyhqpb1bg83mphzahq7zvw58x00syyqi2z49")))) > + "0xkqn4604k2imas6azy1www56br8ls4iv9a44pxcd8h94j1fp44d")))) Could you send a separate patch for direnv update, please? > (build-system emacs-build-system) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'patch-in-direnv > + (lambda* (#:key inputs #:allow-other-keys) > + (let* ((direnv-path (assoc-ref inputs "direnv")) > + (direnv-bin (string-append > + "\"" direnv-path "/bin/direnv\""))) > + (substitute* "direnv.el" > + (("\"direnv\"") direnv-bin)))))))) > + (inputs > + `(("direnv" ,direnv))) > (propagated-inputs > `(("dash" ,emacs-dash) > ("with-editor" ,emacs-with-editor))) > --=20 > 2.26.2 This will make the following change: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=out.diff Content-Transfer-Encoding: quoted-printable Content-Description: diff =2D-- /gnu/store/lxi6pqc97fc17v5gkk1pmcq8fazn85sx-emacs-direnv-2.1.0/share/= emacs/site-lisp/direnv.el 1970-01-01 03:00:01.000000000 +0300 +++ /gnu/store/f7z69fmfijf9babkk2r4lfaljk4rck4h-emacs-direnv-2.1.0/share/em= acs/site-lisp/direnv.el 1970-01-01 03:00:01.000000000 +0300 @@ -30,7 +30,7 @@ =20 (defun direnv--detect () "Detect the direnv executable." =2D (executable-find "direnv")) + (executable-find "/gnu/store/qj4p17czqbmwjx56h7jbf1c245kp8p47-direnv-2.1= 5.2/bin/direnv")) =20 (defvar direnv--output-buffer-name "*direnv*" "Name of the buffer filled with the last direnv output.") @@ -99,7 +99,7 @@ (erase-buffer) (let* ((default-directory directory) (process-environment environment) =2D (exit-code (call-process "direnv" nil `(t ,stderr-tempf= ile) nil "export" "json")) + (exit-code (call-process "/gnu/store/qj4p17czqbmwjx56h7jb= f1c245kp8p47-direnv-2.15.2/bin/direnv" nil `(t ,stderr-tempfile) nil "expor= t" "json")) (json-key-type 'string)) (prog1 (unless (zerop (buffer-size)) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable In the first hunk we don't need a =E2=80=98executable-find=E2=80=99 call on =E2=80=98/gnu/store/=E2=80=A6-direnv-=E2=80=A6/bin/direnv=E2=80=99. The second hunk is not good, because it will require to redefine both direnv--detect and direnv--export in case user needs a custom direnv binary. direnv--export on upstream's master branch is different in way we could avoid the second hunk. Could you take a look on this? Thanks, Oleg. --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEcjhxI46s62NFSFhXFn+OpQAa+pwFAl7ijhkACgkQFn+OpQAa +pwatQ//aqmz/EdEvwIFT7Xm+a6kmlK1vqxrt8kVw/C/ZBqCuSYW/FnkS6lHSu4t OVLNuXBLGTKMEKVi9y6VD7p/Y3C+20rTeAs9onJySR7iJxHfbOSCnk9ZyfA0/0Ix E/VEbMHuxiV8wmwPwmm5ki/iXrhFU7XJtkzCXXiQP5oLElMECXKCFLeFslUl4s42 gpgdqTKibUgIeDzcOzXeacJb8VTMc1eugvV17Lo3LwWGsGeyZj4LYbHCEEfrQQfr 9F7P7wM1JnPI3BEF0xLLHDQtLPzR8w4SnJKfTSXufefscx3UdUyoNHdzD3WFIZtf 0rQ1xeQzWSBdsafP9wMcJ8rLYAXCuR5n/5VkSRKerN5w8SnAlE+f/Y3J0f/0Loct xOJoG8/g865cxdANHqgh1dCM03HahwtuwrScUDTbcLE4I9D/oogfeWXH481r/YZ4 aHm56e6guueWBd61sqgrotcs7VdhG1WSVzhnPY32MKhd1yhdQywrXwNmC4BnaIFs c9kmpbDC/bcLmUmX4mAr5KLbnzrnSj0kHlqsBHjFVS+j6u9fQ+bUfdU4937bkW5c kAyljJ5+Hwm2b1/bIB6qbBwD5G/j71ghCyn4QLs59oGE0meVkXMNLh2D62guvxGG Ho5BMUFM6xZ0XOpM5XzM4kypfI11tS8du8VULzDID/gkmBnOOnU= =aT1b -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 11 16:32:57 2020 Received: (at 41790) by debbugs.gnu.org; 11 Jun 2020 20:32:57 +0000 Received: from localhost ([127.0.0.1]:38195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jjTsf-0007Hx-3T for submit@debbugs.gnu.org; Thu, 11 Jun 2020 16:32:57 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:38983) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jjTsd-0007Hi-E0 for 41790@debbugs.gnu.org; Thu, 11 Jun 2020 16:32:55 -0400 Received: by mail-lj1-f194.google.com with SMTP id a9so8542859ljn.6 for <41790@debbugs.gnu.org>; Thu, 11 Jun 2020 13:32:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=0OCVT7R4n1xIZO0O6jMh3bChCq+O5ItXjJEMMmN1V+k=; b=MI2HLaKCr/L7+nH2PqMANsGn2C7R7Al6bffsMl3yxhC/5ltq383Qiwk/tP/w9dz+0G SY+YOh2IUJQqFHSBH2P/P2mjWSZs82r8PglOY7/GbQ2WltPhA3ihMBO/AVimtJFObykS mBC8HPw7NVnUxUInXrYV++pqW/lIDT4qF9tduUFpdFEDENNhQMIatGO+hTQIZMH0BUq9 Edmx56MB+izSIWsKnfb8cH1lff4bDVQFjtwdiavoXEI1Rq+edT0Mqd9RdMNKOGYnJYhT rE6TJWV9HnSk+CDfzOwGLK1kkBQ6I0WHgzRrFNTH75+8ZLPAIckxQ5ky7Xs2OS0JFnM+ MqiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=0OCVT7R4n1xIZO0O6jMh3bChCq+O5ItXjJEMMmN1V+k=; b=nJgNgKrL7vHzAdgGWDOKBPs0NClGX5E99HAXrL152i6Wlo/Daou6WWemi5vBXkMcy4 63omQXzhMvPsdsvbuQh/SR/crReOzg40IPZTMNJkwR4sMTC0Ww8z9s48JO8xSVZekrdI Pbg5+IoECtVTvsTKuV8YntviTLalKGPiYkjPLX4djMggfZfLn2G8LdCWvF6sEqYukWJK KhX2OvVM3ALDEjBGcuvNkzJfcXK9W3sQ+PIhSIiwBpFoRiSPOu0ZEsd3cUwk3stv+k1J Bahvhh59k2keeldLG3F5YgZ01DOWan1+AsZo12FxeB3quYhPR4nRa0D5sZlNtV2bFZKE VwWA== X-Gm-Message-State: AOAM532rVdzxAIugCxvo82f46O544UYC5tfLqye8sSDLR8Ac0BD1+hKQ URmYrN2mgG3MopGE06NQtwURD29b X-Google-Smtp-Source: ABdhPJw0eQGhzSgAcWN/MjPCvsPDnyETHHu5juN9eO1o6bojunuFAaubbcYODJHbPld5cPctZ9Zkbw== X-Received: by 2002:a05:651c:2cc:: with SMTP id f12mr5003283ljo.329.1591907568956; Thu, 11 Jun 2020 13:32:48 -0700 (PDT) Received: from guixsd (92-100-136-169.dynamic.avangarddsl.ru. [92.100.136.169]) by smtp.gmail.com with ESMTPSA id y18sm1098018lfk.16.2020.06.11.13.31.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2020 13:32:03 -0700 (PDT) From: Oleg Pykhalov To: Katherine Cox-Buday Subject: Re: [bug#41790] [PATCH] Update emacs-direnv References: <871rmmoq7u.fsf@nicolasgoaziou.fr> <87pna6zy3l.fsf@gmail.com> <87k10e92tg.fsf@gmail.com> <87eeql8xws.fsf@gmail.com> Date: Thu, 11 Jun 2020 23:31:29 +0300 In-Reply-To: <87eeql8xws.fsf@gmail.com> (Katherine Cox-Buday's message of "Thu, 11 Jun 2020 09:44:35 -0500") Message-ID: <87o8pp73a6.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41790 Cc: 41790@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Katherine Cox-Buday writes: [=E2=80=A6] > In general, I like to keep packages as close to their source as > possible, but I'm slowly learning that this is not often the case when > packaging things (which is a shame and a risk in my opinion). > > But all things considered, I think this is probably the right approach > here given the feedback I'm getting. It depends. If you take a look on magit-git-executable commentary, it specifically doesn't use a full path to git binary, because of remote systems could have it in different locations. Does emacs-direnv could be used on remote machines? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEcjhxI46s62NFSFhXFn+OpQAa+pwFAl7ilKEACgkQFn+OpQAa +pwHHRAAo9fC76RWnT+NgXAQ8SA3Y+LW4NoVBiNNY4SPH4/cic1uBdCjmW4Ajf8h EwuMhU0coYYhkFkEPNxrNs/q750YTOBqduOGdrJMjXlJ3c/0ZRvJD5abwmBooaLz kXR607o/IWkzdLhG9vXdMTjXfkYTO5Inz59jIbzK6xNFioJgUFVA6FkvuOoz/dbt Tmto+WgAMyitEja273PjnuAKsgCKuzuSnSZY/QC6Onwpk9FzzfBT7q/xG0Bvii66 EcxIIz3UTbi66latTR1kmFJ9+A999Coeudp4DeztRTTyVm6tSUrYNlcP+/CuZfs5 ZrDwMai6wnpayeQcFq6JX+QrA332DMzKNkqPgo++FhMd2TIhl/8r2AcGky0YNUa+ nUQ9wUMky5VANg6uBocDzNyO8haoILKnXif1E5oZQLgBdek9jHuCn037s6z2sT0Q WUswX6u30Gk2IWGAMLLZaBKlbkaWzcuCDdClrj9Hln8ANtM8zYYhVA2FBTln9u1N 3evdtgK1b/41Nm8hoD6TmgBCb1p0vx+YDL3gynaRtM6Zbp9euWAFiSyKsi+T+dWv 1dnuzTcovd8Dv4NL8nPv1R19AAYiIuEwXBQ4hiktcr+iM0bRO8Ss+d2Eoxp1xHlt L75yR1RQR23ehCkzyxhyPrLhTlwNqsY3Nysq208KeN3e4ZX5zu4= =vLiw -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 06 00:50:01 2021 Received: (at 41790-done) by debbugs.gnu.org; 6 Aug 2021 04:50:01 +0000 Received: from localhost ([127.0.0.1]:48861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBro0-00025v-Ur for submit@debbugs.gnu.org; Fri, 06 Aug 2021 00:50:01 -0400 Received: from mail-qt1-f175.google.com ([209.85.160.175]:34649) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBrnz-00025i-IB for 41790-done@debbugs.gnu.org; Fri, 06 Aug 2021 00:49:59 -0400 Received: by mail-qt1-f175.google.com with SMTP id e15so2950463qtx.1 for <41790-done@debbugs.gnu.org>; Thu, 05 Aug 2021 21:49:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=1jutYLmFpHAW49hlNvnX2jbYIX9F/HaAzAtApBtcpio=; b=RnfrjqRM9g5y9qze6+Cp36YqWqaeIkOIPtlqqKNJqaFdIEKEJ6yFcVCRQMH4GdSNsd jHUxc5pFFxRf1BHOIkwkwlU1u7OBR8l8ZaVOFreuLKjro3sLXMjWwc5Y7TvvSSJ4L0wD 3zqlR/T5EuKSNF4wa5+zQnhnmku1tR/U5ognztRZM+RFTGFBT9/2aO3ea77a1+0nMDUj gyOfzENo4T5Se68sSf+shl5tdLdWFDIUCgpGIEwFfx5F86uQ0Ra5veTlBkpADd5BvIuL 6wDJd5b2BdX4xg0/+rsjz268ax7ESUqIvGkLmbXCmw67e7OhCVVBJ7VTMtY7oJXn7uwB hc4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=1jutYLmFpHAW49hlNvnX2jbYIX9F/HaAzAtApBtcpio=; b=baeuoysG36t/kTq88gyvo2SM77yUO5LZicrxEoUdcR3ebAkRAfC2Ig4ufOE6Nj2qSV qdRA+fLNkCC7C1/uzQtORRSxCINWggpTNxTOym5nWfpq992sVxIv/zQn//EvyOGFwIpp ISroN+cWOR5qUba4R9BG9ccvydTTfZEcyfiRj8URTHBaGk1w/X4HxG5eBNSiK6JhHRSX 9VQaaLhN6jlJZtj1HBYwgvyFaO3UaQZRJojurQ5FRxzWS342iExv+4Rzl9CAAvoqvvT8 L6IJTNu+YW0rm3Jz4pQddn0inaoS1l5QH08ZO3FIkz+LwATG2SNd9yXn8nbcbJ6h0Cfp VLyQ== X-Gm-Message-State: AOAM533y232fxqVXjzNVcRBqt3vXZz98B1yVVZ/2P/gSs4kaNXx/hj4J kXUE5I7bheQQ2Q9BaDBQ/bE= X-Google-Smtp-Source: ABdhPJyMNaCRBqRCxuhO3oKQzW5MU5nLCAG4N/dldTGK37qdW1dvMXs+UKrhlI2vaZGRW885521DSA== X-Received: by 2002:ac8:7e86:: with SMTP id w6mr7647540qtj.194.1628225394012; Thu, 05 Aug 2021 21:49:54 -0700 (PDT) Received: from hurd (dsl-151-109.b2b2c.ca. [66.158.151.109]) by smtp.gmail.com with ESMTPSA id x14sm3099120qts.13.2021.08.05.21.49.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Aug 2021 21:49:53 -0700 (PDT) From: Maxim Cournoyer To: Katherine Cox-Buday Subject: Re: bug#41790: [PATCH] Update emacs-direnv References: <871rmmoq7u.fsf@nicolasgoaziou.fr> <87pna6zy3l.fsf@gmail.com> <87k10e92tg.fsf@gmail.com> <87eeql8xws.fsf@gmail.com> Date: Fri, 06 Aug 2021 00:49:52 -0400 In-Reply-To: <87eeql8xws.fsf@gmail.com> (Katherine Cox-Buday's message of "Thu, 11 Jun 2020 09:44:35 -0500") Message-ID: <87sfznjhxr.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41790-done Cc: Oleg Pykhalov , 41790-done@debbugs.gnu.org, Nicolas Goaziou X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Katherine Cox-Buday writes: [...] > (build-system emacs-build-system) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'patch-in-direnv > + (lambda* (#:key inputs #:allow-other-keys) > + (let* ((direnv-path (assoc-ref inputs "direnv")) > + (direnv-bin (string-append > + "\"" direnv-path "/bin/direnv\""))) > + (substitute* "direnv.el" > + (("\"direnv\"") direnv-bin)))))))) > + (inputs > + `(("direnv" ,direnv))) > (propagated-inputs > `(("dash" ,emacs-dash) > ("with-editor" ,emacs-with-editor))) Thanks to Nicolas and Oleg for the thoughtful review. They had good comments about was propagation was not the best way to make the package usable out of the box. Now that the above does the same but in a functional way, I think it is a good addition. I applied the above hunk (the package had already been updated) as commit 0d72f24ac084acf9d69e147a692e5d8bcb2ea21b. Thank you! Closing. Maxim From unknown Sat Jun 21 03:25:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 03 Sep 2021 11:24:11 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator