GNU bug report logs - #41785
[PATCH] DRAFT services: Add 'hurd-in-vm service-type'.

Previous Next

Package: guix-patches;

Reported by: "Jan (janneke) Nieuwenhuizen" <janneke <at> gnu.org>

Date: Wed, 10 Jun 2020 08:55:02 UTC

Severity: normal

Tags: patch

Done: Jan Nieuwenhuizen <janneke <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

Message #68 received at 41785 <at> debbugs.gnu.org (full text, mbox):

From: Jan Nieuwenhuizen <janneke <at> gnu.org>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 41785 <at> debbugs.gnu.org, Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: [bug#41785] [PATCH v3 1/2] image: Make 'find-image' non-monadic.
Date: Sat, 13 Jun 2020 15:05:11 +0200

Mathieu Othacehe writes:

Hey Mathieu,

>>                         (system (current-system))
>>                         (target (operating-system-derivation target-os))
>> -                       (base-image (find-image
>> -                                    installation-disk-image-file-system-type))
>> +                       (base-image -> (find-image
>> +                                       installation-disk-image-file-system-type
>> +                                       (%current-target-system)))
>
> This should be:
>
> (target (current-target-system))
> ...
> (base-image -> (find-image
>                 installation-disk-image-file-system-type
>                 target))

Ah, right.  Done and moved this

>>                         (target (operating-system-derivation target-os))

down.

>> +      ((image ->  (find-image file-system-type (%current-target-system)))
>>         (sys       (system-derivation-for-action os image action
>>                                                  #:file-system-type file-system-type
>>                                                  #:image-size image-size
>
> Same here, otherwise this look good to me.

Thanks!  Pushed to master as 7ca533c7237622d70b423033c4506217d9ce4014

(probably/hopefully soon to be revisited by your image-catalog feature :-)

Greetings,
Janneke

-- 
Jan Nieuwenhuizen <janneke <at> gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com
This bug report was last modified 4 years and 341 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.