GNU bug report logs - #41785
[PATCH] DRAFT services: Add 'hurd-in-vm service-type'.

Previous Next

Full log

Message #62 received at 41785 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: "Jan \(janneke\) Nieuwenhuizen" <janneke <at> gnu.org>
Cc: 41785 <at> debbugs.gnu.org, Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: [bug#41785] [PATCH v3 1/2] image: Make 'find-image' non-monadic.
Date: Sat, 13 Jun 2020 12:56:50 +0200

Hey Jan,

>                         (system (current-system))
>                         (target (operating-system-derivation target-os))
> -                       (base-image (find-image
> -                                    installation-disk-image-file-system-type))
> +                       (base-image -> (find-image
> +                                       installation-disk-image-file-system-type
> +                                       (%current-target-system)))

This should be:

--8<---------------cut here---------------start------------->8---
(target (current-target-system))
...
(base-image -> (find-image
                installation-disk-image-file-system-type
                target))
--8<---------------cut here---------------end--------------->8---

> +      ((image ->  (find-image file-system-type (%current-target-system)))
>         (sys       (system-derivation-for-action os image action
>                                                  #:file-system-type file-system-type
>                                                  #:image-size image-size

Same here, otherwise this look good to me.

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.