GNU bug report logs - #41769
[PATCH] system: Fix typo that breaks grub.cfg generation

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Royce Strange <royball <at> disroot.org>
Subject: bug#41769: closed (Re: [bug#41769] [PATCH] system: Fix typo that
 breaks grub.cfg generation)
Date: Tue, 09 Jun 2020 05:31:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#41769: [PATCH] system: Fix typo that breaks grub.cfg generation

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 41769 <at> debbugs.gnu.org.

-- 
41769: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41769
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: maxim.cournoyer <at> gmail.com
To: Royce Strange <royball <at> disroot.org>
Cc: 41769-done <at> debbugs.gnu.org
Subject: Re: [bug#41769] [PATCH] system: Fix typo that breaks grub.cfg
 generation
Date: Tue, 09 Jun 2020 01:30:10 -0400

Royce Strange <royball <at> disroot.org> writes:

> * gnu/system.scm (boot-parameters->menu-entry):
> Delete quote to evalutate and get kernel boot parameters.
> ---
>  gnu/system.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/system.scm b/gnu/system.scm
> index 21d0fbd190..081e0f2fb3 100644
> --- a/gnu/system.scm
> +++ b/gnu/system.scm
> @@ -400,7 +400,7 @@ The object has its kernel-arguments extended in order to make it bootable."
>       (device (boot-parameters-store-device conf))
>       (device-mount-point (boot-parameters-store-mount-point conf))
>       (linux (and (not multiboot?) kernel))
> -     (linux-arguments (if (not multiboot?) '
> +     (linux-arguments (if (not multiboot?)
>                            (boot-parameters-kernel-arguments conf)
>                            '()))
>       (initrd (boot-parameters-initrd conf))

Pushed, thank you!

Maxim

[Message part 3 (message/rfc822, inline)]

From: Royce Strange <royball <at> disroot.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] system: Fix typo that breaks grub.cfg generation
Date: Mon,  8 Jun 2020 20:12:24 -0500

* gnu/system.scm (boot-parameters->menu-entry):
Delete quote to evalutate and get kernel boot parameters.
---
 gnu/system.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/system.scm b/gnu/system.scm
index 21d0fbd190..081e0f2fb3 100644
--- a/gnu/system.scm
+++ b/gnu/system.scm
@@ -400,7 +400,7 @@ The object has its kernel-arguments extended in order to make it bootable."
      (device (boot-parameters-store-device conf))
      (device-mount-point (boot-parameters-store-mount-point conf))
      (linux (and (not multiboot?) kernel))
-     (linux-arguments (if (not multiboot?) '
+     (linux-arguments (if (not multiboot?)
                           (boot-parameters-kernel-arguments conf)
                           '()))
      (initrd (boot-parameters-initrd conf))
-- 
2.26.2

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.