GNU bug report logs - #41767
[PATCH 0/9] Authenticate channels

Previous Next

Full log

View this message in rfc822 format

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 41767 <at> debbugs.gnu.org
Subject: [bug#41767] [PATCH 9/9] DROP? channels: Add prehistorical authorizations to <channel-introduction>.
Date: Tue, 09 Jun 2020 14:35:57 -0400

Hello!

Ludovic Courtès <ludo <at> gnu.org> writes:

> This allows users to authenticate commits that were made before
> '.guix-authorizations' was introduced.
>
> * guix/channels.scm (<channel-introduction>)[prehistorical-authorizations]:
> New field.
> (%guix-historical-committers): New variable.
> (openpgp-fingerprint->bytevector): New procedure.
> (%guix-channel-introduction): Add 'prehistorical-authorizations' field.
> (authenticate-channel): Honor it.  Pass it as #:default-authorizations
> to 'authenticate-commits'.
> * build-aux/git-authenticate.scm (%historical-committers)
> (%historical-authorized-signing-keys, commit-short-id): Remove.
> * build-aux/git-authenticate.scm (git-authenticate): Rewrite to use
> 'authenticate-channel'.
> * tests/channels.scm ("authenticate-channel, wrong first commit signer")
> ("authenticate-channel, .guix-authorizations"): Adjust accordingly.

I'd be in favor of dropping this commit, to not be burdened by legacy
complexity, which I'm doubtful would see much use anyway.  This means
that a channel require all its commits to have a .guix-authorizations
file to be authenticated.  I think that's fine.

The series LGTM.  I haven't tested it locally, but the tests give me
confidence.

Thank you for working on this!

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.