GNU bug report logs - #41766
Make it possible to change regexp to identify and highlight grep matches via customization

Previous Next

Package: emacs;

Reported by: Simon Lang <simon.lang <at> outlook.com>

Date: Mon, 8 Jun 2020 21:32:02 UTC

Severity: normal

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Simon Lang <Simon.lang <at> outlook.com>
To: Eli Zaretskii <eliz <at> gnu.org>, "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: "juri <at> linkov.net" <juri <at> linkov.net>, "41766 <at> debbugs.gnu.org" <41766 <at> debbugs.gnu.org>, "dgutov <at> yandex.ru" <dgutov <at> yandex.ru>
Subject: bug#41766: Make it possible to change regexp to identify and highlight grep matches via customization
Date: Wed, 10 Jun 2020 21:11:09 +0000

[Message part 1 (text/plain, inline)]
Hi,

I now something to the manual, NEWS and changed the doc string + commit msg as advised. I decided on defcustom in the end because this way it is easy for the user to figure out what goes wrong in case he/she modifies grep-command and highlighting is missing. Hope that is fine.

Pls let me know if there is anything else I need to change.

Thanks!

________________________________________
From: Eli Zaretskii <eliz <at> gnu.org>
Sent: 09 June 2020 15:43
To: Basil L. Contovounesios
Cc: Simon.lang <at> outlook.com; 41766 <at> debbugs.gnu.org; dgutov <at> yandex.ru; juri <at> linkov.net
Subject: Re: bug#41766: Make it possible to change regexp to identify and highlight grep matches via customization

> From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
> Date: Tue, 09 Jun 2020 12:55:25 +0100
> Cc: "41766 <at> debbugs.gnu.org" <41766 <at> debbugs.gnu.org>,
>  Dmitry Gutov <dgutov <at> yandex.ru>, Juri Linkov <juri <at> linkov.net>
>
> I wonder, though: the default value matches some quite obscure codes
> which aren't (and maybe shouldn't be) documented, so is a defcustom
> really suitable for this?

They are SGR escape sequences that Grep emits to color its output.  We
should probably mention that in the doc string.

[0001-lisp-progmodes-grep.el-grep-match-regexp-New-variabl.patch (application/octet-stream, attachment)]
This bug report was last modified 4 years and 240 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.