GNU bug report logs - #41764
`make authenticate` fails to find the keyring branch

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Miguel Ángel Arruga Vivas <rosen644835 <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#41764: closed (`make authenticate` fails to find the keyring
 branch)
Date: Sat, 24 Oct 2020 15:43:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 24 Oct 2020 17:41:44 +0200
with message-id <87h7qjhbrb.fsf <at> gmail.com>
and subject line Re: bug#41764: `make authenticate` fails to find the keyring branch
has caused the debbugs.gnu.org bug report #41764,
regarding `make authenticate` fails to find the keyring branch
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
41764: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41764
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Leo Famulari <leo <at> famulari.name>
To: bug-guix <at> gnu.org
Subject: `make authenticate` fails to find the keyring branch
Date: Mon, 8 Jun 2020 14:54:04 -0400

I just tried pushing for the first time since installing the new
pre-push hook that runs `make authenticate`.

This failed with the following error:

Git error: cannot locate remote-tracking branch 'keyring'

However, `git branch --all` includes "remotes/origin/keyring".

After I did `git checkout origin/keyring`, it worked.

Let's update the manual section Commit Access with the recommended way
to make this branch accessible to `make authenticate`. Maybe it should
even do it automatically?

[Message part 3 (message/rfc822, inline)]

From: Miguel Ángel Arruga Vivas <rosen644835 <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 41764-done <at> debbugs.gnu.org, Leo Famulari <leo <at> famulari.name>
Subject: Re: bug#41764: `make authenticate` fails to find the keyring branch
Date: Sat, 24 Oct 2020 17:41:44 +0200

[Message part 4 (text/plain, inline)]

Hi Ludo,

Thanks for the quick revision.

Ludovic Courtès <ludo <at> gnu.org> writes:
>>  # Authenticate the current Git checkout by checking signatures on every commit.
>> +GUIX_GIT_KEYRING = origin/keyring
>
> You need “?=” or users won’t be able to override it.

The macro definitions provided through the command line are equivalent
to adding these definitions to the end of the file, so this wouldn't
make any difference, so I leave it as only =.
>
> s/git/Git/ in the paragraph, but otherwise LGTM!  ‘origin/keyring’ is
> certainly a better default than ‘keyring’.

Pushed with this change as ef6596a20c to master.

Happy hacking!
Miguel

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.