From unknown Sat Jun 21 05:19:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41761: 28.0.50; M-x count-words counts words only up to a field boundary Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Jun 2020 16:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 41761 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 41761@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159163515428982 (code B ref -1); Mon, 08 Jun 2020 16:53:01 +0000 Received: (at submit) by debbugs.gnu.org; 8 Jun 2020 16:52:34 +0000 Received: from localhost ([127.0.0.1]:57751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiL0k-0007XO-Fm for submit@debbugs.gnu.org; Mon, 08 Jun 2020 12:52:34 -0400 Received: from lists.gnu.org ([209.51.188.17]:55908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiL0j-0007XH-8G for submit@debbugs.gnu.org; Mon, 08 Jun 2020 12:52:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44688) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiL0i-00067C-VP for bug-gnu-emacs@gnu.org; Mon, 08 Jun 2020 12:52:32 -0400 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]:34801) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jiL0i-0000SM-0h for bug-gnu-emacs@gnu.org; Mon, 08 Jun 2020 12:52:32 -0400 Received: by mail-ej1-x62f.google.com with SMTP id l27so19139022ejc.1 for ; Mon, 08 Jun 2020 09:52:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=tgOmRMUt7a0y3TTz6FidNoYRElBUBIRetaxoVwM2dd0=; b=K8wE8t3b4xXDZ35oxZ+SzqJyNa958BEAJ3spSKk9EwKCiekTxzInK8rZ/x9YZrupIr NhkAv6GywjnVbY2qMZAE0m/IwJNISAsRJhgtgC+J8k30a7vYCeCi5ZmtaHzGUttWvATC uPZkEKZnxKtHehqQFiJMeH4T0cy8tTJD0Cs+hrELXE5CxtXNCNEF5a9QVnyiBFipZqPB Nb07Br8tD6iZL9bgQcK9T14RMBcRDSnemIjsWYo+hr4Z+P6V/qmml37j0Gqwul7nKdKU KKp0A8L0ayPa+r/KdKPR15v3p8D+Mi2UOJKLpxWfwoGrw6/wGpFY+IpSGCdSf6/vDLhV qxzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=tgOmRMUt7a0y3TTz6FidNoYRElBUBIRetaxoVwM2dd0=; b=FcD2D7ICRzu9PETnhr+w9ov6cywzZD9bzyEO10gEfA0vRnF3h28TrmBEGhG//vSxPz Uz7yJa/zReu6X9DudIsPGd6BirtRukSf87soA4uSuxH9v5J3A9Vgfes2J879TUn5EYSL 1LiiBw7HJobaiHJ6ZH6biYI+ERGXtpCd003adF3IRx3ps0VFxZ/w2qZHxrg65WQkhwcz LX7cbL/QxbHEDbTL7YttXuBpm1q3umItWdvaupnA7LgDLyiqZxB1xkstIyGWrZTllLV/ OJKdopRXW3NTgFgWsXEfMF8YH8Byo5JLmHxJu5QtQJpWN61voNJGCY86JzJLkVi5uIpx 2gtQ== X-Gm-Message-State: AOAM5303zkUGFlMq6WqRJT2+EvI4xTfra3jpu/fzNZTYRp2gfDlFgP4v sjA3hM4a9gI5ObLm45R/1k4NUOqsD/HsSQ== X-Google-Smtp-Source: ABdhPJwLU2gr/6Axi9GFmiqGVnwViWsISieMWmNRtP61cxBBYOKPAl45tscDyECrU5uSbzuEnlRD5w== X-Received: by 2002:a17:906:2c44:: with SMTP id f4mr3686523ejh.183.1591635149962; Mon, 08 Jun 2020 09:52:29 -0700 (PDT) Received: from chametz ([185.220.101.139]) by smtp.gmail.com with ESMTPSA id cb6sm12897849edb.18.2020.06.08.09.52.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 09:52:29 -0700 (PDT) From: Pip Cet Date: Mon, 08 Jun 2020 16:52:25 +0000 Message-ID: <87y2oxwldi.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::62f; envelope-from=pipcet@gmail.com; helo=mail-ej1-x62f.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) (dotimes (i 10) (insert (propertize "test " 'field (cons nil nil)))) C-p C-a C-n C-SPC C-e M-x count-words Expected result: message "Region has 1 line, 10 words, and 50 characters" Actual result: message "Region has 1 line, 1 word, and 50 characters" From unknown Sat Jun 21 05:19:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41761: [PATCH] bug#41761: 28.0.50; M-x count-words counts words only up to a field boundary Resent-From: Daniel Koning Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jun 2020 20:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41761 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Pip Cet Cc: 41761@debbugs.gnu.org Received: via spool by 41761-submit@debbugs.gnu.org id=B41761.159182014810204 (code B ref 41761); Wed, 10 Jun 2020 20:16:01 +0000 Received: (at 41761) by debbugs.gnu.org; 10 Jun 2020 20:15:48 +0000 Received: from localhost ([127.0.0.1]:35425 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj78W-0002eW-Hj for submit@debbugs.gnu.org; Wed, 10 Jun 2020 16:15:48 -0400 Received: from sender4-of-o56.zoho.com ([136.143.188.56]:21603) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj78T-0002eK-S8 for 41761@debbugs.gnu.org; Wed, 10 Jun 2020 16:15:46 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1591820142; cv=none; d=zohomail.com; s=zohoarc; b=g2oZ0xtKleGidsiJEMCm3oQ6m14MPVwv2oA9JCiGhmijYdsLBXevp45Rea6P0FJmKsJii7XrkL11xSfrOUK4eGSQohXlI/ZYcEicYSJ/6QwvWvgi9Bpo3jZ7IxxRjajGjI/7g2S98S7jYunA6V544WRok3w2A8CvO8OewW0rHOA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591820142; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=MKDT0SKZt0t8AQpAxJ41W1vxAfv5GAa+JQNSO1lf3mA=; b=hPzYRaaCBMW19llhJpKhGQadaelMoT+ijmcbd+anmjqT/Py/jvJVZIm3cc8uFtpO87bTzBBPgkeU3OqDDkDmFGNo1pAxFgcL5hcH87cCcwv9Y7bPvjPrq2Sl9yjt0fMeiNmpJT2UilAIa9575xBIsEN4WHb5YtIV+g6axUsvdEE= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass smtp.mailfrom=dk@danielkoning.com; dmarc=pass header.from= header.from= Received: from cornelius (112.157.239.35.bc.googleusercontent.com [35.239.157.112]) by mx.zohomail.com with SMTPS id 15918201404201010.3798736791774; Wed, 10 Jun 2020 13:15:40 -0700 (PDT) From: Daniel Koning In-Reply-To: <87y2oxwldi.fsf@gmail.com> (Pip Cet's message of "Mon, 08 Jun 2020 16:52:25 +0000") References: <87y2oxwldi.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (darwin) Date: Wed, 10 Jun 2020 15:15:32 -0500 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Zoho-Virus-Status: 1 X-ZohoMailClient: External X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Pip Cet writes: > Expected result: > > message "Region has 1 line, 10 words, and 50 characters" > > Actual result: > > message "Region has 1 line, 1 word, and 50 characters" `count-words' should be disabling field-boundary behavior in `forward-word-strictly' by setting `inhibit-field-text-motion'. Patch included. Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [136.143.188.56 listed in list.dnswl.org] 1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in bl.spamcop.net [Blocked - see ] 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: danielkoning.com] 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [136.143.188.56 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --=-=-= Content-Type: text/plain Pip Cet writes: > Expected result: > > message "Region has 1 line, 10 words, and 50 characters" > > Actual result: > > message "Region has 1 line, 1 word, and 50 characters" `count-words' should be disabling field-boundary behavior in `forward-word-strictly' by setting `inhibit-field-text-motion'. Patch included. I grepped for other calls to `count-words' that might be making the same omission, but everything I saw looked like a use case that should respect field boundaries. Daniel --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Don-t-stop-at-field-boundaries-when-counting-words-B.patch Content-Description: count-words patch >From af0d9c48aaf99d8df5fa55a8ba2c0ee42bf695e9 Mon Sep 17 00:00:00 2001 From: Daniel Koning Date: Wed, 10 Jun 2020 14:42:39 -0500 Subject: [PATCH] Don't stop at field boundaries when counting words (Bug#41761) * lisp/simple.el (count-words): Ensure that `forward-word-strictly' moves point from one field to the next during the word-counting loop. Copyright-paperwork-exempt: yes --- lisp/simple.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/simple.el b/lisp/simple.el index 6d7600e414..9d898eeeec 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -1319,7 +1319,9 @@ count-words END, without printing any message." (interactive (list nil nil)) (cond ((not (called-interactively-p 'any)) - (let ((words 0)) + (let ((words 0) + ;; Count across field boundaries. (Bug#41761) + (inhibit-field-text-motion t)) (save-excursion (save-restriction (narrow-to-region start end) -- 2.20.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 12 20:51:02 2020 Received: (at control) by debbugs.gnu.org; 13 Aug 2020 00:51:02 +0000 Received: from localhost ([127.0.0.1]:46129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k61SP-0001Kr-QP for submit@debbugs.gnu.org; Wed, 12 Aug 2020 20:51:02 -0400 Received: from mail-yb1-f175.google.com ([209.85.219.175]:36718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k61SL-0001KA-2x for control@debbugs.gnu.org; Wed, 12 Aug 2020 20:50:57 -0400 Received: by mail-yb1-f175.google.com with SMTP id g3so2385743ybc.3 for ; Wed, 12 Aug 2020 17:50:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=X1X4CGAcx+1kMsP2HOwnzGptanFBefjKi54nHJ+9i44=; b=dRcqmk0VeLoUp3ww4uY5OlgnG/8yOjzY2pa8TzDGjhMGdlW/vcOreVGNMR/fTZgLK7 6hxRGAQ1kUmbO3xFJC7NUX2DPQOmHuJLwGmzXqUE7CmD5mbA7xbrOYrrZuNP890UJwxC jlQoIMvv5FDCNx8P+T/vTPtHnaSR+29o7hH/2d7lB1Dt0h/VLDoVLbA37v7PcrJfbeFA zTGmHXxFfJNQTcGbWDoU+1JN2ZySyJrjz2SOFyUmUF4bGwgFyHmgqOHfipevCPNEfECW u2ky1iKNIXm3G+yq3sf1f+rJkdujMLAkUiZID38xJK6fVT/+2+u6KuvcFZHTXFUmIXuG h6bA== X-Gm-Message-State: AOAM531slXetY2F/BfDcVcyeqpB1TTkQ8qFpctDvVLOmRQbqYhIgpq2X AA6p8cgmOe3oah3uK3SE2PXFzYWwX51l8aJT+fdF7rvGqxg= X-Google-Smtp-Source: ABdhPJzV4KbmL4I39Ygo3V2BgrzT8BjERiVVIGltnhe988vlmeBLzNL+fRfLyeduF3EhaGqicv2k3M+rV4b4lFzR+qc= X-Received: by 2002:a25:880e:: with SMTP id c14mr3036321ybl.181.1597279851477; Wed, 12 Aug 2020 17:50:51 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 12 Aug 2020 17:50:51 -0700 From: Stefan Kangas MIME-Version: 1.0 Date: Wed, 12 Aug 2020 17:50:51 -0700 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 41761 + patch thanks Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.219.175 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.219.175 listed in list.dnswl.org] 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) tags 41761 + patch thanks From unknown Sat Jun 21 05:19:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41761: [PATCH] bug#41761: 28.0.50; M-x count-words counts words only up to a field boundary Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Aug 2020 09:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41761 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Daniel Koning Cc: 41761@debbugs.gnu.org, Pip Cet Received: via spool by 41761-submit@debbugs.gnu.org id=B41761.159739912613860 (code B ref 41761); Fri, 14 Aug 2020 09:59:01 +0000 Received: (at 41761) by debbugs.gnu.org; 14 Aug 2020 09:58:46 +0000 Received: from localhost ([127.0.0.1]:51865 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6WU0-0003bM-Bd for submit@debbugs.gnu.org; Fri, 14 Aug 2020 05:58:46 -0400 Received: from mail-yb1-f173.google.com ([209.85.219.173]:39634) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6WTh-0003af-AG for 41761@debbugs.gnu.org; Fri, 14 Aug 2020 05:58:40 -0400 Received: by mail-yb1-f173.google.com with SMTP id q16so4898119ybk.6 for <41761@debbugs.gnu.org>; Fri, 14 Aug 2020 02:58:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=CuNLl+QJuo8LLMGP9JEC47YuP1XRDRcwwodtSoCRbc0=; b=mcdcWle+G2OSAT64VW051ad8E6RzFwXKC5gECcCOWG0KuYUUKEKs05yVNnhDrr+u6Y P7679HcMGpq+nD0xMBhzHOS5SeasY2H4MrERrZS/8BasJGuZ9lfPPD28GuF7A2//jJ4D D7Aehwtz/EtYamhxjz6KMi4GrPQyZgLTmE7SQN0/2//uHr/1SF2DdI4z/MhgRuzCh5m4 x8ZDr3DA8afxVn8817cjdj6fPqO0sfM0TXP2QxBbW/E9HLzdbITN7OM1lcz++r6rBgH8 WDjvBR9CcUdxnc3Icv6aRF33RGMdku7UY6hKjGCyCjS+mDCin1HG66Hgu16NPypOI6/5 tPzg== X-Gm-Message-State: AOAM532dWnDw9ioWrwD9xh2lBa2KXn5hjAlp6HDmwKIwT7D7zWcS3ens UIhM21vmr0ASDLkwFbGlad50xEevjtF7LrI7ASU= X-Google-Smtp-Source: ABdhPJxZayPEbrUkpXF8qBQ8myyT4MvXw0hrZ2Rej/a4izsz0e4D8p+0+UmfDUbFO8UnbSTsJhR+7Q41HFP14DmLSXI= X-Received: by 2002:a25:4609:: with SMTP id t9mr2545049yba.231.1597399099799; Fri, 14 Aug 2020 02:58:19 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 14 Aug 2020 02:58:19 -0700 From: Stefan Kangas In-Reply-To: (Daniel Koning's message of "Wed, 10 Jun 2020 15:15:32 -0500") References: <87y2oxwldi.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Date: Fri, 14 Aug 2020 02:58:19 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 41761 28.1 thanks Daniel Koning writes: > Pip Cet writes: > >> Expected result: >> >> message "Region has 1 line, 10 words, and 50 characters" >> >> Actual result: >> >> message "Region has 1 line, 1 word, and 50 characters" > > `count-words' should be disabling field-boundary behavior in > `forward-word-strictly' by setting `inhibit-field-text-motion'. Patch > included. Thanks for the patch. It looks good to me so I pushed it as commit c560ba3036d8. I also pushed a regression test for this bug separately. Closing this bug now. Best regards, Stefan Kangas From unknown Sat Jun 21 05:19:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41761: [PATCH] bug#41761: 28.0.50; M-x count-words counts words only up to a field boundary Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Aug 2020 11:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41761 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: 41761@debbugs.gnu.org, pipcet@gmail.com, dk@danielkoning.com Received: via spool by 41761-submit@debbugs.gnu.org id=B41761.15974033145694 (code B ref 41761); Fri, 14 Aug 2020 11:09:02 +0000 Received: (at 41761) by debbugs.gnu.org; 14 Aug 2020 11:08:34 +0000 Received: from localhost ([127.0.0.1]:51972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6XZa-0001Tm-3M for submit@debbugs.gnu.org; Fri, 14 Aug 2020 07:08:34 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6XZX-0001TX-IB for 41761@debbugs.gnu.org; Fri, 14 Aug 2020 07:08:32 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51724) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6XZR-0001ZO-Iw; Fri, 14 Aug 2020 07:08:25 -0400 Received: from [176.228.60.248] (port=2689 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k6XZQ-0007TB-IU; Fri, 14 Aug 2020 07:08:25 -0400 Date: Fri, 14 Aug 2020 14:08:18 +0300 Message-Id: <83imdllc2l.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Stefan Kangas on Fri, 14 Aug 2020 02:58:19 -0700) References: <87y2oxwldi.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Fri, 14 Aug 2020 02:58:19 -0700 > Cc: 41761@debbugs.gnu.org, Pip Cet > > >> Expected result: > >> > >> message "Region has 1 line, 10 words, and 50 characters" > >> > >> Actual result: > >> > >> message "Region has 1 line, 1 word, and 50 characters" > > > > `count-words' should be disabling field-boundary behavior in > > `forward-word-strictly' by setting `inhibit-field-text-motion'. Patch > > included. > > Thanks for the patch. It looks good to me so I pushed it as commit > c560ba3036d8. Thanks. This change in behavior should be in NEWS. And I'm not sure we shouldn't provide an optional knob to get back the old behavior: some package or user might rely on it. From unknown Sat Jun 21 05:19:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41761: [PATCH] bug#41761: 28.0.50; M-x count-words counts words only up to a field boundary Resent-From: Daniel Koning Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Aug 2020 18:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41761 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 41761@debbugs.gnu.org, Stefan Kangas , pipcet@gmail.com Received: via spool by 41761-submit@debbugs.gnu.org id=B41761.159743111532232 (code B ref 41761); Fri, 14 Aug 2020 18:52:02 +0000 Received: (at 41761) by debbugs.gnu.org; 14 Aug 2020 18:51:55 +0000 Received: from localhost ([127.0.0.1]:53842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6eny-0008No-Qq for submit@debbugs.gnu.org; Fri, 14 Aug 2020 14:51:55 -0400 Received: from sender4-of-o56.zoho.com ([136.143.188.56]:21630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6enw-0008Nf-Ng for 41761@debbugs.gnu.org; Fri, 14 Aug 2020 14:51:53 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1597431105; cv=none; d=zohomail.com; s=zohoarc; b=J5o+IAjHQWbZodBUU2I1nfA23MtdG0Ti5MG7Eet9n2NL03zPfssBqyyhTS3Q1bdv4voNs7Y6No944U/FH6Ga/v9VdSdZZaKGDz4JoDTjIufxt1XJyxE3wLfe1v2BXIn8J0VlqvkbE/FqLoCXGoJa4X9oGYVQ1dKeQjXbY6nXYbU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597431105; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=NWsGJxSmrZ3qs3uMrAppK8AviwRcADw+iXDYkSOLvTs=; b=R5EK1CoIPZ73Zegnn3r9Blguh5DWpZGD7xfhw+s24KofNrZy9+VGtRbxLS5pPRoKU+6id/kRpcO3oUH/fnpis0l9gpSeG8Mg0S7MwKv18PF6lwXVHbnCUdPf81v8f2qk7WxCRUYQWRrVzixu0PaoShZClN/N0aFC4a0sruGP6KY= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass smtp.mailfrom=dk@danielkoning.com; dmarc=pass header.from= header.from= Received: from cornelius (112.157.239.35.bc.googleusercontent.com [35.239.157.112]) by mx.zohomail.com with SMTPS id 1597430928150688.2024784283693; Fri, 14 Aug 2020 11:48:48 -0700 (PDT) From: Daniel Koning In-Reply-To: <83imdllc2l.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 14 Aug 2020 14:08:18 +0300") References: <87y2oxwldi.fsf@gmail.com> <83imdllc2l.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (darwin) Date: Fri, 14 Aug 2020 13:48:44 -0500 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > This change in behavior should be in NEWS. And I'm not sure > we shouldn't provide an optional knob to get back the old behavior: > some package or user might rely on it. I don't think I agree. The "new" behavior is what the documentation described to begin with. And it's a complexity burden to solder new switches onto these simple functions -- more burdensome (I say) than trusting users to impose the constraint by hand if that's what they want. Something like: (count-words start (min end (field-end start t))) Daniel From unknown Sat Jun 21 05:19:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41761: [PATCH] bug#41761: 28.0.50; M-x count-words counts words only up to a field boundary Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Aug 2020 19:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41761 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Daniel Koning Cc: 41761@debbugs.gnu.org, stefan@marxist.se, pipcet@gmail.com Received: via spool by 41761-submit@debbugs.gnu.org id=B41761.15974325272062 (code B ref 41761); Fri, 14 Aug 2020 19:16:01 +0000 Received: (at 41761) by debbugs.gnu.org; 14 Aug 2020 19:15:27 +0000 Received: from localhost ([127.0.0.1]:53895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6fAl-0000XC-DB for submit@debbugs.gnu.org; Fri, 14 Aug 2020 15:15:27 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6fAk-0000Wz-3F for 41761@debbugs.gnu.org; Fri, 14 Aug 2020 15:15:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36153) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6fAe-0003Tk-5I; Fri, 14 Aug 2020 15:15:20 -0400 Received: from [176.228.60.248] (port=4825 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k6fAc-00068B-EW; Fri, 14 Aug 2020 15:15:19 -0400 Date: Fri, 14 Aug 2020 22:15:14 +0300 Message-Id: <834kp5kpj1.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Daniel Koning on Fri, 14 Aug 2020 13:48:44 -0500) References: <87y2oxwldi.fsf@gmail.com> <83imdllc2l.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Daniel Koning > Cc: Stefan Kangas , 41761@debbugs.gnu.org, > pipcet@gmail.com > Date: Fri, 14 Aug 2020 13:48:44 -0500 > > Eli Zaretskii writes: > > > This change in behavior should be in NEWS. And I'm not sure > > we shouldn't provide an optional knob to get back the old behavior: > > some package or user might rely on it. > > I don't think I agree. It's okay to disagree, but I still think it should be in NEWS. It's a change in a long-standing behavior, so users should be told about it. From unknown Sat Jun 21 05:19:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41761: [PATCH] bug#41761: 28.0.50; M-x count-words counts words only up to a field boundary Resent-From: Daniel Koning Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Aug 2020 19:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41761 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 41761@debbugs.gnu.org, stefan@marxist.se, pipcet@gmail.com Received: via spool by 41761-submit@debbugs.gnu.org id=B41761.15974343114798 (code B ref 41761); Fri, 14 Aug 2020 19:46:01 +0000 Received: (at 41761) by debbugs.gnu.org; 14 Aug 2020 19:45:11 +0000 Received: from localhost ([127.0.0.1]:53917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6fdW-0001FK-VX for submit@debbugs.gnu.org; Fri, 14 Aug 2020 15:45:11 -0400 Received: from sender4-of-o56.zoho.com ([136.143.188.56]:21644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6fdT-0001FA-0O for 41761@debbugs.gnu.org; Fri, 14 Aug 2020 15:45:09 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1597434300; cv=none; d=zohomail.com; s=zohoarc; b=aVZaxxmirY2ElPmQC7UDo38W1DthvKWr+06XQxheRkAkujYWsHXxV9xZufPTS8kxvuAV/PggvP/VMyZIAnb5/sVxue14GHdEBLK+eddjBVWqxlvCS+JnXvi25oh5+g4d0dibMzdJ7fK7R+T3qWUAadn6RI+D1U3IwqvDIhoSyUc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597434300; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=tnLr8l0v89b9NDZfmEyDHObqi5VFJ3JdF8Mm3XmwB3E=; b=n9i8nZkIyl/r1OSGBDhQg1RLDkQdKlUpv4qU8ir1dBsdyy9TD+PCilnaPDupOcW46gu2JEDEPyDTWDqSbJ03WYAcP14umZgkbmoYteesqQjnRHU+xp0LFknsLz5YrDwjr5y1HoB6EEaynlj0qdJY9rWr1XXwdRRnwejgZl1N+gk= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass smtp.mailfrom=dk@danielkoning.com; dmarc=pass header.from= header.from= Received: from cornelius (112.157.239.35.bc.googleusercontent.com [35.239.157.112]) by mx.zohomail.com with SMTPS id 1597434295349971.9731849291668; Fri, 14 Aug 2020 12:44:55 -0700 (PDT) From: Daniel Koning In-Reply-To: <834kp5kpj1.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 14 Aug 2020 22:15:14 +0300") References: <87y2oxwldi.fsf@gmail.com> <83imdllc2l.fsf@gnu.org> <834kp5kpj1.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (darwin) Date: Fri, 14 Aug 2020 14:44:52 -0500 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> > This change in behavior should be in NEWS. And I'm not sure >> > we shouldn't provide an optional knob to get back the old behavior: >> > some package or user might rely on it. >> >> I don't think I agree. > > It's okay to disagree, but I still think it should be in NEWS. Excuse my imprecision in quoting you; I don't object to the change going into NEWS. I just meant to contend that the old behavior shouldn't be enshrined in a customization item or anything like that. Some deeply rooted bugs become load-bearing over time, but this doesn't look like one of those, only (you might say literally) an overlooked edge case. From unknown Sat Jun 21 05:19:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41761: [PATCH] bug#41761: 28.0.50; M-x count-words counts words only up to a field boundary Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Aug 2020 23:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41761 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii , Daniel Koning Cc: 41761@debbugs.gnu.org, pipcet@gmail.com Received: via spool by 41761-submit@debbugs.gnu.org id=B41761.159744639823381 (code B ref 41761); Fri, 14 Aug 2020 23:07:01 +0000 Received: (at 41761) by debbugs.gnu.org; 14 Aug 2020 23:06:38 +0000 Received: from localhost ([127.0.0.1]:54058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6imU-000652-Eq for submit@debbugs.gnu.org; Fri, 14 Aug 2020 19:06:38 -0400 Received: from mail-yb1-f170.google.com ([209.85.219.170]:44228) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6imS-00064k-9g for 41761@debbugs.gnu.org; Fri, 14 Aug 2020 19:06:37 -0400 Received: by mail-yb1-f170.google.com with SMTP id i10so6012831ybt.11 for <41761@debbugs.gnu.org>; Fri, 14 Aug 2020 16:06:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=zxYpq29Kah1o/9LF4AYTUm+Xaotp+BI70L6rid80V3k=; b=Zd+B/rt/Hw79kwcz/wgJAKRDslZBItxp83gIBfUJ50sStMNbRSMTmqDX3yi0xbtZRP swo0GiQ0bIi1zdDvacQ9T8rliEvZuDcwXIGUetGaByGjTUXeOY4kOz3NVoRei+aphDwV sKzYUAIqVOYLrzdcJplBjFQQ0t99OoGVvO8TRlAdaAtbVvsbySGpLnereYRTOT7ilapk 6iW03eeGFlIMG4TjXgyL01Y91SFYQk5EkhBonnSC9Up5XMLFMmVVuqfmOqpVUSYol+PT gft6XWwTuP6ynn+5E6W12a3wISgL5YmWgohcoREowkOMqiiUUacNv4MVzi5kQQghKez+ qBBQ== X-Gm-Message-State: AOAM533Za7d/lVw/XusmMgilG537WF7xZPXlufzWFPUyCIU3z92XvOIl eScQsFjk9jwBoFhFIIhMOE3baI59CuDYjGyw4QA= X-Google-Smtp-Source: ABdhPJx9Q3kTcZLEIyMDrHjX0cy0YLyCeR9m4OX2wxR69HpLdDcNAQSBw1YS58Xi90qELgFnNAvocrFJfCKD2+30iBM= X-Received: by 2002:a25:4609:: with SMTP id t9mr6727591yba.231.1597446390916; Fri, 14 Aug 2020 16:06:30 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 14 Aug 2020 16:06:30 -0700 From: Stefan Kangas In-Reply-To: <834kp5kpj1.fsf@gnu.org> References: <87y2oxwldi.fsf@gmail.com> <83imdllc2l.fsf@gnu.org> <834kp5kpj1.fsf@gnu.org> MIME-Version: 1.0 Date: Fri, 14 Aug 2020 16:06:30 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > It's okay to disagree, but I still think it should be in NEWS. It's a > change in a long-standing behavior, so users should be told about it. I'm not sure how to best formulate the NEWS. Does this look okay? diff --git a/etc/NEWS b/etc/NEWS index 53e60cdb5c..b375fef5b7 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -145,6 +145,11 @@ setting the variable 'auto-save-visited-mode' buffer-locally to nil. description of the properties. Likewise 'button-describe' does the same for a button. +--- +** 'count-words' now skips field boundaries. +Before, 'count-words' incorrectly stopped counting the number of words +in buffer at a field boundary. This bug has been fixed. + =0C * Changes in Specialized Modes and Packages in Emacs 28.1 From unknown Sat Jun 21 05:19:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41761: [PATCH] bug#41761: 28.0.50; M-x count-words counts words only up to a field boundary Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Aug 2020 06:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41761 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Daniel Koning Cc: 41761@debbugs.gnu.org, stefan@marxist.se, pipcet@gmail.com Received: via spool by 41761-submit@debbugs.gnu.org id=B41761.159747304819361 (code B ref 41761); Sat, 15 Aug 2020 06:31:01 +0000 Received: (at 41761) by debbugs.gnu.org; 15 Aug 2020 06:30:48 +0000 Received: from localhost ([127.0.0.1]:54224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6piK-00052C-9U for submit@debbugs.gnu.org; Sat, 15 Aug 2020 02:30:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6piH-00051x-GK for 41761@debbugs.gnu.org; Sat, 15 Aug 2020 02:30:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45873) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6piB-0000ih-7p; Sat, 15 Aug 2020 02:30:39 -0400 Received: from [176.228.60.248] (port=2261 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k6piA-0002TR-Dv; Sat, 15 Aug 2020 02:30:38 -0400 Date: Sat, 15 Aug 2020 09:30:35 +0300 Message-Id: <831rk8l8tw.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Daniel Koning on Fri, 14 Aug 2020 14:44:52 -0500) References: <87y2oxwldi.fsf@gmail.com> <83imdllc2l.fsf@gnu.org> <834kp5kpj1.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Daniel Koning > Cc: stefan@marxist.se, 41761@debbugs.gnu.org, pipcet@gmail.com > Date: Fri, 14 Aug 2020 14:44:52 -0500 > > this doesn't look like one of those, only (you might say literally) > an overlooked edge case. We have no reliable way of determining whether that is the case. backward-compatibility is important in a veteran package such as Emacs, so we generally try at least to give users who want previous behavior a fire escape. From unknown Sat Jun 21 05:19:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41761: [PATCH] bug#41761: 28.0.50; M-x count-words counts words only up to a field boundary Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Aug 2020 16:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41761 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: 41761@debbugs.gnu.org, pipcet@gmail.com, dk@danielkoning.com Received: via spool by 41761-submit@debbugs.gnu.org id=B41761.15975089209329 (code B ref 41761); Sat, 15 Aug 2020 16:29:01 +0000 Received: (at 41761) by debbugs.gnu.org; 15 Aug 2020 16:28:40 +0000 Received: from localhost ([127.0.0.1]:56344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6z2t-0002QP-PL for submit@debbugs.gnu.org; Sat, 15 Aug 2020 12:28:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6z2q-0002QB-J3 for 41761@debbugs.gnu.org; Sat, 15 Aug 2020 12:28:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51409) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6z2k-0005AL-UD; Sat, 15 Aug 2020 12:28:30 -0400 Received: from [176.228.60.248] (port=3997 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k6z2j-0004wu-0j; Sat, 15 Aug 2020 12:28:30 -0400 Date: Sat, 15 Aug 2020 19:28:14 +0300 Message-Id: <838sefkh5t.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Stefan Kangas on Fri, 14 Aug 2020 16:06:30 -0700) References: <87y2oxwldi.fsf@gmail.com> <83imdllc2l.fsf@gnu.org> <834kp5kpj1.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Fri, 14 Aug 2020 16:06:30 -0700 > Cc: 41761@debbugs.gnu.org, pipcet@gmail.com > > +** 'count-words' now skips field boundaries. > +Before, 'count-words' incorrectly stopped counting the number of words > +in buffer at a field boundary. This bug has been fixed. I don't think it was a bug, so the wording should be different. Something like 'count-words' now crosses field boundaries. Originally, 'count-words' ignored the text inside field boundaries, now it includes such text in the count. Thanks. From unknown Sat Jun 21 05:19:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41761: [PATCH] bug#41761: 28.0.50; M-x count-words counts words only up to a field boundary Resent-From: Daniel Koning Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Aug 2020 17:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41761 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 41761@debbugs.gnu.org, Stefan Kangas , pipcet@gmail.com Received: via spool by 41761-submit@debbugs.gnu.org id=B41761.159751346525010 (code B ref 41761); Sat, 15 Aug 2020 17:45:02 +0000 Received: (at 41761) by debbugs.gnu.org; 15 Aug 2020 17:44:25 +0000 Received: from localhost ([127.0.0.1]:56407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k70EC-0006VJ-HC for submit@debbugs.gnu.org; Sat, 15 Aug 2020 13:44:24 -0400 Received: from sender4-of-o56.zoho.com ([136.143.188.56]:21624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k70EA-0006VB-DX for 41761@debbugs.gnu.org; Sat, 15 Aug 2020 13:44:23 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1597513456; cv=none; d=zohomail.com; s=zohoarc; b=DDpUr4+TZnt7Pqw37o5nPqE5KXEt4+bTKztvsYkMn8QRkQ6Sr0g4zF5t+AtslTxUZ+QjQDD9sktmIqrkDky1zBjOj9iCmlF0ZSy0Q3cgGIAL3UTb5gpvubH7CgG1zB+kVIRM8V5/vwcQxDjYtpyJfPgJQSuiwmPBkB10RYoJrX0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597513456; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=3G4+zYrS9EiZ6W9LkkaoRnmnqu7iVon0hPYJkmBpsKc=; b=SD7CpxZ+qCpLKrl4aXbPr+aos9Ci0FYVISlBtUg/MH3jvhM1BLkEN5vQKajyVdyn1dv/QnbUjW/IPhyqrEauDUG6w94bPLLeGlHaZ16k6Axeq+H1zkE0DYzs9MS6IdkTGRSYLpqth8UmuR9SqSII1W/R/jilFShHwO2wouao99w= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass smtp.mailfrom=dk@danielkoning.com; dmarc=pass header.from= header.from= Received: from cornelius (112.157.239.35.bc.googleusercontent.com [35.239.157.112]) by mx.zohomail.com with SMTPS id 1597513453005827.371888855199; Sat, 15 Aug 2020 10:44:13 -0700 (PDT) From: Daniel Koning References: <87y2oxwldi.fsf@gmail.com> <83imdllc2l.fsf@gnu.org> <834kp5kpj1.fsf@gnu.org> <838sefkh5t.fsf@gnu.org> Date: Sat, 15 Aug 2020 12:44:10 -0500 In-Reply-To: <838sefkh5t.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 15 Aug 2020 19:28:14 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> +** 'count-words' now skips field boundaries. >> +Before, 'count-words' incorrectly stopped counting the number of words >> +in buffer at a field boundary. This bug has been fixed. > > I don't think it was a bug, so the wording should be different. If the old behavior didn't qualify as a bug, then wouldn't you say the docstring was buggy? It said that the function returned or printed something that it really didn't ("the number of words between START and END"). And there's nothing in the docs to suggest that we should read that as "between START and END, or between START and the next field boundary if that boundary comes before END." (Nor does this rule apply to the other tallies that the function makes. Put an extra line of text beneath the line containing the several fields, and the interactive `count-words' message will reflect that line in its line count and character count, but not in its word count. So between "(defun count-words" and its matching ")", something is amiss, whether it's code or documentation.) If you don't like the word "bug" for this, the NEWS item might at least mention that the prior behavior was undocumented and inconsistent, just to clarify why the manual entry isn't changing along with the code. Daniel From unknown Sat Jun 21 05:19:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41761: [PATCH] bug#41761: 28.0.50; M-x count-words counts words only up to a field boundary Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Aug 2020 17:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41761 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Daniel Koning Cc: 41761@debbugs.gnu.org, stefan@marxist.se, pipcet@gmail.com Received: via spool by 41761-submit@debbugs.gnu.org id=B41761.159751374525488 (code B ref 41761); Sat, 15 Aug 2020 17:50:02 +0000 Received: (at 41761) by debbugs.gnu.org; 15 Aug 2020 17:49:05 +0000 Received: from localhost ([127.0.0.1]:56415 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k70Ij-0006d1-Jd for submit@debbugs.gnu.org; Sat, 15 Aug 2020 13:49:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k70Ih-0006cX-2a for 41761@debbugs.gnu.org; Sat, 15 Aug 2020 13:49:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52488) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k70Ib-0005mF-GE; Sat, 15 Aug 2020 13:48:57 -0400 Received: from [176.228.60.248] (port=1082 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k70Ib-0002Rf-0T; Sat, 15 Aug 2020 13:48:57 -0400 Date: Sat, 15 Aug 2020 20:48:43 +0300 Message-Id: <831rk7kdfo.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Daniel Koning on Sat, 15 Aug 2020 12:44:10 -0500) References: <87y2oxwldi.fsf@gmail.com> <83imdllc2l.fsf@gnu.org> <834kp5kpj1.fsf@gnu.org> <838sefkh5t.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Daniel Koning > Cc: Stefan Kangas , 41761@debbugs.gnu.org, > pipcet@gmail.com > Date: Sat, 15 Aug 2020 12:44:10 -0500 > > If you don't like the word "bug" for this, the NEWS item might at least > mention that the prior behavior was undocumented and inconsistent, just > to clarify why the manual entry isn't changing along with the code. Sorry, I don't understand the point you are trying to make. Is something wrong or inaccurate with the text I proposed for NEWS? From unknown Sat Jun 21 05:19:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41761: [PATCH] bug#41761: 28.0.50; M-x count-words counts words only up to a field boundary Resent-From: Daniel Koning Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Aug 2020 19:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41761 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 41761@debbugs.gnu.org, stefan@marxist.se, pipcet@gmail.com Received: via spool by 41761-submit@debbugs.gnu.org id=B41761.15975206753858 (code B ref 41761); Sat, 15 Aug 2020 19:45:02 +0000 Received: (at 41761) by debbugs.gnu.org; 15 Aug 2020 19:44:35 +0000 Received: from localhost ([127.0.0.1]:56497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k726V-000109-HR for submit@debbugs.gnu.org; Sat, 15 Aug 2020 15:44:35 -0400 Received: from sender4-of-o56.zoho.com ([136.143.188.56]:21670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k726T-000101-Rn for 41761@debbugs.gnu.org; Sat, 15 Aug 2020 15:44:34 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1597520665; cv=none; d=zohomail.com; s=zohoarc; b=aO/+pdwPtFSGzEzQ4pOsk1fWN0k0DsJ1hdqLoxzRLD1BP5BQrKTP1lYx68UIsi8y4vTOlYltnxCqqq/gVIFgGv3IBvhkkDZ5H81UvfjPyvZI/N7nc4Q4ejBouTXEV+pDz4hN417XP8vLkd4ayrSr6urX/8q9IJ/jILszpjQSZJQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597520665; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=tjkQO4Q7HDBKgMDUYSXk2c2971ZAJTeoCSTzH8gDdMQ=; b=gdjrwqHJohk11W4sDcrKrC7OAkhf3sqCisNRvCQtofULhK9TAju0HQ8wNLCUV8XXs6qLuE8ISIphqZruS4Z1SUneboyW0fkZ071z/NyU78Qm8e9F9sqz4JqKf6DdMm0gn+1mIhzxiuRhfAIV4JPYP/owIGl3Dm+JZts+WOmZsOw= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass smtp.mailfrom=dk@danielkoning.com; dmarc=pass header.from= header.from= Received: from cornelius (112.157.239.35.bc.googleusercontent.com [35.239.157.112]) by mx.zohomail.com with SMTPS id 159752066100239.682385898165876; Sat, 15 Aug 2020 12:44:21 -0700 (PDT) From: Daniel Koning In-Reply-To: <831rk7kdfo.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 15 Aug 2020 20:48:43 +0300") References: <87y2oxwldi.fsf@gmail.com> <83imdllc2l.fsf@gnu.org> <834kp5kpj1.fsf@gnu.org> <838sefkh5t.fsf@gnu.org> <831rk7kdfo.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (darwin) Date: Sat, 15 Aug 2020 14:44:18 -0500 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > Is something wrong or inaccurate with the text I proposed for NEWS? Based on other NEWS entries, and the discussion earlier in this thread of Stefan's original phrasing, I assumed that it was customary to mention in NEWS that a change fixes a defect (which I believe this one is, for the reasons I outlined in my last message). If that's not expected, then it doesn't much matter. I do think the prior behavior differs somewhat from the way you phrased it. I would write it as: Originally, when 'inhibit-field-text-motion' was nil, 'count-words' stopped counting words at the end of the field containing START. (It didn't ignore text inside fields, but rather text that was not inside one specific field.) Daniel From unknown Sat Jun 21 05:19:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41761: [PATCH] bug#41761: 28.0.50; M-x count-words counts words only up to a field boundary Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Aug 2020 14:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41761 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Daniel Koning Cc: 41761@debbugs.gnu.org, stefan@marxist.se, pipcet@gmail.com Received: via spool by 41761-submit@debbugs.gnu.org id=B41761.159758717130402 (code B ref 41761); Sun, 16 Aug 2020 14:13:02 +0000 Received: (at 41761) by debbugs.gnu.org; 16 Aug 2020 14:12:51 +0000 Received: from localhost ([127.0.0.1]:58080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k7JP0-0007uH-TX for submit@debbugs.gnu.org; Sun, 16 Aug 2020 10:12:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34396) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k7JOy-0007u3-1L for 41761@debbugs.gnu.org; Sun, 16 Aug 2020 10:12:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39313) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k7JOs-00025W-CC; Sun, 16 Aug 2020 10:12:42 -0400 Received: from [176.228.60.248] (port=4260 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k7JOp-0005u3-Rx; Sun, 16 Aug 2020 10:12:41 -0400 Date: Sun, 16 Aug 2020 17:12:22 +0300 Message-Id: <83pn7qiss9.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Daniel Koning on Sat, 15 Aug 2020 14:44:18 -0500) References: <87y2oxwldi.fsf@gmail.com> <83imdllc2l.fsf@gnu.org> <834kp5kpj1.fsf@gnu.org> <838sefkh5t.fsf@gnu.org> <831rk7kdfo.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Daniel Koning > Cc: stefan@marxist.se, 41761@debbugs.gnu.org, pipcet@gmail.com > Date: Sat, 15 Aug 2020 14:44:18 -0500 > > Eli Zaretskii writes: > > > Is something wrong or inaccurate with the text I proposed for NEWS? > > Based on other NEWS entries, and the discussion earlier in this thread > of Stefan's original phrasing, I assumed that it was customary to > mention in NEWS that a change fixes a defect (which I believe this one > is, for the reasons I outlined in my last message). If that's not > expected, then it doesn't much matter. No, we don't mention bug fixes in NEWS. > I do think the prior behavior differs somewhat from the way you phrased > it. I would write it as: > > Originally, when 'inhibit-field-text-motion' was nil, 'count-words' > stopped counting words at the end of the field containing START. > > (It didn't ignore text inside fields, but rather text that was not > inside one specific field.) I'm not sure I understand the "end of field containing START" part. Supposed the region includes several fields, what would the previous code do? From unknown Sat Jun 21 05:19:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41761: [PATCH] bug#41761: 28.0.50; M-x count-words counts words only up to a field boundary Resent-From: Daniel Koning Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Aug 2020 19:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41761 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 41761@debbugs.gnu.org, stefan@marxist.se, pipcet@gmail.com Received: via spool by 41761-submit@debbugs.gnu.org id=B41761.159760467319884 (code B ref 41761); Sun, 16 Aug 2020 19:05:01 +0000 Received: (at 41761) by debbugs.gnu.org; 16 Aug 2020 19:04:33 +0000 Received: from localhost ([127.0.0.1]:58497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k7NxJ-0005Ae-4u for submit@debbugs.gnu.org; Sun, 16 Aug 2020 15:04:33 -0400 Received: from sender4-of-o56.zoho.com ([136.143.188.56]:21604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k7NxF-0005AU-Fo for 41761@debbugs.gnu.org; Sun, 16 Aug 2020 15:04:31 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1597604664; cv=none; d=zohomail.com; s=zohoarc; b=H6YmWykQjwxsbzl4uO7PVP6rxTqhzf88tYv74BbsiS0DkdzqxxnFTO38ea65bMK2vUOZ3LPt6WUIUBsBa2I8tLktFFmnarL7wtsoPF925pM2JFhDFdH1leqBSNVaROO6h1BhljcOsRyEHe9a4dqXKmOsIsTYga6r8xSO8L9LXSQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597604664; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=4iImr6XAeald/cdJJuBzgEPU9FA8D72becseNeWe+Y0=; b=ExBycMxG1RxhD8vdlcbiAPtLRYAwDYkBS3cBBD8dGehXDdG9Z7yBPli6/nrApVqi/ksGauexitw+mHEv/lmLRKGGi54XJyxjumoCuveimiBQP+XitFdTnAkBJBwtnZnszuOjxeg9M6phuU+bwYxceJDokaR7kMUogDuPb/K5JWM= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass smtp.mailfrom=dk@danielkoning.com; dmarc=pass header.from= header.from= Received: from cornelius (112.157.239.35.bc.googleusercontent.com [35.239.157.112]) by mx.zohomail.com with SMTPS id 1597604661309337.5289904670534; Sun, 16 Aug 2020 12:04:21 -0700 (PDT) From: Daniel Koning References: <87y2oxwldi.fsf@gmail.com> <83imdllc2l.fsf@gnu.org> <834kp5kpj1.fsf@gnu.org> <838sefkh5t.fsf@gnu.org> <831rk7kdfo.fsf@gnu.org> <83pn7qiss9.fsf@gnu.org> Date: Sun, 16 Aug 2020 14:04:14 -0500 In-Reply-To: <83pn7qiss9.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 16 Aug 2020 17:12:22 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> I do think the prior behavior differs somewhat from the way you phrased >> it. I would write it as: >> >> Originally, when 'inhibit-field-text-motion' was nil, 'count-words' >> stopped counting words at the end of the field containing START. >> >> (It didn't ignore text inside fields, but rather text that was not >> inside one specific field.) > > I'm not sure I understand the "end of field containing START" part. > Supposed the region includes several fields, what would the previous > code do? It would only count the words between START and the next field boundary, no matter how many fields came after that. (For START, substitute "the beginning of the region" or "the beginning of the buffer" if it was called interactively.) Try reinstalling the old function definition and evaluating: ELISP> (with-temp-buffer (dotimes (i 9) (insert (propertize "4 words 22 characters " 'field i))) (insert "\n4 words 22 characters") (call-interactively #'count-words)) ; operates on whole buffer => "Buffer has 2 lines, 4 words, and 220 characters." That result arises because of how `count-words' generates its return value: it moves point to the beginning of the buffer (after narrowing the buffer to START and END if they were supplied), then repeatedly calls `forward-word-strictly' until that function returns nil, incrementing the running total each time. Before, if it ran into a field boundary, it would stop short, because `forward-word-strictly' doesn't jump field boundaries by default. I think the value of that form demonstrates why the old behavior was wrong. There does not exist any part of the temp buffer that "has 2 lines, 4 words, and 220 characters." It gives inconsistent results because the line count and character count use techniques which aren't affected by fields. Daniel From unknown Sat Jun 21 05:19:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41761: [PATCH] bug#41761: 28.0.50; M-x count-words counts words only up to a field boundary Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Aug 2020 19:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41761 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Daniel Koning Cc: 41761@debbugs.gnu.org, stefan@marxist.se, pipcet@gmail.com Received: via spool by 41761-submit@debbugs.gnu.org id=B41761.159760605030567 (code B ref 41761); Sun, 16 Aug 2020 19:28:02 +0000 Received: (at 41761) by debbugs.gnu.org; 16 Aug 2020 19:27:30 +0000 Received: from localhost ([127.0.0.1]:58544 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k7OJW-0007wx-8l for submit@debbugs.gnu.org; Sun, 16 Aug 2020 15:27:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k7OJS-0007wh-7Z for 41761@debbugs.gnu.org; Sun, 16 Aug 2020 15:27:28 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43077) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k7OJM-00053J-9W; Sun, 16 Aug 2020 15:27:20 -0400 Received: from [176.228.60.248] (port=4136 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k7OJL-0002sc-BA; Sun, 16 Aug 2020 15:27:19 -0400 Date: Sun, 16 Aug 2020 22:27:01 +0300 Message-Id: <83tux2gzne.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Daniel Koning on Sun, 16 Aug 2020 14:04:14 -0500) References: <87y2oxwldi.fsf@gmail.com> <83imdllc2l.fsf@gnu.org> <834kp5kpj1.fsf@gnu.org> <838sefkh5t.fsf@gnu.org> <831rk7kdfo.fsf@gnu.org> <83pn7qiss9.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Daniel Koning > Cc: stefan@marxist.se, 41761@debbugs.gnu.org, pipcet@gmail.com > Date: Sun, 16 Aug 2020 14:04:14 -0500 > > > I'm not sure I understand the "end of field containing START" part. > > Supposed the region includes several fields, what would the previous > > code do? > > It would only count the words between START and the next field boundary, > no matter how many fields came after that. (For START, substitute "the > beginning of the region" or "the beginning of the buffer" if it was > called interactively.) Thanks, then how about this NEWS entry: 'count-words' now crosses field boundaries. Originally, 'count-words' would stop counting at the first field boundary it encountered; now it keeps counting all the way to the region's (or buffer's) end. From unknown Sat Jun 21 05:19:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41761: [PATCH] bug#41761: 28.0.50; M-x count-words counts words only up to a field boundary Resent-From: Daniel Koning Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Aug 2020 19:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41761 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 41761@debbugs.gnu.org, stefan@marxist.se, pipcet@gmail.com Received: via spool by 41761-submit@debbugs.gnu.org id=B41761.159760669031756 (code B ref 41761); Sun, 16 Aug 2020 19:39:01 +0000 Received: (at 41761) by debbugs.gnu.org; 16 Aug 2020 19:38:10 +0000 Received: from localhost ([127.0.0.1]:58574 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k7OTp-0008G7-Po for submit@debbugs.gnu.org; Sun, 16 Aug 2020 15:38:09 -0400 Received: from sender4-of-o56.zoho.com ([136.143.188.56]:21697) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k7OTo-0008G0-UM for 41761@debbugs.gnu.org; Sun, 16 Aug 2020 15:38:09 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1597606682; cv=none; d=zohomail.com; s=zohoarc; b=Q/GQbfH9dhrJNuFO3afS8Cj+6A9hwwzx/MLKc9KpFmWi+ct06Ix2c+ji3/oa/5S2sVU/92zA/SDvMgTRX4O5KiUrfiZOzS0pIlfTPBsiUcxbYsmOOlZaTITTGDsx9VVj9ad2420+wrfYxRG9AxBrGjaZ9IEEvFegBQULH4KQmuU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1597606682; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=Cv8lwi66B41BBe0ONVbdsxm7DIhVpwXh7mowvqDSTEI=; b=CTyXOdVqdvnb/C+ipT4ok/7EhXje7HMH/CRO/4lIxO5Q/ufraqTVQtv96nD6NZzeiNFes2E0y8h1ILMxB5yKBmA+WE3guRoqGerWH0IhuTCidzzWzhsq0FK7cwXRWkr0CsF1NOXkXXdqLBDPXSHkptSXjeu7V/cKJl3RrOhKanE= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass smtp.mailfrom=dk@danielkoning.com; dmarc=pass header.from= header.from= Received: from cornelius (112.157.239.35.bc.googleusercontent.com [35.239.157.112]) by mx.zohomail.com with SMTPS id 1597606678386865.1067419364703; Sun, 16 Aug 2020 12:37:58 -0700 (PDT) From: Daniel Koning References: <87y2oxwldi.fsf@gmail.com> <83imdllc2l.fsf@gnu.org> <834kp5kpj1.fsf@gnu.org> <838sefkh5t.fsf@gnu.org> <831rk7kdfo.fsf@gnu.org> <83pn7qiss9.fsf@gnu.org> <83tux2gzne.fsf@gnu.org> Date: Sun, 16 Aug 2020 14:37:54 -0500 In-Reply-To: <83tux2gzne.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 16 Aug 2020 22:27:01 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > Thanks, then how about this NEWS entry: > > 'count-words' now crosses field boundaries. > Originally, 'count-words' would stop counting at the first field > boundary it encountered; now it keeps counting all the way to the > region's (or buffer's) end. Looks accurate to me. Thanks! From unknown Sat Jun 21 05:19:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41761: [PATCH] bug#41761: 28.0.50; M-x count-words counts words only up to a field boundary Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Aug 2020 13:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41761 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii , Daniel Koning Cc: 41761@debbugs.gnu.org, pipcet@gmail.com Received: via spool by 41761-submit@debbugs.gnu.org id=B41761.159767227222640 (code B ref 41761); Mon, 17 Aug 2020 13:52:01 +0000 Received: (at 41761) by debbugs.gnu.org; 17 Aug 2020 13:51:12 +0000 Received: from localhost ([127.0.0.1]:59649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k7fXb-0005t5-Ny for submit@debbugs.gnu.org; Mon, 17 Aug 2020 09:51:11 -0400 Received: from mail-yb1-f175.google.com ([209.85.219.175]:41264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k7fXY-0005sq-Jk for 41761@debbugs.gnu.org; Mon, 17 Aug 2020 09:51:10 -0400 Received: by mail-yb1-f175.google.com with SMTP id s195so9454369ybc.8 for <41761@debbugs.gnu.org>; Mon, 17 Aug 2020 06:51:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=oPrOt4oJwPirA0wHQAvOn1CNBKmHbla+iCsJQ2ozDdc=; b=QqPuISqiyS5YngJ9XxTgle163VvFW3xZOXuRvWVzNTHk0a1vXlYec/tfOqsJzLSxTr paocaHUkenkNQ7VIvBqt2njAKOdmlB4nLFw2PCYe4cb+zZzC7M5ubk7TMiSpilmhk4bn tex/rOOFUJBUvhl8HbsHqShk2e+O8ofArMnfNmAvW9TK+km3n5amBXz8E1RvkudGbFDC AlcNYkSmq8YyccoBego9vq4uQbxN+hBaHKW78rk59aGksrrD+X3pNm/J/8a8FJYYqVLy PytCfKvALDFmJhRXlTxmZsUWRFyHGxd+mVWARMSC9BmOLEGifvmEBPuOEDkzPU1nFIFt WUtw== X-Gm-Message-State: AOAM533trtPxzu1UIoDliJYUzSzfL++hGi4cSGpz6V6QeyCS7Cjj5039 HLD2vwPadlpNv885abMjXlkpWanW2yo/m4aPa48= X-Google-Smtp-Source: ABdhPJzX4mbHTT91C6GWyK82uMr47ywZ0Hj3Vwq1qM7aowJe68X7ojhWzo54Spc1/nVISa7++FfLhIg/O5Lvcme5fsQ= X-Received: by 2002:a5b:410:: with SMTP id m16mr19664811ybp.309.1597672263142; Mon, 17 Aug 2020 06:51:03 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 17 Aug 2020 13:51:02 +0000 From: Stefan Kangas In-Reply-To: <83tux2gzne.fsf@gnu.org> References: <87y2oxwldi.fsf@gmail.com> <83imdllc2l.fsf@gnu.org> <834kp5kpj1.fsf@gnu.org> <838sefkh5t.fsf@gnu.org> <831rk7kdfo.fsf@gnu.org> <83pn7qiss9.fsf@gnu.org> <83tux2gzne.fsf@gnu.org> MIME-Version: 1.0 Date: Mon, 17 Aug 2020 13:51:02 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Eli Zaretskii writes: > Thanks, then how about this NEWS entry: > > 'count-words' now crosses field boundaries. > Originally, 'count-words' would stop counting at the first field > boundary it encountered; now it keeps counting all the way to the > region's (or buffer's) end. LGTM as well. Please push to master. (Or, if it's more convenient for you, I could push it in your name.) Best regards, Stefan Kangas From unknown Sat Jun 21 05:19:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41761: [PATCH] bug#41761: 28.0.50; M-x count-words counts words only up to a field boundary Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Aug 2020 16:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41761 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: 41761@debbugs.gnu.org, pipcet@gmail.com, dk@danielkoning.com Received: via spool by 41761-submit@debbugs.gnu.org id=B41761.159768078122133 (code B ref 41761); Mon, 17 Aug 2020 16:13:02 +0000 Received: (at 41761) by debbugs.gnu.org; 17 Aug 2020 16:13:01 +0000 Received: from localhost ([127.0.0.1]:33007 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k7hkq-0005kv-ON for submit@debbugs.gnu.org; Mon, 17 Aug 2020 12:13:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k7hko-0005ki-CO for 41761@debbugs.gnu.org; Mon, 17 Aug 2020 12:12:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59658) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k7hki-00049l-Eq; Mon, 17 Aug 2020 12:12:52 -0400 Received: from [176.228.60.248] (port=4565 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k7hkg-0002xG-Si; Mon, 17 Aug 2020 12:12:51 -0400 Date: Mon, 17 Aug 2020 19:12:37 +0300 Message-Id: <83h7t1gsju.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Stefan Kangas on Mon, 17 Aug 2020 13:51:02 +0000) References: <87y2oxwldi.fsf@gmail.com> <83imdllc2l.fsf@gnu.org> <834kp5kpj1.fsf@gnu.org> <838sefkh5t.fsf@gnu.org> <831rk7kdfo.fsf@gnu.org> <83pn7qiss9.fsf@gnu.org> <83tux2gzne.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Mon, 17 Aug 2020 13:51:02 +0000 > Cc: 41761@debbugs.gnu.org, pipcet@gmail.com > > > 'count-words' now crosses field boundaries. > > Originally, 'count-words' would stop counting at the first field > > boundary it encountered; now it keeps counting all the way to the > > region's (or buffer's) end. > > LGTM as well. Please push to master. Done.