GNU bug report logs - #41756
[PATCH] gnome: gnome-desktop: Add bubblewrap as an input.

Previous Next

Full log

View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 41756 <at> debbugs.gnu.org
Subject: [bug#41756] [PATCH] gnome: gnome-desktop: Add bubblewrap as an input.
Date: Tue, 09 Jun 2020 09:36:59 +0200

Hi!

(There’s a typo in the subject prefix.)

Christopher Baines <mail <at> cbaines.net> skribis:

> This is expected to be available, oddly as libseccomp is available.  These
> changes fix thumbnails for Nautilus.
>
> * gnu/packages/gnome.scm (gnome-desktop)[arguments]: Add 'patch-bubblewrap
> phase.
> [inputs]: Add bubblewrap.

Nice, I didn’t know the thumbnailer would do that.

> +         (add-before 'configure 'patch-bubblewrap
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (substitute* "libgnome-desktop/gnome-desktop-thumbnail-script.c"
> +               (("\"bwrap\",")
> +                (string-append "\"" (which "bwrap") "\","))
> +               (("\"--ro-bind\", \"/usr\", \"/usr\",")
> +                (string-append "\"--ro-bind\", \""
> +                               (%store-directory)
> +                               "\", \""
> +                               (%store-directory)
> +                               "\","))
> +               (("\"--ro-bind\", \"/etc/ld.so.cache\", \"/etc/ld.so.cache\",")
> +                "\"--ro-bind\", \"/run/current-system\", \"/run/current-system\","))

Perhaps we can replace this second --ro-bind with the empty string?

Otherwise LGTM!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.