GNU bug report logs - #41756
[PATCH] gnome: gnome-desktop: Add bubblewrap as an input.

Previous Next

Full log

Message #13 received at 41756-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 41756-done <at> debbugs.gnu.org
Subject: Re: [bug#41756] [PATCH] gnome: gnome-desktop: Add bubblewrap as an
 input.
Date: Sat, 13 Jun 2020 12:04:38 +0100

[Message part 1 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi!
>
> (There’s a typo in the subject prefix.)
>
> Christopher Baines <mail <at> cbaines.net> skribis:
>
>> This is expected to be available, oddly as libseccomp is available.  These
>> changes fix thumbnails for Nautilus.
>>
>> * gnu/packages/gnome.scm (gnome-desktop)[arguments]: Add 'patch-bubblewrap
>> phase.
>> [inputs]: Add bubblewrap.
>
> Nice, I didn’t know the thumbnailer would do that.
>
>> +         (add-before 'configure 'patch-bubblewrap
>> +           (lambda* (#:key inputs #:allow-other-keys)
>> +             (substitute* "libgnome-desktop/gnome-desktop-thumbnail-script.c"
>> +               (("\"bwrap\",")
>> +                (string-append "\"" (which "bwrap") "\","))
>> +               (("\"--ro-bind\", \"/usr\", \"/usr\",")
>> +                (string-append "\"--ro-bind\", \""
>> +                               (%store-directory)
>> +                               "\", \""
>> +                               (%store-directory)
>> +                               "\","))
>> +               (("\"--ro-bind\", \"/etc/ld.so.cache\", \"/etc/ld.so.cache\",")
>> +                "\"--ro-bind\", \"/run/current-system\", \"/run/current-system\","))
>
> Perhaps we can replace this second --ro-bind with the empty string?
>
> Otherwise LGTM!

Great, I've replaced the second --ro-bind as you suggested, that seems
not to be necessary. I've pushed as
3857aba7ab25c50d64a6d7468d2b5b09bc4f5d60.

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.