From unknown Sat Jun 14 19:46:25 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#41756] [PATCH] gnome: gnome-desktop: Add bubblewrap as an input. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 07 Jun 2020 20:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 41756 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 41756@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159156135515976 (code B ref -1); Sun, 07 Jun 2020 20:23:01 +0000 Received: (at submit) by debbugs.gnu.org; 7 Jun 2020 20:22:35 +0000 Received: from localhost ([127.0.0.1]:55036 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ji1oQ-00049c-Mi for submit@debbugs.gnu.org; Sun, 07 Jun 2020 16:22:34 -0400 Received: from lists.gnu.org ([209.51.188.17]:38168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ji1oO-00049T-RK for submit@debbugs.gnu.org; Sun, 07 Jun 2020 16:22:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35570) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ji1oO-000706-LZ for guix-patches@gnu.org; Sun, 07 Jun 2020 16:22:32 -0400 Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27]:39821) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ji1oN-00031g-NO for guix-patches@gnu.org; Sun, 07 Jun 2020 16:22:32 -0400 Received: from localhost (unknown [46.237.173.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 6191027BBE1 for ; Sun, 7 Jun 2020 21:22:29 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 05d8ccaf for ; Sun, 7 Jun 2020 20:22:26 +0000 (UTC) From: Christopher Baines Date: Sun, 7 Jun 2020 21:22:26 +0100 Message-Id: <20200607202226.15637-1-mail@cbaines.net> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/07 16:22:29 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is expected to be available, oddly as libseccomp is available. These changes fix thumbnails for Nautilus. * gnu/packages/gnome.scm (gnome-desktop)[arguments]: Add 'patch-bubblewrap phase. [inputs]: Add bubblewrap. --- gnu/packages/gnome.scm | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index 592cab0b49..92411fb698 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -1286,6 +1286,20 @@ offline sources, providing a centralized place for managing your contacts.") (("\"locale\"") (string-append "\"" libc "/bin/locale\""))) #t))) + (add-before 'configure 'patch-bubblewrap + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "libgnome-desktop/gnome-desktop-thumbnail-script.c" + (("\"bwrap\",") + (string-append "\"" (which "bwrap") "\",")) + (("\"--ro-bind\", \"/usr\", \"/usr\",") + (string-append "\"--ro-bind\", \"" + (%store-directory) + "\", \"" + (%store-directory) + "\",")) + (("\"--ro-bind\", \"/etc/ld.so.cache\", \"/etc/ld.so.cache\",") + "\"--ro-bind\", \"/run/current-system\", \"/run/current-system\",")) + #t)) (add-before 'check 'pre-check (lambda* (#:key inputs #:allow-other-keys) ;; Tests require a running X server and locales. @@ -1315,6 +1329,7 @@ offline sources, providing a centralized place for managing your contacts.") (inputs `(("gdk-pixbuf" ,gdk-pixbuf) ("glib" ,glib) + ("bubblewrap" ,bubblewrap) ("libxext" ,libxext) ("libxkbfile" ,libxkbfile) ("libxrandr" ,libxrandr))) -- 2.26.2 From unknown Sat Jun 14 19:46:25 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#41756] [PATCH] gnome: gnome-desktop: Add bubblewrap as an input. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 09 Jun 2020 07:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41756 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 41756@debbugs.gnu.org Received: via spool by 41756-submit@debbugs.gnu.org id=B41756.159168823216146 (code B ref 41756); Tue, 09 Jun 2020 07:38:01 +0000 Received: (at 41756) by debbugs.gnu.org; 9 Jun 2020 07:37:12 +0000 Received: from localhost ([127.0.0.1]:58736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiYop-0004CL-TO for submit@debbugs.gnu.org; Tue, 09 Jun 2020 03:37:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiYoo-0004C8-2r for 41756@debbugs.gnu.org; Tue, 09 Jun 2020 03:37:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36517) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiYoi-00083t-Ft; Tue, 09 Jun 2020 03:37:04 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=58634 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jiYoe-0006XD-QK; Tue, 09 Jun 2020 03:37:03 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200607202226.15637-1-mail@cbaines.net> Date: Tue, 09 Jun 2020 09:36:59 +0200 In-Reply-To: <20200607202226.15637-1-mail@cbaines.net> (Christopher Baines's message of "Sun, 7 Jun 2020 21:22:26 +0100") Message-ID: <87r1uoofl0.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! (There=E2=80=99s a typo in the subject prefix.) Christopher Baines skribis: > This is expected to be available, oddly as libseccomp is available. These > changes fix thumbnails for Nautilus. > > * gnu/packages/gnome.scm (gnome-desktop)[arguments]: Add 'patch-bubblewrap > phase. > [inputs]: Add bubblewrap. Nice, I didn=E2=80=99t know the thumbnailer would do that. > + (add-before 'configure 'patch-bubblewrap > + (lambda* (#:key inputs #:allow-other-keys) > + (substitute* "libgnome-desktop/gnome-desktop-thumbnail-scri= pt.c" > + (("\"bwrap\",") > + (string-append "\"" (which "bwrap") "\",")) > + (("\"--ro-bind\", \"/usr\", \"/usr\",") > + (string-append "\"--ro-bind\", \"" > + (%store-directory) > + "\", \"" > + (%store-directory) > + "\",")) > + (("\"--ro-bind\", \"/etc/ld.so.cache\", \"/etc/ld.so.cach= e\",") > + "\"--ro-bind\", \"/run/current-system\", \"/run/current-= system\",")) Perhaps we can replace this second --ro-bind with the empty string? Otherwise LGTM! Ludo=E2=80=99. From unknown Sat Jun 14 19:46:25 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Christopher Baines Subject: bug#41756: closed (Re: [bug#41756] [PATCH] gnome: gnome-desktop: Add bubblewrap as an input.) Message-ID: References: <87r1uj8bw9.fsf@cbaines.net> <20200607202226.15637-1-mail@cbaines.net> X-Gnu-PR-Message: they-closed 41756 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 41756@debbugs.gnu.org Date: Sat, 13 Jun 2020 11:05:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1592046302-13676-1" This is a multi-part message in MIME format... ------------=_1592046302-13676-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #41756: [PATCH] gnome: gnome-desktop: Add bubblewrap as an input. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 41756@debbugs.gnu.org. --=20 41756: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D41756 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1592046302-13676-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 41756-done) by debbugs.gnu.org; 13 Jun 2020 11:04:43 +0000 Received: from localhost ([127.0.0.1]:40932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jk3xr-0003Xx-5P for submit@debbugs.gnu.org; Sat, 13 Jun 2020 07:04:43 -0400 Received: from mira.cbaines.net ([212.71.252.8]:51690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jk3xp-0003Xq-Un for 41756-done@debbugs.gnu.org; Sat, 13 Jun 2020 07:04:42 -0400 Received: from localhost (unknown [46.237.175.96]) by mira.cbaines.net (Postfix) with ESMTPSA id 5571327BBE1; Sat, 13 Jun 2020 12:04:41 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 8007812c; Sat, 13 Jun 2020 11:04:39 +0000 (UTC) References: <20200607202226.15637-1-mail@cbaines.net> <87r1uoofl0.fsf@gnu.org> User-agent: mu4e 1.2.0; emacs 26.3 From: Christopher Baines To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#41756] [PATCH] gnome: gnome-desktop: Add bubblewrap as an input. In-reply-to: <87r1uoofl0.fsf@gnu.org> Date: Sat, 13 Jun 2020 12:04:38 +0100 Message-ID: <87r1uj8bw9.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41756-done Cc: 41756-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi! > > (There=E2=80=99s a typo in the subject prefix.) > > Christopher Baines skribis: > >> This is expected to be available, oddly as libseccomp is available. The= se >> changes fix thumbnails for Nautilus. >> >> * gnu/packages/gnome.scm (gnome-desktop)[arguments]: Add 'patch-bubblewr= ap >> phase. >> [inputs]: Add bubblewrap. > > Nice, I didn=E2=80=99t know the thumbnailer would do that. > >> + (add-before 'configure 'patch-bubblewrap >> + (lambda* (#:key inputs #:allow-other-keys) >> + (substitute* "libgnome-desktop/gnome-desktop-thumbnail-scr= ipt.c" >> + (("\"bwrap\",") >> + (string-append "\"" (which "bwrap") "\",")) >> + (("\"--ro-bind\", \"/usr\", \"/usr\",") >> + (string-append "\"--ro-bind\", \"" >> + (%store-directory) >> + "\", \"" >> + (%store-directory) >> + "\",")) >> + (("\"--ro-bind\", \"/etc/ld.so.cache\", \"/etc/ld.so.cac= he\",") >> + "\"--ro-bind\", \"/run/current-system\", \"/run/current= -system\",")) > > Perhaps we can replace this second --ro-bind with the empty string? > > Otherwise LGTM! Great, I've replaced the second --ro-bind as you suggested, that seems not to be necessary. I've pushed as 3857aba7ab25c50d64a6d7468d2b5b09bc4f5d60. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl7kssZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XdYMw/7BA1FB/HwTxiDW/t71BEeDjcMMsgRoc9m9sYc2tjPZny524ay8GT3y0hD AX7ozd/S4KXJIhwMLVTZVr2WNCL2m2vcoI0QK7koVbYemyEqsRT14+5wj9OmfUpt JDubZzBYOglr8tdFDrX/fAdvKZTWZiCUCFo9+CZX+Kcj/pCrt4jVnIXc48GbHHRu MS3SdUChetBylgQAV2zd/xsSZliUzRGN19cwJbSYRrTuAHJnHupn0SDfEUJylkFI rAucdoQ6w4GqLvHfHzoUtaRmRUlqBhpO+IHHSqC4XuboeNhNxfthcq+mGst5wxE8 J9vIbYxQEqnlGcgphv1GngP0t9N64gjH8zQN2sIamlY9i15uPzXRFuwZlOjTh2Ru /EcsjOIfHzsSX5ns9kKU//qPqxVrjUfDXzCp+9XF7CQNq/HsmpGTAZHqCUxRfxhL ZyLhe+REumtKW3Yyy5++VNZWfxuN2/YgKsOtxIMp4GPw/6ClqALa01PUHqRjSnkq KUsHKJpGE5KtTslhmjnbyueaPW4yiIwk8lCmgQ3HXMB0uN1odhTX32jegwX9MjqW IjnrXJLkGAuZY+ItLs6NggDzC4I+FRU7cwzCGyfAPKN0UpbV2oH9h05DLv3S8vUZ hzkYu3fn4pe81VjwWughIoR8RtrqSc1zOdEGqvmHQjCXc0+g0kM= =ns+d -----END PGP SIGNATURE----- --=-=-=-- ------------=_1592046302-13676-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 7 Jun 2020 20:22:35 +0000 Received: from localhost ([127.0.0.1]:55036 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ji1oQ-00049c-Mi for submit@debbugs.gnu.org; Sun, 07 Jun 2020 16:22:34 -0400 Received: from lists.gnu.org ([209.51.188.17]:38168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ji1oO-00049T-RK for submit@debbugs.gnu.org; Sun, 07 Jun 2020 16:22:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35570) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ji1oO-000706-LZ for guix-patches@gnu.org; Sun, 07 Jun 2020 16:22:32 -0400 Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27]:39821) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ji1oN-00031g-NO for guix-patches@gnu.org; Sun, 07 Jun 2020 16:22:32 -0400 Received: from localhost (unknown [46.237.173.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 6191027BBE1 for ; Sun, 7 Jun 2020 21:22:29 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 05d8ccaf for ; Sun, 7 Jun 2020 20:22:26 +0000 (UTC) From: Christopher Baines To: guix-patches@gnu.org Subject: [PATCH] gnome: gnome-desktop: Add bubblewrap as an input. Date: Sun, 7 Jun 2020 21:22:26 +0100 Message-Id: <20200607202226.15637-1-mail@cbaines.net> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/07 16:22:29 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is expected to be available, oddly as libseccomp is available. These changes fix thumbnails for Nautilus. * gnu/packages/gnome.scm (gnome-desktop)[arguments]: Add 'patch-bubblewrap phase. [inputs]: Add bubblewrap. --- gnu/packages/gnome.scm | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index 592cab0b49..92411fb698 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -1286,6 +1286,20 @@ offline sources, providing a centralized place for managing your contacts.") (("\"locale\"") (string-append "\"" libc "/bin/locale\""))) #t))) + (add-before 'configure 'patch-bubblewrap + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "libgnome-desktop/gnome-desktop-thumbnail-script.c" + (("\"bwrap\",") + (string-append "\"" (which "bwrap") "\",")) + (("\"--ro-bind\", \"/usr\", \"/usr\",") + (string-append "\"--ro-bind\", \"" + (%store-directory) + "\", \"" + (%store-directory) + "\",")) + (("\"--ro-bind\", \"/etc/ld.so.cache\", \"/etc/ld.so.cache\",") + "\"--ro-bind\", \"/run/current-system\", \"/run/current-system\",")) + #t)) (add-before 'check 'pre-check (lambda* (#:key inputs #:allow-other-keys) ;; Tests require a running X server and locales. @@ -1315,6 +1329,7 @@ offline sources, providing a centralized place for managing your contacts.") (inputs `(("gdk-pixbuf" ,gdk-pixbuf) ("glib" ,glib) + ("bubblewrap" ,bubblewrap) ("libxext" ,libxext) ("libxkbfile" ,libxkbfile) ("libxrandr" ,libxrandr))) -- 2.26.2 ------------=_1592046302-13676-1--