From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 07 15:25:22 2020 Received: (at submit) by debbugs.gnu.org; 7 Jun 2020 19:25:22 +0000 Received: from localhost ([127.0.0.1]:54926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ji0v4-0000WR-BD for submit@debbugs.gnu.org; Sun, 07 Jun 2020 15:25:22 -0400 Received: from lists.gnu.org ([209.51.188.17]:51876) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ji0v2-0000WG-0K for submit@debbugs.gnu.org; Sun, 07 Jun 2020 15:25:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58040) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ji0v1-00087J-QH for bug-gnu-emacs@gnu.org; Sun, 07 Jun 2020 15:25:19 -0400 Received: from mx.sdf.org ([205.166.94.20]:59828) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ji0uz-0000f2-RF for bug-gnu-emacs@gnu.org; Sun, 07 Jun 2020 15:25:19 -0400 Received: from sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 057JP4Fa019353 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Sun, 7 Jun 2020 19:25:04 GMT Received: (from akrl@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 057JP3bZ022096; Sun, 7 Jun 2020 19:25:03 GMT From: Andrea Corallo To: bug-gnu-emacs@gnu.org Subject: feature/native-comp (master?): temacs crash in GC during mark phase Date: Sun, 07 Jun 2020 20:16:08 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=205.166.94.20; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/07 15:25:15 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Nicolas =?utf-8?Q?B=C3=A9rtolo?= , Paul Eggert X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) I'm experiencing non reproducible GC related crashes building feature/native-comp. Both back-traces I've got looks similar: #0 0x00000000004dfe4c in symbol_marked_p (s=3D0xb4f0) at pdumper.h:149 #1 mark_object (arg=3D) at alloc.c:6731 #2 0x0000000000552390 in traverse_intervals_noorder (tree=3D0xffffffffe070, function=3D0x4e0fe0 , arg=3D0x0) at intervals.c:2= 34 #3 0x00000000004e0060 in mark_object (arg=3D) at alloc.c:67= 84 #4 0x00000000004e08ec in mark_memory (end=3D, start=3D) at alloc.c:4860 #5 mark_stack (bottom=3D, end=3Dend@entry=3D0xffffffff71d0 = "") at alloc.c:5071 #6 0x000000000055fd48 in mark_one_thread (thread=3D0x903b80 ) at thread.c:630 #7 mark_threads_callback (ignore=3D) at thread.c:661 #8 0x00000000004e1238 in garbage_collect () at alloc.c:6101 #9 0x00000000004ff874 in maybe_gc () at lisp.h:5090 #10 eval_sub (form=3Dform@entry=3DXIL(0xcefe63)) at eval.c:2243 #11 0x0000000000500108 in Fwhile (args=3D) at eval.c:1013 ... During: ./temacs --batch -l loadup --temacs=3Dpbootstrap Not sure why but this looks easier to reproduce on aarch64 (even if most of the times is still bootstraping clean). IIUC in this case we are trying to access (struct Lisp_Symbol *) 0xb4f0 but the memory cannot be accessed. The address looks quite odd to me and infact checking with 'info proc mappings' the lowest mapped memory seams to start at 0x400000. So far I was not able to reproduce on X86_64 (where I've rr). This may not be related to feature/native-comp but to one of the recent GC changes and the stack marking strategy. I suspect Nicolas may be observing the same issue on Windows https://lists.gnu.org/archive/html/bug-gnu-emacs/2020-06/msg00320.html I'll keep on looking into this. Regards Andrea In GNU Emacs 28.0.50 (build 1, aarch64-unknown-linux-gnu) of 2020-06-06 built on Repository revision: 3d576c784b3fa01b4d6b33a4172351b7c3a61660 Repository branch: HEAD System Description: Ubuntu 18.04.3 LTS Recent messages: Grep finished with 2 matches found Current locus from *grep* Mark set [2 times] Reverting buffer =E2=80=98Makefile=E2=80=99. Mark set [2 times] Mark saved where search started Mark set [4 times] File GTAGS not found. Run 'gtags'? (y or n) y Quit [2 times] No match Configured using: 'configure --with-nativecomp --with-x-toolkit=3Dno --with-xpm=3Difavailable --with-jpeg=3Difavailable --with-png=3Difavailable --with-gif=3Difavailable --with-tiff=3Difavailable --with-gnutls=3Difavailable --with-nativecomp --prefix=3D/home/koral' Configured features: SOUND NOTIFY INOTIFY ZLIB MODULES THREADS PDUMPER GMP Important settings: value of $LC_ALL: en_US.utf8 value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Debugger Minor modes in effect: global-magit-file-mode: t magit-auto-revert-mode: t global-git-commit-mode: t shell-dirtrack-mode: t recentf-mode: t savehist-mode: t global-ede-mode: t beacon-mode: t global-git-gutter-mode: t global-whitespace-mode: t delete-selection-mode: t async-bytecomp-package-mode: t helm--remap-mouse-mode: t show-paren-mode: t global-undo-tree-mode: t undo-tree-mode: t winner-mode: t global-auto-revert-mode: t display-time-mode: t which-key-mode: t projectile-mode: t global-company-mode: t company-mode: t global-flycheck-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: ~/.emacs.d/lisp/verilog-mode hides /home/koral/share/emacs/28.0.50/lisp/pro= gmodes/verilog-mode Features: (shadow sort mail-extr emacsbug sendmail find-dired make-mode help-fns radix-tree git-rebase vc-annotate vc vc-dispatcher two-column iso-transl semantic/db-file data-debug cedet-files ede/locate semantic/lex-spp vc-git bug-reference macrostep-c cmacexp macrostep hideshow misearch multi-isearch magit-extras magit-bookmark magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log magit-diff smerge-mode diff-mode magit-core magit-autorevert magit-margin magit-transient magit-process git-commit log-edit message rmc puny rfc822 mml mml-sec epa derived epg epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader pcvs-util add-log with-editor ffap tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat shell parse-time iso8601 ls-lisp ivy colir ivy-overlay cus-start cus-load ede/emacs semantic/db semantic/util-modes semantic/util semantic semantic/tag semantic/lex semantic/fw mode-local ede/dired mule-util recentf tree-widget helm-x-files helm-sys term/xterm xterm paredit gnus nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045 ietf-drums mail-utils mm-util mail-prsvr wdired dired dired-loaddefs sanityinc-tomorrow-eighties-theme color-theme-sanityinc-tomorrow color elisp-slime-nav ob-lisp org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete pcomplete org-list org-faces org-entities time-date noutline outline org-version ob-emacs-lisp ob-core ob-eval org-table ol org-keys org-compat org-macs org-loaddefs cal-menu calendar cal-loaddefs server savehist ede/speedbar ede/files ede ede/detect ede/base ede/auto ede/source eieio-base eieio-speedbar speedbar ezimage dframe eieio-custom wid-edit cedet beacon elisp-depend google-translate google-translate-default-ui google-translate-core-ui google-translate-core google-translate-tk google-translate-backend git-gutter helm-gtags pulse which-func imenu whitespace bash-completion vlf vlf-base vlf-tune flex-mode jison-mode bison-mode cc-mode cc-guess cc-menus cc-cmds cc-styles cc-align cc-fonts cc-engine cc-vars cc-defs git f s helm-git-grep delsel magit-mode magit-git magit-utils crm magit-section transient helm-swoop ido helm-command helm-elisp helm-eval edebug backtrace helm-for-files helm-bookmark helm-adaptive helm-info bookmark text-property-search pp helm-external helm-net xml url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap helm-mode helm-files helm-buffers helm-occur helm-tags helm-locate helm-grep helm-regexp format-spec helm-utils helm-help helm-types helm-config helm-easymenu async-bytecomp helm helm-source eieio-compat helm-multi-match helm-lib async paren undo-tree diff winner windmove autorevert filenotify ibuf-macs time image which-key advice projectile grep compile ibuf-ext ibuffer ibuffer-loaddefs thingatpt company-oddmuse company-keywords company-etags etags fileloop generator xref project company-gtags company-dabbrev-code company-dabbrev company-files company-capf company-cmake company-xcode company-clang company-semantic company-eclim company-template company-bbdb company pcase flycheck find-func dash gcmh comp rx cl-extra help-mode k-utils gud easy-mmode comint regexp-opt ansi-color ring edmacro kmacro slime-autoloads info tool-bar package easymenu browse-url url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads inotify multi-tty make-network-process emacs) Memory information: ((conses 16 2475879 106891) (symbols 48 40051 2) (strings 32 181600 47924) (string-bytes 1 9741313) (vectors 16 77416) (vector-slots 8 1228210 168271) (floats 8 780 7731) (intervals 56 158344 397) (buffers 992 56)) From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 07 15:42:03 2020 Received: (at 41755) by debbugs.gnu.org; 7 Jun 2020 19:42:03 +0000 Received: from localhost ([127.0.0.1]:54964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ji1BC-00035k-SJ for submit@debbugs.gnu.org; Sun, 07 Jun 2020 15:42:03 -0400 Received: from mail-oo1-f50.google.com ([209.85.161.50]:44921) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ji1BB-00035G-2e for 41755@debbugs.gnu.org; Sun, 07 Jun 2020 15:42:01 -0400 Received: by mail-oo1-f50.google.com with SMTP id e8so3059449ooi.11 for <41755@debbugs.gnu.org>; Sun, 07 Jun 2020 12:42:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=llhhXsY1L4MdomTZxsvML3bCCLfFxT8+pfux8bl9H8Q=; b=A0QchO26qWylgzcce718YjprgG4xBnhlJgiQUv4/KSCYVpezroUzwkzAnUcmlC5SbE NvdPokfIGGK8MxJQQl6eKhQT65ef3oQ4OvXRvpcBnqU4oGgMqLv1kqGH8GiU+7NZ7g68 KFvt+7t7NrBu4oONTcLtJXZ1HXTKlDaXTLIquMTkD2YNg8EKqdT312Aah9lV77cAxSZ7 xigrO6PB7UEFliOUJzE1dOGQz77srTBlS25JuhA3yPdqiwYUMVjWmCNSGs6K8EH0TlmP MD7PpLegVtlHTOmQr86P1RiiKtYlZ3OYDiOrp6USiO3eNWlXBYDe0VigWDM43lty/5jK r9og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=llhhXsY1L4MdomTZxsvML3bCCLfFxT8+pfux8bl9H8Q=; b=umIIO0+/9HI79YB1U+lOB4xoDTHzjoYpzi+xfbFnoh/kQh/8uagca8/0utjSW1bZ+I CZ02NTZbzWhnJLYpo9keHjcbmsbtEJhW/cGMl8FSZOhBKqaEam1ds0kMvbsFSjLuNcDC Vzdi6dOGwzIbIh2AzjnFel0KomfFRR0WXS6J7cQIQsISG/RCMYmeC6o/it0XfYOGRE5A l//tS9kPa60KA5L9z86BKFooJd7lxPHSNRPKL6DxMcx4sXd7ECOd9O/W1ieVUFhe0z4r AY0j9RCUq+fFgp7KiLeAlS0QxY5kfE0qN20pDYIJWMh42Bw8AXgslZDVAqHmmD/3MOio 93KA== X-Gm-Message-State: AOAM530fBdxf8zXO1DEF/FeSvG1t+Q7GcgSQHrJc2FbYJdpwT6TVpDS0 ZsQeBCYx23DRt/549gjuTn91sApJuz+UvLp25c0= X-Google-Smtp-Source: ABdhPJyMbnLt+IVAF7p5SOK1ylvbM3/pbdLwgfK9EF3CMBihEK4AuYE1rTKRUmoiir7f7p4IPTHxZ4f4qkRhQDhjIZM= X-Received: by 2002:a4a:94d1:: with SMTP id l17mr15038945ooi.88.1591558915405; Sun, 07 Jun 2020 12:41:55 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Pip Cet Date: Sun, 7 Jun 2020 19:41:19 +0000 Message-ID: Subject: Re: bug#41755: feature/native-comp (master?): temacs crash in GC during mark phase To: Andrea Corallo Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 41755 Cc: =?UTF-8?Q?Nicolas_B=C3=A9rtolo?= , Paul Eggert , 41755@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, Jun 7, 2020 at 7:26 PM Andrea Corallo wrote: > I'm experiencing non reproducible GC related crashes building > feature/native-comp. Does it happen for non-optimized builds? Also, what symbol is at Lisp_Object value 0xb4f0 (i.e. iQwhatever == 405)? > Both back-traces I've got looks similar: > > #0 0x00000000004dfe4c in symbol_marked_p (s=0xb4f0) at pdumper.h:149 > #1 mark_object (arg=) at alloc.c:6731 > #2 0x0000000000552390 in traverse_intervals_noorder (tree=0xffffffffe070, > function=0x4e0fe0 , arg=0x0) at intervals.c:234 > #3 0x00000000004e0060 in mark_object (arg=) at alloc.c:6784 > #4 0x00000000004e08ec in mark_memory (end=, start=) > at alloc.c:4860 > #5 mark_stack (bottom=, end=end@entry=0xffffffff71d0 "") > at alloc.c:5071 > #6 0x000000000055fd48 in mark_one_thread (thread=0x903b80 ) > at thread.c:630 > #7 mark_threads_callback (ignore=) at thread.c:661 > #8 0x00000000004e1238 in garbage_collect () at alloc.c:6101 > #9 0x00000000004ff874 in maybe_gc () at lisp.h:5090 > #10 eval_sub (form=form@entry=XIL(0xcefe63)) at eval.c:2243 > #11 0x0000000000500108 in Fwhile (args=) at eval.c:1013 > ... > So far I was not able to reproduce on X86_64 (where I've rr). Please let us know if you manage to. > This may not be related to feature/native-comp but to one of the recent > GC changes and the stack marking strategy. Or to the live_*_p changes... From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 07 15:58:19 2020 Received: (at 41755) by debbugs.gnu.org; 7 Jun 2020 19:58:19 +0000 Received: from localhost ([127.0.0.1]:55003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ji1Qx-0003WM-24 for submit@debbugs.gnu.org; Sun, 07 Jun 2020 15:58:19 -0400 Received: from mail-oo1-f46.google.com ([209.85.161.46]:37652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ji1Qu-0003W6-V5 for 41755@debbugs.gnu.org; Sun, 07 Jun 2020 15:58:17 -0400 Received: by mail-oo1-f46.google.com with SMTP id q188so3068908ooq.4 for <41755@debbugs.gnu.org>; Sun, 07 Jun 2020 12:58:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=F4iI36isrMDIfoaswv37hpuPx+PLHrELKRyVXB+jrOI=; b=N3i0JMcHZ23HLcuKUTSPNKMxhczxrlok7uQkOYXDlOj+ZZrVuoewfAuu4xcJqKiJv+ /Qe1XYwSjoZ9inlIOeyRQs2KDXB8ayaVsxPwcf7ry1++5FhohxU6AV4vpLKxweBlBMld sFa/lA7flDt7c/ujqA/xpED4eXU04/CoOAqVqvSBcN3nwS5ZEz0ZY+ccwfM3PqCTAlK3 uwuDye9PrXI8RSF3yS68gAD6J6i4o+erWEs1qMvTSGDshe6QMEITWvBeT1nNjaTDSCOQ //MyBIM9yFICZfKCPgzptwHZarRWwbS1KT+Ap8jSav7B10KxlMjxu09MT+DQH+G4fHcL aGFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F4iI36isrMDIfoaswv37hpuPx+PLHrELKRyVXB+jrOI=; b=O2IcaUjAh3EKssoyxyY1odXnT4MlhCp82JUC4zRf9W04jt5JGDamBgmVjOlwQkUpXc N53LhqTtN69OOjotLLv+JMCFyWmfVdTH8hZ8YwpHmPtQuYi+g3D84BidcbWQe//170eQ V8zDWVwE55Q1XxahFJoPutbrPfhM2zEIrnJNppGSfZHZFGa4u9p898+5KImQMNDJHY1D wJaymorEK5TeOyAs2yrr7yrqdlPed0SoOlcLGuk4zjh6R8cnFg6gZk61kDgr3pxbG8gq FwjWYCfGhmgDo4dYbIvH7NrQSoIa2I6b+CmwNcUibVEfBxOGAupB6B3O8Q9EIhOdOydl +Y9w== X-Gm-Message-State: AOAM530f2uOgpcg/OqomiDq2VVztzbguJVi0yi6/CsBMp6BsFpDn5nI7 313q5MI2y7OeYok8v5RT5lbYRstoIj6Q4tfqE+M= X-Google-Smtp-Source: ABdhPJygAmaQBdjMzsXsaSaFgNtpXqvlZ4oApdQST01KgnJj9BkrlY3AWKy9GCLIbv8BM3fRmrAXWSUif2B1/zd0dxw= X-Received: by 2002:a4a:e049:: with SMTP id v9mr1478090oos.22.1591559891330; Sun, 07 Jun 2020 12:58:11 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: =?UTF-8?Q?Nicolas_B=C3=A9rtolo?= Date: Sun, 7 Jun 2020 16:57:59 -0300 Message-ID: Subject: Re: bug#41755: feature/native-comp (master?): temacs crash in GC during mark phase To: Pip Cet Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 41755 Cc: Paul Eggert , 41755@debbugs.gnu.org, Andrea Corallo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, I can confirm that what I found was this issue. > Does it happen for non-optimized builds? Also, what symbol is at > Lisp_Object value 0xb4f0 (i.e. iQwhatever == 405)? I haven't been able to reproduce it in non-optimized builds. What I understand so far is that the GC begins marking the stack of the main thread and it takes some data in the stack as a pointer to valid Lisp data. It starts following all the pointers and it eventually SIGSEGVs. I have seen it crash trying to read symbols, conses and strings. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 07 16:18:51 2020 Received: (at 41755) by debbugs.gnu.org; 7 Jun 2020 20:18:51 +0000 Received: from localhost ([127.0.0.1]:55019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ji1kp-00042U-FV for submit@debbugs.gnu.org; Sun, 07 Jun 2020 16:18:51 -0400 Received: from mail-ot1-f52.google.com ([209.85.210.52]:34681) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ji1ko-00042H-QG for 41755@debbugs.gnu.org; Sun, 07 Jun 2020 16:18:51 -0400 Received: by mail-ot1-f52.google.com with SMTP id b18so11981347oti.1 for <41755@debbugs.gnu.org>; Sun, 07 Jun 2020 13:18:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=3xQiyn3PlTAkUIe4f0tPumPM7VodpZ5QZICTlTA/+fU=; b=UvU7BNl0Y/UTCHr/ZqfY3GQ7gWlUvoCWSC77/JtyFeRisMLVgo3jols12UA6PyAYZM XO3Ur2qL0hL4vMavKRfiMLSPZTq9ilcr+nd7AkMKGLVN/7cq/BdndUXvaesy0EO3vS3t JOJR3OTutIitOC0fp9ByOgaq0j9Sau3I8yDh7hf1StwKLKfCYhRLOjwY+dAzNWWfm7pK PGPZVO0x5Z1XX1k9QzevgHpoAtr1v9mW0vwemowH8FypEkSQ+qiJrezCzQx96o81lT3t w+f5PKPj5cFfGyPZ8EeXl/mhUWrK7WUJN0mlr4MbaGb2u6j6iqC9N9C4zfGCoSsNA+ot zfWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=3xQiyn3PlTAkUIe4f0tPumPM7VodpZ5QZICTlTA/+fU=; b=arUha+VkTmk0jalw8rKFreEmeI1QdaCy2aG8GmhNDmRQg6ZMVUd0H6ll9cECY1MT4a SdT1TEyXoeOwpKmXq/HNkayO3a0e4neeN+ykNK6LL4PuzW6zZN19hofpYC3AWjWvhNic xGkVA1q8QSRgeTnRRQAZU9Zuy+yRyCVS81rSHv/ugp99KR4wsqHlJftbWTVXn0Runy6A yPHKH7c6XYYj9vIc+bMipjYIb1UjNz4NRam62uvSgNJzrOhKCaKPmYfO6KKCfYhyHk1t Hli+5KPwIvOcWD5FApLd9frVlIObd9ljRXFGvGT8oi+2rD3BVZo/XnVjIEvW7Kw7d7Rs G6mw== X-Gm-Message-State: AOAM530t8ciwHwvl5sBo1PLCtdZqhT0JIPnA0HtVIPKRkM/0LZhG4wvD ULMXxbDV8/Ta/BQ6xla18nD+6VoqpQYQLJufzls= X-Google-Smtp-Source: ABdhPJxIqdEl9T/doioc7Q7I+HG6p2ke6pPFNaSPBuEBMMJ5+Ec/qjpyK2/HQ275njCd7h2Ya7g/9Hm71OpztIb5Rfk= X-Received: by 2002:a9d:6a44:: with SMTP id h4mr15630873otn.287.1591561125156; Sun, 07 Jun 2020 13:18:45 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Pip Cet Date: Sun, 7 Jun 2020 20:18:09 +0000 Message-ID: Subject: Re: bug#41755: feature/native-comp (master?): temacs crash in GC during mark phase To: =?UTF-8?Q?Nicolas_B=C3=A9rtolo?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 41755 Cc: Paul Eggert , 41755@debbugs.gnu.org, Andrea Corallo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, Jun 7, 2020 at 7:58 PM Nicolas B=C3=A9rtolo wrote: > I can confirm that what I found was this issue. > > > Does it happen for non-optimized builds? Also, what symbol is at > > Lisp_Object value 0xb4f0 (i.e. iQwhatever =3D=3D 405)? > > I haven't been able to reproduce it in non-optimized builds. But you still have last_marked in your build, right? That would be a good starting point to find out which object was marked and what was actually on the stack there... > What I understand so far is that the GC begins marking the stack of the m= ain > thread and it takes some data in the stack as a pointer to valid Lisp dat= a. That's my understanding as well. In Andrea's case, it looks like something was marked as though it were a symbol, but it was actually pointing back to the stack... > It > starts following all the pointers and it eventually SIGSEGVs. I have seen= it > crash trying to read symbols, conses and strings. Is it always a symbol that's found on the stack by mark_maybe_*, though? From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 07 19:09:30 2020 Received: (at 41755) by debbugs.gnu.org; 7 Jun 2020 23:09:30 +0000 Received: from localhost ([127.0.0.1]:55200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ji4Py-0001sR-5j for submit@debbugs.gnu.org; Sun, 07 Jun 2020 19:09:30 -0400 Received: from mail-ot1-f68.google.com ([209.85.210.68]:32985) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ji4Pw-0001sC-IL for 41755@debbugs.gnu.org; Sun, 07 Jun 2020 19:09:28 -0400 Received: by mail-ot1-f68.google.com with SMTP id n6so2834015otl.0 for <41755@debbugs.gnu.org>; Sun, 07 Jun 2020 16:09:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gX2IUxRa9raAm1jqpTlw/CAYN5BVmZexuH3cjN/OYh8=; b=bs6l6PnOYrFQEnk7aWZmWv6QJX2UdG/tmg3jvKmgx26yoQVCucUtdLA1Ez3PBP6s2N ag6qhyoNtVdSYzVZdL2jiYRsYcIq0WVPg7kw5ruoE4pzeEGIuB7lAuqfkVHuDRrqqGLI jyMIh8FsNEITryhpIbY+Qgu8xqM7YMA4Ak/sJeQV6XsMtFt/pSOMN8RjxpkyB+j9twFX 8kH2uuc7tLDMMvJ7004P9BlGPgFZhOnKgyLTZhDgVmWR/sP4kLbnqHQIOFwWFvfKzrNH MF0bD+1D2E2MrEBiA6rVQdYG4qOrGu36CbxoAbO6hqZgNhz9hrG5AIrlqK2RGeZpxv42 Cu6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gX2IUxRa9raAm1jqpTlw/CAYN5BVmZexuH3cjN/OYh8=; b=gSs33b47+I+w4gLJAXZRpKtD3QJRV18BDaI0Z7a+TkI8xT5V80GAbDECkbqvrebCW8 3PRSGVlWuZMiEvORJsgOIgrHFuuxg7da53VnMgVKlpthBAuH2/3niRuzURuuuMYVqhNo ytAAw4Sbd1NHjdwmyHU2VtZ55hjHeQV6zIWLNKLvYajPKv2xeL6vBNnr8iNaVmOkKrvZ MILvt109MvmngqYZeetrO8bYFeGjiLUxZ709dMKyH0nA8eBA6ys3NmWMviia7ffXTvqA RMqzeCyCk3f+2YrhQ383Wz7cQbNowvrBRfiryLlLxeCs6Uw4CV51SE+lGCdmNFwKIr5n bYiw== X-Gm-Message-State: AOAM530TMEwZu2FTJkcT2v54Hf2GzonjA+X8NvaslFg2SCIXTrMHA9Vv osc0CPbVfFmlN8zvO+5h+8e62ro46wX612GqP1U= X-Google-Smtp-Source: ABdhPJzIma1xoK0I/DAjlYNG1a+fbJ3LO5XgDIZ2oW33lhDS2FIsOtofHW45t/+lOLZDLpRn67oAyYlCY+uSsI8xHzM= X-Received: by 2002:a9d:26:: with SMTP id 35mr8856660ota.352.1591571362901; Sun, 07 Jun 2020 16:09:22 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: =?UTF-8?Q?Nicolas_B=C3=A9rtolo?= Date: Sun, 7 Jun 2020 20:09:10 -0300 Message-ID: Subject: Re: bug#41755: feature/native-comp (master?): temacs crash in GC during mark phase To: Pip Cet Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 41755 Cc: Paul Eggert , 41755@debbugs.gnu.org, Andrea Corallo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > But you still have last_marked in your build, right? That would be a > good starting point to find out which object was marked and what was > actually on the stack there... Yes, I'll take a look there. BTW, adding #pragma GCC optimize ("-O0") to the top of alloc.c does not prevent it from crashing, so debugging could be easier. > Is it always a symbol that's found on the stack by mark_maybe_*, though? No, in this case it is a cons. 0x0000000400115a1a in cons_marked_p (c=0xfffffffc00, c@entry=0xbf07b0) at alloc.c:3899 3899 return pdumper_object_p (c) (gdb) bt #0 0x0000000400115a1a in cons_marked_p (c=0xfffffffc00, c@entry=0xbf07b0) at alloc.c:3899 #1 0x000000040011a567 in mark_object (arg=XIL(0xbf0890)) at alloc.c:6775 #2 0x00000004001125d9 in mark_interval_tree_1 (i=0x464a9b3, dummy=0x0) at alloc.c:1468 #3 0x000000040018fde4 in traverse_intervals_noorder (tree=tree@entry=0x464a9b3, function=function@entry=0x4001125b0 , arg=arg@entry=0x0) at intervals.c:234 #4 0x0000000400112619 in mark_interval_tree (i=0x464a9b3) at alloc.c:1477 #5 0x000000040011a2d4 in mark_object (arg=XIL(0x454c0b0)) at alloc.c:6629 #6 0x000000040011a5b2 in mark_object (arg=XIL(0x40061cf60), arg@entry=XIL(0x4d14553)) at alloc.c:6786 #7 0x00000004001171dd in mark_maybe_pointer (p=p@entry=0x4d14553) at alloc.c:4804 #8 0x0000000400117253 in mark_memory (start=0xbf0b30, start@entry=0xbff990, end=0xbff990, end@entry=0xbf0b30) at alloc.c:4854 #9 0x00000004001172b0 in mark_stack (bottom=0xbff990 "", end=end@entry=0xbf0b30 "0\f\277") at alloc.c:5073 #10 0x00000004001a0a71 in mark_one_thread (thread=0x400559500 ) at thread.c:630 #11 mark_threads_callback (ignore=ignore@entry=0x0) at thread.c:661 #12 0x00000004001172fe in flush_stack_call_func1 (func=func@entry=0x4001a0a30 , arg=arg@entry=0x0) at alloc.c:5114 #13 0x00000004001a1c9c in flush_stack_call_func (arg=0x0, func=0x4001a0a30 ) at lisp.h:3825 #14 mark_threads () at thread.c:668 #15 0x0000000000000000 in ?? () Backtrace stopped: previous frame inner to this frame (corrupt stack?) From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 07 23:39:55 2020 Received: (at 41755) by debbugs.gnu.org; 8 Jun 2020 03:39:55 +0000 Received: from localhost ([127.0.0.1]:55566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ji8de-0008WL-RT for submit@debbugs.gnu.org; Sun, 07 Jun 2020 23:39:55 -0400 Received: from mail-ot1-f48.google.com ([209.85.210.48]:33333) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ji8dd-0008W6-3u for 41755@debbugs.gnu.org; Sun, 07 Jun 2020 23:39:53 -0400 Received: by mail-ot1-f48.google.com with SMTP id n6so3172337otl.0 for <41755@debbugs.gnu.org>; Sun, 07 Jun 2020 20:39:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pFexyiZSWjlFZRFYQ6TOhOWW3Z8dhcvQhE7guy1bXGQ=; b=XBIrRC799Hw/MLF95qwWisc/j10k+WBEYMTM7w3/odWeiKPe2OPr7sVsdWa11jb4Ow /U0zC+ZDs1L+mOATHLndHNoAnoDm+QuwkQpo4nuvKaz8HvycQGt3ANXhO5xeVc60JpZh QY5MAXhbdHD7Ic39KaBwNPD88/QI8YGryRHMoYRzxWZgDK5HXHriBfL57LhLS+GMbIbf cPT5iVIqWQzTH3cP+yP863bYMxSgBdBECbpptOvKucmsp1tAdUDH5xyZlf6iKKAoLGfw cfCSILMh5zpgPy0RwemKqBAv4mrQ3mzZJCN3k7/sW7UoyULdYiLeIrPM8BIusXgDJJ4G TM7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pFexyiZSWjlFZRFYQ6TOhOWW3Z8dhcvQhE7guy1bXGQ=; b=KPLtOOEh6tpqGoxg+Ays/neq16suPcYfvdTYTf8Orpv8nLh28VA9B0xlaA9br/zJ96 C9NOfjvPTzg+5IdwVn2qxXLBfAHFmguPpbN0DGCwpuzS84IWgQl4VLcMBrb7EhtHCDIH ClLqxSRo7IA2oAEjGtfcAdf8/Tk4bgFEZYE1b58PPpf1EK4+xQMPY142OBd/ybGWnm+7 6MI6Kx6Iq6OiKxo0TO09XUykRxeZWGWoYMQb/cSBSLetktNda3uRwVjyI60dX/UhIDYY zGJ3mVnK/ZZ6Q/zpHHaRMPx63xQliCrVvMiY/eRs6ltnSS3/BvE9eMN5MzqH7Xjvg19V Z/DA== X-Gm-Message-State: AOAM532owLOuAAd4IQdfnGBe0DKOzP2AcUJOrU+2ao4Z+M94oPwzke02 yqoi8+jfGE1Zc7xNwfB4I7o9wY5VtqQ/yoNb2Tw= X-Google-Smtp-Source: ABdhPJynoQ+CnLqszkW5tpZbatr9CkSKTaNO+Oa8KBkgfpGWmpGeycAMubwAdZRypJ2QCuhvWJnlwekPVBs1rPMbxHc= X-Received: by 2002:a9d:4c19:: with SMTP id l25mr15379075otf.193.1591587587157; Sun, 07 Jun 2020 20:39:47 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: =?UTF-8?Q?Nicolas_B=C3=A9rtolo?= Date: Mon, 8 Jun 2020 00:39:34 -0300 Message-ID: Subject: Re: bug#41755: feature/native-comp (master?): temacs crash in GC during mark phase To: Pip Cet Content-Type: multipart/mixed; boundary="000000000000c321fe05a78a5ce7" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 41755 Cc: Paul Eggert , 41755@debbugs.gnu.org, Andrea Corallo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000c321fe05a78a5ce7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I think I found the bug. Summary: A heap-based cons points to a stack-based string. The bug was introduced by: e38678b268c * Reduce the number of files probed when finding a lisp file. The function load_charset_map_from_file () creates two AUTO_STRINGs for the suffixes it needs. It puts this into a stack-based cons that it passes as t= he "suffixes" argument of openp (). This function then constructs the list of "extended suffixes" that associat= es each suffix with the directory that needs to be inserted in the middle of t= he path, if any. This list is allocated in the heap. When the GC kicks in, the lists are still lying around in memory but the stack-based strings don't exist anymore. The attached patch fixes this case. There may be similar cases in other par= ts of the code. I'll take a look. Nico. El dom., 7 jun. 2020 a las 20:09, Nicolas B=C3=A9rtolo () escribi=C3=B3: > > > But you still have last_marked in your build, right? That would be a > > good starting point to find out which object was marked and what was > > actually on the stack there... > > Yes, I'll take a look there. BTW, adding > > #pragma GCC optimize ("-O0") > > to the top of alloc.c does not prevent it from crashing, so debugging cou= ld be > easier. > > > Is it always a symbol that's found on the stack by mark_maybe_*, though= ? > > No, in this case it is a cons. > > 0x0000000400115a1a in cons_marked_p (c=3D0xfffffffc00, c@entry=3D0xbf07b0= ) > at alloc.c:3899 > 3899 return pdumper_object_p (c) > (gdb) bt > #0 0x0000000400115a1a in cons_marked_p (c=3D0xfffffffc00, > c@entry=3D0xbf07b0) at alloc.c:3899 > #1 0x000000040011a567 in mark_object (arg=3DXIL(0xbf0890)) at alloc.c:67= 75 > #2 0x00000004001125d9 in mark_interval_tree_1 (i=3D0x464a9b3, > dummy=3D0x0) at alloc.c:1468 > #3 0x000000040018fde4 in traverse_intervals_noorder > (tree=3Dtree@entry=3D0x464a9b3, function=3Dfunction@entry=3D0x4001125b0 > , arg=3Darg@entry=3D0x0) at intervals.c:234 > #4 0x0000000400112619 in mark_interval_tree (i=3D0x464a9b3) at alloc.c:1= 477 > #5 0x000000040011a2d4 in mark_object (arg=3DXIL(0x454c0b0)) at alloc.c:6= 629 > #6 0x000000040011a5b2 in mark_object (arg=3DXIL(0x40061cf60), > arg@entry=3DXIL(0x4d14553)) at alloc.c:6786 > #7 0x00000004001171dd in mark_maybe_pointer (p=3Dp@entry=3D0x4d14553) at > alloc.c:4804 > #8 0x0000000400117253 in mark_memory (start=3D0xbf0b30, > start@entry=3D0xbff990, end=3D0xbff990, end@entry=3D0xbf0b30) at > alloc.c:4854 > #9 0x00000004001172b0 in mark_stack (bottom=3D0xbff990 "", > end=3Dend@entry=3D0xbf0b30 "0\f\277") at alloc.c:5073 > #10 0x00000004001a0a71 in mark_one_thread (thread=3D0x400559500 > ) at thread.c:630 > #11 mark_threads_callback (ignore=3Dignore@entry=3D0x0) at thread.c:661 > #12 0x00000004001172fe in flush_stack_call_func1 > (func=3Dfunc@entry=3D0x4001a0a30 , > arg=3Darg@entry=3D0x0) at alloc.c:5114 > #13 0x00000004001a1c9c in flush_stack_call_func (arg=3D0x0, > func=3D0x4001a0a30 ) at lisp.h:3825 > #14 mark_threads () at thread.c:668 > #15 0x0000000000000000 in ?? () > Backtrace stopped: previous frame inner to this frame (corrupt stack?) --000000000000c321fe05a78a5ce7 Content-Type: application/octet-stream; name="0001-Avoid-stack-based-strings-when-calling-openp-.-Fixes.patch" Content-Disposition: attachment; filename="0001-Avoid-stack-based-strings-when-calling-openp-.-Fixes.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kb5y4uic0 RnJvbSAyZmViZGU1M2Q2ZWQwNzBmYTAzMzc1NDUxMTc5NWI1Y2VjNTM2N2M0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWNvbGFzIEJlcnRvbG8gPG5pY29sYXNiZXJ0b2xvQGdtYWls LmNvbT4KRGF0ZTogTW9uLCA4IEp1biAyMDIwIDAwOjM1OjMwIC0wMzAwClN1YmplY3Q6IFtQQVRD SF0gQXZvaWQgc3RhY2stYmFzZWQgc3RyaW5ncyB3aGVuIGNhbGxpbmcgb3BlbnAoKS4gRml4ZXMg IzQxNzU1LgoKVGhlIG9wZW5wKCkgZnVuY3Rpb24gYnVpbGRzIGEgaGVhcCBiYXNlZCBsaXN0IGZy b20gdGhlIHN1ZmZpeGVzLiBJZiB3ZQpwYXNzIHN0YWNrLWJhc2VkIHN0cmluZ3Mgd2UnbGwgZ2V0 IGEgaGVhcC1jb25zIHBvaW50aW5nIHRvIGEKc3RhY2stYmFzZWQgc3RyaW5nLCB3aGljaCB3aWxs IGV4cGxvZGUgZHVyaW5nIEdDLgoKKiBzcmMvY2hhcnNldC5jIChsb2FkX2NoYXJzZXRfbWFwX2Zy b21fZmlsZSk6IEFsbG9jYXRlIHN1ZmZpeGVzIGluIHRoZQpoZWFwLgotLS0KIHNyYy9jaGFyc2V0 LmMgfCA2ICsrKy0tLQogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvY2hhcnNldC5jIGIvc3JjL2NoYXJzZXQuYwppbmRleCA4 NjM1YWFkM2VkNi4uZDljZWFlYThlYjIgMTAwNjQ0Ci0tLSBhL3NyYy9jaGFyc2V0LmMKKysrIGIv c3JjL2NoYXJzZXQuYwpAQCAtNDgwLDkgKzQ4MCw5IEBAIGxvYWRfY2hhcnNldF9tYXBfZnJvbV9m aWxlIChzdHJ1Y3QgY2hhcnNldCAqY2hhcnNldCwgTGlzcF9PYmplY3QgbWFwZmlsZSwKICAgRklM RSAqZnA7CiAgIHN0cnVjdCBjaGFyc2V0X21hcF9lbnRyaWVzICpoZWFkLCAqZW50cmllczsKICAg aW50IG5fZW50cmllczsKLSAgQVVUT19TVFJJTkcgKG1hcCwgIi5tYXAiKTsKLSAgQVVUT19TVFJJ TkcgKHR4dCwgIi50eHQiKTsKLSAgQVVUT19MSVNUMiAoc3VmZml4ZXMsIG1hcCwgdHh0KTsKKyAg TGlzcF9PYmplY3QgbWFwID0gYnVpbGRfc3RyaW5nICgiLm1hcCIpOworICBMaXNwX09iamVjdCB0 eHQgPSBidWlsZF9zdHJpbmcgKCIudHh0Iik7CisgIExpc3BfT2JqZWN0IHN1ZmZpeGVzID0gbGlz dDIgKG1hcCwgdHh0KTsKICAgcHRyZGlmZl90IGNvdW50ID0gU1BFQ1BETF9JTkRFWCAoKTsKICAg cmVjb3JkX3Vud2luZF9wcm90ZWN0X25vdGhpbmcgKCk7CiAgIHNwZWNiaW5kIChRZmlsZV9uYW1l X2hhbmRsZXJfYWxpc3QsIFFuaWwpOwotLSAKMi4yNS4xLndpbmRvd3MuMQoK --000000000000c321fe05a78a5ce7-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 08 02:29:57 2020 Received: (at submit) by debbugs.gnu.org; 8 Jun 2020 06:29:58 +0000 Received: from localhost ([127.0.0.1]:55778 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiBID-0004Sx-Bb for submit@debbugs.gnu.org; Mon, 08 Jun 2020 02:29:57 -0400 Received: from lists.gnu.org ([209.51.188.17]:47970) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiBIB-0004Sp-Mz for submit@debbugs.gnu.org; Mon, 08 Jun 2020 02:29:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33698) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiBIB-0003BI-GV for bug-gnu-emacs@gnu.org; Mon, 08 Jun 2020 02:29:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43030) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiBI7-0006Yg-VR; Mon, 08 Jun 2020 02:29:51 -0400 Received: from [109.253.219.127] (port=32748 helo=[10.134.68.128]) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1jiBI4-0002hm-Vq; Mon, 08 Jun 2020 02:29:50 -0400 Date: Mon, 08 Jun 2020 09:29:43 +0300 User-Agent: K-9 Mail for Android In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: bug#41755: feature/native-comp (master?): temacs crash in GC during mark phase To: bug-gnu-emacs@gnu.org, =?ISO-8859-1?Q?Nicolas_B=E9rtolo?= , Pip Cet From: Eli Zaretskii Message-ID: <5CB87F9A-431C-4BC6-99CD-753844A26BCC@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: Paul Eggert , 41755@debbugs.gnu.org, Andrea Corallo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On June 8, 2020 6:39:34 AM GMT+03:00, "Nicolas B=C3=A9rtolo" wrote: > I think I found the bug=2E Summary: A heap-based cons points to a > stack-based string=2E The bug was introduced by: >=20 > e38678b268c * Reduce the number of files probed when finding a lisp > file=2E >=20 > The function load_charset_map_from_file () creates two AUTO_STRINGs > for the > suffixes it needs=2E It puts this into a stack-based cons that it passes > as the > "suffixes" argument of openp ()=2E >=20 > This function then constructs the list of "extended suffixes" that > associates > each suffix with the directory that needs to be inserted in the middle > of the > path, if any=2E This list is allocated in the heap=2E >=20 > When the GC kicks in, the lists are still lying around in memory but > the > stack-based strings don't exist anymore=2E >=20 > The attached patch fixes this case=2E There may be similar cases in > other parts of > the code=2E I'll take a look=2E >=20 > Nico=2E >=20 >=20 > El dom=2E, 7 jun=2E 2020 a las 20:09, Nicolas B=C3=A9rtolo > () escribi=C3=B3: > > > > > But you still have last_marked in your build, right? That would be > a > > > good starting point to find out which object was marked and what > was > > > actually on the stack there=2E=2E=2E > > > > Yes, I'll take a look there=2E BTW, adding > > > > #pragma GCC optimize ("-O0") > > > > to the top of alloc=2Ec does not prevent it from crashing, so > debugging could be > > easier=2E > > > > > Is it always a symbol that's found on the stack by mark_maybe_*, > though? > > > > No, in this case it is a cons=2E > > > > 0x0000000400115a1a in cons_marked_p (c=3D0xfffffffc00, > c@entry=3D0xbf07b0) > > at alloc=2Ec:3899 > > 3899 return pdumper_object_p (c) > > (gdb) bt > > #0 0x0000000400115a1a in cons_marked_p (c=3D0xfffffffc00, > > c@entry=3D0xbf07b0) at alloc=2Ec:3899 > > #1 0x000000040011a567 in mark_object (arg=3DXIL(0xbf0890)) at > alloc=2Ec:6775 > > #2 0x00000004001125d9 in mark_interval_tree_1 (i=3D0x464a9b3, > > dummy=3D0x0) at alloc=2Ec:1468 > > #3 0x000000040018fde4 in traverse_intervals_noorder > > (tree=3Dtree@entry=3D0x464a9b3, function=3Dfunction@entry=3D0x4001125b= 0 > > , arg=3Darg@entry=3D0x0) at intervals=2Ec:234 > > #4 0x0000000400112619 in mark_interval_tree (i=3D0x464a9b3) at > alloc=2Ec:1477 > > #5 0x000000040011a2d4 in mark_object (arg=3DXIL(0x454c0b0)) at > alloc=2Ec:6629 > > #6 0x000000040011a5b2 in mark_object (arg=3DXIL(0x40061cf60), > > arg@entry=3DXIL(0x4d14553)) at alloc=2Ec:6786 > > #7 0x00000004001171dd in mark_maybe_pointer (p=3Dp@entry=3D0x4d14553) > at > > alloc=2Ec:4804 > > #8 0x0000000400117253 in mark_memory (start=3D0xbf0b30, > > start@entry=3D0xbff990, end=3D0xbff990, end@entry=3D0xbf0b30) at > > alloc=2Ec:4854 > > #9 0x00000004001172b0 in mark_stack (bottom=3D0xbff990 "", > > end=3Dend@entry=3D0xbf0b30 "0\f\277") at alloc=2Ec:5073 > > #10 0x00000004001a0a71 in mark_one_thread (thread=3D0x400559500 > > ) at thread=2Ec:630 > > #11 mark_threads_callback (ignore=3Dignore@entry=3D0x0) at thread=2Ec:= 661 > > #12 0x00000004001172fe in flush_stack_call_func1 > > (func=3Dfunc@entry=3D0x4001a0a30 , > > arg=3Darg@entry=3D0x0) at alloc=2Ec:5114 > > #13 0x00000004001a1c9c in flush_stack_call_func (arg=3D0x0, > > func=3D0x4001a0a30 ) at lisp=2Eh:3825 > > #14 mark_threads () at thread=2Ec:668 > > #15 0x0000000000000000 in ?? () > > Backtrace stopped: previous frame inner to this frame (corrupt > stack?) Thanks, but are you sure the fix should be in load_charset_map_from_file a= nd not in the new code added to openp in the offending commit? Why does th= e additional code in openp need to cons its list off the heap? IOW, it sounds like those additions now made openp unsafe for callers who = manipulate stack-based Lisp objects=2E The old openp was AFAIK careful eno= ugh not to impose any constraints like that on its callers=2E From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 08 02:42:41 2020 Received: (at 41755) by debbugs.gnu.org; 8 Jun 2020 06:42:41 +0000 Received: from localhost ([127.0.0.1]:55800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiBUW-0004n4-TW for submit@debbugs.gnu.org; Mon, 08 Jun 2020 02:42:41 -0400 Received: from mail-oo1-f53.google.com ([209.85.161.53]:34581) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiBUT-0004md-8i for 41755@debbugs.gnu.org; Mon, 08 Jun 2020 02:42:37 -0400 Received: by mail-oo1-f53.google.com with SMTP id v3so3264552oot.1 for <41755@debbugs.gnu.org>; Sun, 07 Jun 2020 23:42:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=8vJDhgrXn8+IcVfvsp4Td1enBqdUDYy5lZK3zRYl7pg=; b=WRpRyv7jHdYpbK2/gwE3i5MA8OmPqKszXBeVTxglUt4/gc8wC/aGtb9eXrbav3b2Ie yZ+YECTHv6nZoXhYMTwf1xpTY8zJgQ/6r7OnW/ETcbsJKKG00OiC+We56wZQbgwNNf18 YWh9dMQLDQy048Dxd5tTy3p3C7pQPMTHfJ/0DNOn9YhndlJFTG2NtTXQovs/sCeZnsHQ gn/sxD75GPZwgGsgJ31eSp4YwVvoGntk7vz9jnrtSEvDUqKsJOsM81j5MPYYCT7Leg1L QtUIq2dew8i1jgf6WUk8OVASw+CuQkzOVl7o39YIMdGQfDxOMCjQspW6wK+sodBTSKeZ UE+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=8vJDhgrXn8+IcVfvsp4Td1enBqdUDYy5lZK3zRYl7pg=; b=AlQFOvvCcuzfOKnNXU17IO4BJcWwJl7nk7qxrd/5z3sWmOb6GktdFt5cTEzO6+sKry ZqSblVv0L81rHefDVDFrVqDFQgGwxfvTi6mpl7AALZ4PzXzikQZlE2eove6Hiz41NaC0 A9PNUapGtpV8gQTTD51x7GB3mbdz/WW3XI3iulFFbT6dTWLD/IfsPvJTYfmSFcKb6JMS cT/O7WZmKOEOgZMw+nxqkXs0U0pe8ehvcqm7FAHhhZ9Xm61DzQBlQEBaRenLvjgRVI0C P3YLQIJmAfdF/W/BOZ0elqHBuW/tQR030YhAfNalKRNbt4znhXdREEIhYwZCggd5SZUq N+pQ== X-Gm-Message-State: AOAM531sXa3VGJofmzLirtOJX2F2J3YIsjHexKYS+axvR+NsW1K8F5QR V/V0Im3jP3Qm1gT9I4NnK8c/IgLdX3NCq1Z+7dM= X-Google-Smtp-Source: ABdhPJyZlw5/HeXCP4771ZYww0l98qDLw8ulXVHLY2XeyqpLUfr+PFAVic+a4kmHDWAW5fHl4sDi+Dc0v55EFQov5h0= X-Received: by 2002:a4a:bc8c:: with SMTP id m12mr726430oop.44.1591598551600; Sun, 07 Jun 2020 23:42:31 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Pip Cet Date: Mon, 8 Jun 2020 06:41:55 +0000 Message-ID: Subject: Re: bug#41755: feature/native-comp (master?): temacs crash in GC during mark phase To: =?UTF-8?Q?Nicolas_B=C3=A9rtolo?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 41755 Cc: Paul Eggert , 41755@debbugs.gnu.org, Andrea Corallo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, Jun 8, 2020 at 3:39 AM Nicolas B=C3=A9rtolo wrote: > I think I found the bug. Summary: A heap-based cons points to a > stack-based string. The bug was introduced by: Good catch! I'm wondering what we could do to make such bugs easier to find... > The attached patch fixes this case. There may be similar cases in other p= arts of > the code. I'll take a look. Would GC_CHECK_MARKED_OBJECTS have caught this? From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 08 14:24:38 2020 Received: (at submit) by debbugs.gnu.org; 8 Jun 2020 18:24:38 +0000 Received: from localhost ([127.0.0.1]:57880 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiMRq-0001Ov-MS for submit@debbugs.gnu.org; Mon, 08 Jun 2020 14:24:38 -0400 Received: from lists.gnu.org ([209.51.188.17]:37870) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiMRq-0001Op-1x for submit@debbugs.gnu.org; Mon, 08 Jun 2020 14:24:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56438) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiMRp-0001sU-Pe for bug-gnu-emacs@gnu.org; Mon, 08 Jun 2020 14:24:37 -0400 Received: from mail-ot1-x335.google.com ([2607:f8b0:4864:20::335]:34021) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jiMRo-0007li-Uj; Mon, 08 Jun 2020 14:24:37 -0400 Received: by mail-ot1-x335.google.com with SMTP id b18so14462694oti.1; Mon, 08 Jun 2020 11:24:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=k16kUmG8L1NRQ9ItF/APOhTL6rXhmyq4oUmEcfOB2fE=; b=kVng7AFVDNJLDKbriKBTlKsAEOkSJDj7ZOMI09FaJLZlNyA84Vty+uMysaRrwjNRkg sc1w6+ALvUKTZg9to3g5hNvyqot/jsEqUypxLQJ1oXwZE9IDUIddrpN4rrbK6svmj8yQ xt6GnIjUaWJr/zUN2CkAIMqhxWT7z053chi+MjcbsB296Ks7j2Z/ZD48GXdURl44teS+ xDZzoXqTJqjpT3cJYJUQOjbPvn+hr+P3HVYVdAU14L+Dwi21fZwRwzT8G/m7NlxlyoyR y4BR1rzAy11yyHQp+cvqRgG507IFA0wA4wJpbW5PqwyjVzv40cbvbtOQY+4vHvQIsOzn 8SBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=k16kUmG8L1NRQ9ItF/APOhTL6rXhmyq4oUmEcfOB2fE=; b=qoZg1p6j924pVvGpBKNxF9aJexA1sCge4BMgxGehKO809JYhr+5lirQgv4IWApbXzZ yfhoHSWPwZbL3Sswrr/aJ5/i2sZMvc5p8njAadXm1/63p6RAzexXwPATb+fZAb/lK4EZ ZusMOpEgofRfXK6KwWtvnfl6taIi/No1dlEJEPuqLZ7eOwU8ioBFYizcu0PPAAa7fG/O ig6zO0tSClA9VWsybsZ7yuA+lOiAEHmMNuoXERSlsMK8oOQquKZS0pjt7z314GKmkfkO 8x5yXkv1azMpp8ofuGGXBPCPyxfgLTtTiX8D1A+WHMdTpPTwgmbxb4IFhp6gvh6UT/lK foCQ== X-Gm-Message-State: AOAM531e/iruKHKwBpAjMz0n5o+didPuXv2yrNhM+f6jtcxE3Ocu5rFv 92TGw0kvIrRWgQPehGq8ZzehjmLCUfDsHISF0sNvx0kf298qRQ== X-Google-Smtp-Source: ABdhPJzSuZkEtxYofRNp8DNrdSc8PAqqbkNbkw0IWEIGNLnWWlULgXU1obJjhZFr7LtrNdJZ8DgkPTKW7MT5nXhLSeo= X-Received: by 2002:a9d:4c19:: with SMTP id l25mr17717189otf.193.1591640675185; Mon, 08 Jun 2020 11:24:35 -0700 (PDT) MIME-Version: 1.0 References: <5CB87F9A-431C-4BC6-99CD-753844A26BCC@gnu.org> In-Reply-To: <5CB87F9A-431C-4BC6-99CD-753844A26BCC@gnu.org> From: =?UTF-8?Q?Nicolas_B=C3=A9rtolo?= Date: Mon, 8 Jun 2020 15:24:23 -0300 Message-ID: Subject: Re: bug#41755: feature/native-comp (master?): temacs crash in GC during mark phase To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::335; envelope-from=nicolasbertolo@gmail.com; helo=mail-ot1-x335.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, Paul Eggert , 41755@debbugs.gnu.org, Pip Cet , Andrea Corallo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > Thanks, but are you sure the fix should be in load_charset_map_from_file and > not in the new code added to openp in the offending commit? Why does the > additional code in openp need to cons its list off the heap? Good idea. It should be easy to rework the openp to avoid putting the suffixes in a heap based list. What openp() does now is turn a list of suffixes into a list of suffixes and associated directories that need to be added to the file path. For example, it turns this: (".eln" ".elc" ".elc.gz" ".el" ".el.gz") into this: ((nil . ".eln") (comp-native-path-postfix . ".eln") (nil . ".elc") (nil . ".elc.gz") (nil . ".el") (nil . ".el.gz")) I did it this way because then iterating over it can be done using a FOR_EACH_TAIL macro. I'll change this to use two lists, one for the suffixes and another one for the directories. The code for iterating them will be just a little more complicated, but it should be safe to pass stack-based suffixes. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 08 14:51:33 2020 Received: (at 41755) by debbugs.gnu.org; 8 Jun 2020 18:51:33 +0000 Received: from localhost ([127.0.0.1]:57905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiMrt-00022B-1W for submit@debbugs.gnu.org; Mon, 08 Jun 2020 14:51:33 -0400 Received: from mail-oi1-f180.google.com ([209.85.167.180]:35145) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiMrs-00021z-Aq for 41755@debbugs.gnu.org; Mon, 08 Jun 2020 14:51:32 -0400 Received: by mail-oi1-f180.google.com with SMTP id k4so14739158oik.2 for <41755@debbugs.gnu.org>; Mon, 08 Jun 2020 11:51:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3+qWGOGFYblQOPeKaH9YFIOxZngvhyc4/e3gK9Kef1w=; b=RhKEUKN8JXtvmQxoKZfnsCt4Vja+PUUzQ01Dw0QDmIXbk20LmN2yzmdP3VYZomnL8C 1EE7pPxXGat8WKkSvBOeL41fu8RncrWUr90p3ReJlaiSEoaByGhzOwFJaxpu6LuWuS7b pxC44DAYQkuFGbRkjvYUpapKhhbhspFo+VOqnF1GFnX334k55nFV02Rp5B9i3cxJJuNU h62ypND8UHZTvzWVS3hE0a62CJCINjTfPpnrfQe5Osl7Uq4EiUEPEYVaUQSsKX6qBGzb vwtfM5IXAh+T1jQ80X9dPwqjg8aOtrx9z5FfHdAGXj3P/hbwhKaxzixfQi5kTGI0kD8S dL9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3+qWGOGFYblQOPeKaH9YFIOxZngvhyc4/e3gK9Kef1w=; b=Rf1MHewD+cwl5eXrmwp1ZW+LK/RncUpJeezIHDeo2T8efDTco0wBMx4fOYUVQ44sxp IhD68EvCZuZED8ef8K0z2ExgQzADPRAA2ylhIjJZH6+hISbCHq9UXool6V9ox5vZU7JY IyxcWLa2JT4BdgbFQ9qD6fdKkeMw/g4WnxBfXFOZ60gDROjIrLWuxyROboROSmCxzSOz qEJug4GaCnEwHjYZiiN65OjWe4mWf14rsX2dDrfM/XQIfrt+0T4xwdpmCrUmkm2ZpdKp irUPPIacf1aqsPo8mQspa85TmPB+hpSmBwdC2b2VAnhdnkI7gK9KPWb8HjDRWo90G+S6 QJ8w== X-Gm-Message-State: AOAM530KNM5oFixYJtXvRl74QaF4GjYe/mhmYdDYTvOde7xGjjF+1v5Q 731XdXZEjPYbYULC0MF17wpfqDRZ6ru5ROmwm5o= X-Google-Smtp-Source: ABdhPJz89Jn3pD4LyR8y8BFQVc5aSkjhDAhIFzDiqNdjfn5zTB7RwJzsPKIPtKmJpSkzroe7k6RTxBVsuCjhagX6I9E= X-Received: by 2002:aca:58c5:: with SMTP id m188mr578689oib.175.1591642286502; Mon, 08 Jun 2020 11:51:26 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: =?UTF-8?Q?Nicolas_B=C3=A9rtolo?= Date: Mon, 8 Jun 2020 15:51:14 -0300 Message-ID: Subject: Re: bug#41755: feature/native-comp (master?): temacs crash in GC during mark phase To: Pip Cet Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41755 Cc: Paul Eggert , 41755@debbugs.gnu.org, Andrea Corallo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > I'm wondering what we could do to make such bugs easier to find... We could add a canary to stack based strings and conses. Then while marking if we come across a stack based string or cons we check that the canary is intact. If it is not, then we can be sure that the memory has been written over. Something like this: struct Stack_String { struct Lisp_String string; uint64_t canary = 0x12341234; }; > Would GC_CHECK_MARKED_OBJECTS have caught this? As far as I can see, during a GC we can't know if a stack-based string is still alive. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 08 15:05:31 2020 Received: (at 41755) by debbugs.gnu.org; 8 Jun 2020 19:05:31 +0000 Received: from localhost ([127.0.0.1]:57941 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiN5O-0002Ou-TX for submit@debbugs.gnu.org; Mon, 08 Jun 2020 15:05:31 -0400 Received: from mail-wm1-f52.google.com ([209.85.128.52]:35498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiN5M-0002Oh-MV for 41755@debbugs.gnu.org; Mon, 08 Jun 2020 15:05:29 -0400 Received: by mail-wm1-f52.google.com with SMTP id q25so690799wmj.0 for <41755@debbugs.gnu.org>; Mon, 08 Jun 2020 12:05:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=OUqFwIc51QLWrdD0lFB7uJj8QWqPB2RjlbxaQ4JcRlM=; b=a/pR7lTSwU+M2m5DleJdNuCsVWTfg4V8pSYRirMjPBo1u5lMNDLf9m9cIfVHCGn3g4 eNMbQ5Za5zy9kTiLpF0t+W/i1NN56l7q9OjoLSf3DljYN1vjnrBA6IwDDDFAuouM9xfi urJXQiZRhCC99elvvU0gb65eK8uclLpWwVUHGNTq5zAAJLQ+KsLxGUWCwNknqL/ePlbq GEjUqEvQ6pxenLWFDtaQM1xAlVZ9O/2mdK37MfLus7sku8mTo2/P0y0/He12k2KFgd3r /lzoIZdH/5i6RzS5cPhUhHdfd3YUfDXkCgQ0URULCufud8db+/iBE7fcW8abfAV2/c70 9BAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=OUqFwIc51QLWrdD0lFB7uJj8QWqPB2RjlbxaQ4JcRlM=; b=purcWS32kkpJXd0U5qDd0jkvjg7zSriNaK5K8dkw9cWpCmKZi2a1y8dtxdoyktm9O6 uhLm4c2/ESRvA8bfPL6xjNqAo0vq9mT/LiIqKTiU5epXWf7/PSw3ohz+RzA3dhOeRTNf b3QZjiajOL9rGezqBpxwhGgaGbfQjqPs6xkplHVJ98hSDR5XOdFVuARmhpncT4+rHm74 CsiMqwQjTursJqKtB3nnFjps00jMfjWsKekyTDamv+e/IfMMJcSCsiogi6lY3WoCF881 ff5HyxQs8IkAYZcIxDCnHaXMx8eTSc/wJ2LhOzsHOtzdGwHlCvCjMSCx7Jc9D8L7zXJW XpQA== X-Gm-Message-State: AOAM533w911FbyuRld8WKi7io5JQ0FSmrzF+0lLj2QnKQ9SVEhdvb1Zp Q6sQotT0XGHiDfFl6D0CzyM= X-Google-Smtp-Source: ABdhPJxUWlpB0pLbAij3rxmu6BmHrVCWFuZ9JI/QEaP1TN46zrZcW8LvzZOn+JuRv5aOWuuONrgunQ== X-Received: by 2002:a1c:7e52:: with SMTP id z79mr179075wmc.104.1591643122823; Mon, 08 Jun 2020 12:05:22 -0700 (PDT) Received: from chametz ([185.220.101.214]) by smtp.gmail.com with ESMTPSA id n19sm418371wmi.33.2020.06.08.12.05.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 12:05:22 -0700 (PDT) From: Pip Cet To: Nicolas =?utf-8?Q?B=C3=A9rtolo?= Subject: Re: bug#41755: feature/native-comp (master?): temacs crash in GC during mark phase References: Date: Mon, 08 Jun 2020 19:05:17 +0000 In-Reply-To: ("Nicolas =?utf-8?Q?B=C3=A9rtolo=22's?= message of "Mon, 8 Jun 2020 15:51:14 -0300") Message-ID: <87tuzlwf82.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41755 Cc: Paul Eggert , 41755@debbugs.gnu.org, Andrea Corallo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Nicolas B=C3=A9rtolo writes: >> I'm wondering what we could do to make such bugs easier to find... > > We could add a canary to stack based strings and conses. Then while > marking if we > come across a stack based string or cons we check that the canary is > intact. If > it is not, then we can be sure that the memory has been written over. I believe we should never be marking stack-based objects. If we do that's a GC bug. Code like AUTO_STRING (s, "foo"); Lisp_Object c =3D Fcons (s, s); garbage_collect (); ... Fsetcar (c, Qnil); Fsetcdr (c, Qnil); shouldn't work. I hope it doesn't :-) (With GC_CHECK_MARKED_OBJECTS, it should abort; without, it would leave the mark bit of s set, so the "..." code would presumably crash). > Something like this: > > struct Stack_String > { > struct Lisp_String string; > uint64_t canary =3D 0x12341234; > }; > >> Would GC_CHECK_MARKED_OBJECTS have caught this? > > As far as I can see, during a GC we can't know if a stack-based string > is still alive. But we can know whether a string is stack-based or not; if it is, we shouldn't be marking it, so we can abort in that case... From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 09 10:20:21 2020 Received: (at 41755) by debbugs.gnu.org; 9 Jun 2020 14:20:21 +0000 Received: from localhost ([127.0.0.1]:60509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jif6z-00026C-EE for submit@debbugs.gnu.org; Tue, 09 Jun 2020 10:20:21 -0400 Received: from mail-oi1-f180.google.com ([209.85.167.180]:33819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jif6x-00025V-E8 for 41755@debbugs.gnu.org; Tue, 09 Jun 2020 10:20:19 -0400 Received: by mail-oi1-f180.google.com with SMTP id b8so18925370oic.1 for <41755@debbugs.gnu.org>; Tue, 09 Jun 2020 07:20:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=H6KCZbh756LH8sptEI55y/J1D6EQiQdqeasfO1cw1ns=; b=PyvsQo6XtpQAkqrWyheyW1lyyd3AgqmvCkXoROHMFZdh90XgU3aJq32JGJ+H/cQYB4 r54v4U/QEiNc3Ncr1VUVjwVr1Uk2a7usspvqy/eMAt5k8ZzJXAeeYxXoX7gX3fHqYqYo CGfKQHE8h88NI8emRrsYa+3ol/89oEGEmcp7tK6wlg+DzMAhJUFD25EsYofl1AxBRef8 T4LvK9DHxrUhc6EaeKvy+fiRWy16trOCK9vk40J44qcD8hlwbLh9RSGXao7hlbO2gU6j i6PxLrxy2+LvHruJrMFOb3YI+9wAwd6lg5fwzOJz7/xLzD6aq6cmrLakkIywQx2+nO0v Iw0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H6KCZbh756LH8sptEI55y/J1D6EQiQdqeasfO1cw1ns=; b=dCmszWnuIh1z+WoXXlp+8AXlPblsjzWuHrPoHtQ3j2x3yUmK2FPNA8JHVaEzhuky3o On/Z05fMa4cups1IRmNWPkBOK3ktoo1Y4BNc816+WpJOCpMfuhJ7tZA06qXHQ+9uhPzB mVIsC7pvk4R5vfEju4jCtj2obSt18nC9qfxCj92WHTcEWy/hggk/7285WXJMqjdixc9w x11tETSuHLaROSq1/D8mH5KTAjqPeX5p2Cwi4tC3PseaPdSXO/KJaiUIo6AATxrelXC9 ZLT7I7SXV5zw04KfxbYsT735lNSih9ApSviy70BRHXurCx0HczcaU/7jxzJwJbF/e3FY bPZg== X-Gm-Message-State: AOAM5315CkzAsh8s/grwspNQhk4eHS/1eARHXCoJZOYmZdaWaTqfUDRN hdIAXoSPwb3vQ85m+qXhbMzHThkJBFB3yJkhzm2IuyC/3xpEEg== X-Google-Smtp-Source: ABdhPJzCGmjmbUM4RrLh6ycyuT2e8HOkWgOxCcDtMMd7zT3Qb+ly75mvFy+2bKFDiOD2mUvcVV6xNAhAsSIKQWLnpRw= X-Received: by 2002:aca:58c5:: with SMTP id m188mr3641856oib.175.1591712413517; Tue, 09 Jun 2020 07:20:13 -0700 (PDT) MIME-Version: 1.0 References: <87tuzlwf82.fsf@gmail.com> In-Reply-To: <87tuzlwf82.fsf@gmail.com> From: =?UTF-8?Q?Nicolas_B=C3=A9rtolo?= Date: Tue, 9 Jun 2020 11:20:01 -0300 Message-ID: Subject: Re: bug#41755: feature/native-comp (master?): temacs crash in GC during mark phase To: 41755@debbugs.gnu.org Content-Type: multipart/mixed; boundary="000000000000ff3dd405a7a76c82" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41755 Cc: Eli Zaretskii , Paul Eggert , Pip Cet , Andrea Corallo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000ff3dd405a7a76c82 Content-Type: text/plain; charset="UTF-8" Hi, Here's a new patch that copies the suffixes before building the heap-based list in openp. I know this is not the solution I proposed, but I couldn't adapt the code without increasing its complexity way too much for my liking. If you think this is not an appropriate solution I will come up with another one. Thanks, Nico. --000000000000ff3dd405a7a76c82 Content-Type: application/octet-stream; name="0001-Copy-suffixes-passed-to-openp-to-avoid-GC-crashes.-F.patch" Content-Disposition: attachment; filename="0001-Copy-suffixes-passed-to-openp-to-avoid-GC-crashes.-F.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kb80gfhe0 RnJvbSA0YjRmZDUyNmFiZTEyNGM4YTc0YmZhMTEyMDlkZDUzYzNhNTY0Y2M3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Tmljb2w9QzM9QTFzPTIwQj1DMz1BOXJ0b2xv Pz0gPG5pY29sYXNiZXJ0b2xvQGdtYWlsLmNvbT4KRGF0ZTogTW9uLCA4IEp1biAyMDIwIDIyOjAx OjI1IC0wMzAwClN1YmplY3Q6IFtQQVRDSF0gQ29weSBzdWZmaXhlcyBwYXNzZWQgdG8gJ29wZW5w JyB0byBhdm9pZCBHQyBjcmFzaGVzLiBGaXhlcwogYnVnIzQxNzU1CgpJbiBvcGVucF9hZGRfbWlk ZGxlX2Rpcl90b19zdWZmaXhlcyB3ZSBidWlsZCBhIGhlYXAtYmFzZWQgbGlzdCBmcm9tCnRoZSBw YXNzZWQgc3VmZml4ZXMuICBJdCBpcyBjcnVjaWFsIHRoYXQgd2UgZG9uJ3QgY3JlYXRlIGEgaGVh cC1iYXNlZApjb25zIHRoYXQgcG9pbnRzIHRvIGEgc3RhY2stYmFzZWQgbGlzdC4KCiogc3JjL2xy ZWFkLmMgKG9wZW5wX2FkZF9taWRkbGVfZGlyX3RvX3N1ZmZpeGVzKTogQ29weSBzdWZmaXhlcyB3 aGVuCmJ1aWxkaW5nIGEgbGlzdCBvZiBtaWRkbGUtZGlycyBhbmQgc3VmZml4ZXMuCi0tLQogc3Jj L2xyZWFkLmMgfCAxNCArKysrKysrKysrLS0tLQogMSBmaWxlIGNoYW5nZWQsIDEwIGluc2VydGlv bnMoKyksIDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2xyZWFkLmMgYi9zcmMvbHJl YWQuYwppbmRleCBjMTI3ZDMyZWIxNy4uNjVkODQ0NjJjNGMgMTAwNjQ0Ci0tLSBhL3NyYy9scmVh ZC5jCisrKyBiL3NyYy9scmVhZC5jCkBAIC0xNjM1LDIxICsxNjM1LDI3IEBAIG9wZW5wX2FkZF9t aWRkbGVfZGlyX3RvX3N1ZmZpeGVzIChMaXNwX09iamVjdCBzdWZmaXhlcykKICAgTGlzcF9PYmpl Y3QgZXh0ZW5kZWRfc3VmID0gUW5pbDsKICAgRk9SX0VBQ0hfVEFJTF9TQUZFICh0YWlsKQogICAg IHsKLSNpZmRlZiBIQVZFX05BVElWRV9DT01QCisgICAgICAvKiAgc3VmZml4ZXMgbWF5IGJlIGEg c3RhY2stYmFzZWQgY29ucyBwb2ludGluZyB0byBzdGFjay1iYXNlZAorICAgICAgICAgIHN0cmlu Z3MuICBXZSBtdXN0IGNvcHkgdGhlIHN1ZmZpeCBpZiB3ZSBhcmUgcHV0dGluZyBpdCBpbnRvCisg ICAgICAgICAgYSBoZWFwLWJhc2VkIGNvbnMgdG8gYXZvaWQgYSBkYW5nbGluZyByZWZlcmVuY2Uu ICBUaGlzIHdvdWxkCisgICAgICAgICAgbGVhZCB0byBjcmFzaGVzIGR1cmluZyB0aGUgR0MuICAq LwogICAgICAgQ0hFQ0tfU1RSSU5HX0NBUiAodGFpbCk7CiAgICAgICBjaGFyICogc3VmID0gU1NE QVRBIChYQ0FSICh0YWlsKSk7CisgICAgICBMaXNwX09iamVjdCBjb3BpZWRfc3VmZml4ID0gYnVp bGRfc3RyaW5nIChzdWYpOworI2lmZGVmIEhBVkVfTkFUSVZFX0NPTVAKICAgICAgIGlmIChzdHJj bXAgKE5BVElWRV9FTElTUF9TVUZGSVgsIHN1ZikgPT0gMCkKICAgICAgICAgewogICAgICAgICAg IENIRUNLX1NUUklORyAoVmNvbXBfbmF0aXZlX3BhdGhfcG9zdGZpeCk7CiAgICAgICAgICAgLyog SGVyZSB3ZSBhZGQgdGhlbSBpbiB0aGUgb3Bwb3NpdGUgb3JkZXIgc28gdGhhdCBucmV2ZXJzZQog ICAgICAgICAgICAgIGNvcnJlY3RzIGl0LiAgKi8KLSAgICAgICAgICBleHRlbmRlZF9zdWYgPSBG Y29ucyAoRmNvbnMgKFFuaWwsIFhDQVIgKHRhaWwpKSwgZXh0ZW5kZWRfc3VmKTsKLSAgICAgICAg ICBleHRlbmRlZF9zdWYgPSBGY29ucyAoRmNvbnMgKFZjb21wX25hdGl2ZV9wYXRoX3Bvc3RmaXgs IFhDQVIgKHRhaWwpKSwKKyAgICAgICAgICBleHRlbmRlZF9zdWYgPSBGY29ucyAoRmNvbnMgKFFu aWwsIGNvcGllZF9zdWZmaXgpLCBleHRlbmRlZF9zdWYpOworICAgICAgICAgIGV4dGVuZGVkX3N1 ZiA9IEZjb25zIChGY29ucyAoVmNvbXBfbmF0aXZlX3BhdGhfcG9zdGZpeCwKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvcGllZF9zdWZmaXgpLAogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBleHRlbmRlZF9zdWYpOwogICAgICAgICB9CiAgICAgICBlbHNl CiAjZW5kaWYKLQlleHRlbmRlZF9zdWYgPSBGY29ucyAoRmNvbnMgKFFuaWwsIFhDQVIgKHRhaWwp KSwgZXh0ZW5kZWRfc3VmKTsKKwlleHRlbmRlZF9zdWYgPSBGY29ucyAoRmNvbnMgKFFuaWwsIGNv cGllZF9zdWZmaXgpLCBleHRlbmRlZF9zdWYpOwogICAgIH0KIAogICBzdWZmaXhlcyA9IEZucmV2 ZXJzZSAoZXh0ZW5kZWRfc3VmKTsKLS0gCjIuMjUuMS53aW5kb3dzLjEKCg== --000000000000ff3dd405a7a76c82-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 10 08:54:27 2020 Received: (at 41755) by debbugs.gnu.org; 10 Jun 2020 12:54:27 +0000 Received: from localhost ([127.0.0.1]:33533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj0FP-0005Mq-5G for submit@debbugs.gnu.org; Wed, 10 Jun 2020 08:54:27 -0400 Received: from mx.sdf.org ([205.166.94.20]:50621) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj0Er-0005Le-GU for 41755@debbugs.gnu.org; Wed, 10 Jun 2020 08:54:26 -0400 Received: from sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 05ACrUcu017711 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Wed, 10 Jun 2020 12:53:32 GMT Received: (from akrl@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 05ACrRxp029110; Wed, 10 Jun 2020 12:53:27 GMT From: Andrea Corallo To: Nicolas =?utf-8?Q?B=C3=A9rtolo?= Subject: Re: bug#41755: feature/native-comp (master?): temacs crash in GC during mark phase References: <87tuzlwf82.fsf@gmail.com> Date: Wed, 10 Jun 2020 12:53:27 +0000 In-Reply-To: ("Nicolas =?utf-8?Q?B=C3=A9rtolo=22's?= message of "Tue, 9 Jun 2020 11:20:01 -0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41755 Cc: Eli Zaretskii , Paul Eggert , 41755@debbugs.gnu.org, Pip Cet X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Nicolas B=C3=A9rtolo writes: > Hi, > > Here's a new patch that copies the suffixes before building the heap-base= d list > in openp. I know this is not the solution I proposed, but I couldn't adap= t the > code without increasing its complexity way too much for my liking. If you= think > this is not an appropriate solution I will come up with another one. > > Thanks, Nico. Hi Nico, I pushed this so the branch is stable to work on for everybody and there's no rush if you want to improve your solution in the meanwhile. Thanks Andrea --=20 akrl@sdf.org From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 27 10:39:15 2020 Received: (at 41755-done) by debbugs.gnu.org; 27 Jun 2020 14:39:15 +0000 Received: from localhost ([127.0.0.1]:44411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpBz9-0004Rc-0y for submit@debbugs.gnu.org; Sat, 27 Jun 2020 10:39:15 -0400 Received: from mx.sdf.org ([205.166.94.22]:65235) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpBz7-0004RU-Nw for 41755-done@debbugs.gnu.org; Sat, 27 Jun 2020 10:39:14 -0400 Received: from sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 05REdBrL024152 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO) for <41755-done@debbugs.gnu.org>; Sat, 27 Jun 2020 14:39:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=sdf.org; s=default; t=1593268752; bh=oqz62BDcmjSKgeUn69+VW/3mxjm/ByU8dsmC8HTZ90U=; h=From:To:Subject:References:Date:In-Reply-To; b=RPuIW0gYn6p84mvOI4NXllD+1BDJ6IOui1WJFMBtHEAUvCCT0SMql+4JiVjfc02KK bWpQJiK6QnMeAVVBHcIB2Q9RjIqBIrA6awURph6emNCsm7ihCMMl0ukYiVnat05WnF AQv5GyQ5kKQVibJJcLl54WjmTzjgHIOK+C9l8+U8= Received: (from akrl@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 05REdBhL001392; Sat, 27 Jun 2020 14:39:11 GMT From: Andrea Corallo To: 41755-done@debbugs.gnu.org Subject: Re: bug#41755: feature/native-comp (master?): temacs crash in GC during mark phase References: <87tuzlwf82.fsf@gmail.com> Date: Sat, 27 Jun 2020 14:39:11 +0000 In-Reply-To: (Andrea Corallo's message of "Wed, 10 Jun 2020 12:53:27 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41755-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I'm closing this bug as the issue originating the crash is fixed. Andrea From unknown Tue Jun 17 01:50:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 26 Jul 2020 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator