From unknown Thu Jun 19 14:03:52 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#41754 <41754@debbugs.gnu.org> To: bug#41754 <41754@debbugs.gnu.org> Subject: Status: [feature/native-comp] Fix crash when loading lambdas from dumps with --enable-checking. Reply-To: bug#41754 <41754@debbugs.gnu.org> Date: Thu, 19 Jun 2025 21:03:52 +0000 retitle 41754 [feature/native-comp] Fix crash when loading lambdas from dum= ps with --enable-checking. reassign 41754 emacs submitter 41754 Nicolas B=C3=A9rtolo severity 41754 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 07 15:08:36 2020 Received: (at submit) by debbugs.gnu.org; 7 Jun 2020 19:08:36 +0000 Received: from localhost ([127.0.0.1]:54892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ji0ep-0008VO-Qv for submit@debbugs.gnu.org; Sun, 07 Jun 2020 15:08:36 -0400 Received: from lists.gnu.org ([209.51.188.17]:48192) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ji0eo-0008VH-Iq for submit@debbugs.gnu.org; Sun, 07 Jun 2020 15:08:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56578) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ji0eo-0005HO-Ed for bug-gnu-emacs@gnu.org; Sun, 07 Jun 2020 15:08:34 -0400 Received: from mail-ot1-x32b.google.com ([2607:f8b0:4864:20::32b]:36842) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ji0en-0006Tl-IY for bug-gnu-emacs@gnu.org; Sun, 07 Jun 2020 15:08:34 -0400 Received: by mail-ot1-x32b.google.com with SMTP id 97so513298otg.3 for ; Sun, 07 Jun 2020 12:08:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=ci7Wu7+cM8o3IHUfKF2ITSwA2a5XOcKxCqmX/sYGmEU=; b=iiaRuz7lvG4/TJEVldgjwS+5uhjTf1NtkrfJMVhmP+wPrXVFbJxik0yO7bQ1akJCHR IXyZ6/+Wjs56q2kLF4xHsAWCXaM73eHJTyG1WYHcGauvr1CGXQfndn/iO+kqhVaRc7aK nDTkDM4/oJIDNGTdMpvqnA1C5G83ELy9PCWBcoMvzx42KF129YkfpYG+knr0LEyyHzZW E7GBAPiLH9DAQsy6jUCLB6nUSeMFhBFL1oXe3tj7H10Q2fuJt7QHnVerXIQbiJ7mg2WI Pbv6+Z1QIJVTq5uh/2S7VXtG4Ffl6sZ11wpm2LnrgdLekmpmbPvYamYK7b86e0yySPKm a7Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=ci7Wu7+cM8o3IHUfKF2ITSwA2a5XOcKxCqmX/sYGmEU=; b=eBJyYIT1OE8bZQHVQQthKy7fz6Zz67r2FqU89MXefjkzm3h2Fu7vFzutvUXWND0oni gkSwkuVzqUC84qL1+SXnz5/LFnMbR5FZhZ6OV/ApbwzgBZFaY7YJxKrXmwSZC3z5zUac UsqhxYDqIuDfs90Ttt0fTKE8qrU2E5RztQg4Bbt4cQ1/qdxT0zkkDETGlNyxxPFZSZCs g3GyDVyMJEAkaLZ9byAkQ8ndRSejD8TrQhcex0QZag+6iv6hSf6p+PiqpQ1tiblZC4wR 25pf6g2+f/jzbZlOJ/gLq32TFNb1PN3Eq3EvwgjhT4sPDVaUeQvoFAwaYLsnIo8gy/A6 AfZw== X-Gm-Message-State: AOAM53003UeSO8ZSvttuFooNJ0x+9vyGXLm0p1jlHyp4mvITe6SDF5YT e0fipXccDkyp84N1kE3fpcIqra3KLVMl3sFLTvAA4s8nLNc= X-Google-Smtp-Source: ABdhPJwLIAgsllB82U5fj3YTouVcfFSIjtvT5y9SmQ9M73lg9rB2w+bQIXHEf+LIiDHAJ/fnUHq1iNrg89P6dAICrkM= X-Received: by 2002:a9d:5f09:: with SMTP id f9mr14969073oti.202.1591556911716; Sun, 07 Jun 2020 12:08:31 -0700 (PDT) MIME-Version: 1.0 From: =?UTF-8?Q?Nicolas_B=C3=A9rtolo?= Date: Sun, 7 Jun 2020 16:08:19 -0300 Message-ID: Subject: [feature/native-comp] Fix crash when loading lambdas from dumps with --enable-checking. To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::32b; envelope-from=nicolasbertolo@gmail.com; helo=mail-ot1-x32b.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi Andrea, I have seen that a lambda may be loaded many times when loading a dump. Is this expected? I don't know enough to tell. If it is, the attached patch prevents an assertion failure when building with --enable-checking. Nico. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 07 15:28:09 2020 Received: (at 41754) by debbugs.gnu.org; 7 Jun 2020 19:28:09 +0000 Received: from localhost ([127.0.0.1]:54954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ji0xl-0000bz-CX for submit@debbugs.gnu.org; Sun, 07 Jun 2020 15:28:09 -0400 Received: from mx.sdf.org ([205.166.94.20]:58966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ji0xj-0000br-JU for 41754@debbugs.gnu.org; Sun, 07 Jun 2020 15:28:08 -0400 Received: from sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 057JS6bI005879 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Sun, 7 Jun 2020 19:28:06 GMT Received: (from akrl@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 057JS6Dp023947; Sun, 7 Jun 2020 19:28:06 GMT From: Andrea Corallo To: Nicolas =?utf-8?Q?B=C3=A9rtolo?= Subject: Re: bug#41754: [feature/native-comp] Fix crash when loading lambdas from dumps with --enable-checking. References: Date: Sun, 07 Jun 2020 19:28:06 +0000 In-Reply-To: ("Nicolas =?utf-8?Q?B=C3=A9rtolo=22's?= message of "Sun, 7 Jun 2020 16:08:19 -0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41754 Cc: 41754@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Nicolas B=C3=A9rtolo writes: > Hi Andrea, > > I have seen that a lambda may be loaded many times when loading a dump. I= s this > expected? I don't know enough to tell. If it is, the attached patch preve= nts an > assertion failure when building with --enable-checking. > > Nico. Hi Nico, the patch is missing. Are you referring to a check in check_comp_unit_relocs? Andrea --=20 akrl@sdf.org From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 07 15:48:35 2020 Received: (at 41754) by debbugs.gnu.org; 7 Jun 2020 19:48:35 +0000 Received: from localhost ([127.0.0.1]:54976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ji1HX-0003Go-4J for submit@debbugs.gnu.org; Sun, 07 Jun 2020 15:48:35 -0400 Received: from mail-oi1-f170.google.com ([209.85.167.170]:39671) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ji1HV-0003GZ-UC for 41754@debbugs.gnu.org; Sun, 07 Jun 2020 15:48:34 -0400 Received: by mail-oi1-f170.google.com with SMTP id d67so13373727oig.6 for <41754@debbugs.gnu.org>; Sun, 07 Jun 2020 12:48:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=S25b7zI9F9XIEns63rQ3vHaoQwGm7xm8iPmMBElExmU=; b=pfowVgol3GDZ3tGk1EACJqD8PbFclk+UMmfKiwzab4IK085MCwJ0R6orkLe+UG6cga nzzXxWyM3Y0Pef4++QDoJs5bxuMrVeALwo+Z4v6TjBmKmEFaPwqaFBx0qbMxwwB3/+xn dQ0899Ud9ehe0xj7x1U50Kxa7AhHR82ahXQbKb9oADAML+lVvYzOgHwQZIBKiNXJSiY4 P9OVahAbz1OnJASNk5K62jbjVybS/iJDveUjdDXfriHF4HCq6aPaQ182ploD1tn8c+k1 Paf334PZbaNCTpKTLgWfCgZW0C01bBO7dHKx+2Dxjm0HtXEKBe0Tp3DP1RistXaHS3M9 onfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=S25b7zI9F9XIEns63rQ3vHaoQwGm7xm8iPmMBElExmU=; b=m028Y/f3I/7dFdBSgMvKtz1idizHAnLSbRJPQxImFavBiRrMt6mwuPfzPxjds2m+eS 8hGaRrSGXPm0sAWrds7VeH2EEZOegkLXctHEaU7zMNL534DUYUWXLXXinHKb54ujAxCP HQPtYLofE5+i0Sf6lhMNk0k8e8if74peSbAipFUpl2jmJEeR+Nl3yP0sUs2glXWLFama Z2dtZ0C8UaoCoVwtiTRkfuiLEsnfYVgkbJEtZOdy0Ur2DR/DI407pByQPSCo6CFf06xo uNJKvFDVc4SAP1msiHsR5vyIsSs3TtiZ5WTtdKF4e94cxFaNFOAWYcUdnGthe4bObeMd zesA== X-Gm-Message-State: AOAM532lw8uT6P5ULXfWZQyP41e4kGk3Fk/hzIBysn7kdpGr0koKegMb viScNLYEv8vEd6+z5ZzDI3HhdygJ3hJ0vrWvaMCoJpDFNhY= X-Google-Smtp-Source: ABdhPJyVQRq90CBLp8zSMbbI3N03AT7Dd/qkhnl3x562csg6TNowScsT1N80VUm60vj4RvcGXipsW59sTWtbrPOyBk4= X-Received: by 2002:aca:b742:: with SMTP id h63mr8503394oif.65.1591559308029; Sun, 07 Jun 2020 12:48:28 -0700 (PDT) MIME-Version: 1.0 From: =?UTF-8?Q?Nicolas_B=C3=A9rtolo?= Date: Sun, 7 Jun 2020 16:48:16 -0300 Message-ID: Subject: Re: bug#41754: [feature/native-comp] Fix crash when loading lambdas from dumps with --enable-checking. To: 41754@debbugs.gnu.org Content-Type: multipart/mixed; boundary="00000000000031c83905a783c7cd" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41754 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000031c83905a783c7cd Content-Type: text/plain; charset="UTF-8" Oops, Here it is. Nico. --00000000000031c83905a783c7cd Content-Type: application/octet-stream; name="0001-Don-t-crash-when-a-lambda-has-been-already-loaded.patch" Content-Disposition: attachment; filename="0001-Don-t-crash-when-a-lambda-has-been-already-loaded.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kb5haqox0 RnJvbSAzNDM1MTFkOTFlYWMzZTg1ZjU3ODAzZmNhODIxNjMyODU4YmI5YmE5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWNvbGFzIEJlcnRvbG8gPG5pY29sYXNiZXJ0b2xvQGdtYWls LmNvbT4KRGF0ZTogU3VuLCA3IEp1biAyMDIwIDE0OjQwOjE0IC0wMzAwClN1YmplY3Q6IFtQQVRD SF0gRG9uJ3QgY3Jhc2ggd2hlbiBhIGxhbWJkYSBoYXMgYmVlbiBhbHJlYWR5IGxvYWRlZC4KCiog c3JjL3BkdW1wZXIuYyAoZHVtcF9kb19kdW1wX3JlbG9jYXRpb24pOiBTa2lwIGxhbWJkYXMgdGhh dCBoYXZlIGJlZW4KbG9hZGVkIGFscmVhZHkuCi0tLQogc3JjL3BkdW1wZXIuYyB8IDQgKysrKwog MSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL3NyYy9wZHVtcGVy LmMgYi9zcmMvcGR1bXBlci5jCmluZGV4IDkyYWM5NmE4ZmFhLi41OTRiNjBiMTQzYiAxMDA2NDQK LS0tIGEvc3JjL3BkdW1wZXIuYworKysgYi9zcmMvcGR1bXBlci5jCkBAIC01MzY1LDYgKzUzNjUs MTAgQEAgZHVtcF9kb19kdW1wX3JlbG9jYXRpb24gKGNvbnN0IHVpbnRwdHJfdCBkdW1wX2Jhc2Us CiAJICAgIFhTRVRTVUJSICh0ZW0sIHN1YnIpOwogCSAgICBMaXNwX09iamVjdCAqZml4dXAgPQog CSAgICAgICYoY29tcF91LT5kYXRhX2ltcF9yZWxvY3NbWEZJWE5VTSAobGFtYmRhX2RhdGFfaWR4 KV0pOworICAgICAgICAgICAgYm9vbCBsYW1iZGFfYWxyZWFkeV9sb2FkZWQgPSBTVUJSUCAoKmZp eHVwKQorICAgICAgICAgICAgICAmJiBYU1VCUiAoKmZpeHVwKS0+ZnVuY3Rpb24uYTAgPT0gZnVu YzsKKyAgICAgICAgICAgIGlmIChsYW1iZGFfYWxyZWFkeV9sb2FkZWQpCisgICAgICAgICAgICAg IHJldHVybjsKIAkgICAgZWFzc2VydCAoRVEgKCpmaXh1cCwgUWxhbWJkYV9maXh1cCkpOwogCSAg ICAqZml4dXAgPSB0ZW07CiAJICAgIEZwdXRoYXNoICh0ZW0sIFFuaWwsIGNvbXBfdS0+bGFtYmRh X2djX2d1YXJkKTsKLS0gCjIuMjUuMS53aW5kb3dzLjEKCg== --00000000000031c83905a783c7cd-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 08 11:42:17 2020 Received: (at 41754) by debbugs.gnu.org; 8 Jun 2020 15:42:17 +0000 Received: from localhost ([127.0.0.1]:57671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiJuj-0005qB-Bj for submit@debbugs.gnu.org; Mon, 08 Jun 2020 11:42:17 -0400 Received: from mx.sdf.org ([205.166.94.20]:53946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiJui-0005q1-4b for 41754@debbugs.gnu.org; Mon, 08 Jun 2020 11:42:16 -0400 Received: from sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 058FgC4n012428 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Mon, 8 Jun 2020 15:42:13 GMT Received: (from akrl@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 058FgCE3024210; Mon, 8 Jun 2020 15:42:12 GMT From: Andrea Corallo To: Nicolas =?utf-8?Q?B=C3=A9rtolo?= Subject: Re: bug#41754: [feature/native-comp] Fix crash when loading lambdas from dumps with --enable-checking. References: Date: Mon, 08 Jun 2020 15:42:12 +0000 In-Reply-To: ("Nicolas =?utf-8?Q?B=C3=A9rtolo=22's?= message of "Sun, 7 Jun 2020 16:08:19 -0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41754 Cc: 41754@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Nicolas B=C3=A9rtolo writes: > Hi Andrea, > > I have seen that a lambda may be loaded many times when loading a dump. I= s this > expected? I don't know enough to tell. If it is, the attached patch preve= nts an > assertion failure when building with --enable-checking. > > Nico. Hi, had a look, this is a real bug. Luckily except for failing the test should not introduce instability in normal builds, still the test is correct. I'll come up with the fix once is tested. Thanks Andrea --=20 akrl@sdf.org From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 08 17:30:45 2020 Received: (at 41754) by debbugs.gnu.org; 8 Jun 2020 21:30:45 +0000 Received: from localhost ([127.0.0.1]:58057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiPLx-0005uq-2M for submit@debbugs.gnu.org; Mon, 08 Jun 2020 17:30:45 -0400 Received: from mx.sdf.org ([205.166.94.20]:54529) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiPLv-0005ui-EG for 41754@debbugs.gnu.org; Mon, 08 Jun 2020 17:30:44 -0400 Received: from sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 058LUg4S014730 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Mon, 8 Jun 2020 21:30:42 GMT Received: (from akrl@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 058LUf0k029392; Mon, 8 Jun 2020 21:30:41 GMT From: Andrea Corallo To: Nicolas =?utf-8?Q?B=C3=A9rtolo?= Subject: Re: bug#41754: [feature/native-comp] Fix crash when loading lambdas from dumps with --enable-checking. References: Date: Mon, 08 Jun 2020 21:30:41 +0000 In-Reply-To: (Andrea Corallo's message of "Mon, 08 Jun 2020 15:42:12 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41754 Cc: 41754@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, with "4784bcc * Fix load logic for the reloading CU case (bug#41754)" this issue should be fixed. Reverting on my local branch "e38678b268 * Reduce the number of..." I did boot-strapped it with and without --enable-checking. Please have a run to confirm when you can. Thanks Andrea -- akrl@sdf.org From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 09 07:55:08 2020 Received: (at 41754) by debbugs.gnu.org; 9 Jun 2020 11:55:09 +0000 Received: from localhost ([127.0.0.1]:59165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jicqS-0006Tc-OJ for submit@debbugs.gnu.org; Tue, 09 Jun 2020 07:55:08 -0400 Received: from mail-ot1-f43.google.com ([209.85.210.43]:41905) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jicqM-0006Su-TF for 41754@debbugs.gnu.org; Tue, 09 Jun 2020 07:55:06 -0400 Received: by mail-ot1-f43.google.com with SMTP id k15so16373371otp.8 for <41754@debbugs.gnu.org>; Tue, 09 Jun 2020 04:55:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1cqJY7twizjGZQUeGppjpEDIE5XJrFZHrj9QJbwzFPE=; b=u31jWqAfKIuDQbh2fspRLEbgPxxacMwA8K1wDoWbSJseafIz60M+sc6XEYkVQixtWE b6nrM5/Y+NTs479NU5Ls7TBZdLlkxF4fea+4/1lc9wM2ANT84BR/clyA28/88/kczAQ8 sAEr/0zl+S5hm2th29X1QOC4SkTg0Gmy1cGuTuQdjcaRZuxoKcVxjeMQttZcrHhOhRh6 GcaQuQfTKVt0oQB5Us3Ef3NiYTA1BjisURtNBn2BzFe9rROyU5zTW6VzaMjyoVSrd3yC 0lSNp0WxOrCXyF/6ZLrVlbMEr8x2I3GqhiBZzeG3BCwl/DdeX/tM72WsSUCvSzMP4aZP f3bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1cqJY7twizjGZQUeGppjpEDIE5XJrFZHrj9QJbwzFPE=; b=CIwTKy9g6tFMMIRBGLUMS3gUsJoUYyq2gFXYBdyO1JnIHDfAwkmd6ZAtzrJsEbrKhL q+SvhUsEYQeOqftKXG7JNXSHeTIIGzrmSiO7JLea7VTnaLW1u6n016pwILFkQhOJShaU 7SgEHTRqmjuJeLdvC5+KtjTas6uIjjfgInmPllDUqefrVnhdL51CG0wh+nusTtlXzcGf wbe0MaLpj4yFmJMWwBOtAHsNRim1MR0WKbHUPF8UO1VgLPig4UZlf905SZkEK3hnfPco X/mwVOqMeeNmVmMoZ4Jjh1IcnjgAlgiloVB7qP2QAdlkd+68ruOMSIJSt6bI6aA58ebT XiAQ== X-Gm-Message-State: AOAM530L5DYy6WQJ0t/FQ7KN55V/cOMVfQON0ujULInawEGf7WtVe5HY MAPoxatI5Halr9nIqwBq3LMzN6eBt5Tt7AgZNyk= X-Google-Smtp-Source: ABdhPJygpM0McoLxhHwOien7clnM9VHiSODmXMB5lTcBBRUKMnjI5+iSIfJjyip6VTH2mEq6oNvcjFZR6RRJaEctHV4= X-Received: by 2002:a9d:4c19:: with SMTP id l25mr20190540otf.193.1591703697096; Tue, 09 Jun 2020 04:54:57 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: =?UTF-8?Q?Nicolas_B=C3=A9rtolo?= Date: Tue, 9 Jun 2020 08:54:45 -0300 Message-ID: Subject: Re: bug#41754: [feature/native-comp] Fix crash when loading lambdas from dumps with --enable-checking. To: Andrea Corallo Content-Type: multipart/mixed; boundary="00000000000074297d05a7a5656f" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41754 Cc: 41754@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000074297d05a7a5656f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Andrea, I can confirm that the issue with lambdas is fixed. I have attached three bug fixes: - Copy the suffixes before building the heap-based list in openp. I know th= is is not the solution I proposed in the bug report, but I couldn't adapt the c= ode without increasing its complexity way too much for my liking. If you thin= k this is not an appropriate solution I will come up with another one. - Fix a simple bug caused by using cl-destructuring-bind incorrectly. - Use a C array to keep the list of native compilation units. This one fixe= s the crashes when closing Emacs. Ideally I would figure out why iterating over a weak hash-table does not skip elements that were already GC'd, but I co= uld not do it. I feel fixing this bug is very important, so I used a C array = to keep the list of native compilation units. Thanks, Nico. El lun., 8 jun. 2020 a las 18:30, Andrea Corallo () escribi= =C3=B3: > > Hi, > > with "4784bcc * Fix load logic for the reloading CU case (bug#41754)" > this issue should be fixed. > > Reverting on my local branch "e38678b268 * Reduce the number of..." I > did boot-strapped it with and without --enable-checking. > > Please have a run to confirm when you can. > > Thanks > > Andrea > > -- > akrl@sdf.org --00000000000074297d05a7a5656f Content-Type: application/octet-stream; name="0001-Fix-usage-of-cl-destructuring-bind-in-package-delete.patch" Content-Disposition: attachment; filename="0001-Fix-usage-of-cl-destructuring-bind-in-package-delete.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kb7v9o8u1 RnJvbSAxZjJlNTM2NmUxM2VjZTRiMWI2MjYyMzIyMjI0OGY2OTY3YjgwNWEzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Tmljb2w9QzM9QTFzPTIwQj1DMz1BOXJ0b2xv Pz0gPG5pY29sYXNiZXJ0b2xvQGdtYWlsLmNvbT4KRGF0ZTogTW9uLCA4IEp1biAyMDIwIDIwOjQ3 OjA2IC0wMzAwClN1YmplY3Q6IFtQQVRDSF0gRml4IHVzYWdlIG9mIGNsLWRlc3RydWN0dXJpbmct YmluZCBpbgogcGFja2FnZS0tZGVsZXRlLWRpcmVjdG9yeS4KCiogbGlzcC9lbWFjcy1saXNwL3Bh Y2thZ2UuZWwgKHBhY2thZ2UtLWRlbGV0ZS1kaXJlY3RvcnkpOiBGaXggdXNhZ2Ugb2YKY2wtZGVz dHJ1Y3R1cmluZy1iaW5kLgotLS0KIGxpc3AvZW1hY3MtbGlzcC9wYWNrYWdlLmVsIHwgMiArLQog MSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0 IGEvbGlzcC9lbWFjcy1saXNwL3BhY2thZ2UuZWwgYi9saXNwL2VtYWNzLWxpc3AvcGFja2FnZS5l bAppbmRleCA5MDRmYzllMTA5NC4uMDE3MWZkNTZmZmQgMTAwNjQ0Ci0tLSBhL2xpc3AvZW1hY3Mt bGlzcC9wYWNrYWdlLmVsCisrKyBiL2xpc3AvZW1hY3MtbGlzcC9wYWNrYWdlLmVsCkBAIC0yMjE1 LDcgKzIyMTUsNyBAQCBwYWNrYWdlLS1kZWxldGUtZGlyZWN0b3J5CiAgICAgICAgICAgICAgKGNv bmRpdGlvbi1jYXNlIGVycgogICAgICAgICAgICAgICAgICAoZGVsZXRlLWRpcmVjdG9yeSBkaXIg dCkKICAgICAgICAgICAgICAgIChmaWxlLWVycm9yCi0gICAgICAgICAgICAgICAgKGNsLWRlc3Ry dWN0dXJpbmctYmluZCAocmVhc29uMSByZWFzb24yIGZpbGVuYW1lKSBlcnIKKyAgICAgICAgICAg ICAgICAoY2wtZGVzdHJ1Y3R1cmluZy1iaW5kIChfIHJlYXNvbjEgcmVhc29uMiBmaWxlbmFtZSkg ZXJyCiAgICAgICAgICAgICAgICAgICAoaWYgKGFuZCAoc3RyaW5nPSAiUmVtb3Zpbmcgb2xkIG5h bWUiIHJlYXNvbjEpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAoc3RyaW5nPSAiUGVybWlz c2lvbiBkZW5pZWQiIHJlYXNvbjIpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAoc3RyaW5n LXByZWZpeC1wIChleHBhbmQtZmlsZS1uYW1lIHBhY2thZ2UtdXNlci1kaXIpCi0tIAoyLjI1LjEu d2luZG93cy4xCgo= --00000000000074297d05a7a5656f Content-Type: application/octet-stream; name="0001-Copy-suffixes-passed-to-openp-to-avoid-GC-crashes.-F.patch" Content-Disposition: attachment; filename="0001-Copy-suffixes-passed-to-openp-to-avoid-GC-crashes.-F.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kb7v9o7b0 RnJvbSA0YjRmZDUyNmFiZTEyNGM4YTc0YmZhMTEyMDlkZDUzYzNhNTY0Y2M3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Tmljb2w9QzM9QTFzPTIwQj1DMz1BOXJ0b2xv Pz0gPG5pY29sYXNiZXJ0b2xvQGdtYWlsLmNvbT4KRGF0ZTogTW9uLCA4IEp1biAyMDIwIDIyOjAx OjI1IC0wMzAwClN1YmplY3Q6IFtQQVRDSF0gQ29weSBzdWZmaXhlcyBwYXNzZWQgdG8gJ29wZW5w JyB0byBhdm9pZCBHQyBjcmFzaGVzLiBGaXhlcwogYnVnIzQxNzU1CgpJbiBvcGVucF9hZGRfbWlk ZGxlX2Rpcl90b19zdWZmaXhlcyB3ZSBidWlsZCBhIGhlYXAtYmFzZWQgbGlzdCBmcm9tCnRoZSBw YXNzZWQgc3VmZml4ZXMuICBJdCBpcyBjcnVjaWFsIHRoYXQgd2UgZG9uJ3QgY3JlYXRlIGEgaGVh cC1iYXNlZApjb25zIHRoYXQgcG9pbnRzIHRvIGEgc3RhY2stYmFzZWQgbGlzdC4KCiogc3JjL2xy ZWFkLmMgKG9wZW5wX2FkZF9taWRkbGVfZGlyX3RvX3N1ZmZpeGVzKTogQ29weSBzdWZmaXhlcyB3 aGVuCmJ1aWxkaW5nIGEgbGlzdCBvZiBtaWRkbGUtZGlycyBhbmQgc3VmZml4ZXMuCi0tLQogc3Jj L2xyZWFkLmMgfCAxNCArKysrKysrKysrLS0tLQogMSBmaWxlIGNoYW5nZWQsIDEwIGluc2VydGlv bnMoKyksIDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2xyZWFkLmMgYi9zcmMvbHJl YWQuYwppbmRleCBjMTI3ZDMyZWIxNy4uNjVkODQ0NjJjNGMgMTAwNjQ0Ci0tLSBhL3NyYy9scmVh ZC5jCisrKyBiL3NyYy9scmVhZC5jCkBAIC0xNjM1LDIxICsxNjM1LDI3IEBAIG9wZW5wX2FkZF9t aWRkbGVfZGlyX3RvX3N1ZmZpeGVzIChMaXNwX09iamVjdCBzdWZmaXhlcykKICAgTGlzcF9PYmpl Y3QgZXh0ZW5kZWRfc3VmID0gUW5pbDsKICAgRk9SX0VBQ0hfVEFJTF9TQUZFICh0YWlsKQogICAg IHsKLSNpZmRlZiBIQVZFX05BVElWRV9DT01QCisgICAgICAvKiAgc3VmZml4ZXMgbWF5IGJlIGEg c3RhY2stYmFzZWQgY29ucyBwb2ludGluZyB0byBzdGFjay1iYXNlZAorICAgICAgICAgIHN0cmlu Z3MuICBXZSBtdXN0IGNvcHkgdGhlIHN1ZmZpeCBpZiB3ZSBhcmUgcHV0dGluZyBpdCBpbnRvCisg ICAgICAgICAgYSBoZWFwLWJhc2VkIGNvbnMgdG8gYXZvaWQgYSBkYW5nbGluZyByZWZlcmVuY2Uu ICBUaGlzIHdvdWxkCisgICAgICAgICAgbGVhZCB0byBjcmFzaGVzIGR1cmluZyB0aGUgR0MuICAq LwogICAgICAgQ0hFQ0tfU1RSSU5HX0NBUiAodGFpbCk7CiAgICAgICBjaGFyICogc3VmID0gU1NE QVRBIChYQ0FSICh0YWlsKSk7CisgICAgICBMaXNwX09iamVjdCBjb3BpZWRfc3VmZml4ID0gYnVp bGRfc3RyaW5nIChzdWYpOworI2lmZGVmIEhBVkVfTkFUSVZFX0NPTVAKICAgICAgIGlmIChzdHJj bXAgKE5BVElWRV9FTElTUF9TVUZGSVgsIHN1ZikgPT0gMCkKICAgICAgICAgewogICAgICAgICAg IENIRUNLX1NUUklORyAoVmNvbXBfbmF0aXZlX3BhdGhfcG9zdGZpeCk7CiAgICAgICAgICAgLyog SGVyZSB3ZSBhZGQgdGhlbSBpbiB0aGUgb3Bwb3NpdGUgb3JkZXIgc28gdGhhdCBucmV2ZXJzZQog ICAgICAgICAgICAgIGNvcnJlY3RzIGl0LiAgKi8KLSAgICAgICAgICBleHRlbmRlZF9zdWYgPSBG Y29ucyAoRmNvbnMgKFFuaWwsIFhDQVIgKHRhaWwpKSwgZXh0ZW5kZWRfc3VmKTsKLSAgICAgICAg ICBleHRlbmRlZF9zdWYgPSBGY29ucyAoRmNvbnMgKFZjb21wX25hdGl2ZV9wYXRoX3Bvc3RmaXgs IFhDQVIgKHRhaWwpKSwKKyAgICAgICAgICBleHRlbmRlZF9zdWYgPSBGY29ucyAoRmNvbnMgKFFu aWwsIGNvcGllZF9zdWZmaXgpLCBleHRlbmRlZF9zdWYpOworICAgICAgICAgIGV4dGVuZGVkX3N1 ZiA9IEZjb25zIChGY29ucyAoVmNvbXBfbmF0aXZlX3BhdGhfcG9zdGZpeCwKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvcGllZF9zdWZmaXgpLAogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBleHRlbmRlZF9zdWYpOwogICAgICAgICB9CiAgICAgICBlbHNl CiAjZW5kaWYKLQlleHRlbmRlZF9zdWYgPSBGY29ucyAoRmNvbnMgKFFuaWwsIFhDQVIgKHRhaWwp KSwgZXh0ZW5kZWRfc3VmKTsKKwlleHRlbmRlZF9zdWYgPSBGY29ucyAoRmNvbnMgKFFuaWwsIGNv cGllZF9zdWZmaXgpLCBleHRlbmRlZF9zdWYpOwogICAgIH0KIAogICBzdWZmaXhlcyA9IEZucmV2 ZXJzZSAoZXh0ZW5kZWRfc3VmKTsKLS0gCjIuMjUuMS53aW5kb3dzLjEKCg== --00000000000074297d05a7a5656f Content-Type: application/octet-stream; name="0001-Use-a-C-array-to-keep-the-list-of-live-native-compil.patch" Content-Disposition: attachment; filename="0001-Use-a-C-array-to-keep-the-list-of-live-native-compil.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kb7v9o8y2 RnJvbSA3MTc0Mzc4NTJiN2U5MWE1ZmI5Y2Y4N2RhYjIxYjQ2NjFmM2JiM2I0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWNvbGFzIEJlcnRvbG8gPG5pY29sYXNiZXJ0b2xvQGdtYWls LmNvbT4KRGF0ZTogU3VuLCA3IEp1biAyMDIwIDE1OjU0OjUwIC0wMzAwClN1YmplY3Q6IFtQQVRD SF0gVXNlIGEgQyBhcnJheSB0byBrZWVwIHRoZSBsaXN0IG9mIGxpdmUgbmF0aXZlIGNvbXBpbGF0 aW9uCiB1bml0cy4KCkkgd2FzIGdldHRpbmcgY3Jhc2hlcyByZWxhdGVkIHRvIHRoZSBhY2Nlc3Mg dG8gdGhlIGhhc2h0YWJsZSB3aGVuCkVtYWNzIHdhcyBhYm91dCB0byBjbG9zZS4gSSBjb3VsZG4n dCBkZWJ1ZyB0aGVtLCBzbyBJIHJlcGxhY2VkIGl0IHdpdGgKYSBzaW1wbGUgQyBhcnJheS4KCiog c3JjL2xpc3AuaCAoYWxsb2NhdGVfbmF0aXZlX2NvbXBfdW5pdCk6IHJlZ2lzdGVyIGV2ZXJ5IG5h dGl2ZQpjb21waWxhdGlvbiB1bml0IGFsbG9jYXRlZC4KKiBzcmMvY29tcC5oOiBFeHBvc2UgcmVn aXN0ZXJfbmF0aXZlX2NvbXBfdW5pdCAoKSB0byBsaXNwLmguCiogc3JjL2NvbXAuYzogUmVtb3Zl IGFsbF9sb2FkZWRfY29tcF91bml0c19oLiBSZXBsYWNlIGl0IHdpdGggYQpkeW5hbWljYWxseSBz aXplZCBhcnJheS4KLS0tCiBzcmMvY29tcC5jIHwgOTQgKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiBzcmMvY29tcC5oIHwgIDUgKysrCiBzcmMv bGlzcC5oIHwgIDkgKysrKy0tCiAzIGZpbGVzIGNoYW5nZWQsIDY2IGluc2VydGlvbnMoKyksIDQy IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9jb21wLmMgYi9zcmMvY29tcC5jCmluZGV4 IDUyMWNhZGNiMTBjLi4xYTdlYWZhYWFkZiAxMDA2NDQKLS0tIGEvc3JjL2NvbXAuYworKysgYi9z cmMvY29tcC5jCkBAIC00MTExLDE3ICs0MTExLDE3IEBAIGhlbHBlcl9QU0VVRE9WRUNUT1JfVFlQ RVBfWFVOVEFHIChMaXNwX09iamVjdCBhLCBlbnVtIHB2ZWNfdHlwZSBjb2RlKQogCiAgIFRoZXJl IGFyZSB0d28gZGF0YSBzdHJ1Y3R1cmVzIHVzZWQ6CiAKLSAgLSBUaGUgYGFsbF9sb2FkZWRfY29t cF91bml0c19oYCBoYXNodGFibGUuCisgIC0gVGhlIGBhbGxfbG9hZGVkX2NvbXBfdW5pdHNgIGxp c3QuCiAKLSAgVGhpcyBoYXNodGFibGUgaXMgdXNlZCBsaWtlIGFuIGFycmF5IG9mIHdlYWsgcmVm ZXJlbmNlcyB0byBuYXRpdmUKLSAgY29tcGlsYXRpb24gdW5pdHMuICBUaGlzIGhhc2ggdGFibGUg aXMgZmlsbGVkIGJ5IGxvYWRfY29tcF91bml0ICgpCi0gIGFuZCBkaXNwb3NlX2FsbF9yZW1haW5p bmdfY29tcF91bml0cyAoKSBpdGVyYXRlcyBvdmVyIGFsbCB2YWx1ZXMKLSAgdGhhdCB3ZXJlIG5v dCBkaXNwb3NlZCBieSB0aGUgR0MgYW5kIHBlcmZvcm1zIGFsbCBkaXNwb3NhbCBzdGVwcwotICB3 aGVuIEVtYWNzIGlzIGNsb3NpbmcuCisgIFRoaXMgbGlzdCBpcyBmaWxsZWQgYnkgYWxsb2NhdGVf bmF0aXZlX2NvbXBfdW5pdCAoKSBhbmQKKyAgZGlzcG9zZV9hbGxfcmVtYWluaW5nX2NvbXBfdW5p dHMgKCkgaXRlcmF0ZXMgb3ZlciBhbGwgdmFsdWVzIHRoYXQKKyAgcmVtYWluIGFuZCBwZXJmb3Jt cyBhbGwgZGlzcG9zYWwgc3RlcHMgd2hlbiBFbWFjcyBpcyBjbG9zaW5nLiAgVGhlCisgIGRpc3Bv c2VfY29tcF91bml0ICgpIGZ1bmN0aW9uIHJlbW92ZXMgZW50cmllcyB0aGF0IHdlcmUgZGlzcG9z ZWQgYnkKKyAgdGhlIEdDLgogCiAgIC0gVGhlIGBkZWxheWVkX2NvbXBfdW5pdF9kaXNwb3NhbF9s aXN0YCBsaXN0LgogCi0gIFRoaXMgaXMgd2VyZSB0aGUgZGlzcG9zZV9jb21wX3VuaXQgKCkgZnVu Y3Rpb24sIHdoZW4gY2FsbGVkIGJ5IHRoZQorICBUaGlzIGlzIHdoZXJlIHRoZSBkaXNwb3NlX2Nv bXBfdW5pdCAoKSBmdW5jdGlvbiwgd2hlbiBjYWxsZWQgYnkgdGhlCiAgIEdDIHN3ZWVwIHN0YWdl LCBzdG9yZXMgdGhlIG9yaWdpbmFsIGZpbGVuYW1lcyBvZiB0aGUgZGlzcG9zZWQgbmF0aXZlCiAg IGNvbXBpbGF0aW9uIHVuaXRzLiAgVGhpcyBpcyBhbiBhZC1ob2MgQyBzdHJ1Y3R1cmUgaW5zdGVh ZCBvZiBhIExpc3AKICAgY29ucyBiZWNhdXNlIHdlIG5lZWQgdG8gYWxsb2NhdGUgaW5zdGFuY2Vz IG9mIHRoaXMgc3RydWN0dXJlIGR1cmluZwpAQCAtNDEzNiw3ICs0MTM2LDM1IEBAIGhlbHBlcl9Q U0VVRE9WRUNUT1JfVFlQRVBfWFVOVEFHIChMaXNwX09iamVjdCBhLCBlbnVtIHB2ZWNfdHlwZSBj b2RlKQogI2lmZGVmIFdJTkRPV1NOVAogI2RlZmluZSBPTERfRUxOX1NVRkZJWF9SRUdFWFAgYnVp bGRfc3RyaW5nICgiXFwuZWxuXFwub2xkXFwnIikKIAotc3RhdGljIExpc3BfT2JqZWN0IGFsbF9s b2FkZWRfY29tcF91bml0c19oOworc3RydWN0IGFsbF9sb2FkZWRfY29tcF91bml0c19zIHsKKyAg c3RydWN0IExpc3BfTmF0aXZlX0NvbXBfVW5pdCAqKm1lbTsKKyAgc2l6ZV90IHNpemU7CisgIHNp emVfdCBjYXBhY2l0eTsKK307CisKK3N0YXRpYyBzdHJ1Y3QgYWxsX2xvYWRlZF9jb21wX3VuaXRz X3MgYWxsX2xvYWRlZF9jb21wX3VuaXRzOworCitzdGF0aWMgdm9pZAorbG9hZGVkX2NvbXBfdW5p dHNfcmVtb3ZlIChzdHJ1Y3QgTGlzcF9OYXRpdmVfQ29tcF9Vbml0ICogY29tcF91KQoreworICBz aXplX3QgaTsKKyAgYm9vbCBmb3VuZCA9IGZhbHNlOworICBmb3IgKGkgPSAwIDsgaSA8IGFsbF9s b2FkZWRfY29tcF91bml0cy5zaXplOyArK2kpCisgICAgaWYgKGFsbF9sb2FkZWRfY29tcF91bml0 cy5tZW1baV0gPT0gY29tcF91KQorICAgICAgeworICAgICAgICBmb3VuZCA9IHRydWU7CisgICAg ICAgIGJyZWFrOworICAgICAgfQorICBpZiAoIWZvdW5kKQorICAgIGVtYWNzX2Fib3J0ICgpOwor CisgIHNpemVfdCBlbGVtZW50c19vbl9yaWdodCA9IGFsbF9sb2FkZWRfY29tcF91bml0cy5zaXpl IC0gaSAtIDE7CisgIG1lbW1vdmUgKCZhbGxfbG9hZGVkX2NvbXBfdW5pdHMubWVtW2ldLAorICAg ICAgICAgICAmYWxsX2xvYWRlZF9jb21wX3VuaXRzLm1lbVtpICsgMV0sCisgICAgICAgICAgIGVs ZW1lbnRzX29uX3JpZ2h0ICogc2l6ZW9mIChzdHJ1Y3QgTGlzcF9OYXRpdmVfQ29tcF9Vbml0ICop KTsKKworICBhbGxfbG9hZGVkX2NvbXBfdW5pdHMubWVtWy0tYWxsX2xvYWRlZF9jb21wX3VuaXRz LnNpemVdID0gTlVMTDsKK30KIAogLyogV2UgbmVlZCB0byBhbGxvY2F0ZSBpbnN0YW5jZXMgb2Yg dGhpcyBzdHJ1Y3QgZHVyaW5nIGEgR0Mgc3dlZXAuCiAgICBUaGlzIGlzIHdoeSBpdCBjYW4ndCBi ZSB0cmFuc2Zvcm1lZCBpbnRvIGEgc2ltcGxlIGNvbnMuICAqLwpAQCAtNDE5MywxNyArNDIyMSw5 IEBAIGNsZWFuX3BhY2thZ2VfdXNlcl9kaXJfb2Zfb2xkX2NvbXBfdW5pdHMgKHZvaWQpCiB2b2lk CiBkaXNwb3NlX2FsbF9yZW1haW5pbmdfY29tcF91bml0cyAodm9pZCkKIHsKLSAgc3RydWN0IExp c3BfSGFzaF9UYWJsZSAqaCA9IFhIQVNIX1RBQkxFIChhbGxfbG9hZGVkX2NvbXBfdW5pdHNfaCk7 Ci0KLSAgZm9yIChwdHJkaWZmX3QgaSA9IDA7IGkgPCBIQVNIX1RBQkxFX1NJWkUgKGgpOyArK2kp CisgIGZvciAocHRyZGlmZl90IGkgPSBhbGxfbG9hZGVkX2NvbXBfdW5pdHMuc2l6ZSAtIDE7IGkg Pj0gMDsgLS1pKQogICAgIHsKLSAgICAgIExpc3BfT2JqZWN0IGsgPSBIQVNIX0tFWSAoaCwgaSk7 Ci0gICAgICBpZiAoIUVRIChrLCBRdW5ib3VuZCkpCi0gICAgICAgIHsKLSAgICAgICAgICBMaXNw X09iamVjdCB2YWwgPSBIQVNIX1ZBTFVFIChoLCBpKTsKLSAgICAgICAgICBzdHJ1Y3QgTGlzcF9O YXRpdmVfQ29tcF9Vbml0ICpjdSA9IFhOQVRJVkVfQ09NUF9VTklUICh2YWwpOwotICAgICAgICAg IGRpc3Bvc2VfY29tcF91bml0IChjdSwgZmFsc2UpOwotICAgICAgICB9CisgICAgICBkaXNwb3Nl X2NvbXBfdW5pdCAoYWxsX2xvYWRlZF9jb21wX3VuaXRzLm1lbVtpXSwgZmFsc2UpOwogICAgIH0K IH0KIApAQCAtNDIyNywyMiArNDI0NywyNiBAQCBmaW5pc2hfZGVsYXllZF9kaXNwb3NhbF9vZl9j b21wX3VuaXRzICh2b2lkKQogICAgICAgeGZyZWUgKGl0ZW0pOwogICAgIH0KIH0KLSNlbmRpZgog CiAvKiBUaGlzIGZ1bmN0aW9uIHB1dHMgdGhlIGNvbXBpbGF0aW9uIHVuaXQgaW4gdGhlCi0gIGBh bGxfbG9hZGVkX2NvbXBfdW5pdHNfaGAgaGFzaG1hcC4gICovCi1zdGF0aWMgdm9pZAotcmVnaXN0 ZXJfbmF0aXZlX2NvbXBfdW5pdCAoTGlzcF9PYmplY3QgY29tcF91KQorICBgYWxsX2xvYWRlZF9j b21wX3VuaXRzYCBsaXN0LiAgKi8KK3ZvaWQKK3JlZ2lzdGVyX25hdGl2ZV9jb21wX3VuaXQgKHN0 cnVjdCBMaXNwX05hdGl2ZV9Db21wX1VuaXQgKiBjb21wX3UpCiB7Ci0jaWZkZWYgV0lORE9XU05U Ci0gIC8qIFdlIGhhdmUgdG8gZG8gdGhpcyBzaW5jZSB3ZSBjYW4ndCB1c2UgYGdlbnN5bScuIFRo aXMgZnVuY3Rpb24gaXMKLSAgICAgY2FsbGVkIGVhcmx5IHdoZW4gbG9hZGluZyBhIGR1bXAgZmls ZSBhbmQgc3Vici5lbCBtYXkgbm90IGhhdmUKLSAgICAgYmVlbiBsb2FkZWQgeWV0LiAgKi8KLSAg c3RhdGljIGludG1heF90IGNvdW50OworICAvKiAgR3JvdyB0aGUgYXJyYXkgaWYgbmVjZXNzYXJ5 LiAgKi8KKyAgaWYgKGFsbF9sb2FkZWRfY29tcF91bml0cy5zaXplICsgMSA+IGFsbF9sb2FkZWRf Y29tcF91bml0cy5jYXBhY2l0eSkKKyAgICB7CisgICAgICBhbGxfbG9hZGVkX2NvbXBfdW5pdHMu Y2FwYWNpdHkgPSBtYXggKDEsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIDIgKiBhbGxfbG9hZGVkX2NvbXBfdW5pdHMuY2FwYWNpdHkpOworICAgICAgYWxsX2xv YWRlZF9jb21wX3VuaXRzLm1lbQorICAgICAgICA9IHhyZWFsbG9jIChhbGxfbG9hZGVkX2NvbXBf dW5pdHMubWVtLAorICAgICAgICAgICAgICAgICAgICBhbGxfbG9hZGVkX2NvbXBfdW5pdHMuY2Fw YWNpdHkKKyAgICAgICAgICAgICAgICAgICAgKiBzaXplb2YgKHN0cnVjdCBMaXNwX05hdGl2ZV9D b21wX1VuaXQgKikpOworICAgIH0KIAotICBGcHV0aGFzaCAobWFrZV9pbnQgKGNvdW50KyspLCBj b21wX3UsIGFsbF9sb2FkZWRfY29tcF91bml0c19oKTsKLSNlbmRpZgorICBhbGxfbG9hZGVkX2Nv bXBfdW5pdHMubWVtW2FsbF9sb2FkZWRfY29tcF91bml0cy5zaXplKytdID0gY29tcF91OwogfQor I2VuZGlmCiAKIC8qIFRoaXMgZnVuY3Rpb24gZGlzcG9zZXMgY29tcGlsYXRpb24gdW5pdHMuICBJ dCBpcyBjYWxsZWQgZHVyaW5nIHRoZSBHQyBzd2VlcAogICAgc3RhZ2UgYW5kIHdoZW4gRW1hY3Mg aXMgY2xvc2luZy4KQEAgLTQyNTcsNiArNDI4MSw3IEBAIGRpc3Bvc2VfY29tcF91bml0IChzdHJ1 Y3QgTGlzcF9OYXRpdmVfQ29tcF9Vbml0ICpjb21wX2hhbmRsZSwgYm9vbCBkZWxheSkKICAgZWFz c2VydCAoY29tcF9oYW5kbGUtPmhhbmRsZSk7CiAgIGR5bmxpYl9jbG9zZSAoY29tcF9oYW5kbGUt PmhhbmRsZSk7CiAjaWZkZWYgV0lORE9XU05UCisgIGxvYWRlZF9jb21wX3VuaXRzX3JlbW92ZSAo Y29tcF9oYW5kbGUpOwogICBpZiAoIWRlbGF5KQogICAgIHsKICAgICAgIExpc3BfT2JqZWN0IGRp cm5hbWUgPSBpbnRlcm5hbF9jb25kaXRpb25fY2FzZV8xICgKQEAgLTQ1MDEsMTIgKzQ1MjYsNiBA QCBsb2FkX2NvbXBfdW5pdCAoc3RydWN0IExpc3BfTmF0aXZlX0NvbXBfVW5pdCAqY29tcF91LCBi b29sIGxvYWRpbmdfZHVtcCwKICAgICAgIGRfdmVjX2xlbiA9IFhGSVhOVU0gKEZsZW5ndGggKGNv bXBfdS0+ZGF0YV9pbXB1cmVfdmVjKSk7CiAgICAgICBmb3IgKEVNQUNTX0lOVCBpID0gMDsgaSA8 IGRfdmVjX2xlbjsgaSsrKQogCWRhdGFfaW1wX3JlbG9jc1tpXSA9IEFSRUYgKGNvbXBfdS0+ZGF0 YV9pbXB1cmVfdmVjLCBpKTsKLQotICAgICAgLyogSWYgd2UgcmVnaXN0ZXIgdGhlbSB3aGlsZSBk dW1waW5nIHdlIHdpbGwgZ2V0IHNvbWUgZW50cmllcyBpbgotCSB0aGUgaGFzaCB0YWJsZSB0aGF0 IHdpbGwgYmUgZHVwbGljYXRlZCB3aGVuIHBkdW1wZXIgY2FsbHMKLQkgbG9hZF9jb21wX3VuaXQu ICAqLwotICAgICAgaWYgKCF3aWxsX2R1bXBfcCAoKSkKLQlyZWdpc3Rlcl9uYXRpdmVfY29tcF91 bml0IChjb21wX3VfbGlzcF9vYmopOwogICAgIH0KIAogICBpZiAoIWxvYWRpbmdfZHVtcCkKQEAg LTQ4MTgsMTEgKzQ4MzcsNiBAQCBzeW1zX29mX2NvbXAgKHZvaWQpCiAgIHN0YXRpY3BybyAoJmRl bGF5ZWRfc291cmNlcyk7CiAgIGRlbGF5ZWRfc291cmNlcyA9IFFuaWw7CiAKLSNpZmRlZiBXSU5E T1dTTlQKLSAgc3RhdGljcHJvICgmYWxsX2xvYWRlZF9jb21wX3VuaXRzX2gpOwotICBhbGxfbG9h ZGVkX2NvbXBfdW5pdHNfaCA9IENBTExOIChGbWFrZV9oYXNoX3RhYmxlLCBRQ3dlYWtuZXNzLCBR dmFsdWUpOwotI2VuZGlmCi0KICAgREVGVkFSX0xJU1AgKCJjb21wLWN0eHQiLCBWY29tcF9jdHh0 LAogCSAgICAgICBkb2M6IC8qIFRoZSBjb21waWxlciBjb250ZXh0LiAgKi8pOwogICBWY29tcF9j dHh0ID0gUW5pbDsKZGlmZiAtLWdpdCBhL3NyYy9jb21wLmggYi9zcmMvY29tcC5oCmluZGV4IDUw NzM3OWJmNWU2Li5lNDE5NmQ0YTVmOSAxMDA2NDQKLS0tIGEvc3JjL2NvbXAuaAorKysgYi9zcmMv Y29tcC5oCkBAIC0xMDEsNiArMTAxLDExIEBAIFhOQVRJVkVfQ09NUF9VTklUIChMaXNwX09iamVj dCBhKQogCiBleHRlcm4gdm9pZCBjbGVhbl9wYWNrYWdlX3VzZXJfZGlyX29mX29sZF9jb21wX3Vu aXRzICh2b2lkKTsKIAorI2lmZGVmIFdJTkRPV1NOVAorZXh0ZXJuIHZvaWQKK3JlZ2lzdGVyX25h dGl2ZV9jb21wX3VuaXQgKHN0cnVjdCBMaXNwX05hdGl2ZV9Db21wX1VuaXQgKiBjb21wX3VuaXQp OworI2VuZGlmCisKICNlbHNlIC8qICNpZmRlZiBIQVZFX05BVElWRV9DT01QICovCiAKIHN0YXRp YyBpbmxpbmUgdm9pZApkaWZmIC0tZ2l0IGEvc3JjL2xpc3AuaCBiL3NyYy9saXNwLmgKaW5kZXgg MjJjZDE2NmM5NTQuLmY2NDQ2M2FmZWVjIDEwMDY0NAotLS0gYS9zcmMvbGlzcC5oCisrKyBiL3Ny Yy9saXNwLmgKQEAgLTQ3NjQsOCArNDc2NCwxMyBAQCBTVUJSX05BVElWRV9DT01QSUxFRFAgKExp c3BfT2JqZWN0IGEpCiBJTkxJTkUgc3RydWN0IExpc3BfTmF0aXZlX0NvbXBfVW5pdCAqCiBhbGxv Y2F0ZV9uYXRpdmVfY29tcF91bml0ICh2b2lkKQogewotICByZXR1cm4gQUxMT0NBVEVfWkVST0VE X1BTRVVET1ZFQ1RPUiAoc3RydWN0IExpc3BfTmF0aXZlX0NvbXBfVW5pdCwKLQkJCQkgICAgICAg ZGF0YV9pbXB1cmVfdmVjLCBQVkVDX05BVElWRV9DT01QX1VOSVQpOworICBzdHJ1Y3QgTGlzcF9O YXRpdmVfQ29tcF9Vbml0ICogY29tcF91CisgICAgPSBBTExPQ0FURV9aRVJPRURfUFNFVURPVkVD VE9SIChzdHJ1Y3QgTGlzcF9OYXRpdmVfQ29tcF9Vbml0LAorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgZGF0YV9pbXB1cmVfdmVjLCBQVkVDX05BVElWRV9DT01QX1VOSVQpOwor I2lmZGVmIFdJTkRPV1NOVAorICByZWdpc3Rlcl9uYXRpdmVfY29tcF91bml0IChjb21wX3UpOwor I2VuZGlmCisgIHJldHVybiBjb21wX3U7CiB9CiAjZWxzZQogSU5MSU5FIGJvb2wKLS0gCjIuMjUu MS53aW5kb3dzLjEKCg== --00000000000074297d05a7a5656f-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 09 10:07:42 2020 Received: (at 41754-done) by debbugs.gnu.org; 9 Jun 2020 14:07:42 +0000 Received: from localhost ([127.0.0.1]:60476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jieuk-0001je-2n for submit@debbugs.gnu.org; Tue, 09 Jun 2020 10:07:42 -0400 Received: from mx.sdf.org ([205.166.94.20]:53757) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jieui-0001jU-1p for 41754-done@debbugs.gnu.org; Tue, 09 Jun 2020 10:07:40 -0400 Received: from sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 059E7cLZ028577 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Tue, 9 Jun 2020 14:07:38 GMT Received: (from akrl@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 059E7co9023206; Tue, 9 Jun 2020 14:07:38 GMT From: Andrea Corallo To: Nicolas =?utf-8?Q?B=C3=A9rtolo?= Subject: Re: bug#41754: [feature/native-comp] Fix crash when loading lambdas from dumps with --enable-checking. References: Date: Tue, 09 Jun 2020 14:07:37 +0000 In-Reply-To: ("Nicolas =?utf-8?Q?B=C3=A9rtolo=22's?= message of "Tue, 9 Jun 2020 08:54:45 -0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41754-done Cc: 41754-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Nicolas B=C3=A9rtolo writes: > Hi Andrea, > > I can confirm that the issue with lambdas is fixed. Good closing this. I pushed the `package--delete-directory' fix. Please post the patches you are submitting in the thread you have discussed the related issue so they can be effectively reviewed by people you have discussed with. Andrea =20 --=20 akrl@sdf.org From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 09 10:30:48 2020 Received: (at 41754-done) by debbugs.gnu.org; 9 Jun 2020 14:30:48 +0000 Received: from localhost ([127.0.0.1]:60539 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jifH5-0002Pf-RN for submit@debbugs.gnu.org; Tue, 09 Jun 2020 10:30:47 -0400 Received: from mail-ot1-f53.google.com ([209.85.210.53]:46064) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jifH3-0002PS-Pd for 41754-done@debbugs.gnu.org; Tue, 09 Jun 2020 10:30:46 -0400 Received: by mail-ot1-f53.google.com with SMTP id m2so16741773otr.12 for <41754-done@debbugs.gnu.org>; Tue, 09 Jun 2020 07:30:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DmnPe94reubuuqy5lUuhrgnl1TevwJg4mxIHQwRkuRk=; b=VjS8bRW63JL+mIQRdzwTTGr8FnfoIZVDMcudUD/VDU83wlIbIK3+thXSJXBpqsfXIr g6B7tEH1rtgc2X25TCvpoH1kKWg/R5ldbA7w6BFuLM5PKNmXoHUP3/qGVp1KE4XMmIgu +9dPJrn2gRI/EvHj77FJP3PROHxdyoyeJsfwJnCPQi6U+Re3QWNQm36HLDwA2yISeyFv ctsro+ebRIP8ROU5m3w5cPjDZYhavnFD69g0DfcBSj6oDO/62GZyjOTp/l1vmTq/9Q70 DI3SoJkVrGwThzOWy0VbmILEYs8FNTl15ev5NVyqYMHz/KkwILnoU4fpn4bvsVagNc92 QAIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DmnPe94reubuuqy5lUuhrgnl1TevwJg4mxIHQwRkuRk=; b=ZTywqoykolbcqe/5pqDi1pY2+jLUrx5P3i95D2VkGTAAw01Nju8PeskSTgbN8UgVl2 PVgSlSAn7sLJRwvY9Z0rt5rame9GBpO9ojqUf0k/0kzvc4oIuRuMnJbX2A4jb+s1uU6I x0caCHsR7DVURJWR1kQ3RZ4HoWBMDf3a9qOo9XenX+o6HqHnTvp0km9g3pm/HReGyZnM hBfRzha85n5DgyqpS1K85Q4vtMuV3RJ7PQx7de562fYgqKKYFa7oLspWsLoXX0/Q7mx7 JuLFoIYpfC04YXdF10TChU7Btgjk4HfBCtrA30x8PyX9PZufICgr1xCnGVplBxNWNNDK +CvA== X-Gm-Message-State: AOAM531xGB2OW9Y2K8B+8CPb7zaLvk/aCDqHZBwbaqhjsaQQTUr4uEaw BhYICVcvV8WmabKl6D5VDYs51+FljB5OgQ0X8/g= X-Google-Smtp-Source: ABdhPJxpAQjSyIBMq4IdcUoOQcp1BxpSShG8SmNj706HsspcQiFTfaXqLqGy+olo/M4XGgszVIOLJbk+CQB0vxebMp0= X-Received: by 2002:a9d:26:: with SMTP id 35mr14911688ota.352.1591713040017; Tue, 09 Jun 2020 07:30:40 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: =?UTF-8?Q?Nicolas_B=C3=A9rtolo?= Date: Tue, 9 Jun 2020 11:30:27 -0300 Message-ID: Subject: Re: bug#41754: [feature/native-comp] Fix crash when loading lambdas from dumps with --enable-checking. To: Andrea Corallo Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41754-done Cc: 41754-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > I pushed the `package--delete-directory' fix. Please post the patches > you are submitting in the thread you have discussed the related issue so > they can be effectively reviewed by people you have discussed with. Sorry. I apologize. I thought the discussion in those threads was over, after having identified the bug, that's why I sent them directly to you. I didn't mean to sidestep anyone. Nico. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 09 11:03:32 2020 Received: (at 41754) by debbugs.gnu.org; 9 Jun 2020 15:03:32 +0000 Received: from localhost ([127.0.0.1]:60589 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jifml-0003G8-Sk for submit@debbugs.gnu.org; Tue, 09 Jun 2020 11:03:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53138) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jifmW-0003Fa-1w for 41754@debbugs.gnu.org; Tue, 09 Jun 2020 11:03:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43139) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jifmQ-0008Or-Pv; Tue, 09 Jun 2020 11:03:10 -0400 Received: from [176.228.60.248] (port=3091 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jifmP-0004JB-9L; Tue, 09 Jun 2020 11:03:10 -0400 Date: Tue, 09 Jun 2020 18:02:49 +0300 Message-Id: <83zh9c5lk6.fsf@gnu.org> From: Eli Zaretskii To: Nicolas =?utf-8?Q?B=C3=A9rtolo?= In-Reply-To: (message from Nicolas =?utf-8?Q?B=C3=A9rtolo?= on Tue, 9 Jun 2020 08:54:45 -0300) Subject: Re: bug#41754: [feature/native-comp] Fix crash when loading lambdas from dumps with --enable-checking. References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41754 Cc: 41754@debbugs.gnu.org, akrl@sdf.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Nicolas Bértolo > Date: Tue, 9 Jun 2020 08:54:45 -0300 > Cc: 41754@debbugs.gnu.org > > - Copy the suffixes before building the heap-based list in openp. I know this is > not the solution I proposed in the bug report, but I couldn't adapt the code > without increasing its complexity way too much for my liking. If you think > this is not an appropriate solution I will come up with another one. This conses a string for each extension each time through the loop, doesn't it? Is that really necessary? Maybe we should take a step back and consider restructuring the code a bit. AFAIU, you cons the extended_suf list to be able to use the FOR_* loops that manipulate lists, is that correct? If so, could it be that removing that constraint will lead to a more elegant and less expensive code? After all, all this function does is to append STR to each directory in PATH, then try finding the resulting file with or without one of the extensions in SUFFIXES. Could we produce the file name to probe without walking a single list? From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 09 11:11:35 2020 Received: (at 41754) by debbugs.gnu.org; 9 Jun 2020 15:11:35 +0000 Received: from localhost ([127.0.0.1]:60594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jifuZ-0003S6-0e for submit@debbugs.gnu.org; Tue, 09 Jun 2020 11:11:35 -0400 Received: from mail-oi1-f174.google.com ([209.85.167.174]:44116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jifuX-0003Rt-Hb for 41754@debbugs.gnu.org; Tue, 09 Jun 2020 11:11:33 -0400 Received: by mail-oi1-f174.google.com with SMTP id x202so19035434oix.11 for <41754@debbugs.gnu.org>; Tue, 09 Jun 2020 08:11:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Q7I8jWwT4yZT8htsecvbdP8WHv1fA+mba5Y8CHgKmjI=; b=cXZYgVcALBAR0HEw2tOJCXS+NkQ8G3QgIUp7YvJ2coRc10KUp2SkAyD5RdOuG2y62c bt5952wPlnP+TGDlTjr/MQ+4/BKaiw35cGtwjpPrKBv0FR9QSibEyP1glguxdnnNmm2O AxK85C0a4puBOay1gYiURFM/4OZog9xqYhBshHYC0ClstDj2SbcnduNCJWjV9/H4WH4i MbT45/bxooVEkP1Lo6Frvt787z3r3KLp3XFy2+BhbX+YACE4vHHnKJeESIyWt9YgtLOz W5carMU+ga8CfmcubbDUNZiqj8uv9mC5FAgVu294uCUU8A5JGfKamxTDhf6rq+06c9o0 R0CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Q7I8jWwT4yZT8htsecvbdP8WHv1fA+mba5Y8CHgKmjI=; b=GID24KezFnXo2mg/H6uM6aO056VSIqUcf+PC+VHlyH/KF723Ck8GWyEZfE44D8fvjK aIHRXweKqL3C6xrUf4TWkHLuY51iSozYQICHu38wBY+qCGTwfjce+TpRF6jbYiGtMTBa TWtMr4pl1kBSCLWOTvLIxrPbSVlBslf/8d4/BPOAJW2aeUeNz8+isFn2bdRoaywfgZ6q JQZHeANhHmGNFt9pBMGFWodUv5Id6g4zAy+wVTzQ/FmOgGW377fBaC8h2atc7Out4Enl VyEgiyYsxOjVeQfY1pBcLwAB7Aou26ul+EFIO9KeEe1aMefJqDRG6EyJmeWwoWcNgBWX PTJA== X-Gm-Message-State: AOAM5318Gm5xZ0A3bueBPDKhMU2kN1I6CYY4HVZp5dX2Iv5h2SenBX6C FgKLPfbyH6rd91Y48Rxcnu2bvxyCjcSXxbqDRLQ= X-Google-Smtp-Source: ABdhPJwKi3C9nb1HdMshjMqADIpZVE6UGvwQxZYOxLELz9n7muZTC/xxfnlda2uYO+fA6ajVcKrbbKM2b/ByST1c6uA= X-Received: by 2002:aca:b742:: with SMTP id h63mr3826109oif.65.1591715487899; Tue, 09 Jun 2020 08:11:27 -0700 (PDT) MIME-Version: 1.0 References: <83zh9c5lk6.fsf@gnu.org> In-Reply-To: <83zh9c5lk6.fsf@gnu.org> From: =?UTF-8?Q?Nicolas_B=C3=A9rtolo?= Date: Tue, 9 Jun 2020 12:11:15 -0300 Message-ID: Subject: Re: bug#41754: [feature/native-comp] Fix crash when loading lambdas from dumps with --enable-checking. To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41754 Cc: 41754@debbugs.gnu.org, Andrea Corallo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > This conses a string for each extension each time through the loop, > doesn't it? Is that really necessary? It does. I thought that keeping the code simple (aka using the FOR_* macros) more important than saving a few memory allocations, especially when this function accesses the filesystem, which should be much more expensive. > AFAIU, you cons the extended_suf list to be able to use the > FOR_* loops that manipulate lists, is that correct? Exactly. > If so, could it be that removing that constraint will lead to a more elegant > and less expensive code? After all, all this function does is to append STR to > each directory in PATH, then try finding the resulting file with or without one > of the extensions in SUFFIXES. Could we produce the file name to probe without > walking a single list? I'll come up with a new version taking your suggestions into account. Thanks, Nico. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 09 11:54:06 2020 Received: (at 41754) by debbugs.gnu.org; 9 Jun 2020 15:54:07 +0000 Received: from localhost ([127.0.0.1]:60625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jigZi-0004V1-KF for submit@debbugs.gnu.org; Tue, 09 Jun 2020 11:54:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jigZg-0004UX-Kf for 41754@debbugs.gnu.org; Tue, 09 Jun 2020 11:54:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44122) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jigZb-0001OK-1B; Tue, 09 Jun 2020 11:53:59 -0400 Received: from [176.228.60.248] (port=2214 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jigZa-00080Y-H2; Tue, 09 Jun 2020 11:53:58 -0400 Date: Tue, 09 Jun 2020 18:53:39 +0300 Message-Id: <83y2ow5j7g.fsf@gnu.org> From: Eli Zaretskii To: Nicolas =?utf-8?Q?B=C3=A9rtolo?= In-Reply-To: (message from Nicolas =?utf-8?Q?B=C3=A9rtolo?= on Tue, 9 Jun 2020 12:11:15 -0300) Subject: Re: bug#41754: [feature/native-comp] Fix crash when loading lambdas from dumps with --enable-checking. References: <83zh9c5lk6.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41754 Cc: 41754@debbugs.gnu.org, akrl@sdf.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Nicolas Bértolo > Date: Tue, 9 Jun 2020 12:11:15 -0300 > Cc: Andrea Corallo , 41754@debbugs.gnu.org > > > If so, could it be that removing that constraint will lead to a more elegant > > and less expensive code? After all, all this function does is to append STR to > > each directory in PATH, then try finding the resulting file with or without one > > of the extensions in SUFFIXES. Could we produce the file name to probe without > > walking a single list? > > I'll come up with a new version taking your suggestions into account. Please don't see what I wrote as a requirement. Just take it into consideration and see if it leads to something reasonable. If you feel that the result will not be significantly better, there's no need to come up with yet another solution; I'd hate to ask you to do redundant work unless my idea really happens to lead to an elegant solution. And thanks for your continued work on these matters, highly appreciated. From unknown Thu Jun 19 14:03:52 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 08 Jul 2020 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator