Subject: Re: [bug#41753] [PATCH] gnu: Add tup.

From: Jakub Kądziołka <[email-masked]>
Date: Mon, 15 Jun 2020 00:15:37 +0200

On Sun, Jun 14, 2020 at 10:58:07PM +0200, Ludovic Courtès wrote:
> Hi,
> 
> Jakub Kądziołka <[email-masked]> skribis:
> 
> > * gnu/packages/build-tools.scm (tup): New variable.
> > * gnu/packages/patches/tup-unbundle-dependencies.patch: New file.
> > * gnu/local.mk (dist_patch_DATA): Register new file.
> 
> [...]
> 
> > --- /dev/null
> > +++ b/gnu/packages/patches/tup-unbundle-dependencies.patch
> > @@ -0,0 +1,74 @@
> > +From 895a7d4e8200f9430414a5fe47756efb67d2e5d0 Mon Sep 17 00:00:00 2001
> > +From: =?UTF-8?q?Jakub=20K=C4=85dzio=C5=82ka?= <[email-masked]>
> > +Date: Sun, 7 Jun 2020 15:14:42 +0200
> > +Subject: [PATCH] Unbundle dependencies
> > +
> > +---
> > + build.sh        | 10 ++++------
> > + src/tup/db.c    |  2 +-
> > + src/tup/tupid.h |  2 +-
> > + 3 files changed, 6 insertions(+), 8 deletions(-)
> 
> Nitpick: I’d remove the whole Git header and just keep the subject.
> 
> Otherwise LGTM!

Thanks for the review! I have pushed a revised patch as commit
2c1d1b7599a3738cdbdcaa281d56fa47b0b4c025.

Regards,
Jakub Kądziołka