GNU bug report logs - #41744
27.0.91; Various D-Bus cleanups

Previous Next

Package: emacs;

Reported by: "Basil L. Contovounesios" <contovob <at> tcd.ie>

Date: Sat, 6 Jun 2020 23:28:02 UTC

Severity: minor

Tags: fixed, patch

Found in version 27.0.91

Fixed in version 28.1

Done: "Basil L. Contovounesios" <contovob <at> tcd.ie>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Michael Albinus <michael.albinus <at> gmx.de>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 41744 <at> debbugs.gnu.org
Subject: bug#41744: 27.0.91; Various D-Bus cleanups
Date: Thu, 18 Jun 2020 11:59:14 +0200
"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:

Hi Basil,

> The doc patch for emacs-27 has now propagated to master, so here's a
> rebased version of the patch for master.  WDYT?
>
> --- a/lisp/net/dbus.el
> +++ b/lisp/net/dbus.el
> @@ -169,7 +166,6 @@ dbus-ignore-errors
>
>  (define-obsolete-variable-alias 'dbus-event-error-hooks
>    'dbus-event-error-functions "24.3")

I believe we should remove this variable now.

> @@ -339,8 +335,8 @@ dbus-call-method
>
> +(define-obsolete-function-alias 'dbus-call-method-non-blocking
> +  #'dbus-call-method "24.3")

Dito.

Otherwise, it looks good to me (but I haven't tested comprehensively).

For a while, I have on my wishlist to declare a D-Bus event as a
defstruct, like this:

(cl-defstruct (dbus-event (:type list) :named)
  "A D-Bus event, coming from or sent to other applications."
  bus-name message-type serial-number
  service-name path-name interface-name member-name handler)

But I don't know whether it is worth the effort.

> Thanks,
>
> --
> Basil

Best regards, Michael.




This bug report was last modified 4 years and 336 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.