From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 06 15:24:06 2020 Received: (at submit) by debbugs.gnu.org; 6 Jun 2020 19:24:06 +0000 Received: from localhost ([127.0.0.1]:52534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jheQH-0002JH-RP for submit@debbugs.gnu.org; Sat, 06 Jun 2020 15:24:06 -0400 Received: from lists.gnu.org ([209.51.188.17]:44370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jheQG-0002JA-FN for submit@debbugs.gnu.org; Sat, 06 Jun 2020 15:24:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41422) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jheQG-0000It-91 for bug-gnu-emacs@gnu.org; Sat, 06 Jun 2020 15:24:04 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:48516 helo=mail.ericabrahamsen.net) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jheQF-0006Y0-9a for bug-gnu-emacs@gnu.org; Sat, 06 Jun 2020 15:24:03 -0400 Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 65CC9FA034 for ; Sat, 6 Jun 2020 19:23:54 +0000 (UTC) From: Eric Abrahamsen To: bug-gnu-emacs@gnu.org Subject: 28.0.50; Derive gnus-edit-form-mode from lisp-data-mode Date: Sat, 06 Jun 2020 12:23:52 -0700 Message-ID: <87wo4kroaf.fsf@ericabrahamsen.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=52.70.2.18; envelope-from=eric@ericabrahamsen.net; helo=mail.ericabrahamsen.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/06 15:23:55 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Hopefully this is fairly uncontroversial: Gnus has a gnus-edit-form-mode for editing group parameters and other things, which presents the data as elisp forms and is a perfect use-case for lisp-data-mode -- turning on paredit or what have you. This patch derives the former from the latter. Eric --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Derive-gnus-edit-form-mode-from-lisp-data-mode.patch >From c8785b43abf7db5721950001e93f5a0c57b76d28 Mon Sep 17 00:00:00 2001 From: Eric Abrahamsen Date: Sat, 6 Jun 2020 12:13:15 -0700 Subject: [PATCH] Derive gnus-edit-form-mode from lisp-data-mode * lisp/gnus/gnus-eform.el (gnus-edit-form-mode): Handy for users who have turned on things like paredit for lisp-data-mode. --- lisp/gnus/gnus-eform.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/gnus/gnus-eform.el b/lisp/gnus/gnus-eform.el index 54118aad1e..ee573fb736 100644 --- a/lisp/gnus/gnus-eform.el +++ b/lisp/gnus/gnus-eform.el @@ -67,9 +67,9 @@ gnus-edit-form-make-menu-bar ["Exit" gnus-edit-form-exit t])) (gnus-run-hooks 'gnus-edit-form-menu-hook))) -(define-derived-mode gnus-edit-form-mode fundamental-mode "Edit Form" +(define-derived-mode gnus-edit-form-mode lisp-data-mode "Edit Form" "Major mode for editing forms. -It is a slightly enhanced emacs-lisp-mode. +It is a slightly enhanced `lisp-data-mode'. \\{gnus-edit-form-mode-map}" (when (gnus-visual-p 'group-menu 'menu) -- 2.27.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 06 16:06:21 2020 Received: (at 41742) by debbugs.gnu.org; 6 Jun 2020 20:06:21 +0000 Received: from localhost ([127.0.0.1]:52544 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhf5B-0003KF-9A for submit@debbugs.gnu.org; Sat, 06 Jun 2020 16:06:21 -0400 Received: from mail-wr1-f52.google.com ([209.85.221.52]:34406) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhf58-0003Jw-Ba for 41742@debbugs.gnu.org; Sat, 06 Jun 2020 16:06:20 -0400 Received: by mail-wr1-f52.google.com with SMTP id r7so13292300wro.1 for <41742@debbugs.gnu.org>; Sat, 06 Jun 2020 13:06:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=rEVlDepisWSPE8jk2TS7ICnSGybRkhKnEV1ndj83/Ao=; b=OmZhSr0CdxgKFM97FE9yrBQlwiXhDT+Z2GXxFRfcy1sBEkUBKj4n4rmB1wTbg11LEI aoPp+xmM/sJJ8Lab/8DbyTtpeTZ5eBseHaZCENlmW++wBCiAmtWzeXvF28w3gA01o/y2 VTJW1PrgWbZisMlDnHdp2c5v62th9DeCe8gwOMjXq33LVmNqPjyv6PMyWl0LkOrEU9Y+ EGMJZn7ReG+1NSV0Q9xV7C8eb8aUYV/StHP6sBYj7R9MFiXrTxyYtUE051+fbDIQpCa/ GciNN9EsTMTasfqIPpfjCkSsQxxm+inXPcRuy6GZMoJVQLCm5nPVa9DmyBX3cWb92HhV BEmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=rEVlDepisWSPE8jk2TS7ICnSGybRkhKnEV1ndj83/Ao=; b=HzGhISDg52vYXKH4o0GlhJn3FbmIc7jrUCBp8zDxt0ttLuHvJFpLOvJnVeWU24dFGM SzFoMotMEd7wndaEWymoNRXwnaAk0+Emp5EmdKisy0sxioIFl2ckR5bd+KKeFDRe3fs3 Iz4E2HWswS/SFW1U0/7XN8Ab6hc80Wf924BuV8T98GVvFlK3nsJvDjlO++afJPcBSmH9 4VHOP13bxZCcMVYY/pvp+n0kMC1/NynLbK0Qy7hOTrnBHQDZrJvEy1l1phb06c6qpVKC GgK4DSOONc4fHzwEIRGX7cpWnB9yqMv6lbp09EGBTyPgruj6Ul3j6uWLyILesY6MfxQW lkVw== X-Gm-Message-State: AOAM530WovyZhs7x4seuzX9pihfonAeL9rwpTAfJdtoVWW9KUa83QGDG nCUQHHMwpnoxo7nd9z8RR5ySSw== X-Google-Smtp-Source: ABdhPJzI9LCSmm906wNY1yU7BBnWY7B5wZNgvEejdRkTEG4kHF460980VCf31TsWFVkSYsRpqec+0g== X-Received: by 2002:adf:9163:: with SMTP id j90mr15407389wrj.65.1591473972560; Sat, 06 Jun 2020 13:06:12 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id w15sm16684467wmk.30.2020.06.06.13.06.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jun 2020 13:06:11 -0700 (PDT) From: "Basil L. Contovounesios" To: Eric Abrahamsen Subject: Re: bug#41742: 28.0.50; Derive gnus-edit-form-mode from lisp-data-mode References: <87wo4kroaf.fsf@ericabrahamsen.net> Date: Sat, 06 Jun 2020 21:06:10 +0100 In-Reply-To: <87wo4kroaf.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sat, 06 Jun 2020 12:23:52 -0700") Message-ID: <87r1usq7rh.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41742 Cc: 41742@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric Abrahamsen writes: > Hopefully this is fairly uncontroversial: Gnus has a gnus-edit-form-mode > for editing group parameters and other things, which presents the data > as elisp forms and is a perfect use-case for lisp-data-mode -- turning > on paredit or what have you. This patch derives the former from the > latter. LGTM, FWIW. While there, would you mind cleaning up how gnus-edit-form-mode-map is defined? It currently does a defvar+unless+setq dance, whereas it should ideally only be a defvar+let, as per the last few paragraphs of (info "(elisp) Tips for Defining"). Thanks, -- Basil From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 06 16:25:23 2020 Received: (at 41742) by debbugs.gnu.org; 6 Jun 2020 20:25:24 +0000 Received: from localhost ([127.0.0.1]:52563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhfNb-0003oM-NR for submit@debbugs.gnu.org; Sat, 06 Jun 2020 16:25:23 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:59430 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhfNZ-0003o8-Go for 41742@debbugs.gnu.org; Sat, 06 Jun 2020 16:25:22 -0400 Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 61FD3FA0E2; Sat, 6 Jun 2020 20:25:15 +0000 (UTC) From: Eric Abrahamsen To: "Basil L. Contovounesios" Subject: Re: bug#41742: 28.0.50; Derive gnus-edit-form-mode from lisp-data-mode References: <87wo4kroaf.fsf@ericabrahamsen.net> <87r1usq7rh.fsf@tcd.ie> Date: Sat, 06 Jun 2020 13:25:13 -0700 In-Reply-To: <87r1usq7rh.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sat, 06 Jun 2020 21:06:10 +0100") Message-ID: <87eeqsrlg6.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41742 Cc: 41742@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) "Basil L. Contovounesios" writes: > Eric Abrahamsen writes: > >> Hopefully this is fairly uncontroversial: Gnus has a gnus-edit-form-mode >> for editing group parameters and other things, which presents the data >> as elisp forms and is a perfect use-case for lisp-data-mode -- turning >> on paredit or what have you. This patch derives the former from the >> latter. > > LGTM, FWIW. > > While there, would you mind cleaning up how gnus-edit-form-mode-map is > defined? It currently does a defvar+unless+setq dance, whereas it > should ideally only be a defvar+let, as per the last few paragraphs of > (info "(elisp) Tips for Defining"). Huh, the last few paragraphs of that info page make it look like it's _okay_ to do defvar+unless+setq, am I misreading this? Granted it only says to do it so you can get the docstring closer to the defvar, and there's no docstring in this case, but it does seem acceptable. I wonder what the point of writing it this way is, otherwise? From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 06 18:31:55 2020 Received: (at 41742) by debbugs.gnu.org; 6 Jun 2020 22:31:55 +0000 Received: from localhost ([127.0.0.1]:52682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhhM3-0002fj-8l for submit@debbugs.gnu.org; Sat, 06 Jun 2020 18:31:55 -0400 Received: from mail-wm1-f43.google.com ([209.85.128.43]:34672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhhM1-0002fW-Si for 41742@debbugs.gnu.org; Sat, 06 Jun 2020 18:31:54 -0400 Received: by mail-wm1-f43.google.com with SMTP id u26so11593415wmn.1 for <41742@debbugs.gnu.org>; Sat, 06 Jun 2020 15:31:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=m4vWwJ9efazxi3OhjipPkRdJ3jk3Egg3TlFn8BliWTM=; b=ZivKPBS31B3M36hRy4hyzSl3xpfCyjIwe8yJBZiN2rfkQw81gv+l8lOacGGM4TXDIp H/xilVzzLwkDN0x+vi65Dm67FKKoywLQ+uOEtyn2388guhGRUc6XNteiU0Th0NPpW4Z9 F0cticn3lMC/1x3tQ8EszbvoNEKg8GgfW/d3s6tAR0JSGcz2RjZjgiWuTU0ApUJAWdNQ CchGdTCmnWqIkTRt1WLMAxIQjAEf0giBIDnJgOkVZkXXtWXzoYU7QXmCkDVlZ+9dFuMT sQx7ePQJicAgkjC/1HqT+T2AeAP3bCt2CL2rQ1YvfeK21hqFNv8Mw4FfvPot3COZY8yd ZDXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=m4vWwJ9efazxi3OhjipPkRdJ3jk3Egg3TlFn8BliWTM=; b=rkeExT4qWyDjQf2/V95Nim40aFENS9ou5Sfpwhrbdpoc1Zg3dztuZb9iQhDNbxInJe bxLxrb7tpmoi/uwxnUiwzpbFmfogOpymnh52rmjMur8IdsifJzhW44g1A+2XMJcvoj55 HacAqqw1fMNNS3P50WeK2PgYtZocd6JRDscNxEgfrTGqi9sf86+ZYbVe1WaR/yS3QvYI 1VVZQE8A/40ySDOkYRVcyQ8iMyddPXpvp978A5bVB84rCj0y5EN1RDdBgoKHKgJ5t0mj k5bkzqQ7/Mco3t+zxVvQC9vp34RI15hKVY6Bn4LlhokI9NROweyDP9EsknN7rdPBgBdp kzYQ== X-Gm-Message-State: AOAM531wXTayaCB2oXWJ1AeVUia1wWqycV++PF9XwotczF+yBhNo+Uyd M0cMQmDUR+p3DbyIp5yMBPVI+Q== X-Google-Smtp-Source: ABdhPJwCk4yqdFEl8S2EoYQpaeNV+SImo6qhi7DzSa5azlFDR7bYdiadJtpu6MeVYdMnJ2LlP+tTkA== X-Received: by 2002:a1c:2e58:: with SMTP id u85mr8968320wmu.123.1591482708036; Sat, 06 Jun 2020 15:31:48 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id k26sm17261017wmi.27.2020.06.06.15.31.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jun 2020 15:31:47 -0700 (PDT) From: "Basil L. Contovounesios" To: Eric Abrahamsen Subject: Re: bug#41742: 28.0.50; Derive gnus-edit-form-mode from lisp-data-mode References: <87wo4kroaf.fsf@ericabrahamsen.net> <87r1usq7rh.fsf@tcd.ie> <87eeqsrlg6.fsf@ericabrahamsen.net> Date: Sat, 06 Jun 2020 23:31:46 +0100 In-Reply-To: <87eeqsrlg6.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sat, 06 Jun 2020 13:25:13 -0700") Message-ID: <87a71frfl9.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41742 Cc: 41742@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric Abrahamsen writes: > "Basil L. Contovounesios" writes: > >> While there, would you mind cleaning up how gnus-edit-form-mode-map is >> defined? It currently does a defvar+unless+setq dance, whereas it >> should ideally only be a defvar+let, as per the last few paragraphs of >> (info "(elisp) Tips for Defining"). > > Huh, the last few paragraphs of that info page make it look like it's > _okay_ to do defvar+unless+setq, am I misreading this? Granted it only > says to do it so you can get the docstring closer to the defvar, and > there's no docstring in this case, but it does seem acceptable. I posit it's always better to defvar+let in one swell foop. > I wonder what the point of writing it this way is, otherwise? In most places I've seen defvar+unless, it's due to the author thinking in terms of "if the user hasn't already defined this map before loading this file, then..." But defvar provides these semantics for free and in a cleaner way. Unless I'm missing something, that is. -- Basil From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 06 19:35:00 2020 Received: (at 41742) by debbugs.gnu.org; 6 Jun 2020 23:35:00 +0000 Received: from localhost ([127.0.0.1]:52749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhiL5-0004CE-Uy for submit@debbugs.gnu.org; Sat, 06 Jun 2020 19:35:00 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:34704 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhiL4-0004C0-GF for 41742@debbugs.gnu.org; Sat, 06 Jun 2020 19:34:58 -0400 Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id BE62EFA0E2; Sat, 6 Jun 2020 23:34:51 +0000 (UTC) From: Eric Abrahamsen To: "Basil L. Contovounesios" Subject: Re: bug#41742: 28.0.50; Derive gnus-edit-form-mode from lisp-data-mode References: <87wo4kroaf.fsf@ericabrahamsen.net> <87r1usq7rh.fsf@tcd.ie> <87eeqsrlg6.fsf@ericabrahamsen.net> <87a71frfl9.fsf@tcd.ie> Date: Sat, 06 Jun 2020 16:34:50 -0700 In-Reply-To: <87a71frfl9.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sat, 06 Jun 2020 23:31:46 +0100") Message-ID: <87tuznrco5.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41742 Cc: 41742@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain On 06/06/20 23:31 PM, Basil L. Contovounesios wrote: > Eric Abrahamsen writes: > >> "Basil L. Contovounesios" writes: >> >>> While there, would you mind cleaning up how gnus-edit-form-mode-map is >>> defined? It currently does a defvar+unless+setq dance, whereas it >>> should ideally only be a defvar+let, as per the last few paragraphs of >>> (info "(elisp) Tips for Defining"). >> >> Huh, the last few paragraphs of that info page make it look like it's >> _okay_ to do defvar+unless+setq, am I misreading this? Granted it only >> says to do it so you can get the docstring closer to the defvar, and >> there's no docstring in this case, but it does seem acceptable. > > I posit it's always better to defvar+let in one swell foop. In principle, I agree. >> I wonder what the point of writing it this way is, otherwise? > > In most places I've seen defvar+unless, it's due to the author thinking > in terms of "if the user hasn't already defined this map before loading > this file, then..." > > But defvar provides these semantics for free and in a cleaner way. > > Unless I'm missing something, that is. I can't imagine anyone actually defining the whole map in their own config, rather than just adding keybindings as necessary. And as you (and the manual) point out, defvar already handles atomic definition/double loading avoidance, etc. Here's another version... --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Derive-gnus-edit-form-mode-from-lisp-data-mode-fix-m.patch >From 0ee576ed0819a15a37a01e2b3a3bc176e9827c04 Mon Sep 17 00:00:00 2001 From: Eric Abrahamsen Date: Sat, 6 Jun 2020 12:13:15 -0700 Subject: [PATCH] Derive gnus-edit-form-mode from lisp-data-mode, fix mode map * lisp/gnus/gnus-eform.el (gnus-edit-form-mode): Handy for users who have turned on things like paredit for lisp-data-mode. (gnus-edit-form-mode-map): Put creation of the map inside the defvar. --- lisp/gnus/gnus-eform.el | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/lisp/gnus/gnus-eform.el b/lisp/gnus/gnus-eform.el index 54118aad1e..1bc1261ee8 100644 --- a/lisp/gnus/gnus-eform.el +++ b/lisp/gnus/gnus-eform.el @@ -50,13 +50,13 @@ gnus-edit-form-menu-hook (defvar gnus-edit-form-buffer "*Gnus edit form*") (defvar gnus-edit-form-done-function nil) -(defvar gnus-edit-form-mode-map nil) -(unless gnus-edit-form-mode-map - (setq gnus-edit-form-mode-map (make-sparse-keymap)) - (set-keymap-parent gnus-edit-form-mode-map emacs-lisp-mode-map) - (gnus-define-keys gnus-edit-form-mode-map - "\C-c\C-c" gnus-edit-form-done - "\C-c\C-k" gnus-edit-form-exit)) +(defvar gnus-edit-form-mode-map + (let ((map (make-sparse-keymap))) + (set-keymap-parent map emacs-lisp-mode-map) + (gnus-define-keys map + "\C-c\C-c" gnus-edit-form-done + "\C-c\C-k" gnus-edit-form-exit) + map)) (defun gnus-edit-form-make-menu-bar () (unless (boundp 'gnus-edit-form-menu) @@ -67,9 +67,9 @@ gnus-edit-form-make-menu-bar ["Exit" gnus-edit-form-exit t])) (gnus-run-hooks 'gnus-edit-form-menu-hook))) -(define-derived-mode gnus-edit-form-mode fundamental-mode "Edit Form" +(define-derived-mode gnus-edit-form-mode lisp-data-mode "Edit Form" "Major mode for editing forms. -It is a slightly enhanced emacs-lisp-mode. +It is a slightly enhanced `lisp-data-mode'. \\{gnus-edit-form-mode-map}" (when (gnus-visual-p 'group-menu 'menu) -- 2.27.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 06 19:41:41 2020 Received: (at 41742) by debbugs.gnu.org; 6 Jun 2020 23:41:42 +0000 Received: from localhost ([127.0.0.1]:52753 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhiRZ-0004Lm-Of for submit@debbugs.gnu.org; Sat, 06 Jun 2020 19:41:41 -0400 Received: from mail-wm1-f41.google.com ([209.85.128.41]:38567) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhiRY-0004LZ-3C for 41742@debbugs.gnu.org; Sat, 06 Jun 2020 19:41:40 -0400 Received: by mail-wm1-f41.google.com with SMTP id f185so12851413wmf.3 for <41742@debbugs.gnu.org>; Sat, 06 Jun 2020 16:41:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=sn9pg0bAYthIveDFy8azo3Wk//9BScBc6cGZ0rARhbk=; b=Y30sLJgIRnIRUWnb+6iqUE/FqvWO3Im0cVd5TgMxd77HAc0Rfs2ewJ951EYgZL4msF B6oNUp+vjgWT6M04mbS75THNX4zEK+rWgcums3qEcTZo1kImHc2xx5WI0AGeVkXwHtPS YRc4fekRqLLStUa9yvpmMnJQ1RfSSWTqmnDV0DLHHVzJDacmSrxvOPnlIQ9g6cpOf62z tb2toLWdkT3egdtTrUVOYL6RqF2mtyrGKXwZUO8FjXoqCXaE2FGXtpCCNdr4gpbYAgHg hyQb+GKI6hj61zgmXoFJyXU3WyW3pahZ0Vpv26kTnPVl/Fw6T5YJ9qneN6pK/TGpnxjd X62w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=sn9pg0bAYthIveDFy8azo3Wk//9BScBc6cGZ0rARhbk=; b=cnF1/I+idy0Vw6NXnsyYajTAvPTL3q9UXetrFlLkf3Wm0VmRF/63PiUnZyI4Gc0Lrt H1bhm+zlfryVcvTM60jqCUmQuQMGpoGyHJMndZjAq2XeT7fadUy+zGR/9ck5skT6p+Ag jP6eSiQIXi7b5rq1arwfTUKmEKUtv0Ejr2uhbk4XzjMNsS3ZChBl7wCNZHdbgAFXKdiJ wnOClUOjcwYMVLWh+Py5FumCvLQ4YzGXnPv70jNjNemjoCtMD39ZiRXBkBsmcwaUOK5j jOrZ+76kTmu/MSMjIVeXout8tQz/86c3yubsByprE/V8llND+HgHZXAxio4+RXMgTvcr fEMQ== X-Gm-Message-State: AOAM533FNMnVe+IuV2Ii0P4TOwS9yQYkPCFlW83uIQEdyjqrgozHiq7O sMK5yaUNyWiLvch+Msi+U4OqTA== X-Google-Smtp-Source: ABdhPJwkcG6AUufiwkE/vNFCuHJdHsNvtBF9StpaI//Wyi9tyeod1sMEpPl1Zo080G3i00+Y4wPbeg== X-Received: by 2002:a1c:b386:: with SMTP id c128mr7873670wmf.133.1591486894151; Sat, 06 Jun 2020 16:41:34 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id b185sm22562105wmd.3.2020.06.06.16.41.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jun 2020 16:41:33 -0700 (PDT) From: "Basil L. Contovounesios" To: Eric Abrahamsen Subject: Re: bug#41742: 28.0.50; Derive gnus-edit-form-mode from lisp-data-mode References: <87wo4kroaf.fsf@ericabrahamsen.net> <87r1usq7rh.fsf@tcd.ie> <87eeqsrlg6.fsf@ericabrahamsen.net> <87a71frfl9.fsf@tcd.ie> <87tuznrco5.fsf@ericabrahamsen.net> Date: Sun, 07 Jun 2020 00:41:32 +0100 In-Reply-To: <87tuznrco5.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sat, 06 Jun 2020 16:34:50 -0700") Message-ID: <87d06bpxsj.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41742 Cc: 41742@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric Abrahamsen writes: > Here's another version... Thanks, LGTM except for one tiny nit. > From 0ee576ed0819a15a37a01e2b3a3bc176e9827c04 Mon Sep 17 00:00:00 2001 > From: Eric Abrahamsen > Date: Sat, 6 Jun 2020 12:13:15 -0700 > Subject: [PATCH] Derive gnus-edit-form-mode from lisp-data-mode, fix mode map > > * lisp/gnus/gnus-eform.el (gnus-edit-form-mode): Handy for users who > have turned on things like paredit for lisp-data-mode. I'd say "Derive from lisp-data-mode" here as well, since the sentence does not otherwise stand on its own without the preceding commit summary's context. -- Basil From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 06 19:46:14 2020 Received: (at 41742) by debbugs.gnu.org; 6 Jun 2020 23:46:14 +0000 Received: from localhost ([127.0.0.1]:52768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhiVy-0004TH-7g for submit@debbugs.gnu.org; Sat, 06 Jun 2020 19:46:14 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:34922 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhiVw-0004T5-78 for 41742@debbugs.gnu.org; Sat, 06 Jun 2020 19:46:12 -0400 Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 86578FA0E2; Sat, 6 Jun 2020 23:46:06 +0000 (UTC) From: Eric Abrahamsen To: "Basil L. Contovounesios" Subject: Re: bug#41742: 28.0.50; Derive gnus-edit-form-mode from lisp-data-mode References: <87wo4kroaf.fsf@ericabrahamsen.net> <87r1usq7rh.fsf@tcd.ie> <87eeqsrlg6.fsf@ericabrahamsen.net> <87a71frfl9.fsf@tcd.ie> <87tuznrco5.fsf@ericabrahamsen.net> <87d06bpxsj.fsf@tcd.ie> Date: Sat, 06 Jun 2020 16:46:05 -0700 In-Reply-To: <87d06bpxsj.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 07 Jun 2020 00:41:32 +0100") Message-ID: <87pnabrc5e.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41742 Cc: 41742@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 06/07/20 00:41 AM, Basil L. Contovounesios wrote: > Eric Abrahamsen writes: > >> Here's another version... > > Thanks, LGTM except for one tiny nit. > >> From 0ee576ed0819a15a37a01e2b3a3bc176e9827c04 Mon Sep 17 00:00:00 2001 >> From: Eric Abrahamsen >> Date: Sat, 6 Jun 2020 12:13:15 -0700 >> Subject: [PATCH] Derive gnus-edit-form-mode from lisp-data-mode, fix mode map >> >> * lisp/gnus/gnus-eform.el (gnus-edit-form-mode): Handy for users who >> have turned on things like paredit for lisp-data-mode. > > I'd say "Derive from lisp-data-mode" here as well, since the sentence > does not otherwise stand on its own without the preceding commit > summary's context. Sure! I've made the change locally. I'll wait a few days for possible objections (though I don't expect any) and then push. Thanks, Eric From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 12 12:31:05 2020 Received: (at 41742) by debbugs.gnu.org; 12 Jun 2020 16:31:05 +0000 Received: from localhost ([127.0.0.1]:40502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jjma9-0001aP-9K for submit@debbugs.gnu.org; Fri, 12 Jun 2020 12:31:05 -0400 Received: from ericabrahamsen.net ([52.70.2.18]:41032 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jjma6-0001Zn-C9; Fri, 12 Jun 2020 12:31:04 -0400 Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 3D1B8FA0E2; Fri, 12 Jun 2020 16:30:56 +0000 (UTC) From: Eric Abrahamsen To: "Basil L. Contovounesios" Subject: Re: bug#41742: 28.0.50; Derive gnus-edit-form-mode from lisp-data-mode References: <87wo4kroaf.fsf@ericabrahamsen.net> <87r1usq7rh.fsf@tcd.ie> <87eeqsrlg6.fsf@ericabrahamsen.net> <87a71frfl9.fsf@tcd.ie> <87tuznrco5.fsf@ericabrahamsen.net> <87d06bpxsj.fsf@tcd.ie> Date: Fri, 12 Jun 2020 09:30:54 -0700 Message-ID: <87lfksmekh.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41742 Cc: 41742@debbugs.gnu.org, 41742-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 06/07/20 00:41 AM, Basil L. Contovounesios wrote: > Eric Abrahamsen writes: > >> Here's another version... > > Thanks, LGTM except for one tiny nit. > >> From 0ee576ed0819a15a37a01e2b3a3bc176e9827c04 Mon Sep 17 00:00:00 2001 >> From: Eric Abrahamsen >> Date: Sat, 6 Jun 2020 12:13:15 -0700 >> Subject: [PATCH] Derive gnus-edit-form-mode from lisp-data-mode, fix mode map >> >> * lisp/gnus/gnus-eform.el (gnus-edit-form-mode): Handy for users who >> have turned on things like paredit for lisp-data-mode. > > I'd say "Derive from lisp-data-mode" here as well, since the sentence > does not otherwise stand on its own without the preceding commit > summary's context. Done, and pushed. Thanks! From unknown Tue Jun 17 01:50:33 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 11 Jul 2020 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator