From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 06 05:00:28 2020 Received: (at submit) by debbugs.gnu.org; 6 Jun 2020 09:00:28 +0000 Received: from localhost ([127.0.0.1]:50685 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhUgm-0007IR-BP for submit@debbugs.gnu.org; Sat, 06 Jun 2020 05:00:28 -0400 Received: from lists.gnu.org ([209.51.188.17]:33110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhUgk-0007IK-U5 for submit@debbugs.gnu.org; Sat, 06 Jun 2020 05:00:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46534) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhUgk-00017v-K9 for guix-patches@gnu.org; Sat, 06 Jun 2020 05:00:26 -0400 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:50630) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jhUgj-0007K3-FP; Sat, 06 Jun 2020 05:00:26 -0400 Received: by mail-wm1-x344.google.com with SMTP id v19so10512544wmj.0; Sat, 06 Jun 2020 02:00:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=R07Wp8G2eBZauvIE7MseLhWmwPrZafZeWszLfr/XgFE=; b=qx4PcLE/+37tTdHco+dIeQYqeljPwLPl3mHvKnykjEIFhPcaN9LowPdgff4fSTqROC SX7AMJI1oOJT3G/UosAjVL+CEnbIMOtEPCSpn6cvyOtK7Id80fbtZSZJsfrYpsG2tymG 6vQLRvLrqedbDxr6xpHfyMQYSF9DxiH24SoSpmwlGltd8ccZAEMIUxz9lWpNflDCBYX0 Qi83r7I62xF2CPle/Of1ArCIpqNR5O/Y2FLI68NnlKqlE0MyClYYM6PJJjLJssrq9Kmg PEFh9O24Gt60no3V1vzv9+LLvtaxxUcOYyES3q6+Y4yO7keihhccvownKjh/m0O8ji2g jd6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=R07Wp8G2eBZauvIE7MseLhWmwPrZafZeWszLfr/XgFE=; b=thJMisJpABAJtDehnyuaFDSkEXO82SG8+UoGC82XHiDzuumEmHyZn1Ba8GsrYKYcXJ ZNgcMks0V5fh/RgXnhcbPqZeAQW9uxrL/dRpF2qidKlSexlKKmtunp4Voab2TgIVrXK2 w6Lqcj5pSLdHoLxKXVbWKNlKvJLVg+1tSZbf7HorWRDRmzmWzl1XQoGyx9N84MLZFDoM l7K5tWFK34T/rDcSXOA5UYPLQJsmRu6If0Dzs35Jrh4WZp1yhsG9QFdMpnAhYHocZ0qd nz3EhdZO0uPdxoL/kTP38D2P2sgfZaq6qEEP9SXRykzY1v/ZHY8gTjGBilci+3Z/iDR8 6Opw== X-Gm-Message-State: AOAM531sAOayBT+Jr9VQvJYNMMJsDLLUy9/7WMi9c9iwjHqRpKHDEHRF Wt0jRkQm0yEZkeFLwhjHUyNiSCqlS80= X-Google-Smtp-Source: ABdhPJzo4Y0Rouet/4Myw4zDF34mj7hszKx9ZB/YzEa9LTUsEUB291iqmw0v1M+VI2jg50egKm2SxQ== X-Received: by 2002:a7b:c7d8:: with SMTP id z24mr6375433wmk.28.1591434022570; Sat, 06 Jun 2020 02:00:22 -0700 (PDT) Received: from meru.fronius.com ([2a01:e0a:fa:a50:809b:e323:9e90:279b]) by smtp.gmail.com with ESMTPSA id x205sm15569384wmx.21.2020.06.06.02.00.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jun 2020 02:00:21 -0700 (PDT) From: Mathieu Othacehe X-Google-Original-From: Mathieu Othacehe To: guix-patches@gnu.org Subject: [PATCH] gnu: sudo: Separate Python output. Date: Sat, 6 Jun 2020 11:00:14 +0200 Message-Id: <20200606090014.12578-1-othacehe@gnu.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::344; envelope-from=m.othacehe@gmail.com; helo=mail-wm1-x344.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit Cc: Mathieu Othacehe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) The Python plugin of "sudo" drag the Python interpreter to the closure of Guix System. Put it in a separate output. * gnu/packages/admin.scm (sudo)[arguments]: Add a 'separate-python-output phase. --- Hello, Here's a patch to remove Python from the Guix Sytem closure. As Python cross-compilation is broken, the "python" output cannot be populated when cross-compiling. This is not great. An alternative would be not to provide "python" output when cross-compiling but that requires to turn "output" into a thunk field, and I been advised not to do that (for performance reasons) in the past. WDYT? Thanks, Mathieu gnu/packages/admin.scm | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm index 77981e520a..9d9d70c88d 100644 --- a/gnu/packages/admin.scm +++ b/gnu/packages/admin.scm @@ -1375,6 +1375,7 @@ system administrator.") (delete-file-recursively "lib/zlib") #t)))) (build-system gnu-build-system) + (outputs (list "out" "python")) (arguments `(#:configure-flags (list (string-append "--docdir=" (assoc-ref %outputs "out") @@ -1432,7 +1433,23 @@ system administrator.") (substitute* "plugins/sudoers/Makefile.in" (("^pre-install:" match) (string-append match "\ndisabled-" match))) - #t))) + #t)) + (add-after 'install 'separate-python-output + (lambda* (#:key target outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out")) + (out:python (assoc-ref outputs "python"))) + ;; Python cross-compilation is not working. + (if target + (mkdir-p (string-append out:python "/empty")) + (for-each + (lambda (file) + (let ((old (string-append out "/" file)) + (new (string-append out:python "/" file))) + (mkdir-p (dirname new)) + (rename-file old new))) + (list "libexec/sudo/python_plugin.so" + "libexec/sudo/python_plugin.la"))) + #t)))) ;; XXX: The 'testsudoers' test series expects user 'root' to exist, but ;; the chroot's /etc/passwd doesn't have it. Turn off the tests. -- 2.26.2 From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 06 05:20:40 2020 Received: (at 41734) by debbugs.gnu.org; 6 Jun 2020 09:20:40 +0000 Received: from localhost ([127.0.0.1]:50732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhV0K-0007p4-7L for submit@debbugs.gnu.org; Sat, 06 Jun 2020 05:20:40 -0400 Received: from tobias.gr ([80.241.217.52]:40590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhV0H-0007os-AR for 41734@debbugs.gnu.org; Sat, 06 Jun 2020 05:20:38 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id 2949ebfa; Sat, 6 Jun 2020 09:20:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc :subject:references:in-reply-to:message-id:date:mime-version :content-type; s=2018; i=me@tobias.gr; bh=+BFfTLhvmi9b+yKtm1nwBx 8BOD8xHf3a7CSHX9tsbTg=; b=GKWCUhRsCc4lGjallP5FzKT5bhLe2bx0Z0Yt0G rjxn87yoLVqyaZpe5gqNnnSYO7HQvL0PWElEBkRF4j7uh+GUvre7JcEcT9tGmmrp /O1/gU5zM/xEhQq1wE0eRbOg7UiDUCwDuzTTmb7XE8SFeNgCMtqCiRcdMYuE/2de WufW06TYlvtAgXP8a1sQ3C41eBisg7ZZaKtEg7eCWRTY0sOAIiv+D66OQyIjquG7 IabstZLfplVVerriyZ0kSdJLqg8vkqJh1H6tia/uwW4gIjJo6mnv4q0LU3EBd8Hw pKH28euOOMKsTmIE1jTx3DWVZQur6nw8Uye0N9LUxZSKGvDw== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 193f30b8 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Sat, 6 Jun 2020 09:20:41 +0000 (UTC) From: Tobias Geerinckx-Rice To: Mathieu Othacehe Subject: Re: [bug#41734] [PATCH] gnu: sudo: Separate Python output. References: <20200606090014.12578-1-othacehe@gnu.org> In-reply-to: <20200606090014.12578-1-othacehe@gnu.org> Message-ID: <87sgf8a6u5.fsf@nckx> Date: Sat, 06 Jun 2020 11:20:34 +0200 MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41734 Cc: 41734@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Mathieu, Mathieu Othacehe =E5=86=99=E9=81=93=EF=BC=9A > * gnu/packages/admin.scm (sudo)[arguments]: Add a=20 > 'separate-python-output > phase. Missing [outputs] entry. > WDYT? I like it! In fact I suggest dropping the cross-compilation=20 comment. IMO this doesn't need to be reverted or reconsidered=20 even when that's fixed. Thanks, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXttf4gAKCRANsP+IT1Vt eXioAQCxOjhFrsdChFbvL+G9Ve4HHHOQgQNC2RyOA+YQ8YYt9gEAm3ks9OKJn9IP Eg16+7FRSXZHRweLY+q7iCqM/CNN/Qk= =pk2g -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 08 04:56:31 2020 Received: (at 41734-done) by debbugs.gnu.org; 8 Jun 2020 08:56:31 +0000 Received: from localhost ([127.0.0.1]:55901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiDa3-0001iW-Gs for submit@debbugs.gnu.org; Mon, 08 Jun 2020 04:56:31 -0400 Received: from mail-wm1-f46.google.com ([209.85.128.46]:40085) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiDa1-0001iJ-UW for 41734-done@debbugs.gnu.org; Mon, 08 Jun 2020 04:56:30 -0400 Received: by mail-wm1-f46.google.com with SMTP id r15so15670544wmh.5 for <41734-done@debbugs.gnu.org>; Mon, 08 Jun 2020 01:56:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=eYYl9+f304saaA2D31wEVlFBbEDaRtcyCUdKZpIknhU=; b=WEcbVS36qY8KDH2a8kxqnHoGe5pqkrbcBmeVVPgNq/sF5qkBxfwVvvW9WqiYvbQYfE ClgwUmRAAbjOpyxTc0zcaYABL7pDFTi5ZArrPtxmL1Dow+Dh9Sw3SjzZGaNVK7SX7obr IanG3ysXtm0ZDsHoBt+vvXFG8odgGCpNryjx48HnCA3Csseryd6P8Z4LbX/5Knrq+TXI 5IeM3i+V3vuhBMLXri0PzYNQASFKPDctYXvvqQDHPW9SkB8DK3YfxtqDMWt+mw61g5PK tDzqdCnDvksNi71f457D0BIFdY8Dc4Qr+5iRavORq9+5jqOLbsMVOuafIa53JSHxdPGy tqMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=eYYl9+f304saaA2D31wEVlFBbEDaRtcyCUdKZpIknhU=; b=p6WCCjgWZhNhGaMC7Rw2lWU7JXst7srNZIHPXbBJzR9V2vIXf/e3pUwmVZ5d2V+jzu JkNpesIGUUG7wRpPacIx0HDHL8bAP589bZ1JqqXrBI34w/SAQ9ML3MRo6PwT8nmf7ViK wiBEMnPoMZJnn8X3YygeBXZETZPe7/WNiCgradSusBUxS0M75uL7iqGdhH1TojXPCITe UP783n6NlwBnnl8RvVXd8Eut5gm8v0pl5vdgwuGLp1xM7nJdVsZ17Q0hKBeI5f+kencg tGIxOoZXKdFlcDM+DCvtHQwUegi3AKj6pasi8tPShseQCAhBwgDi3Y+qs/LAN0akpnZV U9jQ== X-Gm-Message-State: AOAM532jVCMuqPTV+cZqzIetVpZyeMASAldF/IihZaNak/rhymfy4rHp mgE2psLoubrNmiSJ9eu45wTE9RdclnE= X-Google-Smtp-Source: ABdhPJz7wBcJCy6JPV5/4Zw0Pa0X1OdmuVdD4qd1IOxQ0+V1kTCk0e/IPh5s6g+S9AObL8W752pE+g== X-Received: by 2002:a1c:6155:: with SMTP id v82mr15669570wmb.25.1591606583621; Mon, 08 Jun 2020 01:56:23 -0700 (PDT) Received: from meru (lfbn-ann-1-136-86.w86-200.abo.wanadoo.fr. [86.200.104.86]) by smtp.gmail.com with ESMTPSA id l1sm24120624wrb.31.2020.06.08.01.56.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 01:56:22 -0700 (PDT) From: Mathieu Othacehe To: Tobias Geerinckx-Rice Subject: Re: [bug#41734] [PATCH] gnu: sudo: Separate Python output. References: <20200606090014.12578-1-othacehe@gnu.org> <87sgf8a6u5.fsf@nckx> Date: Mon, 08 Jun 2020 10:56:21 +0200 In-Reply-To: <87sgf8a6u5.fsf@nckx> (Tobias Geerinckx-Rice's message of "Sat, 06 Jun 2020 11:20:34 +0200") Message-ID: <87v9k2aqbu.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41734-done Cc: 41734-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hey Tobias, > I like it! In fact I suggest dropping the cross-compilation comment. IMO > this doesn't need to be reverted or reconsidered even when that's fixed. Fixed and pushed, thanks for having a look! Mathieu From unknown Sat Jun 21 05:13:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 06 Jul 2020 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator