GNU bug report logs - #41731
[PATCH] gnu: Add emacs-flymake-shellcheck.

Previous Next

Full log

View this message in rfc822 format

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Fredrik Salomonsson <plattfot <at> gmail.com>
Cc: 41731 <at> debbugs.gnu.org
Subject: [bug#41731] [PATCH] gnu: Add emacs-flymake-shellcheck.
Date: Sat, 06 Jun 2020 09:44:56 +0200

Hello,

Fredrik Salomonsson <plattfot <at> gmail.com> writes:

> * gnu/packages/emacs-xyz.scm (emacs-flymake-shellcheck): New variable.

Thank you. Some comments follow.

> +      (propagated-inputs
> +       `(("shellcheck" ,shellcheck)))

I don't think we should do that. It is up to the user to install
ShellCheck if they want.

For example, installing `emacs-flycheck-haskell' doesn't pull GHC in
user's profile.

> +      (home-page "https://github.com/federicotdn/flymake-shellcheck")
> +      (synopsis "Flymake backend for Bash/Sh powered by ShellCheck")
> +      (description
> +       "This package provides a backend for Flymake (emacs-26+) to use the

Nitpick: you can remove the (emacs-26+) part.

> +tool @command{shellcheck} for static analyzing @command{bash} and @command{sh}

Nitpick: since you seem to talk about the tool as a whole, I suggest:

  @command{shellcheck} -> ShellCheck

> +scripts.  Please see the description on @command{shellcheck} for more
> +information on what it can do."

I think you can remove the last sentence.

Could you send an updated patch?

Regards,

-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.