From unknown Wed Jun 18 00:24:56 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#41731 <41731@debbugs.gnu.org> To: bug#41731 <41731@debbugs.gnu.org> Subject: Status: [PATCH] gnu: Add emacs-flymake-shellcheck. Reply-To: bug#41731 <41731@debbugs.gnu.org> Date: Wed, 18 Jun 2025 07:24:56 +0000 retitle 41731 [PATCH] gnu: Add emacs-flymake-shellcheck. reassign 41731 guix-patches submitter 41731 Fredrik Salomonsson severity 41731 normal tag 41731 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 05 19:34:05 2020 Received: (at submit) by debbugs.gnu.org; 5 Jun 2020 23:34:05 +0000 Received: from localhost ([127.0.0.1]:50345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhLqe-0001vq-QQ for submit@debbugs.gnu.org; Fri, 05 Jun 2020 19:34:05 -0400 Received: from lists.gnu.org ([209.51.188.17]:39398) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhLqZ-0001vP-Ro for submit@debbugs.gnu.org; Fri, 05 Jun 2020 19:34:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38344) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhLqX-0008UF-Tt for guix-patches@gnu.org; Fri, 05 Jun 2020 19:33:59 -0400 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]:38802) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jhLqU-0007h2-UE for guix-patches@gnu.org; Fri, 05 Jun 2020 19:33:57 -0400 Received: by mail-pl1-x631.google.com with SMTP id m7so4300450plt.5 for ; Fri, 05 Jun 2020 16:33:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LFu5YHeORRWg0Rptgb6JXNrNCRZXLRKIRQwe+NYg1oI=; b=NiDH3iWlLfvE+uRxLo0SV12AgfZM9uoGSmLxZA3HoiDk2F32c5oHU7KQcUxUBS3JZp cIjD1I66/3itAGPeMYlW+2CLuEqJQE9/IpbREka2asOV/ILl8qrmFCT23+Rj8U7L3tKV jLcSEeXuevKHr4/qeFWHS6dI2s0vIQkGn6sfH2NcLNkMFSctqPM0Ot6S5sMxIVT73pX1 ECDYOPxoRrOFlJx2UKwQN4j8JFW3TJxfzVhR2qHIuu53oALtfc1zTfCjYVPYNz3DspT9 Q5HVrAZ+n8Zt5lGrIt9M9HwMMGJjHKZhezqn7xaZOZED9e5UFHaM81krqAHqKBbL8LON zwow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LFu5YHeORRWg0Rptgb6JXNrNCRZXLRKIRQwe+NYg1oI=; b=M8SSl+ciSh7NAFz3CQjWPyrVqapyc1O46MojQd8pUOdtfWrGnwcYfpfG3Kp7HTtp/X JHKahvx/bNhLNbm+EMzcU9Ma8wQ7uWvEimmcoh1Bl0JUwgp2qKq/oSXdgnfowMzaUqdY ajwbq8adZ68qwHYBX68dwIYVDJXPMganVa6BFQkS7geyls1XVX/ae8/ru1thXG1Ed4rb wnXRUwPdzOMENekSlT3Eu3NnKhRnc0IduOgNSJ8U0wdKa/fMjsB9wTkVwSUU7TJ0IvZK OHP8rCNDJcNNlUWKGsQvhtLesqQ2lodPp7qeTKqQEVFNtAa2xay7J647soJGLc8iyUq1 b2tw== X-Gm-Message-State: AOAM532JxiJH1vmqiX9f+ZsT3BTWsx0fXHvc2CGHr2LnxJKvgNjeZei8 TOtIgAu9HjY6tH4SkLR0UF/c3UwY X-Google-Smtp-Source: ABdhPJx33YAF9aqUdPTOUY1C/eX+9zJCpeL34MN//JrF6gYVdQuVdAHZKY14LSRMMGpV8rMUsd1sVw== X-Received: by 2002:a17:90a:a617:: with SMTP id c23mr5662302pjq.86.1591400032392; Fri, 05 Jun 2020 16:33:52 -0700 (PDT) Received: from localhost (node-1w7jr9qqzayzqnit5wh171cm2.ipv6.telus.net. [2001:569:7a05:3a00::111a]) by smtp.gmail.com with ESMTPSA id j2sm602292pfb.73.2020.06.05.16.33.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jun 2020 16:33:51 -0700 (PDT) From: Fredrik Salomonsson To: guix-patches@gnu.org Subject: [PATCH] gnu: Add emacs-flymake-shellcheck. Date: Fri, 5 Jun 2020 16:33:49 -0700 Message-Id: <20200605233349.140049-1-plattfot@gmail.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::631; envelope-from=plattfot@gmail.com; helo=mail-pl1-x631.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: submit Cc: Fredrik Salomonsson X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/emacs-xyz.scm (emacs-flymake-shellcheck): New variable. --- gnu/packages/emacs-xyz.scm | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 6110374281..73d030f239 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -992,6 +992,34 @@ different tools. It highlights errors and warnings inline in the buffer, and provides an optional IDE-like error list.") (license license:gpl3+)))) ;+GFDLv1.3+ for the manual +(define-public emacs-flymake-shellcheck + ;; No tag, version grabbed from source .el file. + (let ((commit "78956f0e5bb9c4d35989657a55929e8e3f5691e6") + (revision "0")) + (package + (name "emacs-flymake-shellcheck") + (version (git-version "0.1" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/federicotdn/flymake-shellcheck.git") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 "068mx5p4drwgppy4ry1rfq6qi79w6d82b4rnpl2jm37grsg94lix")))) + (build-system emacs-build-system) + (propagated-inputs + `(("shellcheck" ,shellcheck))) + (home-page "https://github.com/federicotdn/flymake-shellcheck") + (synopsis "Flymake backend for Bash/Sh powered by ShellCheck") + (description + "This package provides a backend for Flymake (emacs-26+) to use the +tool @command{shellcheck} for static analyzing @command{bash} and @command{sh} +scripts. Please see the description on @command{shellcheck} for more +information on what it can do.") + (license license:gpl3+)))) + (define-public emacs-a (package (name "emacs-a") -- 2.26.2 From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 06 03:45:07 2020 Received: (at 41731) by debbugs.gnu.org; 6 Jun 2020 07:45:07 +0000 Received: from localhost ([127.0.0.1]:50593 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhTVr-0005Ll-0E for submit@debbugs.gnu.org; Sat, 06 Jun 2020 03:45:07 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:51727) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhTVo-0005Kr-Qn for 41731@debbugs.gnu.org; Sat, 06 Jun 2020 03:45:05 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id D615CC0008; Sat, 6 Jun 2020 07:44:57 +0000 (UTC) From: Nicolas Goaziou To: Fredrik Salomonsson Subject: Re: [bug#41731] [PATCH] gnu: Add emacs-flymake-shellcheck. References: <20200605233349.140049-1-plattfot@gmail.com> Date: Sat, 06 Jun 2020 09:44:56 +0200 In-Reply-To: <20200605233349.140049-1-plattfot@gmail.com> (Fredrik Salomonsson's message of "Fri, 5 Jun 2020 16:33:49 -0700") Message-ID: <871rmsab9j.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41731 Cc: 41731@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Fredrik Salomonsson writes: > * gnu/packages/emacs-xyz.scm (emacs-flymake-shellcheck): New variable. Thank you. Some comments follow. > + (propagated-inputs > + `(("shellcheck" ,shellcheck))) I don't think we should do that. It is up to the user to install ShellCheck if they want. For example, installing `emacs-flycheck-haskell' doesn't pull GHC in user's profile. > + (home-page "https://github.com/federicotdn/flymake-shellcheck") > + (synopsis "Flymake backend for Bash/Sh powered by ShellCheck") > + (description > + "This package provides a backend for Flymake (emacs-26+) to use the Nitpick: you can remove the (emacs-26+) part. > +tool @command{shellcheck} for static analyzing @command{bash} and @command{sh} Nitpick: since you seem to talk about the tool as a whole, I suggest: @command{shellcheck} -> ShellCheck > +scripts. Please see the description on @command{shellcheck} for more > +information on what it can do." I think you can remove the last sentence. Could you send an updated patch? Regards, -- Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 06 12:55:36 2020 Received: (at 41731) by debbugs.gnu.org; 6 Jun 2020 16:55:36 +0000 Received: from localhost ([127.0.0.1]:52354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhc6a-00050x-JY for submit@debbugs.gnu.org; Sat, 06 Jun 2020 12:55:36 -0400 Received: from mail-pf1-f169.google.com ([209.85.210.169]:42830) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhc6Z-00050m-TQ for 41731@debbugs.gnu.org; Sat, 06 Jun 2020 12:55:36 -0400 Received: by mail-pf1-f169.google.com with SMTP id b5so6479358pfp.9 for <41731@debbugs.gnu.org>; Sat, 06 Jun 2020 09:55:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LFu5YHeORRWg0Rptgb6JXNrNCRZXLRKIRQwe+NYg1oI=; b=ZM4p/PIyjX2JK9HZw71P0pX2m9AUDEVZ7UXsttILwvWh71d0Vy+GD0fs8pb0tMxlqW rCDzvPSEeI4ddIDqXLgolQUdrHMnIBRWJOrL6VXo9xaBsnTjY4oBOTp9gQIb3vmk6m1x 96VZeW1Pva19Qmm//XqK2eOdGr+Sm9KphikoQcqSx+YhjJtMBq8iT7EpRTJWOMi+mxd6 VQP4RVHnnxT0C1zj/diI8bwqQGPrGeqB8TpcFtMFjjzjM5VLBKEcFJZ6+hQn8IQKChmk lmZXurTQkYsSKsFVFq2vf5u7e3jDnUlKpQBc0sbw6oKaUXv4NkPE5uZ33upwzYjVhTu6 s4OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LFu5YHeORRWg0Rptgb6JXNrNCRZXLRKIRQwe+NYg1oI=; b=FDmdOBiCxUhvOSgFkdrENYQmm25k9Kn2tZFV8XF3GfH7Ab5L2b+1gCf8Ny/G+TWwel 3LwUXbBXlIZKGZfqe6iMpybQDcw8/wwN0OO4evEaznlzFtycBiT+NgWACWd8Yb7DP7LY 4VmhrCYtp0Iv/uf3yoJgUunHTRO6NHNj+5KgH7+3OMW5Fcxndf33RkzuKgp2kBx3FF6M YmhvUWPVggP+g6nF+vB3qGPMB1GjVGvhb3WOzE8VzmcGixasr4KJgcPqkfOeGu9WiUe6 XhFQILln1n+iZ8OmYBsK+cbCxMjISH25RdybBQNBxB7WptwG9wTBSNLvWTlWd8FimB1z TGLg== X-Gm-Message-State: AOAM532aXMH9uG80EGyt+Qlzeg+4SUoy1Oz6I051FoMZzkwrJTQnX9Go 1Too/cfFgCdJ/+WT90UAXg2h05KI X-Google-Smtp-Source: ABdhPJxI/BNmVL5Kp9Oo2sY36/uVaTwrnXmxONNdM1m9OGQqK8DdVtjmhJuGMy3RMjpYUbYCp22T4A== X-Received: by 2002:a63:f91b:: with SMTP id h27mr13972308pgi.276.1591462529688; Sat, 06 Jun 2020 09:55:29 -0700 (PDT) Received: from localhost (node-1w7jr9qqzayzqnit5wh171cm2.ipv6.telus.net. [2001:569:7a05:3a00::111a]) by smtp.gmail.com with ESMTPSA id m20sm2861012pfk.52.2020.06.06.09.55.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jun 2020 09:55:28 -0700 (PDT) From: Fredrik Salomonsson To: 41731@debbugs.gnu.org Subject: [PATCH] gnu: Add emacs-flymake-shellcheck. Date: Sat, 6 Jun 2020 09:55:12 -0700 Message-Id: <20200606165512.2471-1-plattfot@gmail.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41731 Cc: Fredrik Salomonsson X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/emacs-xyz.scm (emacs-flymake-shellcheck): New variable. --- gnu/packages/emacs-xyz.scm | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 6110374281..73d030f239 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -992,6 +992,34 @@ different tools. It highlights errors and warnings inline in the buffer, and provides an optional IDE-like error list.") (license license:gpl3+)))) ;+GFDLv1.3+ for the manual +(define-public emacs-flymake-shellcheck + ;; No tag, version grabbed from source .el file. + (let ((commit "78956f0e5bb9c4d35989657a55929e8e3f5691e6") + (revision "0")) + (package + (name "emacs-flymake-shellcheck") + (version (git-version "0.1" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/federicotdn/flymake-shellcheck.git") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 "068mx5p4drwgppy4ry1rfq6qi79w6d82b4rnpl2jm37grsg94lix")))) + (build-system emacs-build-system) + (propagated-inputs + `(("shellcheck" ,shellcheck))) + (home-page "https://github.com/federicotdn/flymake-shellcheck") + (synopsis "Flymake backend for Bash/Sh powered by ShellCheck") + (description + "This package provides a backend for Flymake (emacs-26+) to use the +tool @command{shellcheck} for static analyzing @command{bash} and @command{sh} +scripts. Please see the description on @command{shellcheck} for more +information on what it can do.") + (license license:gpl3+)))) + (define-public emacs-a (package (name "emacs-a") -- 2.26.2 From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 06 12:58:51 2020 Received: (at 41731) by debbugs.gnu.org; 6 Jun 2020 16:58:51 +0000 Received: from localhost ([127.0.0.1]:52357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhc9j-00055L-2z for submit@debbugs.gnu.org; Sat, 06 Jun 2020 12:58:51 -0400 Received: from sender4-of-o56.zoho.com ([136.143.188.56]:21608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhc9g-00055B-VD for 41731@debbugs.gnu.org; Sat, 06 Jun 2020 12:58:49 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1591462725; cv=none; d=zohomail.com; s=zohoarc; b=jRS2V3bKA3lUmWBfj8DFfDWr31XXp+SPFJUQZPZW/Py9K+QM9thIsDmV/BNvIjCa58iB5XWt5AdHx0N7KwsXAYIMdBYizWo16udrUhjea+r1tmYxjuelppfTPuKCbnGj4oHr4JYg76SvuPW3qb5F0AOT3wBZvEA9wcPkg0D13Yo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591462725; h=Content-Type:Date:From:MIME-Version:Message-ID:Subject:To; bh=DiQfYDho5voSVfO69E2tOgvtnsWEjhteB0GGpoAxbLE=; b=cCSlHTEP+xToqQ12P3u5er2xvg7Kwx5/2YG6MxoiDPL33uOhCr07iPA/aCOh/tDOjltv0gJJO/rJOI2aOj4LoKZcoAHX5fFla800wwlBKH29HmqQfVPQqtkf9Iq88xyIjadZoc/atOgghFUqK6d0DlOU9gMa2SHjInuVC2Kf9g4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=issues.guix.gnu.org@elephly.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1591462725; s=zoho; d=elephly.net; i=issues.guix.gnu.org@elephly.net; h=MIME-Version:Content-Type:From:To:Date:Message-ID:Subject; bh=DiQfYDho5voSVfO69E2tOgvtnsWEjhteB0GGpoAxbLE=; b=OxCqbT4muUNIrz4Iql27xvflZxlYWg693Z7OharN+efozA41ZwWiMq5zn1xKz4Mu pomqq5t8++J0Fy2Sachy9VFQuDT14lkmV2v5tYW3JrWVzr/4RA1dPWgkni1p0e7PCSV 9HUJGhoI/KggU2WxCLKYZmKmnVCEGpkYHTfMumZI= Received: from localhost (wholesomeserver.media.mit.edu [18.27.197.252]) by mx.zohomail.com with SMTPS id 1591462722597431.17378962088605; Sat, 6 Jun 2020 09:58:42 -0700 (PDT) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 From: Fredrik Salomonsson via web To: 41731@debbugs.gnu.org Date: Sat, 6 Jun 2020 18:58:36 +0200 Message-ID: <7fb6383380f0.6fc48000b697ae9@guile.gnu.org> Subject: [PATCH] gnu: Add emacs-flymake-shellcheck. X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41731 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thanks for the feedback. I was debating to myself whether to include shellcheck or not. As when I looked around in emacs-xyz.scm, for example `emacs-ag' does propagate the-silver-searcher but `emacs-direnv' does not. Anyway, I removed it in the latest patch. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 06 13:01:48 2020 Received: (at 41731) by debbugs.gnu.org; 6 Jun 2020 17:01:48 +0000 Received: from localhost ([127.0.0.1]:52360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhcCa-0005B7-Hh for submit@debbugs.gnu.org; Sat, 06 Jun 2020 13:01:48 -0400 Received: from mail-pj1-f52.google.com ([209.85.216.52]:52431) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhcCY-0005Av-9o for 41731@debbugs.gnu.org; Sat, 06 Jun 2020 13:01:47 -0400 Received: by mail-pj1-f52.google.com with SMTP id k2so3957684pjs.2 for <41731@debbugs.gnu.org>; Sat, 06 Jun 2020 10:01:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=f/e7Hoq7FxkeZw0BOPHaGZmXe0pO6aUZxd3OJ5AsV5Y=; b=VVSgGaBFVaCUFN4Ro6vzZn1o0sVp0VsYPdkwimlCztOoZcTvtcARJ2FxZCbKdqloer aWNBQq8jVR6Rc14VXOlrM4dCFhBMWvN7cVmkFX/r/7Nuk6iUphx42ZZP96yjvelPZNoa elqNb9jz1SejPbzzr9UgLKHF7v/rO6Ks75hrZCNCFmNkK5pMRsv9oNeWZ2GnvjWyANG/ RNaVYosvzFkmptVZh7KieMtYES4dIJRg4+GkFbCWpahRre4tOb2lVwEcC6/lPED2pCyj +vzdiA6hqk63PjzmzAWF/eUZf4dhiYUIBjgPAMrR9CIKhtliHKV4jnK8DF2uzWvis1lA vkcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=f/e7Hoq7FxkeZw0BOPHaGZmXe0pO6aUZxd3OJ5AsV5Y=; b=aQgLHB2HGbY3GTdDNpkcD/kWcfjTQO9cZAGpgen+/S94E/ksf6lWm7UAxI0H3xeD8M LZoVZY+CDrNdlYqJGPKC6UWokADgFjic/1Ee9QgpDUj+X5DHZfE/Pv7Roq60EhVs0QmY U2Q7HRSX+4/zW09+J+VhF9nbH+/b+BZsCxLX3Ob7UYu5JMWzloFuXevGZ0t6eV4Uqs+9 jMZGtDFo1kqcN33J/RXn1X6RFYU3sC/uGzZWGoaXiFPciuMVy8OkrypNZWnDYH5hKgnV QRxKP9s3eJCYkzFntT2kzOQsSspWifEB4FFQff1F8VruYs0j2/hfKXj5n2JKGH9Fh6xH Qc5A== X-Gm-Message-State: AOAM532IufW2MEaDEjXCX671ic42mfUHGX+FlkmlfzQMHl9qAlKI2qpx /teSZdSvViIu809WFIYd7fz0jVEA X-Google-Smtp-Source: ABdhPJxWlOxGMRMwtgJ+w7Wd/X9dV+jkjU3CLwvwSWAKyBvdQzLt9aOd3Hy0pqgZUnHeysSP1AxeXA== X-Received: by 2002:a17:90a:8c12:: with SMTP id a18mr7565221pjo.198.1591462900100; Sat, 06 Jun 2020 10:01:40 -0700 (PDT) Received: from localhost (node-1w7jr9qqzayzqnit5wh171cm2.ipv6.telus.net. [2001:569:7a05:3a00::111a]) by smtp.gmail.com with ESMTPSA id y136sm2820231pfg.55.2020.06.06.10.01.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jun 2020 10:01:39 -0700 (PDT) From: Fredrik Salomonsson To: 41731@debbugs.gnu.org Subject: [PATCH] gnu: Add emacs-flymake-shellcheck. Date: Sat, 6 Jun 2020 10:01:37 -0700 Message-Id: <20200606170137.3343-1-plattfot@gmail.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41731 Cc: Fredrik Salomonsson X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/emacs-xyz.scm (emacs-flymake-shellcheck): New variable. --- gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 6110374281..d957497a06 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -992,6 +992,31 @@ different tools. It highlights errors and warnings inline in the buffer, and provides an optional IDE-like error list.") (license license:gpl3+)))) ;+GFDLv1.3+ for the manual +(define-public emacs-flymake-shellcheck + ;; No tag, version grabbed from source .el file. + (let ((commit "78956f0e5bb9c4d35989657a55929e8e3f5691e6") + (revision "0")) + (package + (name "emacs-flymake-shellcheck") + (version (git-version "0.1" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/federicotdn/flymake-shellcheck.git") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 "068mx5p4drwgppy4ry1rfq6qi79w6d82b4rnpl2jm37grsg94lix")))) + (build-system emacs-build-system) + (home-page "https://github.com/federicotdn/flymake-shellcheck") + (synopsis "Flymake backend for Bash/Sh powered by ShellCheck") + (description + "This package provides a backend for Flymake to use the +tool ShellCheck for static analyzing @command{bash} and @command{sh} +scripts.") + (license license:gpl3+)))) + (define-public emacs-a (package (name "emacs-a") -- 2.26.2 From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 06 13:04:21 2020 Received: (at 41731) by debbugs.gnu.org; 6 Jun 2020 17:04:21 +0000 Received: from localhost ([127.0.0.1]:52363 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhcF2-0005Ey-Uo for submit@debbugs.gnu.org; Sat, 06 Jun 2020 13:04:21 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:39889) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhcF1-0005Ek-9T for 41731@debbugs.gnu.org; Sat, 06 Jun 2020 13:04:19 -0400 Received: by mail-wm1-f65.google.com with SMTP id k26so12110135wmi.4 for <41731@debbugs.gnu.org>; Sat, 06 Jun 2020 10:04:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=bXSTXg/0x1KhWGh8aWed0A9jqR8632Shgwn7nM4iCBs=; b=BAGH0m66rssuHf+lBBSK7+twI3tgay4LFYNMk70S/sL96RKJ2YpRMwGgaYdlAiP7CJ 9UNqhGOA3/+StubRFSZLN2aJ4abhjkjf2YUZ90XA+ql6dn7RCZj1V9OPCasTd01Q7Tt8 YZFAWukIeSWXZCXYHuCmARQ0v4m31oiGUUN0AvFL2u4c6mQ3ksU2IZkiKhfm1g1y50SR STC/Sv6Y1ceaFmm+IbtD+ITkqc723gBCdtKHAnfUoVvY0yb51FqkG+6tIuWCQSv/LeJA SqjcZcdAyYbdhiJcKYsdVGtQ1HnGAA5wYP0S/AgKma11I2eYDsuNJ+MsREIL6uQ1zZU+ Tjeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=bXSTXg/0x1KhWGh8aWed0A9jqR8632Shgwn7nM4iCBs=; b=btuyv0nj0oChORCDlfbjXlsUbNnMP180RTsIAY3g5zmRptbH24jwg+qU2WX2zyN2AF lrckErBAWaGw2qESp7XuwXWWj8WWMQZp3FKixtI6lXacmroaYl9/m8+ucbDvsomFqezO BgvbBans4SQPJHpt2+sIDiN5jq3A/GGgPqezrwXWgWnrn2FZffKWGMCZOcKlm1mZxO1i dxQYVJLx1bj9Tx5enzdsaBlZHCPOeVNTQr14gHGs6J/KUJOaxbZP/xkCyZihwVVMYKkG KP9KHgqBcg+7CyyVbk29NWOc6/yU9uta07c/a5JLaVLC8hDlBU56iCJWMPdgkKq0MFcv dFOg== X-Gm-Message-State: AOAM531elvadY0DFIkIajt4XqCKr2+WPrGWojN+EX4qvFrN9ruCSRUY+ 6ityhwum1RIwYYusiZHn6X+HT1CXU5BJ0I/gzCpafw== X-Google-Smtp-Source: ABdhPJxz+uCdDp6DlVTwO7cXcE6D69y2MTLycTPud7TRkYwvjYRM4jvKJ4jvSobsT2qQmjmUWre7mSed9tgnPzbQw88= X-Received: by 2002:a1c:7e43:: with SMTP id z64mr7877349wmc.72.1591463053159; Sat, 06 Jun 2020 10:04:13 -0700 (PDT) MIME-Version: 1.0 References: <20200606170137.3343-1-plattfot@gmail.com> In-Reply-To: <20200606170137.3343-1-plattfot@gmail.com> From: Fredrik Salomonsson Date: Sat, 6 Jun 2020 10:04:02 -0700 Message-ID: Subject: Re: [PATCH] gnu: Add emacs-flymake-shellcheck. To: 41731@debbugs.gnu.org Content-Type: multipart/alternative; boundary="000000000000f4eff405a76d5d9a" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41731 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000f4eff405a76d5d9a Content-Type: text/plain; charset="UTF-8" Sorry, sent the old patch again. The last one should be the correct one. -- s/Fred[re]+i[ck]+/Fredrik/g --000000000000f4eff405a76d5d9a Content-Type: text/html; charset="UTF-8"
Sorry, sent the old patch again. The last one should be the correct one.

--
s/Fred[re]+i[ck]+/Fredrik/g
--000000000000f4eff405a76d5d9a-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 07 15:23:05 2020 Received: (at 41731-done) by debbugs.gnu.org; 7 Jun 2020 19:23:05 +0000 Received: from localhost ([127.0.0.1]:54914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ji0sq-0000SB-PN for submit@debbugs.gnu.org; Sun, 07 Jun 2020 15:23:04 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:41487) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ji0so-0000RT-5Q for 41731-done@debbugs.gnu.org; Sun, 07 Jun 2020 15:23:03 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 0640C20003; Sun, 7 Jun 2020 19:22:54 +0000 (UTC) From: Nicolas Goaziou To: Fredrik Salomonsson via web Subject: Re: [bug#41731] [PATCH] gnu: Add emacs-flymake-shellcheck. References: <20200605233349.140049-1-plattfot@gmail.com> <7fb6383380f0.6fc48000b697ae9@guile.gnu.org> Date: Sun, 07 Jun 2020 21:22:53 +0200 In-Reply-To: <7fb6383380f0.6fc48000b697ae9@guile.gnu.org> (Fredrik Salomonsson via web's message of "Sat, 6 Jun 2020 18:58:36 +0200") Message-ID: <875zc27kaa.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41731-done Cc: 41731-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Fredrik Salomonsson via web writes: > I was debating to myself whether to include shellcheck or not. As when > I looked around in emacs-xyz.scm, for example `emacs-ag' does > propagate the-silver-searcher but `emacs-direnv' does not. emacs-ag package contains a comment explaining why the propagated inputs is required. Sometimes, it is unavoidable, but usage of propagated-inputs should be as limited as possible. > Anyway, I removed it in the latest patch. Thank you. I applied your patch. Regards, -- Nicolas Goaziou From unknown Wed Jun 18 00:24:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 06 Jul 2020 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator