GNU bug report logs - #41704
[PATCH] services: nix: Set NIX_CONF_DIR environment variable.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Peng Mei Yu <pengmeiyu <at> riseup.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#41704: closed ([PATCH] services: nix: Set NIX_CONF_DIR
 environment variable.)
Date: Tue, 16 Jun 2020 10:59:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 16 Jun 2020 18:58:11 +0800
with message-id <87ftavl1ly.fsf <at> pengmeiyu.com>
and subject line Re: [bug#41704] [PATCH V2] services: nix: Set NIX_CONF_DIR environment variable.
has caused the debbugs.gnu.org bug report #41704,
regarding [PATCH] services: nix: Set NIX_CONF_DIR environment variable.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
41704: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41704
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Peng Mei Yu <pengmeiyu <at> riseup.net>
To: guix-patches <at> gnu.org
Cc: Peng Mei Yu <pengmeiyu <at> riseup.net>
Subject: [PATCH] services: nix: Set NIX_CONF_DIR environment variable.
Date: Thu,  4 Jun 2020 15:01:03 +0800

* gnu/services/nix.scm (nix-shepherd-service): Set NIX_CONF_DIR environment
variable to "/etc/nix".
---
 gnu/services/nix.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/services/nix.scm b/gnu/services/nix.scm
index dfe33991d0..2cdddd8866 100644
--- a/gnu/services/nix.scm
+++ b/gnu/services/nix.scm
@@ -96,7 +96,9 @@ GID."
     (documentation "Run nix-daemon.")
     (requirement '())
     (start #~(make-forkexec-constructor
-              (list (string-append #$nix "/bin/nix-daemon"))))
+              (list (string-append #$nix "/bin/nix-daemon"))
+              #:environment-variables
+              '("NIX_CONF_DIR=/etc/nix")))
     (respawn? #f)
     (stop #~(make-kill-destructor)))))
 
-- 
2.26.2

[Message part 3 (message/rfc822, inline)]

From: Peng Mei Yu <pengmeiyu <at> riseup.net>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 41704-done <at> debbugs.gnu.org
Subject: Re: [bug#41704] [PATCH V2] services: nix: Set NIX_CONF_DIR
 environment variable.
Date: Tue, 16 Jun 2020 18:58:11 +0800

Hi,

Tobias Geerinckx-Rice writes:

> I agree with Ludo' that fixing this at the package level is more ‘appropriate’
> than in the service.

I agree too.

>> There is no obvious way to fix the error, so setting NIX_CONF_DIR is
>> easier.  Perhaps someone can fix the nix package with a clean patch.
>> That would be better.
>
> Obvious is different things to different people, but here's my go-to approach.
> Override the relevant variables during the install phase without changing any
> run-time settings:
>
> #+begin_example
> diff --git a/gnu/packages/package-management.scm
> b/gnu/packages/package-management.scm
> index c1e6657dff..fefa17a162 100644
> --- a/gnu/packages/package-management.scm
> +++ b/gnu/packages/package-management.scm
> @@ -551,6 +551,19 @@ out) and returning a package that uses that as its
> 'source'."
>               (base32
>                "1hbqsrp1ii2sfq8x2mahjrl2182qck76n8blrl1jfz3xq99m6i15"))))
>     (build-system gnu-build-system)
> +    (arguments
> +     `(#:configure-flags
> +       (list "--sysconfdir=/etc")
> +       #:phases
> +       (modify-phases %standard-phases
> +         (replace 'install
> +           (lambda* (#:key (make-flags '()) outputs #:allow-other-keys)
> +             (let* ((out (assoc-ref outputs "out"))
> +                    (etc (string-append out "/etc")))
> +               (apply invoke "make" "install"
> +                      (string-append "sysconfdir=" etc)
> +                      (string-append "profiledir=" etc "/profile.d")
> +                      make-flags)))))))
>     (native-inputs `(("pkg-config" ,pkg-config)))
>     (inputs `(("boost" ,boost)
>               ("brotli" ,brotli)
> #+end_example
>
> It installs correctly.  I didn't test the service.

This is the clean patch I was asking for.  The service works well on my
computer.  Thank you.  Please push this patch.


--
Peng Mei Yu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.