GNU bug report logs - #41695
[PATCH] Update Go to v1.14.4

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#41695: closed ([PATCH] Update Go to v1.14.4)
Date: Fri, 26 Jun 2020 10:56:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 26 Jun 2020 11:55:21 +0100
with message-id <87bll66qqu.fsf <at> cbaines.net>
and subject line Re: [bug#41695] [PATCH] Update Go to v1.14.4
has caused the debbugs.gnu.org bug report #41695,
regarding [PATCH] Update Go to v1.14.4
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
41695: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41695
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] Update Go to v1.14.4
Date: Wed, 3 Jun 2020 18:36:31 -0500

[Message part 3 (text/plain, inline)]

There are too many dependent Go packages to test, but I compiled
syncthing which should be a reasonably representative test.

[0001-gnu-go-Update-to-1.14.4.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: Katherine Cox-Buday <cox.katherine.e <at> gmail.com>,
 Jack Hill <jackhill <at> jackhill.us>
Cc: 41695-done <at> debbugs.gnu.org
Subject: Re: [bug#41695] [PATCH] Update Go to v1.14.4
Date: Fri, 26 Jun 2020 11:55:21 +0100

[Message part 6 (text/plain, inline)]

Jack Hill <jackhill <at> jackhill.us> writes:

> On Sat, 6 Jun 2020, Katherine Cox-Buday wrote:
>
>> Jack Hill <jackhill <at> jackhill.us> writes:
>>
>> You're welcome! Thanks for the review. I wish I had more time to
>> contribute to Guix.
>>
>> I suppose I should have qualified my statement by saying there's too
>> many dependent Go packages for me to test. I should invest in a better
>> computer :)
>
> More computing is nice, but in the meantime, I'm happy to be part of a
> community of other Guix people who can provide extra cycles when
> needed.
>
> I'd like to recognize the work Chris and Danjela are doing on Guix
> Data Service to ease patch review as well.
>
>>> Reading through the Go release notes [1], the following change to the
>>> net/url package caught my eye:
>>>
>>>> When parsing of a URL fails (for example by Parse or
>>>> ParseRequestURI), the resulting Error message will now quote the
>>>> unparsable URL. This provides clearer structure and consistency with
>>>> other parsing errors.
>>>
>>> I think this could be the cause of the docker test failure. Should we
>>> patch docker or perhaps try to update it?
>>
>> Spot on! I've updated docker and docker-cli. hyperledger-fabric depends
>> on docker-cli and also continues to build. I've attached a patch which
>> should supersede the prior patch. It updates go, docker, and docker-cli
>> atomically.
>
> I'm happy to confirm that the revised path fixes the docker problem
> here as well.
>
> […]
>
>>> I am curious, why switch to using git-fetch?
>>
>> `guix lint` now complains about downloading tarballs. I have also
>> recently seen some chatter on the mailing list about preferring this.
>
> Right, I remember that thread, thanks!
>
> Hopefully a more experienced reviewer/committer will confirm that
> everything looks good and push soon.

Thanks for the patch Katherine, and thanks to doing some review
Jack. I've had a look now, and pushed (with a small commit message
changes): 6e9f8826087fbd824c546f6daad70f090fa1a8d7

Thanks again,

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.