From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 03 13:08:41 2020 Received: (at submit) by debbugs.gnu.org; 3 Jun 2020 17:08:41 +0000 Received: from localhost ([127.0.0.1]:44503 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgWsb-0005Be-31 for submit@debbugs.gnu.org; Wed, 03 Jun 2020 13:08:41 -0400 Received: from lists.gnu.org ([209.51.188.17]:50640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgWQX-0004We-6D for submit@debbugs.gnu.org; Wed, 03 Jun 2020 12:39:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48790) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgWQW-00016Y-Vh for bug-gnu-emacs@gnu.org; Wed, 03 Jun 2020 12:39:40 -0400 Received: from mail-qk1-x732.google.com ([2607:f8b0:4864:20::732]:40367) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jgWQW-0001Si-7x for bug-gnu-emacs@gnu.org; Wed, 03 Jun 2020 12:39:40 -0400 Received: by mail-qk1-x732.google.com with SMTP id c185so2795776qke.7 for ; Wed, 03 Jun 2020 09:39:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=CCWDVFj0VieoTuGSaB1qj3cFkYXTlEw/o3X8cGUq8mI=; b=sl52momonRotg49zCBxIIspkMEusA+QsXCbdROI2W2UhfxRVVz46TMGlR5bOvKRXFB DKo4PqaPMpBFnMWCX1WJMjHIhGzal649QR/y+LJSnocU6NpW/tazgtKUX86E/9z2SvYd l5xUtamwzgzwwRpdfZ0dfByL/1pRraPkgMkXTAqkJqMn3kkRUXNWOPvjp0m3Vb36qnas OTlRtTdENJTzMGwyNulIYRKhOZLfGif420O5gIu2+0rH3POAZGzyREI2uqYaLCEQ39C4 F74WbOem0PSQo/qy/G6V6VDQJUGCK3UJsOfS/xlQK0reP5rLT9jV5JnBejybmX1GzCrD 3J+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=CCWDVFj0VieoTuGSaB1qj3cFkYXTlEw/o3X8cGUq8mI=; b=C58H/nsvomYl8ClZe5AnUM3plF2PfYu2QVn1iFde0TTdbGZNRjCHArmrxcgQiGLCsQ aXsbraLSNZbloKOW4bED1pliTD3M7OZIAjDjre07AifoNsImXi432e5YWRFEr2kqB+E9 rqChcPpxAjIkvRP+SFZema0gKJJvSfJ2WfOulszW5kEhyM9K9imMZot5XFHkZOBSviKs RSvOow44OxEKq7kfgLHqyS8psvIsrQeonolLy0r39nDAiCPSOP5sjqtoKRg+L9MvtfYv /PN2JKyabwPdte6AsmNzEhSbR7Q1Os8pydkWsrMVPkrErP7jMygxCg8UKEoMIsVU2+cE ofSA== X-Gm-Message-State: AOAM533cwdgKQetx41Bs5sNCV4oje5jL8N3aDMM3oavFlcL29n5JYfCe prwwqxtm3HrwVRZUX8pwe/7ZDBcb X-Google-Smtp-Source: ABdhPJzmhvBi7r7CwRUJ9jQGI1IsYggc7JeBi6h9V604oVUcx5YhGZqRA6jZw7W4fBrtcc+Qux5aEw== X-Received: by 2002:a37:2cc7:: with SMTP id s190mr476271qkh.413.1591202378588; Wed, 03 Jun 2020 09:39:38 -0700 (PDT) Received: from PuercoDesktop.54.183.15.10 ([200.121.213.12]) by smtp.gmail.com with ESMTPSA id m53sm2500915qtb.64.2020.06.03.09.39.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2020 09:39:38 -0700 (PDT) From: Javier Olaechea To: bug-gnu-emacs@gnu.org Subject: [PATCH] Add bookmark-jump-other-tab Date: Wed, 3 Jun 2020 11:39:25 -0500 Message-Id: <20200603163925.11161-1-pirata@gmail.com> X-Mailer: git-send-email 2.17.1 Received-SPF: pass client-ip=2607:f8b0:4864:20::732; envelope-from=pirata@gmail.com; helo=mail-qk1-x732.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 03 Jun 2020 13:08:40 -0400 Cc: Javier Olaechea X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * lisp/bookmark.el (bookmark-jump-other-tab): Add function to open a bookmark on another tab --- lisp/bookmark.el | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/lisp/bookmark.el b/lisp/bookmark.el index 5bb1698171..99bb70ae0e 100644 --- a/lisp/bookmark.el +++ b/lisp/bookmark.el @@ -1142,6 +1142,14 @@ bookmark-jump-other-frame (let ((pop-up-frames t)) (bookmark-jump-other-window bookmark))) +;;;###autoload +(defun bookmark-jump-other-tab (bookmark) + "Jump to BOOKMARK in another tab. See `bookmark-jump' for more." + (interactive + (list (bookmark-completing-read "Jump to bookmark (in another tab)" + bookmark-current-bookmark))) + (bookmark-jump bookmark 'switch-to-buffer-other-tab)) + (defun bookmark-jump-noselect (bookmark) "Return the location pointed to by BOOKMARK (see `bookmark-jump'). The return value has the form (BUFFER . POINT). -- 2.17.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 03 13:16:25 2020 Received: (at 41691) by debbugs.gnu.org; 3 Jun 2020 17:16:25 +0000 Received: from localhost ([127.0.0.1]:44514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgX05-0005NQ-MN for submit@debbugs.gnu.org; Wed, 03 Jun 2020 13:16:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39852) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgX04-0005NE-7J for 41691@debbugs.gnu.org; Wed, 03 Jun 2020 13:16:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45079) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgWzy-0008Gd-Qg; Wed, 03 Jun 2020 13:16:18 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1jgWzx-0000I0-7d; Wed, 03 Jun 2020 13:16:17 -0400 From: Glenn Morris To: Javier Olaechea Subject: Re: bug#41691: [PATCH] Add bookmark-jump-other-tab References: <20200603163925.11161-1-pirata@gmail.com> X-Spook: Emergency Landing Stuck threat Lon Horiuchi Warning X-Ran: eA=m#gZ;u7D8P5@3YTPV(_a?X5I{.8cm,hNvc:sp:8ms!qxnT.A!/1lVl4.Vp'l2$tfcYw X-Hue: white X-Debbugs-No-Ack: yes X-Attribution: GM Date: Wed, 03 Jun 2020 13:16:17 -0400 In-Reply-To: <20200603163925.11161-1-pirata@gmail.com> (Javier Olaechea's message of "Wed, 3 Jun 2020 11:39:25 -0500") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41691 Cc: 41691@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Personally I hope that every "-other-window" command doesn't get an "-other-tab" counterpart (to go along with "-other-frame"), but rather that a single systematic method is developed, like the elpa.gnu.org package other-frame-window. Ref eg https://lists.gnu.org/r/emacs-devel/2019-10/msg00261.html (AFAICS nothing has been implemented) From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 03 19:05:52 2020 Received: (at 41691) by debbugs.gnu.org; 3 Jun 2020 23:05:52 +0000 Received: from localhost ([127.0.0.1]:44719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgcSG-00059h-Ed for submit@debbugs.gnu.org; Wed, 03 Jun 2020 19:05:52 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:44513) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgcSF-000595-57 for 41691@debbugs.gnu.org; Wed, 03 Jun 2020 19:05:51 -0400 X-Originating-IP: 91.129.108.6 Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6]) (Authenticated sender: juri@linkov.net) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 1EC941BF20B; Wed, 3 Jun 2020 23:05:43 +0000 (UTC) From: Juri Linkov To: Glenn Morris Subject: Re: bug#41691: [PATCH] Add bookmark-jump-other-tab Organization: LINKOV.NET References: <20200603163925.11161-1-pirata@gmail.com> Date: Thu, 04 Jun 2020 02:00:32 +0300 In-Reply-To: (Glenn Morris's message of "Wed, 03 Jun 2020 13:16:17 -0400") Message-ID: <87bllzvjov.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41691 Cc: Javier Olaechea , 41691@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Personally I hope that every "-other-window" command doesn't get an > "-other-tab" counterpart (to go along with "-other-frame"), but rather > that a single systematic method is developed, like the elpa.gnu.org > package other-frame-window. Ref eg > > https://lists.gnu.org/r/emacs-devel/2019-10/msg00261.html > > (AFAICS nothing has been implemented) Actually, this is already implemented, but without an obvious keybinding. This small patch binds a general command to 'C-x t t' (or maybe a better key would be 'C-x t w'). Then after typing 'C-x t t' as a prefix key sequence, the next command will display its buffer in a new tab: diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el index 76e7f8c33a..529f5e5e4b 100644 --- a/lisp/tab-bar.el +++ b/lisp/tab-bar.el @@ -1585,6 +1585,7 @@ tab-prefix-map (define-key tab-prefix-map "b" 'switch-to-buffer-other-tab) (define-key tab-prefix-map "f" 'find-file-other-tab) (define-key tab-prefix-map "\C-f" 'find-file-other-tab) +(define-key tab-prefix-map "t" 'windmove-display-new-tab) (provide 'tab-bar) From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 04 19:47:11 2020 Received: (at 41691) by debbugs.gnu.org; 4 Jun 2020 23:47:11 +0000 Received: from localhost ([127.0.0.1]:47849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgzZm-0006a5-Qm for submit@debbugs.gnu.org; Thu, 04 Jun 2020 19:47:11 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:41001) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgzZl-0006Zq-Cs for 41691@debbugs.gnu.org; Thu, 04 Jun 2020 19:47:10 -0400 X-Originating-IP: 91.129.108.6 Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6]) (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id D92E2FF805; Thu, 4 Jun 2020 23:47:01 +0000 (UTC) From: Juri Linkov To: Glenn Morris Subject: Re: bug#41691: [PATCH] Add bookmark-jump-other-tab Organization: LINKOV.NET References: <20200603163925.11161-1-pirata@gmail.com> <87bllzvjov.fsf@mail.linkov.net> Date: Fri, 05 Jun 2020 02:34:23 +0300 In-Reply-To: <87bllzvjov.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 04 Jun 2020 02:00:32 +0300") Message-ID: <87y2p2gzvs.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41691 Cc: Javier Olaechea , 41691@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain >> Personally I hope that every "-other-window" command doesn't get an >> "-other-tab" counterpart (to go along with "-other-frame"), but rather >> that a single systematic method is developed, like the elpa.gnu.org >> package other-frame-window. Ref eg >> >> https://lists.gnu.org/r/emacs-devel/2019-10/msg00261.html >> >> (AFAICS nothing has been implemented) > > Actually, this is already implemented, but without an obvious keybinding. > This small patch binds a general command to 'C-x t t' (or maybe a better > key would be 'C-x t w'). > > Then after typing 'C-x t t' as a prefix key sequence, > the next command will display its buffer in a new tab: > > @@ -1585,6 +1585,7 @@ tab-prefix-map > (define-key tab-prefix-map "b" 'switch-to-buffer-other-tab) > (define-key tab-prefix-map "f" 'find-file-other-tab) > (define-key tab-prefix-map "\C-f" 'find-file-other-tab) > +(define-key tab-prefix-map "t" 'windmove-display-new-tab) I see that using windmove-display-new-tab in tab-bar.el is inappropriate, so here is refactoring: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=other-tab-prefix.patch diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el index 76e7f8c33a..dd9d520ed9 100644 --- a/lisp/tab-bar.el +++ b/lisp/tab-bar.el @@ -1575,6 +1575,21 @@ find-file-other-tab value) (switch-to-buffer-other-tab value)))) +(defun other-tab-prefix () + "Display the next buffer in a new tab. +The next buffer is the buffer displayed by the next command invoked +immediately after this command (ignoring reading from the minibuffer). +Creates a new tab before displaying the buffer. +When `switch-to-buffer-obey-display-actions' is non-nil, +`switch-to-buffer' commands are also supported." + (interactive) + (display-buffer-override-next-command + (lambda (buffer alist) + (cons (let ((tab-bar-new-tab-choice t)) + (tab-bar-new-tab) + (selected-window)) + 'tab)))) + (define-key tab-prefix-map "2" 'tab-new) (define-key tab-prefix-map "1" 'tab-close-other) (define-key tab-prefix-map "0" 'tab-close) @@ -1585,6 +1600,7 @@ tab-prefix-map (define-key tab-prefix-map "b" 'switch-to-buffer-other-tab) (define-key tab-prefix-map "f" 'find-file-other-tab) (define-key tab-prefix-map "\C-f" 'find-file-other-tab) +(define-key tab-prefix-map "t" 'other-tab-prefix) (provide 'tab-bar) diff --git a/lisp/window.el b/lisp/window.el index d658cb81f6..3f851c86f4 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -10069,6 +10069,46 @@ window--adjust-process-windows (set-process-window-size process (cdr size) (car size)))))))))) (add-hook 'window-configuration-change-hook 'window--adjust-process-windows) + + +(defun display-buffer-override-next-command (action-function &optional exit-function) + "Override `display-buffer-overriding-action' for the next command. +`action-function' is called to prepare the window where the buffer should +be displayed. This function takes two arguments `buffer' and `alist', and +should return a cons with the displayed window and type. See argument +meaning in `window--display-buffer'. `exit-function' is called after the +buffer is displayed in the window. The function takes one argument `window'." + (let* ((new-window) + (minibuffer-depth (minibuffer-depth)) + (action (lambda (buffer alist) + (unless (> (minibuffer-depth) minibuffer-depth) + (let* ((ret (funcall action-function buffer alist)) + (window (car ret)) + (type (cdr ret))) + (setq new-window (window--display-buffer buffer window + type alist)))))) + (command this-command) + (clearfun (make-symbol "clear-display-buffer-overriding-action")) + (exitfun + (lambda () + (setq display-buffer-overriding-action + (delq action display-buffer-overriding-action)) + (when (functionp exit-function) + (funcall exit-function new-window)) + (remove-hook 'post-command-hook clearfun)))) + (fset clearfun + (lambda () + (unless (or + ;; Remove the hook immediately + ;; after exiting the minibuffer. + (> (minibuffer-depth) minibuffer-depth) + ;; But don't remove immediately after + ;; adding the hook by the same command below. + (eq this-command command)) + (funcall exitfun)))) + (add-hook 'post-command-hook clearfun) + (push action display-buffer-overriding-action))) + ;; Some of these are in tutorial--default-keys, so update that if you ;; change these. diff --git a/lisp/windmove.el b/lisp/windmove.el index f96383197b..38e3fee83a 100644 --- a/lisp/windmove.el +++ b/lisp/windmove.el @@ -462,59 +462,38 @@ windmove-display-in-direction When `switch-to-buffer-obey-display-actions' is non-nil, `switch-to-buffer' commands are also supported." (let* ((no-select (xor (consp arg) windmove-display-no-select)) - (old-window (or (minibuffer-selected-window) (selected-window))) - (new-window) - (minibuffer-depth (minibuffer-depth)) - (action (lambda (buffer alist) - (unless (> (minibuffer-depth) minibuffer-depth) - (let* ((type 'reuse) - (window (cond - ((eq dir 'new-tab) - (let ((tab-bar-new-tab-choice t)) - (tab-bar-new-tab)) - (setq type 'tab) - (selected-window)) - ((eq dir 'new-frame) - (let* ((params (cdr (assq 'pop-up-frame-parameters alist))) - (pop-up-frame-alist (append params pop-up-frame-alist)) - (frame (make-frame-on-current-monitor - pop-up-frame-alist))) - (unless (cdr (assq 'inhibit-switch-frame alist)) - (window--maybe-raise-frame frame)) - (setq type 'frame) - (frame-selected-window frame))) - ((eq dir 'same-window) - (selected-window)) - (t (window-in-direction - dir nil nil - (and arg (prefix-numeric-value arg)) - windmove-wrap-around))))) - (unless window - (setq window (split-window nil nil dir) type 'window)) - (setq new-window (window--display-buffer buffer window - type alist)))))) - (command this-command) - (clearfun (make-symbol "clear-display-buffer-overriding-action")) - (exitfun - (lambda () - (setq display-buffer-overriding-action - (delq action display-buffer-overriding-action)) - (when (window-live-p (if no-select old-window new-window)) - (select-window (if no-select old-window new-window))) - (remove-hook 'post-command-hook clearfun)))) - (fset clearfun - (lambda () - (unless (or - ;; Remove the hook immediately - ;; after exiting the minibuffer. - (> (minibuffer-depth) minibuffer-depth) - ;; But don't remove immediately after - ;; adding the hook by the same command below. - (eq this-command command)) - (funcall exitfun)))) - (add-hook 'post-command-hook clearfun) - (push action display-buffer-overriding-action) - (message "[display-%s]" dir))) + (old-window (or (minibuffer-selected-window) (selected-window)))) + (display-buffer-override-next-command + (lambda (buffer alist) + (let* ((type 'reuse) + (window (cond + ((eq dir 'new-tab) + (let ((tab-bar-new-tab-choice t)) + (tab-bar-new-tab)) + (setq type 'tab) + (selected-window)) + ((eq dir 'new-frame) + (let* ((params (cdr (assq 'pop-up-frame-parameters alist))) + (pop-up-frame-alist (append params pop-up-frame-alist)) + (frame (make-frame-on-current-monitor + pop-up-frame-alist))) + (unless (cdr (assq 'inhibit-switch-frame alist)) + (window--maybe-raise-frame frame)) + (setq type 'frame) + (frame-selected-window frame))) + ((eq dir 'same-window) + (selected-window)) + (t (window-in-direction + dir nil nil + (and arg (prefix-numeric-value arg)) + windmove-wrap-around))))) + (unless window + (setq window (split-window nil nil dir) type 'window)) + (cons window type))) + (lambda (new-window) + (when (window-live-p (if no-select old-window new-window)) + (select-window (if no-select old-window new-window)))))) + (message "[display-%s]" dir)) ;;;###autoload (defun windmove-display-left (&optional arg) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 06 19:55:11 2020 Received: (at 41691) by debbugs.gnu.org; 6 Jun 2020 23:55:11 +0000 Received: from localhost ([127.0.0.1]:52772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhieR-0004ex-3B for submit@debbugs.gnu.org; Sat, 06 Jun 2020 19:55:11 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:36033) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhieP-0004eg-4o for 41691@debbugs.gnu.org; Sat, 06 Jun 2020 19:54:57 -0400 X-Originating-IP: 91.129.108.6 Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6]) (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 54658FF802; Sat, 6 Jun 2020 23:54:49 +0000 (UTC) From: Juri Linkov To: Javier Olaechea Subject: Re: bug#41691: [PATCH] Add bookmark-jump-other-tab Organization: LINKOV.NET References: <20200603163925.11161-1-pirata@gmail.com> <87bllzvjov.fsf@mail.linkov.net> <87y2p2gzvs.fsf@mail.linkov.net> Date: Sun, 07 Jun 2020 02:42:57 +0300 In-Reply-To: <87y2p2gzvs.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 05 Jun 2020 02:34:23 +0300") Message-ID: <87pnabbw1q.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41691 Cc: 41691@debbugs.gnu.org, Glenn Morris X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> Then after typing 'C-x t t' as a prefix key sequence, >> the next command will display its buffer in a new tab: Now pushed to master. Javier, do you agree this is a good way to open a bookmark on another tab with an easy-to-type key sequence: C-x t t C-x r b so this feature request can be closed? From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 06 22:44:10 2020 Received: (at 41691) by debbugs.gnu.org; 7 Jun 2020 02:44:11 +0000 Received: from localhost ([127.0.0.1]:52937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhlIA-0000Jr-G7 for submit@debbugs.gnu.org; Sat, 06 Jun 2020 22:44:10 -0400 Received: from mail-il1-f175.google.com ([209.85.166.175]:35958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhkIb-0007EH-O4 for 41691@debbugs.gnu.org; Sat, 06 Jun 2020 21:40:34 -0400 Received: by mail-il1-f175.google.com with SMTP id a13so13477972ilh.3 for <41691@debbugs.gnu.org>; Sat, 06 Jun 2020 18:40:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=L+oFIw95BBN50zcGVc6NOXTkoZ9Xtng7U6YvkX8TKTs=; b=Mpix0I7QiEvstZmPXtyKTaIY/BACcUZDSaF/AjwcIu/tDdBwNIxRv8bQE7VCewlEfl qBfYmMgUILz+s2ESgpCR/PMx0fKAE2uxIckIsfJmN34AMOUtDCDWgesAWgSXDnjeuHks vv0VN3tDSAXJHooCGkn1+mx8+0N1E+FAIBeBBv0Of+jYfF8mQaMVL/AfVHZyXu8dltGX OppzyKkz0ufGOk1wowIcND4sewNMv3MB4y4M2zb0LbICHGYOfcn107kJBv8neKgd3Mjp kIkQ4Nhygangula73naVrJ/qfuvVu2p6yjQ+/L0RtoKpdP1HWls52iqsMdQ8hZLwi+pm 41Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=L+oFIw95BBN50zcGVc6NOXTkoZ9Xtng7U6YvkX8TKTs=; b=eY+TrPyURqcJZ1lkXOoUH7ohvVT2OsmPmMg17mFKc6OB/LMEHidkXw9FVu/MXnDmsM fMXHReqEiT+2jMZD6hF0Oisbkzf2yE6n7U9QH3U2kYA8nS4mprXnILe5xL+oewPhcGeT uTAPtqMzjwkkXUAEJzZx3D7/AZ+B1dPWAQLQNUa6vqss4hptjKbfeU3ecga0VD/cgPrp T2oy33OklsZQ8boDaWgL7bIVyDeKZ/azKuBEg24uMKQnkNCLL1UFSER9gO1Xa0dYtqO0 PhDEwBdyb3SSvuMCfYPb3HDQ7NffIchD5uDu1hv9l5QVwr92puK1POJse+LCkxaWfsRU 6QuA== X-Gm-Message-State: AOAM530ovObyBM1knmDJ5lSdVQqJwBHxD1WYevV8LtZsu/cyQ0JoZ+pr DuMm5o8+iqzeGRNcgVRrBE/LwL6SyZ5i8OeX6eVPhsR7 X-Google-Smtp-Source: ABdhPJwk35ro2Y/n5oHjyp4YucQSL5WV7u3iugDmdZWQO8A3zG7GqYSwgVLI0aWe9MW4tkAIMxItTeFxfCrMsYqNdsE= X-Received: by 2002:a92:995a:: with SMTP id p87mr8248377ili.21.1591494028062; Sat, 06 Jun 2020 18:40:28 -0700 (PDT) MIME-Version: 1.0 References: <20200603163925.11161-1-pirata@gmail.com> <87bllzvjov.fsf@mail.linkov.net> <87y2p2gzvs.fsf@mail.linkov.net> <87pnabbw1q.fsf@mail.linkov.net> In-Reply-To: <87pnabbw1q.fsf@mail.linkov.net> From: Javier Olaechea Date: Sat, 6 Jun 2020 20:40:16 -0500 Message-ID: Subject: Re: bug#41691: [PATCH] Add bookmark-jump-other-tab To: Juri Linkov Content-Type: multipart/alternative; boundary="00000000000034737105a7749442" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41691 X-Mailman-Approved-At: Sat, 06 Jun 2020 22:44:09 -0400 Cc: 41691@debbugs.gnu.org, Glenn Morris X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000034737105a7749442 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > do you agree this is a good way to open a bookmark on another tab with an easy-to-type key sequence: Yeah. It is better to provide a general solution. On Sat, Jun 6, 2020 at 6:54 PM Juri Linkov wrote: > >> Then after typing 'C-x t t' as a prefix key sequence, > >> the next command will display its buffer in a new tab: > > Now pushed to master. > > Javier, do you agree this is a good way to open a bookmark > on another tab with an easy-to-type key sequence: > > C-x t t > C-x r b > > so this feature request can be closed? > --=20 "I object to doing things that computers can do." =E2=80=94 Olin Shivers --00000000000034737105a7749442 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> do you agree this is a good way to open a bookmarkon another tab with an easy-to-type key sequence:

Yeah.= It is better to provide a general solution.



--
"I object to doing things that computers ca= n do." =E2=80=94 Olin Shivers
--00000000000034737105a7749442-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 07 18:57:39 2020 Received: (at control) by debbugs.gnu.org; 7 Jun 2020 22:57:39 +0000 Received: from localhost ([127.0.0.1]:55182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ji4EV-0007sq-C1 for submit@debbugs.gnu.org; Sun, 07 Jun 2020 18:57:39 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:35619) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ji4ET-0007sb-3Q for control@debbugs.gnu.org; Sun, 07 Jun 2020 18:57:37 -0400 Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6]) (Authenticated sender: juri@linkov.net) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 54084200003 for ; Sun, 7 Jun 2020 22:57:29 +0000 (UTC) From: Juri Linkov To: control@debbugs.gnu.org Subject: Re: bug#41691: [PATCH] Add bookmark-jump-other-tab Organization: LINKOV.NET References: <20200603163925.11161-1-pirata@gmail.com> <87bllzvjov.fsf@mail.linkov.net> <87y2p2gzvs.fsf@mail.linkov.net> <87pnabbw1q.fsf@mail.linkov.net> Date: Mon, 08 Jun 2020 01:42:42 +0300 In-Reply-To: (Javier Olaechea's message of "Sat, 6 Jun 2020 20:40:16 -0500") Message-ID: <87y2oyzdxh.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) tags 41691 fixed close 41691 28.0.50 thanks >> do you agree this is a good way to open a bookmark > on another tab with an easy-to-type key sequence: > > Yeah. It is better to provide a general solution. Thanks, so closing this. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 10 17:56:31 2020 Received: (at 41691) by debbugs.gnu.org; 10 Jun 2020 21:56:31 +0000 Received: from localhost ([127.0.0.1]:35512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj8hz-0005AY-88 for submit@debbugs.gnu.org; Wed, 10 Jun 2020 17:56:31 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:43545) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj8hx-0005AF-1y for 41691@debbugs.gnu.org; Wed, 10 Jun 2020 17:56:29 -0400 Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6]) (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 2549B240002 for <41691@debbugs.gnu.org>; Wed, 10 Jun 2020 21:56:21 +0000 (UTC) From: Juri Linkov To: 41691@debbugs.gnu.org Subject: Re: bug#41691: [PATCH] Add bookmark-jump-other-tab References: <20200603163925.11161-1-pirata@gmail.com> <87bllzvjov.fsf@mail.linkov.net> <87y2p2gzvs.fsf@mail.linkov.net> Date: Thu, 11 Jun 2020 00:50:21 +0300 In-Reply-To: <87y2p2gzvs.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 05 Jun 2020 02:34:23 +0300") Message-ID: <87v9jyocea.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41691 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain >> Then after typing 'C-x t t' as a prefix key sequence, >> the next command will display its buffer in a new tab: Now here is a patch for doing the same for a new window with 'C-x 4 4', and a new frame with 'C-x 5 5': --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=other-window-frame.patch diff --git a/lisp/window.el b/lisp/window.el index b6f44341e8..c3d1a775b7 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -4005,6 +4005,22 @@ other-window ;; Always return nil. nil)))) +(defun other-window-prefix () + "Display the buffer of the next command in a new window. +The next buffer is the buffer displayed by the next command invoked +immediately after this command (ignoring reading from the minibuffer). +Creates a new window before displaying the buffer, or switches to the window +that already contains that buffer. +When `switch-to-buffer-obey-display-actions' is non-nil, +`switch-to-buffer' commands are also supported." + (interactive) + (display-buffer-override-next-command + (lambda (buffer alist) + (cons (display-buffer-pop-up-window + buffer (append alist '((inhibit-same-window . t)))) + 'window))) + (message "Display next command buffer in a new window...")) + ;; This should probably return non-nil when the selected window is part ;; of an atomic window whose root is the frame's root window. (defun one-window-p (&optional nomini all-frames) @@ -10131,5 +10147,6 @@ ctl-x-map (define-key ctl-x-map "-" 'shrink-window-if-larger-than-buffer) (define-key ctl-x-map "+" 'balance-windows) (define-key ctl-x-4-map "0" 'kill-buffer-and-window) +(define-key ctl-x-4-map "4" 'other-window-prefix) ;;; window.el ends here diff --git a/lisp/frame.el b/lisp/frame.el index 6c2f774709..25634fb445 100644 --- a/lisp/frame.el +++ b/lisp/frame.el @@ -1070,6 +1070,23 @@ other-frame (setq arg (1+ arg))) (select-frame-set-input-focus frame))) +(defun other-frame-prefix () + "Display the buffer of the next command in a new frame. +The next buffer is the buffer displayed by the next command invoked +immediately after this command (ignoring reading from the minibuffer). +Creates a new frame before displaying the buffer, or switches to the frame +that already contains that buffer. +When `switch-to-buffer-obey-display-actions' is non-nil, +`switch-to-buffer' commands are also supported." + (interactive) + (display-buffer-override-next-command + (lambda (buffer alist) + (cons (display-buffer-pop-up-frame + buffer (append alist '((reusable-frames . 0) + (inhibit-same-window . t)))) + 'frame))) + (message "Display next command buffer in a new frame...")) + (defun iconify-or-deiconify-frame () "Iconify the selected frame, or deiconify if it's currently an icon." (interactive) @@ -2697,6 +2714,7 @@ ctl-x-5-map (define-key ctl-x-5-map "1" 'delete-other-frames) (define-key ctl-x-5-map "0" 'delete-frame) (define-key ctl-x-5-map "o" 'other-frame) +(define-key ctl-x-5-map "5" 'other-frame-prefix) (define-key global-map [f11] 'toggle-frame-fullscreen) (define-key global-map [(meta f10)] 'toggle-frame-maximized) (define-key esc-map [f10] 'toggle-frame-maximized) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 21 19:19:26 2020 Received: (at 41691) by debbugs.gnu.org; 21 Jun 2020 23:19:26 +0000 Received: from localhost ([127.0.0.1]:32823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jn9FG-0006Qt-Gi for submit@debbugs.gnu.org; Sun, 21 Jun 2020 19:19:26 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:49353) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jn9FD-0006QE-J3 for 41691@debbugs.gnu.org; Sun, 21 Jun 2020 19:19:24 -0400 X-Originating-IP: 91.129.108.6 Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6]) (Authenticated sender: juri@linkov.net) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id C2169FF802 for <41691@debbugs.gnu.org>; Sun, 21 Jun 2020 23:19:16 +0000 (UTC) From: Juri Linkov To: 41691@debbugs.gnu.org Subject: Re: bug#41691: [PATCH] Add bookmark-jump-other-tab Organization: LINKOV.NET References: <20200603163925.11161-1-pirata@gmail.com> <87bllzvjov.fsf@mail.linkov.net> <87y2p2gzvs.fsf@mail.linkov.net> <87v9jyocea.fsf@mail.linkov.net> Date: Mon, 22 Jun 2020 02:18:27 +0300 In-Reply-To: <87v9jyocea.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 11 Jun 2020 00:50:21 +0300") Message-ID: <87r1u8ggag.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41691 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >>> Then after typing 'C-x t t' as a prefix key sequence, >>> the next command will display its buffer in a new tab: > > Now here is a patch for doing the same for a new window with > 'C-x 4 4', and a new frame with 'C-x 5 5': Pushed to master. There is also a new command 'same-window-prefix', but it's currently unbound. What would be a good keybinding? Maybe 'C-x 4 1'? From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 22 11:07:09 2020 Received: (at 41691) by debbugs.gnu.org; 22 Jun 2020 15:07:09 +0000 Received: from localhost ([127.0.0.1]:34305 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnO2O-0001hi-Nx for submit@debbugs.gnu.org; Mon, 22 Jun 2020 11:07:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnO2K-0001h7-Eo for 41691@debbugs.gnu.org; Mon, 22 Jun 2020 11:07:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43304) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jnO2E-0004mH-MW; Mon, 22 Jun 2020 11:06:58 -0400 Received: from [176.228.60.248] (port=3911 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jnO2D-0000Vt-Cy; Mon, 22 Jun 2020 11:06:58 -0400 Date: Mon, 22 Jun 2020 18:06:53 +0300 Message-Id: <83sgenta0i.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <87r1u8ggag.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 22 Jun 2020 02:18:27 +0300) Subject: Re: bug#41691: [PATCH] Add bookmark-jump-other-tab References: <20200603163925.11161-1-pirata@gmail.com> <87bllzvjov.fsf@mail.linkov.net> <87y2p2gzvs.fsf@mail.linkov.net> <87v9jyocea.fsf@mail.linkov.net> <87r1u8ggag.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41691 Cc: 41691@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Date: Mon, 22 Jun 2020 02:18:27 +0300 > > > Now here is a patch for doing the same for a new window with > > 'C-x 4 4', and a new frame with 'C-x 5 5': > > Pushed to master. There is also a new command 'same-window-prefix', > but it's currently unbound. What would be a good keybinding? > Maybe 'C-x 4 1'? Please be sure to call out these changes in NEWS, and possibly also in the ELisp manual. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 28 18:22:12 2020 Received: (at 41691) by debbugs.gnu.org; 28 Jun 2020 22:22:12 +0000 Received: from localhost ([127.0.0.1]:47152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpfgh-0004Eo-S9 for submit@debbugs.gnu.org; Sun, 28 Jun 2020 18:22:12 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:48251) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpfgZ-0004Dc-VY for 41691@debbugs.gnu.org; Sun, 28 Jun 2020 18:22:04 -0400 X-Originating-IP: 91.129.96.187 Received: from mail.gandi.net (m91-129-96-187.cust.tele2.ee [91.129.96.187]) (Authenticated sender: juri@linkov.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 98C861C0003; Sun, 28 Jun 2020 22:21:57 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#41691: [PATCH] Add bookmark-jump-other-tab Organization: LINKOV.NET References: <20200603163925.11161-1-pirata@gmail.com> <87bllzvjov.fsf@mail.linkov.net> <87y2p2gzvs.fsf@mail.linkov.net> <87v9jyocea.fsf@mail.linkov.net> <87r1u8ggag.fsf@mail.linkov.net> <83sgenta0i.fsf@gnu.org> Date: Mon, 29 Jun 2020 01:00:01 +0300 In-Reply-To: <83sgenta0i.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 22 Jun 2020 18:06:53 +0300") Message-ID: <87ftaehmvy.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41691 Cc: 41691@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> > Now here is a patch for doing the same for a new window with >> > 'C-x 4 4', and a new frame with 'C-x 5 5': >> >> Pushed to master. There is also a new command 'same-window-prefix', >> but it's currently unbound. What would be a good keybinding? >> Maybe 'C-x 4 1'? > > Please be sure to call out these changes in NEWS, and possibly also in > the ELisp manual. These changes were already in NEWS, but other details are still under discussion on emacs-devel. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 29 10:35:33 2020 Received: (at 41691) by debbugs.gnu.org; 29 Jun 2020 14:35:33 +0000 Received: from localhost ([127.0.0.1]:49056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpuse-0005zb-Td for submit@debbugs.gnu.org; Mon, 29 Jun 2020 10:35:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jpusc-0005zL-Eq for 41691@debbugs.gnu.org; Mon, 29 Jun 2020 10:35:31 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60428) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jpusW-0000F7-Oa; Mon, 29 Jun 2020 10:35:24 -0400 Received: from [176.228.60.248] (port=3710 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jpusW-00082A-72; Mon, 29 Jun 2020 10:35:24 -0400 Date: Mon, 29 Jun 2020 17:35:15 +0300 Message-Id: <83o8p20wkc.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <87ftaehmvy.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 29 Jun 2020 01:00:01 +0300) Subject: Re: bug#41691: [PATCH] Add bookmark-jump-other-tab References: <20200603163925.11161-1-pirata@gmail.com> <87bllzvjov.fsf@mail.linkov.net> <87y2p2gzvs.fsf@mail.linkov.net> <87v9jyocea.fsf@mail.linkov.net> <87r1u8ggag.fsf@mail.linkov.net> <83sgenta0i.fsf@gnu.org> <87ftaehmvy.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41691 Cc: 41691@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: 41691@debbugs.gnu.org > Date: Mon, 29 Jun 2020 01:00:01 +0300 > > >> > Now here is a patch for doing the same for a new window with > >> > 'C-x 4 4', and a new frame with 'C-x 5 5': > >> > >> Pushed to master. There is also a new command 'same-window-prefix', > >> but it's currently unbound. What would be a good keybinding? > >> Maybe 'C-x 4 1'? > > > > Please be sure to call out these changes in NEWS, and possibly also in > > the ELisp manual. > > These changes were already in NEWS IMNSHO, insufficiently so. The Lisp-level aspects of this are not described, AFAICT, and the fact that this is a prefix command isn't explained. This is going to be a major feature (or at least it can be), so a single sentence is barely enough to describe it in NEWS. Can we please improve the description of these new features? From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 29 19:04:42 2020 Received: (at 41691) by debbugs.gnu.org; 29 Jun 2020 23:04:42 +0000 Received: from localhost ([127.0.0.1]:49734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jq2pN-0003JW-VT for submit@debbugs.gnu.org; Mon, 29 Jun 2020 19:04:42 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:60649) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jq2pL-0003JH-JO for 41691@debbugs.gnu.org; Mon, 29 Jun 2020 19:04:40 -0400 Received: from mail.gandi.net (m91-129-96-187.cust.tele2.ee [91.129.96.187]) (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 2A407240007; Mon, 29 Jun 2020 23:04:32 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#41691: [PATCH] Add bookmark-jump-other-tab Organization: LINKOV.NET References: <20200603163925.11161-1-pirata@gmail.com> <87bllzvjov.fsf@mail.linkov.net> <87y2p2gzvs.fsf@mail.linkov.net> <87v9jyocea.fsf@mail.linkov.net> <87r1u8ggag.fsf@mail.linkov.net> <83sgenta0i.fsf@gnu.org> <87ftaehmvy.fsf@mail.linkov.net> <83o8p20wkc.fsf@gnu.org> Date: Tue, 30 Jun 2020 01:52:19 +0300 In-Reply-To: <83o8p20wkc.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 29 Jun 2020 17:35:15 +0300") Message-ID: <87mu4llcj8.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41691 Cc: 41691@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> > Please be sure to call out these changes in NEWS, and possibly also in >> > the ELisp manual. >> >> These changes were already in NEWS > > IMNSHO, insufficiently so. The Lisp-level aspects of this are not These commands are not intended to be used programmatically at Lisp-level. Or do you mean to describe a new function 'display-buffer-override-next-command'? > described, AFAICT, and the fact that this is a prefix command isn't NEWS mentions the key prefix. Do you think NEWS should also mention the name of the prefix command like 'other-window-prefix'? > explained. This is going to be a major feature (or at least it can > be), so a single sentence is barely enough to describe it in NEWS. Do you want to copy the docstrings of these commands to NEWS? > Can we please improve the description of these new features? Definitely they will be described in the manual soon. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 30 17:33:54 2020 Received: (at 41691) by debbugs.gnu.org; 30 Jun 2020 21:33:54 +0000 Received: from localhost ([127.0.0.1]:51829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jqNt4-0007EM-7w for submit@debbugs.gnu.org; Tue, 30 Jun 2020 17:33:54 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:33471) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jqNsy-0007DZ-Af for 41691@debbugs.gnu.org; Tue, 30 Jun 2020 17:33:48 -0400 X-Originating-IP: 91.129.96.187 Received: from mail.gandi.net (m91-129-96-187.cust.tele2.ee [91.129.96.187]) (Authenticated sender: juri@linkov.net) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 57FD21BF208; Tue, 30 Jun 2020 21:33:40 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#41691: [PATCH] Add bookmark-jump-other-tab Organization: LINKOV.NET References: <20200603163925.11161-1-pirata@gmail.com> <87bllzvjov.fsf@mail.linkov.net> <87y2p2gzvs.fsf@mail.linkov.net> <87v9jyocea.fsf@mail.linkov.net> <87r1u8ggag.fsf@mail.linkov.net> <83sgenta0i.fsf@gnu.org> <87ftaehmvy.fsf@mail.linkov.net> <83o8p20wkc.fsf@gnu.org> <87mu4llcj8.fsf@mail.linkov.net> Date: Wed, 01 Jul 2020 00:30:47 +0300 In-Reply-To: <87mu4llcj8.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 30 Jun 2020 01:52:19 +0300") Message-ID: <87o8p02qd4.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41691 Cc: 41691@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Please be sure to call out these changes in NEWS, and possibly also in > the ELisp manual. Please check if it's better now. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 01 10:35:27 2020 Received: (at 41691) by debbugs.gnu.org; 1 Jul 2020 14:35:27 +0000 Received: from localhost ([127.0.0.1]:53555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jqdpf-0003X8-Ay for submit@debbugs.gnu.org; Wed, 01 Jul 2020 10:35:27 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jqdpb-0003Wu-Ud for 41691@debbugs.gnu.org; Wed, 01 Jul 2020 10:35:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40096) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jqdpW-00046A-Fh; Wed, 01 Jul 2020 10:35:18 -0400 Received: from [176.228.60.248] (port=2102 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jqdpG-0003fj-4t; Wed, 01 Jul 2020 10:35:15 -0400 Date: Wed, 01 Jul 2020 17:34:57 +0300 Message-Id: <83wo3nxq0e.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <87o8p02qd4.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 01 Jul 2020 00:30:47 +0300) Subject: Re: bug#41691: [PATCH] Add bookmark-jump-other-tab References: <20200603163925.11161-1-pirata@gmail.com> <87bllzvjov.fsf@mail.linkov.net> <87y2p2gzvs.fsf@mail.linkov.net> <87v9jyocea.fsf@mail.linkov.net> <87r1u8ggag.fsf@mail.linkov.net> <83sgenta0i.fsf@gnu.org> <87ftaehmvy.fsf@mail.linkov.net> <83o8p20wkc.fsf@gnu.org> <87mu4llcj8.fsf@mail.linkov.net> <87o8p02qd4.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41691 Cc: 41691@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: 41691@debbugs.gnu.org > Date: Wed, 01 Jul 2020 00:30:47 +0300 > > > Please be sure to call out these changes in NEWS, and possibly also in > > the ELisp manual. > > Please check if it's better now. Much better, thank you. From unknown Tue Sep 23 05:03:23 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 30 Jul 2020 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator