From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 02 20:26:23 2020 Received: (at submit) by debbugs.gnu.org; 3 Jun 2020 00:26:23 +0000 Received: from localhost ([127.0.0.1]:41350 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgHEc-0002uY-Qd for submit@debbugs.gnu.org; Tue, 02 Jun 2020 20:26:23 -0400 Received: from lists.gnu.org ([209.51.188.17]:58108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgHEb-0002uP-4b for submit@debbugs.gnu.org; Tue, 02 Jun 2020 20:26:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36816) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgHEa-0007lM-Uj for bug-gnu-emacs@gnu.org; Tue, 02 Jun 2020 20:26:20 -0400 Received: from dancol.org ([2600:3c01::f03c:91ff:fedf:adf3]:54332) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgHEZ-0007gV-1b for bug-gnu-emacs@gnu.org; Tue, 02 Jun 2020 20:26:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:To:From: Subject:Date:Message-ID:Sender:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=RPeC+gmEHWhSRmZnpGCfSNjhJ0djsfylAzGov75NEEY=; b=mjgv5MUtSG1daquKPw22YwQuWw Bv/ZxYFWUH+hUaX4XCmg9gJm6VBMEPOdLo0S4o1lJXzn8LgPYvO84LVLa5xX0iJn2qQx9lW/3qwPt p4MePFPrgJQo+9RSDopFVpulRKq/YNQ08Tuwddx4vIcty9maOWcWbaJ+Nc67iaCIF7nmzkIaP53D6 7BZP9+EIlFhQyyQIhqgPUxsDPX/i/8nxXPo8IChpMVVtzgpuKm/zBM7FbRcNDY0wL6w4ath3zD5f1 soVnFbmFib/MILrKvF5BK+ZV4tbf1UVsbbEDPhSuArTidGfQHTbjqCf+L5q/ov4Psk6gEgK6vLpr9 zmjzH8sQ==; Received: from localhost ([127.0.0.1] helo=dancol.org) by dancol.org with esmtp (Exim 4.89) (envelope-from ) id 1jgHET-0008Q3-NY; Tue, 02 Jun 2020 17:26:13 -0700 Received: from 127.0.0.1 (SquirrelMail authenticated user dancol) by dancol.org with HTTP; Tue, 2 Jun 2020 17:26:13 -0700 Message-ID: <6abccf7f9125449bc7297aab126f49a0.squirrel@dancol.org> Date: Tue, 2 Jun 2020 17:26:13 -0700 Subject: Recent compiled byte code changes broke loading From: "Daniel Colascione" To: bug-gnu-emacs@gnu.org User-Agent: SquirrelMail/1.4.23 [SVN] MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal Received-SPF: pass client-ip=2600:3c01::f03c:91ff:fedf:adf3; envelope-from=dancol@dancol.org; helo=dancol.org X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: 3.2 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: f0b0105d913a94c66f230874c9269b19dbbc83bd changes how we generate and evaluate byte-code objects. It causes a weird wrong-type-argument when loading some elc files, however: Debugger entered--Lisp error: (wrong-type-argument stringp ("/home/dancol/emacs/conf/gnus.elc" . 1556)) read(get-file-char) load("~/emacs/conf/gnus" nil t) (lambda nil (load "~/emacs/conf/gnus" nil t) [...] Content analysis details: (3.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: dancol.org] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [2600:3c01:0:0:f03c:91ff:fedf:adf3 listed in] [zen.spamhaus.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.9 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom; id=dancol%40dancol.org; ip=209.51.188.17; r=debbugs.gnu.org] -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [209.51.188.17 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 1.0 XPRIO Has X-Priority header X-Debbugs-Envelope-To: submit Cc: eggert@cs.ucla.edu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: f0b0105d913a94c66f230874c9269b19dbbc83bd changes how we generate and evaluate byte-code objects. It causes a weird wrong-type-argument when loading some elc files, however: Debugger entered--Lisp error: (wrong-type-argument stringp ("/home/dancol/emacs/conf/gnus.elc" . 1556)) read(get-file-char) load("~/emacs/conf/gnus" nil t) (lambda nil (load "~/emacs/conf/gnus" nil t) [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: dancol.org] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [2600:3c01:0:0:f03c:91ff:fedf:adf3 listed in] [zen.spamhaus.org] -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [209.51.188.17 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.9 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom;id=dancol%40dancol.org;ip=209.51.188.17;r=debbugs.gnu.org] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager f0b0105d913a94c66f230874c9269b19dbbc83bd changes how we generate and evaluate byte-code objects. It causes a weird wrong-type-argument when loading some elc files, however: Debugger entered--Lisp error: (wrong-type-argument stringp ("/home/dancol/emacs/conf/gnus.elc" . 1556)) read(get-file-char) load("~/emacs/conf/gnus" nil t) (lambda nil (load "~/emacs/conf/gnus" nil t))() eval-after-load-helper("/home/dancol/edev/debug/lisp/gnus/gnus.elc") run-hook-with-args(eval-after-load-helper "/home/dancol/edev/debug/lisp/gnus/gnus.elc") do-after-load-evaluation("/home/dancol/edev/debug/lisp/gnus/gnus.elc") I did a bit of debugging. We're passing some kind of cons cell to the Fstring_as_unibyte call in read1. (The CDR seems invalid too somehow?) There's a difference in the generated elc file ("gnus.elc" above) that seems to drive the error. Bad: (defalias 'qtmstr-setup-summary-mode #[nil #@38 ("\300\301!\207" . [hl-line-mode 1])(#$ . 1556) nil 2]) Good: (defalias 'qtmstr-setup-summary-mode #[nil "\300\301!\207" [hl-line-mode 1] 2]) Reverting f0b0105d913a94c66f230874c9269b19dbbc83bd seems to fix the problem for now. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 02 21:43:59 2020 Received: (at 41680-done) by debbugs.gnu.org; 3 Jun 2020 01:43:59 +0000 Received: from localhost ([127.0.0.1]:41522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgIRj-00070G-AP for submit@debbugs.gnu.org; Tue, 02 Jun 2020 21:43:59 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:48052) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgIRh-000703-T6 for 41680-done@debbugs.gnu.org; Tue, 02 Jun 2020 21:43:58 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 926511600AF; Tue, 2 Jun 2020 18:43:51 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id y9AHZs3czhQ7; Tue, 2 Jun 2020 18:43:50 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id B8BDF1600B4; Tue, 2 Jun 2020 18:43:50 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id YSFr4ZybWzD3; Tue, 2 Jun 2020 18:43:50 -0700 (PDT) Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 8D1C71600AF; Tue, 2 Jun 2020 18:43:50 -0700 (PDT) Subject: Re: Recent compiled byte code changes broke loading To: Daniel Colascione References: <6abccf7f9125449bc7297aab126f49a0.squirrel@dancol.org> From: Paul Eggert Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= LS0tLS1CRUdJTiBQR1AgUFVCTElDIEtFWSBCTE9DSy0tLS0tCgptUUlOQkV5QWNtUUJFQURB QXlIMnhvVHU3cHBHNUQzYThGTVpFb243NGRDdmM0K3ExWEEySjJ0QnkycHdhVHFmCmhweHhk R0E5Smo1MFVKM1BENGJTVUVnTjh0TFowc2FuNDdsNVhUQUZMaTI0NTZjaVNsNW04c0thSGxH ZHQ5WG0KQUF0bVhxZVpWSVlYL1VGUzk2ZkR6ZjR4aEVtbS95N0xiWUVQUWRVZHh1NDd4QTVL aFRZcDVibHRGM1dZRHoxWQpnZDdneDA3QXV3cDdpdzdlTnZub0RUQWxLQWw4S1lEWnpiRE5D UUdFYnBZM2VmWkl2UGRlSStGV1FONFcra2doCnkrUDZhdTZQcklJaFlyYWV1YTdYRGRiMkxT MWVuM1NzbUUzUWpxZlJxSS9BMnVlOEpNd3N2WGUvV0szOEV6czYKeDc0aVRhcUkzQUZINmls QWhEcXBNbmQvbXNTRVNORnQ3NkRpTzFaS1FNcjlhbVZQa25qZlBtSklTcWRoZ0IxRApsRWR3 MzRzUk9mNlY4bVp3MHhmcVQ2UEtFNDZMY0ZlZnpzMGtiZzRHT1JmOHZqRzJTZjF0azVlVThN Qml5Ti9iClowM2JLTmpOWU1wT0REUVF3dVA4NGtZTGtYMndCeHhNQWhCeHdiRFZadWR6eERa SjFDMlZYdWpDT0pWeHEya2wKakJNOUVUWXVVR3FkNzVBVzJMWHJMdzYrTXVJc0hGQVlBZ1Jy NytLY3dEZ0JBZndoUEJZWDM0blNTaUhsbUxDKwpLYUhMZUNMRjVaSTJ2S20zSEVlQ1R0bE9n N3haRU9OZ3d6TCtmZEtvK0Q2U29DOFJSeEpLczhhM3NWZkk0dDZDCm5yUXp2SmJCbjZneGRn Q3U1aTI5SjFRQ1lyQ1l2cWwyVXlGUEFLK2RvOTkvMWpPWFQ0bTI4MzZqMXdBUkFRQUIKdENC UVlYVnNJRVZuWjJWeWRDQThaV2RuWlhKMFFHTnpMblZqYkdFdVpXUjFQb2tDUGdRVEFRSUFL QVVDVElCeQpaQUliQXdVSkVzd0RBQVlMQ1FnSEF3SUdGUWdDQ1FvTEJCWUNBd0VDSGdFQ0Y0 QUFDZ2tRN1pmcERtS3FmalJSCkd3LytJajAzZGhZZllsL2dYVlJpdXpWMWdHcmJIayt0bmZy SS9DN2ZBZW9GelE1dFZnVmluU2hhUGtabzBIVFAKZjE4eDZJREVkQWlPOE1xbzF5cDBDdEht ekdNQ0o1MG80R3JnZmpscjZnLyt2dEVPS2JobGVzek4yWHBKdnB3TQoyUWdHdm4vbGFUTFV1 OFBIOWFSV1RzN3FKSlpLS0tBYjRzeFljOTJGZWhQdTZGT0QwZERpeWhsREFxNGxPVjJtCmRC cHpRYmlvam9aelFMTVF3anBnQ1RLMjU3MmVLOUVPRVF5U1VUaFhyU0l6NkFTZW5wNE5ZVEZI czl0dUpRdlgKazlnWkRkUFNsM2JwKzQ3ZEd4bHhFV0xwQklNN3pJT053NGtzNGF6Z1Q4bnZE WnhBNUlaSHR2cUJsSkxCT2JZWQowTGU2MVdwMHkzVGxCRGgycWRLOGVZTDQyNlc0c2NFTVN1 aWc1Z2I4T0F0UWlCVzZrMnNHVXh4ZWl2OG92V3U4CllBWmdLSmZ1b1dJK3VSbk1FZGRydVk4 SnNvTTU0S2FLdlppa2tLczJiZzFuZHRMVnpIcEo2cUZaQzdRVmplSFUKaDYvQm1ndmRqV1Ba WUZUdE4rS0E5Q1dYM0dRS0tnTjN1dTk4OHl6bkQ3TG5COThUNEVVSDFIQS9HbmZCcU1WMQpn cHpUdlBjNHFWUWluQ21Ja0VGcDgzemwrRzVmQ2pKSjNXN2l2ekNuWW80S2hLTHBGVW05N29r VEtSMkxXM3haCnpFVzRjTFNXTzM4N01USzNDekRPeDVxZTZzNGE5MVp1Wk0vai9UUWRUTERh cU5uODNrQTRIcTQ4VUhYWXhjSWgKK05kOGsvM3c2bEZ1b0swd3JPRml5d2pMeCswdXI1am1t YmVjQkdIYzF4ZGhBRkc1QWcwRVRJQnlaQUVRQUthRgo2NzhUOXd5SDR3alRyVjFQejNjREVv U25WLzBaVXJPVDM3cDFkY0d5ai9JWHExeDY3MEhSVmFoQW1rMHNacFljCjI1UEY5RDVHUFlI RldsTmp1UFU5NnJEbmRYQjNoZWRtQlJoTGRDNGJBWGpJNERWK2JtZFZlK3EvSU1ubFpSYVYK bG05RWlNQ1ZBUjZ3MTNzUmV1N3FYa1c5cjNSd1kyQXpYc2twL3RBZTRCUktyMVptYnZpMm5i blE2ZXBFQzQycgpSYngwQjFFaGpiSVFaNUpIR2syNGlQVDdMZEJnbk5tb3M1d1lqendObGtN UUQ1VDBZZHpoazdKK1V4d0E1bTQ2Cm1PaFJEQzJyRlYvQTBnbTVUTHk4RFhqdi9Fc2M0Z1lu WWFpNlNRcW5VRVZoNUx1VjhZQ0pCbmlqcytUaXc3MXgKMWljbW42eEdJNDVFdWdKT2dlYyty THlwWWdwVnA0eDBISTVUODhxQlJZQ2t4SDNLZzhRbytFV05BOUE0TFJROQpEWDhuam9uYTBn ZjBzMDN0b2NLOGtCTjY2VW9xcVB0SEJuYzRlTWdCeW1DZmxLMTJlS2ZkMllZeG55ZzljWmF6 CldBNVZzbHZUeHBtNzZoYmc1b2lBRUgvVmcvOE14SHlBblBoZnJnd3lQcm1KRWNWQmFmZHNw Sm5ZUXhCWU5jbzIKTEZQSWhsT3ZXaDhyNGF0K3MrTTNMYjI2b1VUY3psZ2RXMVNmM1NEQTc3 Qk1SbkYwRlF5RSs3QXpWNzlNQk40eQpraXFhZXpReHRhRjFGeS90dmtoZmZTbzh1K2R3RzBF Z0poK3RlMzhnVGNJU1ZyMEdJUHBsTHo2WWhqcmJIclBSCkYxQ041VXVMOURCR2p4dU4zNVJM TlZFZnRhNlJVRmxSNk5jdFRqdnJBQkVCQUFHSkFpVUVHQUVDQUE4RkFreUEKY21RQ0d3d0ZD UkxNQXdBQUNna1E3WmZwRG1LcWZqU3JIQS8rS3pBS3ZUeFJoQTlNV05MeEl5SjdTNXVKMTZn cwpUM29DalpyQktHRWhLTU9HWDRPMEdBNlZPRXJ5TzdRUkNDWWFoM294U0czOElBbk5laXdK WGdVOUJ6a2s4NVVHCmJQRWQ3SEdGL1ZTZUhDUXdXb3U2anFVRFRTRHZuOVloTlRkRzBLWFBN NzRhQyt4cjJab3cxTzJtaFhpaGdXS0QKMER3KzBMWVBuVU9zUTBLT0Z4SFhYWUhtUnJTMU9a UFU1OUJMdmMrVFJoSWhhZlNIS0x3YlhLKzZja2t4Qng2aAo4ejVjY3BHMFFzNGJGaGRGWW5G ckVpZURMb0dtbkUyWUxoZFY2c3dKOVZOQ1M2cExpRW9oVDNmbTdhWG0xNXRaCk9JeXpNWmhI UlNBUGJsWHhRMFpTV2pxOG9ScmNZTkZ4YzRXMVVScEFrQkNPWUpvWHZRZkQ1TDNscUFsOFRD cUQKVXpZeGhIL3RKaGJEZEhycUhINzY3amFEYVRCMStUYWxwLzJBTUt3Y1hOT2Rpa2xHeGJt SFZHNllHbDZnOExyYgpzdTlOWkVJNHlMbEh6dWlrdGhKV2d6KzN2WmhWR3lObHQrSE5Jb0Y2 Q2pETDJvbXU1Y0VxNFJESE00NFFxUGs2Cmw3TzBwVXZOMW1UNEIrUzFiMDhSS3BxbS9mZjAx NUUzN0hOVi9waUl2Smx4R0FZejhQU2Z1R0NCMXRoTVlxbG0KZ2RoZDkvQmFiR0ZiR0dZSEE2 VTQvVDV6cVUrZjZ4SHkxU3NBUVoxTVNLbEx3ZWtCSVQrNC9jTFJHcUNIam5WMApxNUgvVDZh N3Q1bVBrYnpTck9MU280cHVqK0lUb05qWXlZSURCV3pobEExOWF2T2ErcnZVam1IdEQzc0ZO N2NYCld0a0dvaThidU5jYnk0VT0KPUFMNm8KLS0tLS1FTkQgUEdQIFBVQkxJQyBLRVkgQkxP Q0stLS0tLQo= Organization: UCLA Computer Science Department Message-ID: Date: Tue, 2 Jun 2020 18:43:50 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <6abccf7f9125449bc7297aab126f49a0.squirrel@dancol.org> Content-Type: multipart/mixed; boundary="------------2FE16562190DCCDE15C4824A" Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41680-done Cc: 41680-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --------------2FE16562190DCCDE15C4824A Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Thanks for reporting that bug. I installed the attached patch, which should fix it, and am boldly closing the bug report. --------------2FE16562190DCCDE15C4824A Content-Type: text/x-patch; charset=UTF-8; name="0001-Fix-bug-in-recent-byte-code-checking-hoist.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Fix-bug-in-recent-byte-code-checking-hoist.patch" >From 00613f4c4a464c16d6d50a34e1b8b68fc50f2d2e Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Tue, 2 Jun 2020 18:40:10 -0700 Subject: [PATCH] Fix bug in recent byte-code checking hoist Problem reported by Daniel Colascione (Bug#41680). * src/lread.c (read1): Check that AREF (tmp, COMPILED_BYTECODE) is a string before subjecting it to STRING_MULTIBYTE. Be more consistent about using AREF in the neighborhood, to help prevent this sort of problem from recurring. --- src/lread.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/src/lread.c b/src/lread.c index 29deddaf15..8064bf4d0e 100644 --- a/src/lread.c +++ b/src/lread.c @@ -2966,17 +2966,18 @@ read1 (Lisp_Object readcharfun, int *pch, bool first_in_list) struct Lisp_Vector *vec; tmp = read_vector (readcharfun, 1); vec = XVECTOR (tmp); - if (! (COMPILED_STACK_DEPTH < vec->header.size - && (FIXNUMP (vec->contents[COMPILED_ARGLIST]) - || CONSP (vec->contents[COMPILED_ARGLIST]) - || NILP (vec->contents[COMPILED_ARGLIST])) - && ((STRINGP (vec->contents[COMPILED_BYTECODE]) - && VECTORP (vec->contents[COMPILED_CONSTANTS])) - || CONSP (vec->contents[COMPILED_BYTECODE])) - && FIXNATP (vec->contents[COMPILED_STACK_DEPTH]))) + if (! (COMPILED_STACK_DEPTH < ASIZE (tmp) + && (FIXNUMP (AREF (tmp, COMPILED_ARGLIST)) + || CONSP (AREF (tmp, COMPILED_ARGLIST)) + || NILP (AREF (tmp, COMPILED_ARGLIST))) + && ((STRINGP (AREF (tmp, COMPILED_BYTECODE)) + && VECTORP (AREF (tmp, COMPILED_CONSTANTS))) + || CONSP (AREF (tmp, COMPILED_BYTECODE))) + && FIXNATP (AREF (tmp, COMPILED_STACK_DEPTH)))) invalid_syntax ("Invalid byte-code object"); - if (STRING_MULTIBYTE (AREF (tmp, COMPILED_BYTECODE))) + if (STRINGP (AREF (tmp, COMPILED_BYTECODE)) + && STRING_MULTIBYTE (AREF (tmp, COMPILED_BYTECODE))) { /* BYTESTR must have been produced by Emacs 20.2 or earlier because it produced a raw 8-bit string for byte-code and @@ -2987,7 +2988,7 @@ read1 (Lisp_Object readcharfun, int *pch, bool first_in_list) Fstring_as_unibyte (AREF (tmp, COMPILED_BYTECODE))); } - if (COMPILED_DOC_STRING < vec->header.size + if (COMPILED_DOC_STRING < ASIZE (tmp) && EQ (AREF (tmp, COMPILED_DOC_STRING), make_fixnum (0))) { /* read_list found a docstring like '(#$ . 5521)' and treated it -- 2.17.1 --------------2FE16562190DCCDE15C4824A-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 03 10:02:44 2020 Received: (at control) by debbugs.gnu.org; 3 Jun 2020 14:02:44 +0000 Received: from localhost ([127.0.0.1]:44284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgTye-0004qa-An for submit@debbugs.gnu.org; Wed, 03 Jun 2020 10:02:44 -0400 Received: from mail-qt1-f181.google.com ([209.85.160.181]:42990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgTyc-0004qM-LJ for control@debbugs.gnu.org; Wed, 03 Jun 2020 10:02:42 -0400 Received: by mail-qt1-f181.google.com with SMTP id q14so2061935qtr.9 for ; Wed, 03 Jun 2020 07:02:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=630cWNSpTJ7D/UtIaimwOMtJVOxCcpg3hDYPwfqs2s4=; b=oEJrg430axfX3CKUU0Osl9Nvz6zZpkGnT3h8r3F9miAYxcRGldykVbzg5xth2INwaJ 2BOzxeOTeZ6rGLL/0GIHNiFNZSSqBheeXaz580h9izwplwBaq3Z+w5r4lH1pk7yqX8I9 zHek9Foi2lzdPxSQrsMWwwvTP4ffz04mholL8PO6SB2EXLhE7Vue/eV1+xOl2qxTyj5O MxuVaQi8U8ItYPDQet3/T6lSuBSWImZC3lov6VYH7Lcl4JKHrDMFrA00kDnKvdx5rnN4 ooxR7fwB4L3C4Vr7xeIvWmEKopWM30pZ1rFe+VbogILCrPlX67OOUvklsI8mM4Hwb2yL 48Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=630cWNSpTJ7D/UtIaimwOMtJVOxCcpg3hDYPwfqs2s4=; b=F0qvbZTMe7QBjV8Jm9gJYXHt4ij5UaruLDdQ5cB2ehNIRL5d3d75hj1UUXiTLK28SK 0J7F4Mh6MoV3pN/8nxbYUyVWXqyQdAI517aF8BVbA+JfpcFjbktj0yl1UxtBmYCM1emY 6NcC4Gv5tcPEUp7NKwqRABDsF0wRq6O3tJ3H9ZA4q7dwPrRKHzKwzWGxoIqZln2AwhXg /7+zxpIV8TLUQo5LefQsixZEUW1uibmK9GbXPqEWlYM7yRkRz2NH1Iim5sz8v1K6C8kb 5EJWZfJit9POUI7+uAWnUmlwNCFfbyN5C8HLA6c69sfz2gkWzpOX7/4ZWASzNYGtFEad xrkA== X-Gm-Message-State: AOAM531DTnSsifZ/c3o4W+Y9SSzg2V+eSjyo89KFv4B5mjF/FWFKF/y1 hAn3T6aINL2QuJgVQOm1NMlNgrKU X-Google-Smtp-Source: ABdhPJxirBii49p72wGyFtOafRr6kUU1E/Pk0ISjTellv0I6xZYyfmttaDOQGXk2Kz6rpqQpeqiP0Q== X-Received: by 2002:ac8:3682:: with SMTP id a2mr33266642qtc.137.1591192956664; Wed, 03 Jun 2020 07:02:36 -0700 (PDT) Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.38.42]) by smtp.gmail.com with ESMTPSA id 124sm1604302qkm.115.2020.06.03.07.02.35 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 Jun 2020 07:02:36 -0700 (PDT) From: Noam Postavsky To: control@debbugs.gnu.org Subject: control message for bug #41680 Date: Wed, 03 Jun 2020 10:02:35 -0400 Message-ID: <851rmwtfgk.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) # Fixed by the same commit; most likely the same bug. merge 41680 41443 quit From unknown Fri Aug 15 19:28:44 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 02 Jul 2020 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator