GNU bug report logs - #41679
[PATCH] gnu: Update protonvpn-cli to 2.2.4

Previous Next

Full log

Message #8 received at 41679 <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: Ryan Prior <rprior <at> protonmail.com>
Cc: 41679 <at> debbugs.gnu.org
Subject: Re: [bug#41679] [PATCH] gnu: Update protonvpn-cli to 2.2.4
Date: Sun, 07 Jun 2020 23:18:21 +0200

Hello Ryan,

Thank you for the patch!

Ryan Prior <rprior <at> protonmail.com> writes:

> * gnu/packages/vpn.scm (protonvpn-cli): Update to 2.2.4
> ---
>  gnu/packages/vpn.scm | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

The update is fine, but that package is missing several dependencies, at
least: python-jinja2, coreutils and iproute. Try running it in a pure
environment and it will crash “guix environment --pure --container
--ad-hoc protonvpn-cli -- protonvpn -h”.

Searching the source for “subprocess.run” I find call to other binaries
which aren't listed as dependencies. Could you wrap the “protonvpn”
binary with the “PATH” of all the binaries it uses to avoid propagating
a whole lot of packages. Probably only “python-jinja2” should be
propagated.

- Brice

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.