From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 02 15:41:45 2020 Received: (at submit) by debbugs.gnu.org; 2 Jun 2020 19:41:45 +0000 Received: from localhost ([127.0.0.1]:41016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgCnB-0008Os-9J for submit@debbugs.gnu.org; Tue, 02 Jun 2020 15:41:45 -0400 Received: from lists.gnu.org ([209.51.188.17]:41450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgCn9-0008Ol-Py for submit@debbugs.gnu.org; Tue, 02 Jun 2020 15:41:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32830) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgCn9-000821-IY for guix-patches@gnu.org; Tue, 02 Jun 2020 15:41:43 -0400 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]:40025) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jgCn8-0008MG-Px for guix-patches@gnu.org; Tue, 02 Jun 2020 15:41:43 -0400 Received: by mail-pl1-x642.google.com with SMTP id t16so1819395plo.7 for ; Tue, 02 Jun 2020 12:41:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=X5B/OQjMCqgL4bVbdcj9uZZB4nLStDTfQJlH4tFFsgE=; b=o8bIxptTfZ5Fm1u7C4rsLr8DYJWpdHyTXJFg/CETNxb4F2o+EROE9AwmAfI6zcB+hr e7wzR4SiOymrMNG/NIe6YrbXVYfwaWaqEzrMHUodSGahvZcD71eNRpR8kY5FPMiN6do0 uY5gTYH5oDEPoaTNvllRAFiTvkm4DwJcXeRWTbkYBF4yD/xIshiWMC5XP9Qo82RajCLI DCZ8rFTvS6bPv5VvxOwvTUnle5FDeePKCs2fRSI612iL1yVOGDuWilLt7mwPcYMJVIe1 DY8rCsGCuoYSwBMAWRb9F9mo2Wfe5Ho4ALD80cV6zlwgtGrhe7iUausLshQPmUOWXoUm Tdyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=X5B/OQjMCqgL4bVbdcj9uZZB4nLStDTfQJlH4tFFsgE=; b=oiKObT7Px2RLsUjDbbF9SjhHd1+pYCA0D6m3W2GL6Oh8tmhtLu7MMh/kyHV+TELgk4 An92PmQ9b+s14yiiaxr0JV1EGqr5dn8pKvKlNsnRMinbEJ8y2r9X7rSo6Qu/zsKR1kS5 Ez1dDrrwEwhNOEv4WVInya3RjvS61QWZ1ZINpOV1gE2uxnHof+R50hx2GUhqQ+pB5OfL JUQn1BIjDiuIw31GECXhnK7wGOqUAAQUloWVTNM8kU5gXk+otuRjCW9fggpmLctJkq6v AASMB40pk9l7BOEjdpW4siYfKZKo1uRKi2ADmc0n6uos7b5tNS0g1B02IRvWCUT4FL3/ Q47Q== X-Gm-Message-State: AOAM533ib4M7esuxa86KZPjAvZZD0Ul421z3MZPKu5/PS+dqsw8kjSfl QXr3KFGh+bcCC5kw5FzO+IOmkIm7 X-Google-Smtp-Source: ABdhPJxsZqRqWtVh8m8UVbhfncurZRRNapW4ghQM3SH1UIGYbQG0fZfgOrg+IbqwiDKLfCg1PFPOFQ== X-Received: by 2002:a17:902:bb96:: with SMTP id m22mr27299497pls.222.1591126901058; Tue, 02 Jun 2020 12:41:41 -0700 (PDT) Received: from localhost (node-1w7jr9qqzayzqnit5wh171cm2.ipv6.telus.net. [2001:569:7a05:3a00::111a]) by smtp.gmail.com with ESMTPSA id n3sm2704999pgq.30.2020.06.02.12.41.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2020 12:41:40 -0700 (PDT) From: Fredrik Salomonsson To: guix-patches@gnu.org Subject: [PATCH] gnu: Add emacs-glsl-mode Date: Tue, 2 Jun 2020 12:41:37 -0700 Message-Id: <20200602194137.30412-1-plattfot@gmail.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::642; envelope-from=plattfot@gmail.com; helo=mail-pl1-x642.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit Cc: Fredrik Salomonsson X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/emacs-xyz.scm (emacs-glsl-mode): New variable --- gnu/packages/emacs-xyz.scm | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 5f0a0184f9..94fd5cb1c8 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -22693,6 +22693,34 @@ sense in the @samp{To} and @samp{Cc} headers). When in the message body, this executes a different function (default: @code{indent-relative}).") (license license:gpl2+)))) +(define-public emacs-glsl-mode + ;; No tag, version grabbed from source .el file. + (let ((commit "b07112016436d9634cd4ef747f9af6b01366d136") + (revision "0")) + (package + (name "emacs-glsl-mode") + (version (git-version "2.4" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/jimhourihan/glsl-mode") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0bav9ipfm0vy26n74ngsmjzc7fsyqz6xmriadzx55s44h8p5dn1s")))) + (build-system emacs-build-system) + (home-page + "https://github.com/jimhourihan/glsl-mode") + (synopsis + "Major mode for Open GLSL shader files") + (description + "Major mode for editing OpenGLSL grammar files, usually files ending with +`.vert', `.frag', `.glsl', `.geom'. Is is based on c-mode plus some +features and pre-specified fontifications.") + (license license:gpl3+)))) + (define-public emacs-gnus-harvest (let ((commit "feda071a87b799bd5d23cacde3ee71f0b166e75d") (revision "0")) -- 2.26.2 From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 02 16:04:10 2020 Received: (at 41671) by debbugs.gnu.org; 2 Jun 2020 20:04:10 +0000 Received: from localhost ([127.0.0.1]:41040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgD8s-0002dT-GD for submit@debbugs.gnu.org; Tue, 02 Jun 2020 16:04:10 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:52755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgD8q-0002dD-3e for 41671@debbugs.gnu.org; Tue, 02 Jun 2020 16:04:09 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 4F7A1240006; Tue, 2 Jun 2020 20:04:01 +0000 (UTC) From: Nicolas Goaziou To: Fredrik Salomonsson Subject: Re: [bug#41671] [PATCH] gnu: Add emacs-glsl-mode References: <20200602194137.30412-1-plattfot@gmail.com> Date: Tue, 02 Jun 2020 22:04:00 +0200 In-Reply-To: <20200602194137.30412-1-plattfot@gmail.com> (Fredrik Salomonsson's message of "Tue, 2 Jun 2020 12:41:37 -0700") Message-ID: <878sh5dykv.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41671 Cc: 41671@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Fredrik Salomonsson writes: > * gnu/packages/emacs-xyz.scm (emacs-glsl-mode): New variable Thank you. Some comments follow. Nitpick: you need full stops at the end of each sentence in the commit message. > + (sha256 > + (base32 > + "0bav9ipfm0vy26n74ngsmjzc7fsyqz6xmriadzx55s44h8p5dn1s")))) Nitpick: could you move the hash on the same line as `base32'? > + (build-system emacs-build-system) > + (home-page > + "https://github.com/jimhourihan/glsl-mode") Nitpick: could you move the URL on the same line as `home-page'? > + (synopsis > + "Major mode for Open GLSL shader files") Nitpick: =E2=80=A6 guess what=E2=80=A6 ;) > + (description > + "Major mode for editing OpenGLSL grammar files, usually files end= ing with > +`.vert', `.frag', `.glsl', `.geom'. This should be a complete sentence, e.g., The library provides a major mode=E2=80=A6 Note that Texinfo syntax for file extensions is @file, so the rest of the sentence ought to be: files ending with @file{.vert}, @file{.frag}=E2=80=A6 > Is is based on c-mode plus some Typo and nitpick: "It is based on C mode" Could you send an updated patch? Regards, --=20 Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 02 17:03:02 2020 Received: (at 41671) by debbugs.gnu.org; 2 Jun 2020 21:03:02 +0000 Received: from localhost ([127.0.0.1]:41088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgE3p-000422-Vk for submit@debbugs.gnu.org; Tue, 02 Jun 2020 17:03:02 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:36047) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgE3n-00041X-P3 for 41671@debbugs.gnu.org; Tue, 02 Jun 2020 17:03:00 -0400 Received: by mail-pg1-f194.google.com with SMTP id t7so143995pgt.3 for <41671@debbugs.gnu.org>; Tue, 02 Jun 2020 14:02:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=/eUuWtAQiPe4n/CVyk2GR/Fxo/wRhdZoUO87RnmMYTQ=; b=Y9sRXrT6wto64BPyupJHW7L3+1z4r0BuTbph1Y7PA9zQ3k2XRr9Zx7VuvIIGbI1tDk gfTy70HFCeeYWef5Po6NF2zKM2wDhIehgHegENJbWjylAF8hDHVwiT+376t08dWnR4PP VIJa1K4qsR0dZ5/keYaj3Z26ncR8jhOwamp/fc4fuDxcKgXkEXOWrWNffI0oUoxRi+tp pcLIK3ycIO7qVoH/g9FUAecJBilrbb6BZJGiUuWrRtIKRUySFoOCrFLP2XLLtEI48WUt MuRMa7gZN+LywKmOenqJs6Ou9XLciENcgmv5ByNmyaN54wpsXcAMY1qM2yXsS+BYHc+X CMyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=/eUuWtAQiPe4n/CVyk2GR/Fxo/wRhdZoUO87RnmMYTQ=; b=s+yeB6yzln8ysOoh8sGpEKNldowKeGj7c+MBPWRrg79pvYOem3exRXktPmGxMMvMkH d8bvo2nqDs+WoEEsUabxHLvoJuU93GCzNFn6vFdfH9N1yEVFEbjnoCJ7c4eRLYjSf0uH 8pXQqKfB/7kVpsAefG3guiQbenmhaW7Zu5GQ7EaFZ7S50mnVEBzyjGldyAzLk8vBjtKs AfOkWRIdRTI8vycGsX8mmMe6FHH4DQ/aA6zt3WcP7fbPksQT1edEN7rm+cfvENPGxCED osS/8OD9epTWVwAd9E8eeAQ7/wdiFA9jQisZoIhx8/THDRR8KE5WzBm8TkY3wC1UY+UX 3Lig== X-Gm-Message-State: AOAM530al0iMEO12RsYIPWaeFhpQ4gIZ8uHl8EZy3wTWUpJI1r0cDTKO ftOyY5IN+r15uSp2gGBmi2+ann0J X-Google-Smtp-Source: ABdhPJxFkOGDuuDYB7XYTqKOpCmA+I6qXTRhQIY3r/iGcgnTz+bqfCBmNXw7pAnoyD/V44qtiTfCtQ== X-Received: by 2002:a62:4e8a:: with SMTP id c132mr25773711pfb.22.1591131773437; Tue, 02 Jun 2020 14:02:53 -0700 (PDT) Received: from localhost (node-1w7jr9qqzayzqnit5wh171cm2.ipv6.telus.net. [2001:569:7a05:3a00::111a]) by smtp.gmail.com with ESMTPSA id h3sm2925742pgk.67.2020.06.02.14.02.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2020 14:02:52 -0700 (PDT) From: Fredrik Salomonsson To: 41671@debbugs.gnu.org Subject: [PATCH] gnu: Add emacs-glsl-mode. Date: Tue, 2 Jun 2020 14:02:49 -0700 Message-Id: <20200602210249.36527-1-plattfot@gmail.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41671 Cc: Fredrik Salomonsson X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/emacs-xyz.scm (emacs-glsl-mode): New variable. --- gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 5f0a0184f9..2701081b9c 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -22693,6 +22693,32 @@ sense in the @samp{To} and @samp{Cc} headers). When in the message body, this executes a different function (default: @code{indent-relative}).") (license license:gpl2+)))) +(define-public emacs-glsl-mode + ;; No tag, version grabbed from source .el file. + (let ((commit "b07112016436d9634cd4ef747f9af6b01366d136") + (revision "0")) + (package + (name "emacs-glsl-mode") + (version (git-version "2.4" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/jimhourihan/glsl-mode") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 "0bav9ipfm0vy26n74ngsmjzc7fsyqz6xmriadzx55s44h8p5dn1s")))) + (build-system emacs-build-system) + (home-page "https://github.com/jimhourihan/glsl-mode") + (synopsis "Major mode for Open GLSL shader files") + (description + "This package provides a major mode for editing OpenGLSL grammar files, +usually files ending with @file{.vert}, @file{.frag}, @file{.glsl} or +@file{.geom}. It is based on C mode plus some features and pre-specified +fontifications.") + (license license:gpl3+)))) + (define-public emacs-gnus-harvest (let ((commit "feda071a87b799bd5d23cacde3ee71f0b166e75d") (revision "0")) -- 2.26.2 From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 02 17:08:51 2020 Received: (at 41671) by debbugs.gnu.org; 2 Jun 2020 21:08:52 +0000 Received: from localhost ([127.0.0.1]:41094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgE9T-00049k-Ml for submit@debbugs.gnu.org; Tue, 02 Jun 2020 17:08:51 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:39761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgE9S-00049X-8o for 41671@debbugs.gnu.org; Tue, 02 Jun 2020 17:08:50 -0400 Received: by mail-wm1-f68.google.com with SMTP id k26so4546486wmi.4 for <41671@debbugs.gnu.org>; Tue, 02 Jun 2020 14:08:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/EZqNR8XZj7oCfDIxdA9aHv1iAN/Vw+gZ0tzTMI3wTs=; b=RTfgb4rlLqy0ChlsbAs3lvKkSyIUC+Sxhy6nryMar88yiZI8eHex5khQmq9GmxyBgF aZ3EYjBEQTPw2/bSNrI9EvAWi09qn5lDAowOHNclV3TT8GrLkyf3+LuMVn+tPQOJ5PFK cpTkJoxzXoBfC2SuzmS9Idrehia5nLOEh/LFPDS2nXMGGhIhkz1EJkZx0D8OSE07y/W0 jPFxictZk+pIdzgU7Uk473BWsKebhgJfe9/IHGAEr08cYejI53+2nkFnwaEIO3Yiu6Hz /uV7W3HcJugRJSVwE+yO3h24if+Wb7upWVsPayMAwp6Qkf8m3jQ5rNMB3c9AgeK3OxdF 53iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/EZqNR8XZj7oCfDIxdA9aHv1iAN/Vw+gZ0tzTMI3wTs=; b=ms0hpWy+ZE4zg1qFLy+Clpm7yDcygFTOm44P8LTt34NBzVBYfIXueawAKmHJoBik+P DygeHqETnnWG4dKG5GUix3MiGEx/Jd+3utX2VPuGeRM9kuHlx3HGc1Hcdy95znIfWIZi C6nkBc5iPpVYu8b7FpsLcLTJPXZu5auROdQDVFgAkKD6LOF3p0X8giR1iVSiax3UKlWQ p/1n9cr6Gixiwv5DGb+aoLz6nq8cZMK7n9YLPxrIJz6uT2S2LedAHlYMfjT3aJXSN4wb /iJPP4fUrp9s5ZaNMxKknCUcHEY7jQQ5z4GjNaLBjJvAE9w5adtwx3hWt6dndPN3C3vz J42A== X-Gm-Message-State: AOAM531mOAxUYJlx07oZQW4jePH4iFe1DlTfKphuAT8QfxG8KPnaqCaE kZRyIVBuxuAvmL21EZ+z/lShX/jb7WHSihaZgac= X-Google-Smtp-Source: ABdhPJwzKLnpbfox0sDSvuGdrnejZzyMSdaeH3qDajNPZfOqhBl91IvDtoFs7yMoi6RVDtbbnTkdOdqVsXjYedjkTGM= X-Received: by 2002:a1c:7e43:: with SMTP id z64mr5526717wmc.72.1591132124302; Tue, 02 Jun 2020 14:08:44 -0700 (PDT) MIME-Version: 1.0 References: <20200602194137.30412-1-plattfot@gmail.com> <878sh5dykv.fsf@nicolasgoaziou.fr> In-Reply-To: <878sh5dykv.fsf@nicolasgoaziou.fr> From: Fredrik Salomonsson Date: Tue, 2 Jun 2020 14:08:33 -0700 Message-ID: Subject: Re: [bug#41671] [PATCH] gnu: Add emacs-glsl-mode To: Nicolas Goaziou Content-Type: multipart/alternative; boundary="0000000000000f50c005a7205126" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41671 Cc: 41671@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000000f50c005a7205126 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Nicolas, Den tis 2 juni 2020 kl 13:04 skrev Nicolas Goaziou = : > Nitpick: you need full stops at the end of each sentence in the commit > message. > > > + (sha256 > > + (base32 > > + "0bav9ipfm0vy26n74ngsmjzc7fsyqz6xmriadzx55s44h8p5dn1s")))) > > Nitpick: could you move the hash on the same line as `base32'? > > > + (build-system emacs-build-system) > > + (home-page > > + "https://github.com/jimhourihan/glsl-mode") > > Nitpick: could you move the URL on the same line as `home-page'? > > > + (synopsis > > + "Major mode for Open GLSL shader files") > > Nitpick: =E2=80=A6 guess what=E2=80=A6 ;) > > > + (description > > + "Major mode for editing OpenGLSL grammar files, usually files > ending with > > +`.vert', `.frag', `.glsl', `.geom'. > > This should be a complete sentence, e.g., > > The library provides a major mode=E2=80=A6 > > Note that Texinfo syntax for file extensions is @file, so the rest of > the sentence ought to be: > > files ending with @file{.vert}, @file{.frag}=E2=80=A6 > > > Is is based on c-mode plus some > > Typo and nitpick: "It is based on C mode" > > Could you send an updated patch? > Thank you for the speedy response. I sent in a new patch, which should fix all the things mentioned above. Let me know if it ended up in the right place. I'm pretty new with the git send-email workflow. --=20 s/Fred[re]+i[ck]+/Fredrik/g --0000000000000f50c005a7205126 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Nicolas,

Den tis 2 juni 2020 kl 13:04 skrev Nicolas Goaziou= <mail@nicol= asgoaziou.fr>:
Nitpick: you need full stops at the end of each sentence in the commit
message.

> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(sha256
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (base32
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"0bav9ipfm0vy26n74ngsmj= zc7fsyqz6xmriadzx55s44h8p5dn1s"))))

Nitpick: could you move the hash on the same line as `base32'?

> +=C2=A0 =C2=A0 =C2=A0 (build-system emacs-build-system)
> +=C2=A0 =C2=A0 =C2=A0 (home-page
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0"https://github.com/ji= mhourihan/glsl-mode")

Nitpick: could you move the URL on the same line as `home-page'?

> +=C2=A0 =C2=A0 =C2=A0 (synopsis
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0"Major mode for Open GLSL shader file= s")

Nitpick: =E2=80=A6 guess what=E2=80=A6 ;)

> +=C2=A0 =C2=A0 =C2=A0 (description
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0"Major mode for editing OpenGLSL gram= mar files, usually files ending with
> +`.vert', `.frag', `.glsl', `.geom'.

This should be a complete sentence, e.g.,

=C2=A0 The library provides a major mode=E2=80=A6

Note that Texinfo syntax for file extensions is @file, so the rest of
the sentence ought to be:

=C2=A0 files ending with @file{.vert}, @file{.frag}=E2=80=A6

> Is is based on c-mode plus some

Typo and nitpick: "It is based on C mode"

Could you send an updated patch?
Thank you for the speedy response. I sent in a new patch, whic= h should fix all the things mentioned above.
Let me know if it en= ded up in the right place. I'm pretty new with the git send-email workf= low.=C2=A0

--
s/Fred[re]+i[ck]+/Fredrik/g
--0000000000000f50c005a7205126-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 04 08:59:24 2020 Received: (at 41671-done) by debbugs.gnu.org; 4 Jun 2020 12:59:25 +0000 Received: from localhost ([127.0.0.1]:45419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgpSu-0002Vj-N4 for submit@debbugs.gnu.org; Thu, 04 Jun 2020 08:59:24 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:59093) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgpSt-0002VT-2n for 41671-done@debbugs.gnu.org; Thu, 04 Jun 2020 08:59:23 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id E4A7620011; Thu, 4 Jun 2020 12:59:15 +0000 (UTC) From: Nicolas Goaziou To: Fredrik Salomonsson Subject: Re: [bug#41671] [PATCH] gnu: Add emacs-glsl-mode. References: <20200602194137.30412-1-plattfot@gmail.com> <20200602210249.36527-1-plattfot@gmail.com> Date: Thu, 04 Jun 2020 14:59:14 +0200 In-Reply-To: <20200602210249.36527-1-plattfot@gmail.com> (Fredrik Salomonsson's message of "Tue, 2 Jun 2020 14:02:49 -0700") Message-ID: <87k10nrnq5.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41671-done Cc: 41671-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a duplicate of 41673. I'm closing it, too. From unknown Sat Jun 14 08:58:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 03 Jul 2020 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator