GNU bug report logs - #41649
27.0.91; beginning-of-defun doesn't work inside React markup in js-jsx-mode

Previous Next

Full log

Message #26 received at 41649 <at> debbugs.gnu.org (full text, mbox):

From: Alan Mackenzie <acm <at> muc.de>
To: Dmitry Gutov <dgutov <at> yandex.ru>, Brian Leung <bkleung89 <at> gmail.com>
Cc: 41649 <at> debbugs.gnu.org
Subject: Re: bug#41649: 27.0.91; beginning-of-defun doesn't work inside React
 markup in js-jsx-mode
Date: Thu, 4 Jun 2020 16:23:40 +0000

Hello, Dmitry and Brian.

On Wed, Jun 03, 2020 at 23:08:09 +0300, Dmitry Gutov wrote:
> On 03.06.2020 22:39, Alan Mackenzie wrote:
> > I'll get a patch onto the list as soon as I've got the time and energy to
> > check it over carefully.

> Thanks!

Would you please try out the following patch, which ought to fix the
problem the patch should fix.  Seeing as how it corrects the value of a
number of configuration variables (around fifteen), there might be
further incidental benefits.



diff --git a/lisp/progmodes/js.el b/lisp/progmodes/js.el
index 5ec3e94275..04b449ecd2 100644
--- a/lisp/progmodes/js.el
+++ b/lisp/progmodes/js.el
@@ -4591,7 +4591,6 @@ js-mode
   (setq imenu-create-index-function #'js--imenu-create-index)
 
   ;; for filling, pretend we're cc-mode
-  (c-init-language-vars js-mode)
   (setq-local comment-line-break-function #'c-indent-new-comment-line)
   (setq-local comment-multi-line t)
   (setq-local electric-indent-chars


It might well be too late to include this patch in the Emacs 27 release.
If you're reading this, Eli, what do you say?

-- 
Alan Mackenzie (Nuremberg, Germany).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.