GNU bug report logs - #41647
Binutils GAS testsuite errors with DejaGNU master

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41647 in the body.
You can then email your comments to 41647 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jozef Lawrynowicz <jozef.l <at> mittosystems.com>
To: bug-dejagnu <at> gnu.org
Subject: Binutils GAS testsuite errors with DejaGNU master
Date: Mon, 1 Jun 2020 15:50:45 +0100

I'm having problems running the binutils GAS testsuite for msp430-elf,
when using the latest DejaGNU master branch (commit d37c15b).
runtest reports that it cannot find the GAS tool config file.
It works if I check out dejagnu-1.6.2-release.

I have configured binutils with the following:
  ../configure --target=msp430-elf --disable-gdb --disable-sim \
    --disable-nls --enable-languages=c,c++

Then running
  make check-gas RUNTESTFLAGS=--target_board=msp430-sim

>                 === gas tests ===
>
> Schedule of variations:
>     msp430-sim
>
> Running target msp430-sim
> Using /usr/local/share/dejagnu/baseboards/msp430-sim.exp as board description file for target.
> Using /usr/local/share/dejagnu/config/sim.exp as generic interface file for target.
> Using /usr/local/share/dejagnu/baseboards/basic-sim.exp as board description file for target.
> WARNING: Couldn't find tool config file for sim, using default.
> WARNING: could not find testsuite; trying /home/jozef/msp430/binutils-gdb/gas/testsuite.
> Running /home/jozef/msp430/binutils-gdb/gas/testsuite/gas/aarch64/aarch64.exp ...
> Running /home/jozef/msp430/binutils-gdb/gas/testsuite/gas/all/gas.exp ...
> ERROR: (DejaGnu) proc "gas_test p2425.s {} {} {pcrel values in assignment}" does not exist.
> The error code is TCL LOOKUP COMMAND gas_test
> The info on the error is:
> invalid command name "gas_test"
>     while executing
> "::tcl_unknown gas_test p2425.s {} {} {pcrel values in assignment}"
>     ("uplevel" body line 1)
>     invoked from within
> "uplevel 1 ::tcl_unknown $args"

Meanwhile if I checkout dejagnu-1.6.2-release, reinstall DejaGNU, and run the
same command, the testsuite runs as expected.

>                 === gas tests ===
>
> Schedule of variations:
>     msp430-sim
>
> Running target msp430-sim
> Using /usr/local/share/dejagnu/baseboards/msp430-sim.exp as board description file for target.
> Using /usr/local/share/dejagnu/config/sim.exp as generic interface file for target.
> Using /usr/local/share/dejagnu/baseboards/basic-sim.exp as board description file for target.
> Using /home/jozef/msp430/binutils-gdb/gas/testsuite/config/default.exp as tool-and-target-specific interface file.
> Running /home/jozef/msp430/binutils-gdb/gas/testsuite/gas/aarch64/aarch64.exp ...
> Running /home/jozef/msp430/binutils-gdb/gas/testsuite/gas/all/gas.exp ...
> Running /home/jozef/msp430/binutils-gdb/gas/testsuite/gas/alpha/alpha.exp ...
> ....

Jozef

Message #8 received at 41647 <at> debbugs.gnu.org (full text, mbox):

From: Jacob Bachmeyer <jcb62281 <at> gmail.com>
To: Jozef Lawrynowicz <jozef.l <at> mittosystems.com>
Cc: 41647 <at> debbugs.gnu.org
Subject: Re: bug#41647: Binutils GAS testsuite errors with DejaGNU master
Date: Mon, 01 Jun 2020 22:11:23 -0500

Jozef Lawrynowicz wrote:
> I'm having problems running the binutils GAS testsuite for msp430-elf,
> when using the latest DejaGNU master branch (commit d37c15b).
> runtest reports that it cannot find the GAS tool config file.
> It works if I check out dejagnu-1.6.2-release.
>
> I have configured binutils with the following:
>   ../configure --target=msp430-elf --disable-gdb --disable-sim \
>     --disable-nls --enable-languages=c,c++
>   

I believe that I have found the cause of your problem, and it can only 
occur when the package is configured using a relative file name.  
Automake writes a "site.exp" file that sets srcdir to a relative name.  
This is then overridden on the command line with an absolute file name 
before changing the current directory to the testsuite directory in the 
build tree, but there is a long-standing issue in DejaGnu with 
"site.exp" overriding command line parameters during the window in which 
the tool init file is loaded.

An immediate workaround is to use an absolute file name when running 
configure.

> Meanwhile if I checkout dejagnu-1.6.2-release, reinstall DejaGNU, and run the
> same command, the testsuite runs as expected.
>   

Since 1.6.2, DejaGnu has become more strict about looking exactly where 
it is told to look for files as part of a general cleanup.  Cleaning up 
DejaGnu's own use of Automake probably fixed some unknown bug that was 
covering up this issue.

I have opened branch PR41647 for addressing this issue; so far, it 
contains two commits that add additional verbose output that made the 
cause of this issue obvious.  I am unsure about how aggressively the 
first command line parse should override site.exp and have opened a 
discussion on the DejaGnu mailing list.


-- Jacob

Message #11 received at 41647 <at> debbugs.gnu.org (full text, mbox):

From: Jacob Bachmeyer <jcb62281 <at> gmail.com>
To: Jozef Lawrynowicz <jozef.l <at> mittosystems.com>
Cc: 41647 <at> debbugs.gnu.org
Subject: Re: bug#41647: Binutils GAS testsuite errors with DejaGNU master
Date: Tue, 02 Jun 2020 22:51:16 -0500

I do not currently have a setup for testing cross-gas, but the bug is 
also confirmed to affect native builds.

A proposed patch is currently in testing and will be pushed to the 
PR41647 branch if the GAS testsuite passes for native x86-64 with it 
applied.

Message #14 received at 41647 <at> debbugs.gnu.org (full text, mbox):

From: Jacob Bachmeyer <jcb62281 <at> gmail.com>
To: Jozef Lawrynowicz <jozef.l <at> mittosystems.com>
Cc: 41647 <at> debbugs.gnu.org
Subject: Re: bug#41647: Binutils GAS testsuite errors with DejaGNU master
Date: Tue, 02 Jun 2020 22:56:08 -0500

The native x86-64 GAS testsuite has passed with DejaGnu commit 
5fafcd43b2d22b2227e62f7278584418c6449824 on PR41647.  Please confirm 
that this also fixes your cross-assembler tests.

Message #17 received at 41647 <at> debbugs.gnu.org (full text, mbox):

From: Jozef Lawrynowicz <jozef.l <at> mittosystems.com>
To: Jacob Bachmeyer <jcb62281 <at> gmail.com>
Cc: 41647 <at> debbugs.gnu.org
Subject: Re: bug#41647: Binutils GAS testsuite errors with DejaGNU master
Date: Wed, 3 Jun 2020 09:44:06 +0100

On Tue, Jun 02, 2020 at 10:56:08PM -0500, Jacob Bachmeyer wrote:
> The native x86-64 GAS testsuite has passed with DejaGnu commit
> 5fafcd43b2d22b2227e62f7278584418c6449824 on PR41647.  Please confirm that
> this also fixes your cross-assembler tests.

I can confirm that the patch fixes the GAS testsuite errors for
msp430-elf, and everything is working as expected.

Thanks!
Jozef

Message #20 received at 41647 <at> debbugs.gnu.org (full text, mbox):

From: Rob Savoye <rob <at> senecass.com>
To: Jozef Lawrynowicz <jozef.l <at> mittosystems.com>,
 Jacob Bachmeyer <jcb62281 <at> gmail.com>
Cc: 41647 <at> debbugs.gnu.org
Subject: Re: bug#41647: Binutils GAS testsuite errors with DejaGNU master
Date: Wed, 3 Jun 2020 08:02:49 -0600

On 6/3/20 2:44 AM, Jozef Lawrynowicz wrote:
> On Tue, Jun 02, 2020 at 10:56:08PM -0500, Jacob Bachmeyer wrote:
>> The native x86-64 GAS testsuite has passed with DejaGnu commit
>> 5fafcd43b2d22b2227e62f7278584418c6449824 on PR41647.  Please confirm that
>> this also fixes your cross-assembler tests.
> 
> I can confirm that the patch fixes the GAS testsuite errors for
> msp430-elf, and everything is working as expected.

  Thanks for testing this patch, and thanks Jacob for the bug fix. It's
now in master.

	- rob -

Message #25 received at 41647-done <at> debbugs.gnu.org (full text, mbox):

From: Jacob Bachmeyer <jcb62281 <at> gmail.com>
To: 41647-done <at> debbugs.gnu.org
Subject: Patch applied; closing bug
Date: Wed, 03 Jun 2020 15:22:41 -0500

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.