GNU bug report logs - #41636
[PATCH] combinators: Recurse fold2 to named let loop.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jakub Kądziołka <kuba <at> kadziolka.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#41636: closed ([PATCH] combinators: Recurse fold2 to named
 let loop.)
Date: Mon, 01 Jun 2020 12:59:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 1 Jun 2020 14:58:26 +0200
with message-id <20200601125826.2m7xnnzy2kogvbo7 <at> gravity>
and subject line Re: [PATCH] combinators: Recurse fold2 to named let loop.
has caused the debbugs.gnu.org bug report #41636,
regarding [PATCH] combinators: Recurse fold2 to named let loop.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
41636: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41636
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: guix-patches <at> gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH] combinators: Recurse fold2 to named let loop.
Date: Mon,  1 Jun 2020 05:41:13 +0530

* guix/combinators.scm (fold2): Recurse to named let loop, not fold2 itself.
---
 guix/combinators.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/guix/combinators.scm b/guix/combinators.scm
index 11cad62ccf..4707b59363 100644
--- a/guix/combinators.scm
+++ b/guix/combinators.scm
@@ -1,6 +1,7 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2012, 2013, 2014, 2015, 2016, 2017 Ludovic Courtès <ludo <at> gnu.org>
 ;;; Copyright © 2014 Eric Bavier <bavier <at> member.fsf.org>
+;;; Copyright © 2020 Arun Isaac <arunisaac <at> systemreboot.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -56,7 +57,7 @@
            (call-with-values
                (lambda () (proc (car lst1) (car lst2) result1 result2))
              (lambda (result1 result2)
-               (fold2 proc result1 result2 (cdr lst1) (cdr lst2)))))))))
+               (loop result1 result2 (cdr lst1) (cdr lst2)))))))))
 
 (define (fold-tree proc init children roots)
   "Call (PROC NODE RESULT) for each node in the tree that is reachable from
-- 
2.26.2

[Message part 3 (message/rfc822, inline)]

From: Jakub Kądziołka <kuba <at> kadziolka.net>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 41636-done <at> debbugs.gnu.org
Subject: Re: [PATCH] combinators: Recurse fold2 to named let loop.
Date: Mon, 1 Jun 2020 14:58:26 +0200

[Message part 4 (text/plain, inline)]

On Mon, Jun 01, 2020 at 05:41:13AM +0530, Arun Isaac wrote:
> * guix/combinators.scm (fold2): Recurse to named let loop, not fold2 itself.
> ---
>  guix/combinators.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Thanks for the patch! I agree that this is better for consistency, thus
I have pushed your patch as commit 7a99c58c4597a550703f32018efafb0fe84d5c72.

Cheers!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.