From debbugs-submit-bounces@debbugs.gnu.org Sun May 31 20:11:27 2020 Received: (at submit) by debbugs.gnu.org; 1 Jun 2020 00:11:27 +0000 Received: from localhost ([127.0.0.1]:34139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfY34-0003pl-Qr for submit@debbugs.gnu.org; Sun, 31 May 2020 20:11:27 -0400 Received: from lists.gnu.org ([209.51.188.17]:41094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfY32-0003pe-VJ for submit@debbugs.gnu.org; Sun, 31 May 2020 20:11:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39854) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jfY32-0004Zc-Q8 for guix-patches@gnu.org; Sun, 31 May 2020 20:11:24 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:53328) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jfY2z-0000ow-8u for guix-patches@gnu.org; Sun, 31 May 2020 20:11:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VyQNdAZcUHsMhOsUU9DXxTnoYrzc9I0TyibJbpGuf+Q=; b=dfVxLfed8xihUqmAJi9W8HXWHx p4SXWNfAwscac4petuW/ebi6lZbvA2SKmOsOrviNo4qyWF2PiRQwI37zkRda08Pmm74xVwd2SzKeU rnarEu59YbgHw/J1lCVEy6st0cpQg8l2m3Ng3ScAb4DKjOjjQ22YZe+iuZ6ZrDYvT7UE=; Received: from [192.168.2.1] (helo=steel.lan) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jfY2t-000Zlo-EE; Mon, 01 Jun 2020 05:41:15 +0530 From: Arun Isaac To: guix-patches@gnu.org Subject: [PATCH] combinators: Recurse fold2 to named let loop. Date: Mon, 1 Jun 2020 05:41:13 +0530 Message-Id: <20200601001113.10439-1-arunisaac@systemreboot.net> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=139.59.75.54; envelope-from=arunisaac@systemreboot.net; helo=mugam.systemreboot.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/31 20:00:35 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Arun Isaac X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * guix/combinators.scm (fold2): Recurse to named let loop, not fold2 itself. --- guix/combinators.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/guix/combinators.scm b/guix/combinators.scm index 11cad62ccf..4707b59363 100644 --- a/guix/combinators.scm +++ b/guix/combinators.scm @@ -1,6 +1,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2012, 2013, 2014, 2015, 2016, 2017 Ludovic Courtès ;;; Copyright © 2014 Eric Bavier +;;; Copyright © 2020 Arun Isaac ;;; ;;; This file is part of GNU Guix. ;;; @@ -56,7 +57,7 @@ (call-with-values (lambda () (proc (car lst1) (car lst2) result1 result2)) (lambda (result1 result2) - (fold2 proc result1 result2 (cdr lst1) (cdr lst2))))))))) + (loop result1 result2 (cdr lst1) (cdr lst2))))))))) (define (fold-tree proc init children roots) "Call (PROC NODE RESULT) for each node in the tree that is reachable from -- 2.26.2 From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 01 08:58:32 2020 Received: (at 41636-done) by debbugs.gnu.org; 1 Jun 2020 12:58:32 +0000 Received: from localhost ([127.0.0.1]:34778 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfk1P-0003ps-Vu for submit@debbugs.gnu.org; Mon, 01 Jun 2020 08:58:32 -0400 Received: from pat.zlotemysli.pl ([37.59.186.212]:52638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfk1O-0003pi-3p for 41636-done@debbugs.gnu.org; Mon, 01 Jun 2020 08:58:30 -0400 Received: (qmail 11473 invoked by uid 1009); 1 Jun 2020 14:58:28 +0200 Received: from 188.123.215.55 (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl (envelope-from , uid 1002) with qmail-scanner-2.08st (clamdscan: 0.98.6/25829. spamassassin: 3.4.0. perlscan: 2.08st. Clear:RC:1(188.123.215.55):. Processed in 0.036125 secs); 01 Jun 2020 12:58:28 -0000 Received: from unknown (HELO gravity) (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl with SMTP; 1 Jun 2020 14:58:27 +0200 Date: Mon, 1 Jun 2020 14:58:26 +0200 From: Jakub =?utf-8?B?S8SFZHppb8WCa2E=?= To: Arun Isaac Subject: Re: [PATCH] combinators: Recurse fold2 to named let loop. Message-ID: <20200601125826.2m7xnnzy2kogvbo7@gravity> References: <20200601001113.10439-1-arunisaac@systemreboot.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rq3bvscjbhwv6i63" Content-Disposition: inline In-Reply-To: <20200601001113.10439-1-arunisaac@systemreboot.net> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41636-done Cc: 41636-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --rq3bvscjbhwv6i63 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jun 01, 2020 at 05:41:13AM +0530, Arun Isaac wrote: > * guix/combinators.scm (fold2): Recurse to named let loop, not fold2 itself. > --- > guix/combinators.scm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Thanks for the patch! I agree that this is better for consistency, thus I have pushed your patch as commit 7a99c58c4597a550703f32018efafb0fe84d5c72. Cheers! --rq3bvscjbhwv6i63 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE5Xa/ss9usT31cTO54xWnWEYTFWQFAl7U+3IACgkQ4xWnWEYT FWSgxRAAlgxzYqL1eReWjMlesKyEEWy5DeCrW3PPpXrcBZBGVVc44+4dmdlBVLOz voxbIzhkMp3Hvie9h6A5t+eEfW1DzasQbP2ozNxjZL0/vUDyqcTfrNvX3wauonaw SEHDbOgFm1RvULpmLnVQvH804asJYkWuYUX8xwlN8er6C9JRxDKVuw7UENSdkhtf RfGJ4h8UjE9QoItTH2Duy436tTOYxDE2UuWK4aFsEfL0rtpVB1IOVlOktBe8ENak F0NP3iFDlQfcRum0ZUSYGpJlWELFnJrE3+9JmrWWmU8wvuo11/J8tgsyRqQI4Lsp EE+CeO0SDFva+lZwsCz8XtixLexyzyVXB1KpwP0YDd37Yj4q/u9p/IIB6ELr47Mm C8KpUWTC+7kb8bQBEN6V3xrpLTaAWR8rAglr/Dt+Oz+V1R9rOnVETvPSFr032IvX KTvcEqAtOp10fYm2Ei6Pf5zhnGXGKYsC/yRjgTbCxyzPSlP1kZjW/iIoH2GqIdow 7qQIy7lc03k0j0iSuotjIRasCHOwX1+CRyfci+6KIGtnsafVslTMJlGg+62Oq885 Aas+pMESqU8Qm/mVLmmdfdlK7DzoYwYvkw91pQb/M5eiTnZ9XadUpfz4PEbPOt5+ /opo/iYh9jVlTuM7toquUr/REDKPot1qIqP3xSEV92JycEdkBnI= =M7Xd -----END PGP SIGNATURE----- --rq3bvscjbhwv6i63-- From unknown Sun Jun 15 08:52:47 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 30 Jun 2020 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator