From debbugs-submit-bounces@debbugs.gnu.org Sun May 31 15:37:44 2020 Received: (at submit) by debbugs.gnu.org; 31 May 2020 19:37:44 +0000 Received: from localhost ([127.0.0.1]:33877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfTmC-0005m9-8m for submit@debbugs.gnu.org; Sun, 31 May 2020 15:37:44 -0400 Received: from lists.gnu.org ([209.51.188.17]:56098) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfTmA-0005m1-34 for submit@debbugs.gnu.org; Sun, 31 May 2020 15:37:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46060) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jfTm9-0007Hr-SL for bug-gnu-emacs@gnu.org; Sun, 31 May 2020 15:37:41 -0400 Received: from mout02.posteo.de ([185.67.36.142]:36773) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jfTm8-00049L-9c for bug-gnu-emacs@gnu.org; Sun, 31 May 2020 15:37:41 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 4A4A02400FB for ; Sun, 31 May 2020 21:37:35 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 49ZpVN4hPbz6tmc; Sun, 31 May 2020 21:37:32 +0200 (CEST) From: Andrew Schwartzmeyer Content-Type: multipart/mixed; boundary="Apple-Mail=_6E39C28F-00C9-48AF-9672-30D96097D832" Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Prompts incorrect for multi-occur and multi-isearch when using fido-mode Message-Id: <877C203C-84D6-4093-AC35-160A9FFCDF2D@schwartzmeyer.com> Date: Sun, 31 May 2020 12:37:29 -0700 To: bug-gnu-emacs@gnu.org X-Mailer: Apple Mail (2.3608.80.23.2.2) Received-SPF: pass client-ip=185.67.36.142; envelope-from=andrew@schwartzmeyer.com; helo=mout02.posteo.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/31 15:37:35 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: joaotavora@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --Apple-Mail=_6E39C28F-00C9-48AF-9672-30D96097D832 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 When fido-mode is enabled, you need to use M-j to end the selection, not = RET. This is similar to ido-mode, which was already special-cased for = multi-occur and multi-isearch-buffers. The attached patch fixes these two instances, however I=E2=80=99ve = discovered two more bugs while testing it. For one, M-j does NOT work in = multi-isearch-files, and I=E2=80=99m not sure why. It=E2=80=99s supposed = to work; it works for the other two. So I didn=E2=80=99t update the = prompt in that function (which, by the way is not special cased for = ido-mode, For two, the check for ido-mode is actually broken, but I don=E2=80=99t = yet know how to fix it. It does (eq read-buffer-function = #'ido-read-buffer), but actually nowadays (maybe this was different in = the past), ido-mode doesn=E2=80=99t set read-buffer-function, unless you = call ido-everywhere, and then it still doesn=E2=80=99t set it but = overrides it with an advice, so that its value is #f(advice-wrapper = :override nil ido-read-buffer), and this fails the eq test. Anyway, I=E2=80=99d suggest applying this patch for now, and then = figuring out how to fix the check for ido. Thanks, Andy --Apple-Mail=_6E39C28F-00C9-48AF-9672-30D96097D832 Content-Disposition: attachment; filename=0001-Fix-prompts-when-using-fido-mode.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Fix-prompts-when-using-fido-mode.patch" Content-Transfer-Encoding: quoted-printable =46rom=2086c663ae22845a075cea9216a4a5e053e6c16c04=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Andrew=20Schwartzmeyer=20= =0ADate:=20Sun,=2031=20May=202020=2011:56:01=20= -0700=0ASubject:=20[PATCH]=20Fix=20prompts=20when=20using=20fido-mode=0A=0A= When=20fido-mode=20is=20enabled,=20you=20need=20to=20use=20M-j=20to=20= end=20the=20selection,=20not=0ARET.=20This=20is=20similar=20to=20= ido-mode,=20which=20was=20already=20special-cased=20for=0Amulti-occur=20= and=20multi-isearch-buffers.=0A---=0A=20lisp/misearch.el=20|=2011=20= ++++++++---=0A=20lisp/replace.el=20=20|=2011=20++++++++---=0A=202=20= files=20changed,=2016=20insertions(+),=206=20deletions(-)=0A=0Adiff=20= --git=20a/lisp/misearch.el=20b/lisp/misearch.el=0Aindex=20= 958c10a1b..69ba77fea=20100644=0A---=20a/lisp/misearch.el=0A+++=20= b/lisp/misearch.el=0A@@=20-237,9=20+237,14=20@@=20set=20in=20= `multi-isearch-buffers'=20or=20`multi-isearch-buffers-regexp'."=0A=20=09=20= (ido-ignore-item-temp-list=20bufs))=0A=20=20=20=20=20(while=20(not=20= (string-equal=0A=20=09=09=20(setq=20buf=20(read-buffer=0A-=09=09=09=20=20= =20=20(if=20(eq=20read-buffer-function=20#'ido-read-buffer)=0A-=09=09=09=09= "Next=20buffer=20to=20search=20(C-j=20to=20end):=20"=0A-=09=09=09=20=20=20= =20=20=20"Next=20buffer=20to=20search=20(RET=20to=20end):=20")=0A+=09=09=09= =20=20=20=20(concat=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20"Next=20buffer=20to=20search=20"=0A+=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20(cond=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20((eq=20read-buffer-function=20= #'ido-read-buffer)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20"(C-j=20to=20end):=20")=0A+=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20((bound-and-true-p=20fido-mode)=0A+=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20"(M-j=20= to=20end):=20")=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20(t=20"(RET=20to=20end):=20")))=0A=20=09= =09=09=20=20=20=20nil=20t))=0A=20=09=09=20""))=0A=20=20=20=20=20=20=20= (add-to-list=20'bufs=20buf)=0Adiff=20--git=20a/lisp/replace.el=20= b/lisp/replace.el=0Aindex=2069092c16f..8cd92d894=20100644=0A---=20= a/lisp/replace.el=0A+++=20b/lisp/replace.el=0A@@=20-1585,9=20+1585,14=20= @@=20See=20also=20`multi-occur-in-matching-buffers'."=0A=20=09=20=20=20= (ido-ignore-item-temp-list=20bufs))=0A=20=20=20=20=20=20=20(while=20(not=20= (string-equal=0A=20=09=09=20=20=20(setq=20buf=20(read-buffer=0A-=09=09=09= =20=20=20=20=20=20(if=20(eq=20read-buffer-function=20#'ido-read-buffer)=0A= -=09=09=09=09=20=20"Next=20buffer=20to=20search=20(C-j=20to=20end):=20"=0A= -=09=09=09=09"Next=20buffer=20to=20search=20(RET=20to=20end):=20")=0A+=09= =09=09=20=20=20=20=20=20(concat=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20"Next=20buffer=20= to=20search=20"=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20(cond=0A+=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= ((eq=20read-buffer-function=20#'ido-read-buffer)=0A+=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20"(C-j=20to=20end):=20")=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20((bound-and-true-p=20= fido-mode)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20"(M-j=20to=20end):=20")=0A+=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(t=20"(RET=20to=20end):=20")))=0A=20=09=09=09=20=20=20=20=20=20= nil=20t))=0A=20=09=09=20=20=20""))=0A=20=09(cl-pushnew=20buf=20bufs)=0A= --=20=0A2.26.0=0A=0A= --Apple-Mail=_6E39C28F-00C9-48AF-9672-30D96097D832-- From debbugs-submit-bounces@debbugs.gnu.org Sun May 31 16:58:05 2020 Received: (at 41633) by debbugs.gnu.org; 31 May 2020 20:58:05 +0000 Received: from localhost ([127.0.0.1]:33962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfV1x-0007dv-Fh for submit@debbugs.gnu.org; Sun, 31 May 2020 16:58:05 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:40337) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfV1w-0007dS-JW for 41633@debbugs.gnu.org; Sun, 31 May 2020 16:58:04 -0400 Received: by mail-wm1-f68.google.com with SMTP id r15so9387466wmh.5 for <41633@debbugs.gnu.org>; Sun, 31 May 2020 13:58:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=wrCTXlgyydDtFi3igW2ZIB7cDB2+MGeXSMBqrk1wZAU=; b=sooJz665O9dRM8433TvTjulIWEBvHKjWmDmsBe1clIbZVqeEt9fp6sPqB8F6gugGyM 7uQwMaepBAs0y6XqognW1GN7vnb32oJ3xdjWHwcG8IsqtJy2GBD9GHf7CGO4kyRJI0if C67mRP/jTgL+zJbKRsQBGH7xr821+iwtm5Oq+jEknGvlXs1meZX7CCsK2eUDTzG1Yd5P 2sTiZfz/p62LqBw9d7A7cf8VDRbTIp9FBrnXnsu+U01h3ozScgo4vC3m2sSA0A7n7337 ltemamRNA7DHzZbQtnB0mIP8/5Yt7r4VT3EDKJ5ZjpFy3cd8QI0uUH0dp0XUi08vS2qj s/kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=wrCTXlgyydDtFi3igW2ZIB7cDB2+MGeXSMBqrk1wZAU=; b=dKdbAmG0dPJ7EsTumKPogs3OOhIR6la+4J2UItah3b9PE08dSA9ADD5x1VwphaF/1t cQhdLH9QWW6iqkBAB/pKiJGbwbJ6EPWGLd+d/Bz9g1swBPIGJvGj6BkHoonD+y4sIKHN BsfViD3xg1XoiKVf1XgHBnXbwD6vJSh4sAidxIVCiiyLMr4BTmtkOJWHX5O2l6VsvJFp DF1dzTZbBOVB4FIh+mQJSjLroyysCoBlRAxOrAYq3OkcQjn9zJXCEIib1qUDY/LtEylL vzPjz/TRl1ivJBEHB8OVRZ2PXdk4oGt9EyfklDneWFKgYHrWsiLQ0ALSj61axSb5L0lm Mr9w== X-Gm-Message-State: AOAM533XAi4+LhopNCJAO1YsLs8BlhtLlVezm1y9ENtUsS95Bhp/DqnY fVd0/fRfVCRGMZwlUkygKS6weWRWJHU= X-Google-Smtp-Source: ABdhPJzKvckWz0Fz9oXaLVx6qG/qHZ/pO/+05AXODpONSBNI8Wc9VuGmKx/Wui74KUf7G1mHBRmmuw== X-Received: by 2002:a7b:c0c8:: with SMTP id s8mr19345000wmh.134.1590958678386; Sun, 31 May 2020 13:57:58 -0700 (PDT) Received: from krug (89-180-149-156.net.novis.pt. [89.180.149.156]) by smtp.gmail.com with ESMTPSA id l17sm8353816wmi.3.2020.05.31.13.57.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 31 May 2020 13:57:57 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Andrew Schwartzmeyer Subject: Re: bug#41633: Prompts incorrect for multi-occur and multi-isearch when using fido-mode References: <877C203C-84D6-4093-AC35-160A9FFCDF2D@schwartzmeyer.com> Date: Sun, 31 May 2020 21:57:55 +0100 In-Reply-To: <877C203C-84D6-4093-AC35-160A9FFCDF2D@schwartzmeyer.com> (Andrew Schwartzmeyer's message of "Sun, 31 May 2020 12:37:29 -0700") Message-ID: <87zh9nn7os.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41633 Cc: 41633@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Andrew Schwartzmeyer writes: > Anyway, I=E2=80=99d suggest applying this patch for now, and then figurin= g out > how to fix the check for ido. Hi Andrew, Thanks for the report. I don't have anything to comment here specifically, since I'm not familiar with the modes that you propose patching, so let's wait for someone more knowledgeable with those modes. However, at first sight, it doesn't seem to be particularly off the mark, except that a user might change that binding and break it. Maybe a better, more generic fix would be ask the current minibuffer for the answer, perhaps by searching the keymap for the keybinding that maps to a command symbol that has a certain property set on it (and then fido-mode and ido-mode would play ball). But maybe that's too complex... Jo=C3=A3o PS: It's fine to include me in your bug report to call my attention (indeed I encourage you to do so). However, the manner in which you must do so is a bit counter-intuitive: you should avoid "CC:" in the mail you send to bug-gnu-emacs@gnu.org, because if you do and I then "reply to all", it'll just cause another bug report, and not the effect you intend. If your mail client allows it, use "X-Debbugs-CC:" instead. Alternatively, you can forward me the email that you get (usually within minutes) from @debbugs.gnu.org. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 01 19:03:03 2020 Received: (at 41633) by debbugs.gnu.org; 1 Jun 2020 23:03:03 +0000 Received: from localhost ([127.0.0.1]:37283 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jftSR-0004Gd-Bo for submit@debbugs.gnu.org; Mon, 01 Jun 2020 19:03:03 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:44011) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jftSP-0004Fo-55 for 41633@debbugs.gnu.org; Mon, 01 Jun 2020 19:03:01 -0400 X-Originating-IP: 91.129.108.6 Received: from mail.gandi.net (m91-129-108-6.cust.tele2.ee [91.129.108.6]) (Authenticated sender: juri@linkov.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 063751C0002; Mon, 1 Jun 2020 23:02:53 +0000 (UTC) From: Juri Linkov To: =?iso-8859-1?Q?Jo=E3o_T=E1vora?= Subject: Re: bug#41633: Prompts incorrect for multi-occur and multi-isearch when using fido-mode Organization: LINKOV.NET References: <877C203C-84D6-4093-AC35-160A9FFCDF2D@schwartzmeyer.com> <87zh9nn7os.fsf@gmail.com> Date: Tue, 02 Jun 2020 01:49:46 +0300 In-Reply-To: <87zh9nn7os.fsf@gmail.com> (=?iso-8859-1?Q?=22Jo=E3o_T=E1vora?= =?iso-8859-1?Q?=22's?= message of "Sun, 31 May 2020 21:57:55 +0100") Message-ID: <87eeqys8ol.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41633 Cc: Andrew Schwartzmeyer , 41633@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Thanks for the report. I don't have anything to comment here > specifically, since I'm not familiar with the modes that you propose > patching, so let's wait for someone more knowledgeable with those modes. I don't know who is more knowledgeable since I just blindly copied that ugly ‘(eq read-buffer-function #'ido-read-buffer)’ from multi-occur to multi-isearch-read-buffers. Also I see that the patch that Andrew sent works fine in multi-isearch-files. > However, at first sight, it doesn't seem to be particularly off the > mark, except that a user might change that binding and break it. Maybe > a better, more generic fix would be ask the current minibuffer for the > answer, perhaps by searching the keymap for the keybinding that maps to > a command symbol that has a certain property set on it (and then > fido-mode and ido-mode would play ball). But maybe that's too > complex... Something like this is needed indeed, not too complicated. If it's not easy to just rephrase the prompt to avoid mentions of the key, then I suggest to display the string returned from (substitute-command-keys "(\\[exit-minibuffer] to end): ") called in the minibuffer. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 27 09:34:11 2020 Received: (at 41633) by debbugs.gnu.org; 27 Sep 2020 13:34:11 +0000 Received: from localhost ([127.0.0.1]:48694 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMWod-0003kc-48 for submit@debbugs.gnu.org; Sun, 27 Sep 2020 09:34:11 -0400 Received: from quimby.gnus.org ([95.216.78.240]:37484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMWoZ-0003kN-WE for 41633@debbugs.gnu.org; Sun, 27 Sep 2020 09:34:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=M3qY5bG7gJAvF48NU5rUPKVWS8WwtSSUoAzaYQOx9sk=; b=RvUkEOhi/qlWS9IYN+3M1S/mm6 SvN8TIi6OQT/X93mNzgVJnkT7gLBiAlnOWpJW9jBf9WSSYCcoabvbMm80lhHZw0cC88IrfNuGHHnN CrP8UnE54UuApdLG031f6MTWwe/v4bcTy1W1RmreFd9p0/oEgpDz40M7EB3oL+6yCXx8=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kMWoP-0004Rj-Hj; Sun, 27 Sep 2020 15:34:00 +0200 From: Lars Ingebrigtsen To: Juri Linkov Subject: Re: bug#41633: Prompts incorrect for multi-occur and multi-isearch when using fido-mode References: <877C203C-84D6-4093-AC35-160A9FFCDF2D@schwartzmeyer.com> <87zh9nn7os.fsf@gmail.com> <87eeqys8ol.fsf@mail.linkov.net> X-Now-Playing: Mia Doi Todd's _Come Out Of Your Mine_: "Your Room" Date: Sun, 27 Sep 2020 15:33:55 +0200 In-Reply-To: <87eeqys8ol.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 02 Jun 2020 01:49:46 +0300") Message-ID: <87d0272vjw.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Juri Linkov writes: > Something like this is needed indeed, not too complicated. > If it's not easy to just rephrase the prompt to avoid mentions of > the key, then I suggest to display the string returned from > > (subs [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41633 Cc: Andrew Schwartzmeyer , 41633@debbugs.gnu.org, =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: > Something like this is needed indeed, not too complicated. > If it's not easy to just rephrase the prompt to avoid mentions of > the key, then I suggest to display the string returned from > > (substitute-command-keys "(\\[exit-minibuffer] to end): ") > > called in the minibuffer. Here's a stupid question -- how do you do that? :-) I looked around for a primitive to eval something in the minibuffer, but I can't find one. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 30 15:19:45 2020 Received: (at 41633) by debbugs.gnu.org; 30 Sep 2020 19:19:45 +0000 Received: from localhost ([127.0.0.1]:33168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNhdg-00039n-VK for submit@debbugs.gnu.org; Wed, 30 Sep 2020 15:19:45 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:59933) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNhdU-00038x-OV for 41633@debbugs.gnu.org; Wed, 30 Sep 2020 15:19:33 -0400 Received: from mail.gandi.net (m91-129-108-13.cust.tele2.ee [91.129.108.13]) (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id D2B01100009; Wed, 30 Sep 2020 19:19:24 +0000 (UTC) From: Juri Linkov To: Lars Ingebrigtsen Subject: Re: bug#41633: Prompts incorrect for multi-occur and multi-isearch when using fido-mode References: <877C203C-84D6-4093-AC35-160A9FFCDF2D@schwartzmeyer.com> <87zh9nn7os.fsf@gmail.com> <87eeqys8ol.fsf@mail.linkov.net> <87d0272vjw.fsf@gnus.org> Date: Wed, 30 Sep 2020 22:08:30 +0300 In-Reply-To: <87d0272vjw.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 27 Sep 2020 15:33:55 +0200") Message-ID: <87r1qjf6u1.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41633 Cc: Andrew Schwartzmeyer , 41633@debbugs.gnu.org, =?iso-8859-1?Q?Jo=E3o_T=E1vora?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Something like this is needed indeed, not too complicated. >> If it's not easy to just rephrase the prompt to avoid mentions of >> the key, then I suggest to display the string returned from >> >> (substitute-command-keys "(\\[exit-minibuffer] to end): ") >> >> called in the minibuffer. > > Here's a stupid question -- how do you do that? :-) I looked around for > a primitive to eval something in the minibuffer, but I can't find one. Sorry, I meant just (substitute-command-keys "(\\\\[icomplete-fido-exit] to end): ") => "(M-j to end): " not necessarily called in the minibuffer, but with the minibuffer's keymap. A more complex solution like proposed by João would be to set a certain property set on a command's symbol that exits the minibuffer. But maybe 'cond' in Andrew's path with an additional substitute-command-keys (for the case when the user remaps the default keys) is fine. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 30 21:03:30 2020 Received: (at 41633) by debbugs.gnu.org; 1 Oct 2020 01:03:31 +0000 Received: from localhost ([127.0.0.1]:33426 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNn0M-0002uc-N8 for submit@debbugs.gnu.org; Wed, 30 Sep 2020 21:03:30 -0400 Received: from quimby.gnus.org ([95.216.78.240]:51822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNn0J-0002uL-OU for 41633@debbugs.gnu.org; Wed, 30 Sep 2020 21:03:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=g76en1hQnt2e6VYfz48UwEBM52YtdVHvJlsf27K3DfE=; b=R7CBph34KV/RKiYgF7qdXLP6az Rh1iJc28FTY8UTlUrVM69CbwEzPVr5+cPoovX36QmlK0ZmrVy/dNr9ZP86H1JT67QNQopOq/xFAn5 QhYvQ4r+nJgqH6I8p5+7+AfHzUiA3SuswhojIs7IL91dLxwgRxUA3feH6DA9PTFhxvJw=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNn08-0008Lv-Oo; Thu, 01 Oct 2020 03:03:21 +0200 From: Lars Ingebrigtsen To: Juri Linkov Subject: Re: bug#41633: Prompts incorrect for multi-occur and multi-isearch when using fido-mode References: <877C203C-84D6-4093-AC35-160A9FFCDF2D@schwartzmeyer.com> <87zh9nn7os.fsf@gmail.com> <87eeqys8ol.fsf@mail.linkov.net> <87d0272vjw.fsf@gnus.org> <87r1qjf6u1.fsf@mail.linkov.net> X-Now-Playing: Max Tundra's _Mastered By Guy At The Exchange_: "Cabasa" Date: Thu, 01 Oct 2020 03:03:15 +0200 In-Reply-To: <87r1qjf6u1.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 30 Sep 2020 22:08:30 +0300") Message-ID: <87v9fuwyek.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Juri Linkov writes: > Sorry, I meant just > > (substitute-command-keys > "(\\\\[icomplete-fido-exit] to end): ") > => "(M-j to end): " > > not necessarily called in the minibuffer, but with the m [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41633 Cc: Andrew Schwartzmeyer , 41633@debbugs.gnu.org, =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: > Sorry, I meant just > > (substitute-command-keys > "(\\\\[icomplete-fido-exit] to end): ") > => "(M-j to end): " > > not necessarily called in the minibuffer, but with the minibuffer's keymap. Ah, I'd forgotten about the \\ construct. And then the actual minibuffer map isn't relevant... or is it? Anyway, I factored this out into multi-occur--prompt (and used it from both call sites), and it seems to work well for me in both fido and ido modes when calling multi-occur. Pushed to Emacs 28 now. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 30 21:03:36 2020 Received: (at control) by debbugs.gnu.org; 1 Oct 2020 01:03:36 +0000 Received: from localhost ([127.0.0.1]:33429 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNn0R-0002ut-Up for submit@debbugs.gnu.org; Wed, 30 Sep 2020 21:03:36 -0400 Received: from quimby.gnus.org ([95.216.78.240]:51838) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNn0P-0002uT-G2 for control@debbugs.gnu.org; Wed, 30 Sep 2020 21:03:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=iZNfpzF7NZCckg+oQCAqNMNfaPQGyEmnIffXdTzWzZo=; b=c917VdJIEs+d4cvl7tFS4hmgPz wL59k52FkaGyCv6nrlLKg0FibGvH5HvfJEkDGH+rtK8n8VYMT/zwPgdV9YX4ZydX5vTrfRh7SVFV/ gW8FffKvC5MnCPexKUi03u17H8z6JC2V7VQQ22xE/IXk2rTOwDRA+3OVh02EM9JA5QHk=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNn0H-0008MA-Pq for control@debbugs.gnu.org; Thu, 01 Oct 2020 03:03:27 +0200 Date: Thu, 01 Oct 2020 03:03:24 +0200 Message-Id: <87tuvewyeb.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #41633 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 41633 fixed close 41633 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 41633 fixed close 41633 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 04 15:46:37 2020 Received: (at 41633) by debbugs.gnu.org; 4 Oct 2020 19:46:37 +0000 Received: from localhost ([127.0.0.1]:46826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kP9xs-0002Lj-Rl for submit@debbugs.gnu.org; Sun, 04 Oct 2020 15:46:37 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:46853) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kP9xq-0002LR-LO; Sun, 04 Oct 2020 15:46:35 -0400 Received: from mail.gandi.net (m91-129-108-13.cust.tele2.ee [91.129.108.13]) (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id CE6B1100002; Sun, 4 Oct 2020 19:46:25 +0000 (UTC) From: Juri Linkov To: Andrew Schwartzmeyer Subject: Re: bug#41633: Prompts incorrect for multi-occur and multi-isearch when using fido-mode References: <877C203C-84D6-4093-AC35-160A9FFCDF2D@schwartzmeyer.com> Date: Sun, 04 Oct 2020 22:31:09 +0300 In-Reply-To: <877C203C-84D6-4093-AC35-160A9FFCDF2D@schwartzmeyer.com> (Andrew Schwartzmeyer's message of "Sun, 31 May 2020 12:37:29 -0700") Message-ID: <87a6x4wxbm.fsf@linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41633 Cc: 41633@debbugs.gnu.org, joaotavora@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit reopen 41633 quit > For two, the check for ido-mode is actually broken, but I don’t yet know > how to fix it. It does (eq read-buffer-function #'ido-read-buffer), but > actually nowadays (maybe this was different in the past), ido-mode doesn’t > set read-buffer-function, unless you call ido-everywhere, and then it still > doesn’t set it but overrides it with an advice, so that its value is > #f(advice-wrapper :override nil ido-read-buffer), and this fails the > eq test. > > Anyway, I’d suggest applying this patch for now, and then figuring out > how to fix the check for ido. I confirm it doesn't work with ido-everywhere. Maybe this is a better condition? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=ido-everywhere.patch diff --git a/lisp/replace.el b/lisp/replace.el index 4883ecfc8f..b717a2a25c 100644 --- a/lisp/replace.el +++ b/lisp/replace.el @@ -1588,7 +1588,7 @@ multi-occur--prompt (concat "Next buffer to search " (cond - ((eq read-buffer-function #'ido-read-buffer) + ((bound-and-true-p ido-everywhere) (substitute-command-keys "(\\\\[ido-select-text] to end): ")) ((bound-and-true-p fido-mode) --=-=-=-- From unknown Fri Jun 20 07:16:55 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug No longer marked as fixed in versions 28.1 and reopened. Date: Sun, 04 Oct 2020 19:47:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug No longer marked as fixed in versions 28.1 and reopened. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 05 02:36:26 2020 Received: (at 41633) by debbugs.gnu.org; 5 Oct 2020 06:36:26 +0000 Received: from localhost ([127.0.0.1]:47542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPK6k-0003mz-9Z for submit@debbugs.gnu.org; Mon, 05 Oct 2020 02:36:26 -0400 Received: from quimby.gnus.org ([95.216.78.240]:45306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPK6h-0003mk-MO for 41633@debbugs.gnu.org; Mon, 05 Oct 2020 02:36:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZBb+5yN8oFYPTvVZgcE8sOku4f38CpsLW9WdnTf/11o=; b=hMyjGag+I5V0J5aYHK0KhLBJAe diabcPlhs/o1JS8O+yQ/rwCq/Pv6NS4XXlp0tmPLCysOhUy+HqyG049Mkq5CEOoxvKZWxxAyMc85f V6Ab1ObICOaYddRjyEjKOblAVvd8ak2Lsmb80cFp9w/QmC43G/TzxhX7QFlUBbhSDbl4=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kPK6U-0004R1-Qx; Mon, 05 Oct 2020 08:36:16 +0200 From: Lars Ingebrigtsen To: Juri Linkov Subject: Re: bug#41633: Prompts incorrect for multi-occur and multi-isearch when using fido-mode References: <877C203C-84D6-4093-AC35-160A9FFCDF2D@schwartzmeyer.com> <87a6x4wxbm.fsf@linkov.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEXSRjLjSjSrPDBW JyPWa1fbi3PkvLT///+l+FD6AAAAAWJLR0QHFmGI6wAAAAd0SU1FB+QKBQYhMJKkQloAAAGnSURB VDjL1ZLNbusgEIWJZbJOq3ZPh2ZfgdQ1aQevfW8Z1lEFvP8jdLCJY1v3PkAnSqScj/nhDEL8kjj9 R+9ACPvyD/BoTgcLe/VQgTbavm3FQ6c02BpmpWshZtHqDdB2HbdSB7xUYKavtmppHkuegDadUvz/ oemylPIF50iujrCKgUGuP2U3fowMql7SFjQ5ib44IVQHrfkxYc0p7NPrtwKAroGI5Dkl8UkgtaqU EJETrtOhanDT+wq4lKfAA7IxG1ByDODHCjalfBYJwPgKOlCtEXmMbvg0oM8uik6JNq6MwSXpreWh 3OqGfb3bmKRhHfAaF1QdHND5CVTDXAPH6qAUDPhTDRiXUhS875+BH4HJREuGGIKQvpefvKf3hJTX N5Ee8S+vcChj7zZAIg4f9jyUP9uF9M8BXcz5mN0OhIDY4xjDab9cj56iK5dFoSmBClvs03E10WQA xRKQKK/fQprd4sPo2xLnuM7gym8rFxrvYJyfzygQqWR8WsZ1dcEyc39uwU7dU/S8RsnuMQh3ADPw xKNtQDcDanHX2+Jv4LQvdQO3qX4A+7+AFHeY4dQAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjAtMTAt MDVUMDY6MzM6NDgrMDA6MDB2N8LgAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIwLTEwLTA1VDA2OjMz OjQ4KzAwOjAwB2p6XAAAAABJRU5ErkJggg== X-Now-Playing: Stereolab's _Margerine Eclipse_: "La Demeure" Date: Mon, 05 Oct 2020 08:36:07 +0200 In-Reply-To: <87a6x4wxbm.fsf@linkov.net> (Juri Linkov's message of "Sun, 04 Oct 2020 22:31:09 +0300") Message-ID: <877ds5rxgo.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Juri Linkov writes: > I confirm it doesn't work with ido-everywhere. > Maybe this is a better condition? > > diff --git a/lisp/replace.el b/lisp/replace.el > index 4883ecfc8f..b717a2a25c 100644 > --- a/lisp/replace.el > [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41633 Cc: Andrew Schwartzmeyer , 41633@debbugs.gnu.org, joaotavora@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: > I confirm it doesn't work with ido-everywhere. > Maybe this is a better condition? > > diff --git a/lisp/replace.el b/lisp/replace.el > index 4883ecfc8f..b717a2a25c 100644 > --- a/lisp/replace.el > +++ b/lisp/replace.el > @@ -1588,7 +1588,7 @@ multi-occur--prompt > (concat > "Next buffer to search " > (cond > - ((eq read-buffer-function #'ido-read-buffer) > + ((bound-and-true-p ido-everywhere) Makes sense, I think -- I think pretty much the only way to have ido enabled in these two functions is to have ido-anywhere enabled? On the other hand, perhaps somebody bound read-buffer-function "manually" here, so perhaps something like (or (eq read-buffer-function #'ido-read-buffer) (bound-and-true-p ido-everywhere)) would be slightly more correct? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 06 14:38:19 2020 Received: (at 41633) by debbugs.gnu.org; 6 Oct 2020 18:38:19 +0000 Received: from localhost ([127.0.0.1]:54136 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPrqs-0004US-VS for submit@debbugs.gnu.org; Tue, 06 Oct 2020 14:38:19 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:34443) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPrqq-0004Tp-BX; Tue, 06 Oct 2020 14:38:17 -0400 Received: from mail.gandi.net (m91-129-102-160.cust.tele2.ee [91.129.102.160]) (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 07613100005; Tue, 6 Oct 2020 18:38:07 +0000 (UTC) From: Juri Linkov To: Lars Ingebrigtsen Subject: Re: bug#41633: Prompts incorrect for multi-occur and multi-isearch when using fido-mode Organization: LINKOV.NET References: <877C203C-84D6-4093-AC35-160A9FFCDF2D@schwartzmeyer.com> <87a6x4wxbm.fsf@linkov.net> <877ds5rxgo.fsf@gnus.org> Date: Tue, 06 Oct 2020 21:36:35 +0300 In-Reply-To: <877ds5rxgo.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 05 Oct 2020 08:36:07 +0200") Message-ID: <87sgar8amk.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41633 Cc: Andrew Schwartzmeyer , 41633@debbugs.gnu.org, joaotavora@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) tags 41633 fixed close 41633 28.0.50 quit >> @@ -1588,7 +1588,7 @@ multi-occur--prompt >> (concat >> "Next buffer to search " >> (cond >> - ((eq read-buffer-function #'ido-read-buffer) >> + ((bound-and-true-p ido-everywhere) > > Makes sense, I think -- I think pretty much the only way to have ido > enabled in these two functions is to have ido-anywhere enabled? On the > other hand, perhaps somebody bound read-buffer-function "manually" here, > so perhaps something like > > (or (eq read-buffer-function #'ido-read-buffer) > (bound-and-true-p ido-everywhere)) > > would be slightly more correct? Ok, let's use both. So closing this again. From unknown Fri Jun 20 07:16:55 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 04 Nov 2020 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator