From unknown Sat Jun 21 12:34:55 2025 X-Loop: help-debbugs@gnu.org Subject: bug#41622: [PATCH] tests: Change gnulib commit to compile make check Resent-From: Colton Lewis Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 30 May 2020 23:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 41622 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: 41622@debbugs.gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159088093222255 (code B ref -1); Sat, 30 May 2020 23:23:02 +0000 Received: (at submit) by debbugs.gnu.org; 30 May 2020 23:22:12 +0000 Received: from localhost ([127.0.0.1]:59417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfAnr-0005mt-QN for submit@debbugs.gnu.org; Sat, 30 May 2020 19:22:12 -0400 Received: from lists.gnu.org ([209.51.188.17]:44118) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfAjg-0005gK-CS for submit@debbugs.gnu.org; Sat, 30 May 2020 19:17:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52638) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jfAjg-0004e9-6Z for bug-coreutils@gnu.org; Sat, 30 May 2020 19:17:52 -0400 Received: from mail-yb1-xb44.google.com ([2607:f8b0:4864:20::b44]:35561) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jfAjf-0004Mu-Dc for bug-coreutils@gnu.org; Sat, 30 May 2020 19:17:51 -0400 Received: by mail-yb1-xb44.google.com with SMTP id v15so3177248ybk.2 for ; Sat, 30 May 2020 16:17:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=BwjyR5d40hhx1GJJekN1CyQhXrhZzdFJb1pl6GV3HRw=; b=fj3+WJGLGfGA+aEEVwJHkc8loQIEqCPxH4gTfgiB89Eeqx1XoLGcoSi2GzWNDaai2l 7h6ePpd2WgmLSIgvl/lOZTpz6yNHHquv2HECI66+LjvLFESInFZRhhmbWKkQrw2C8/at 4uf8Ny9vhR4Q7quSMwQR4f492ZXPiAVONhK3pePe0hy5d7Qqp7OEN9KFZoo8w69hV35d Sq0D1846+qANrqNzRIn5hCtMs/F+edx3dnL0qghscsjJVh+NEc9UApOZ1ifnKoTzpGkv 4HGupqVrEgzvemLf7SgVdbKscCW1IOoE1htt6oPoAoHZWU0FcFAbaK7oZgwzMvDNjGXv gAag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=BwjyR5d40hhx1GJJekN1CyQhXrhZzdFJb1pl6GV3HRw=; b=gfRdKyVVg+r/N2NnSZPUpleS1O4W9pjUIEg+Axwx7P+KSzSYnspURBRYIxeEgZ7Or/ tMHTuJGZLBCVW/9JauMDYRg6GpRhNlKay5VHj4xecIbKrH+bVlaB8RddP8tWh8XaUMZc y6KKmLW1oQ+MgAPV9C2a5v7i4ApnMl4X+GiQaBgDss3i863c2RApFwFsdML/LdWy6mlL /MLrN7BEl7UGooDGVJqnyA51eq+bgSigK6N7QAWniImJPPZ8MGUZaO27yECJoM59jOfR KeJrGOmMSKS56aCvkXwftGLH6gNM5+GrOlfmbDdgUM2l2g2+d90jpvGtgutEBlvCpNQ9 T6ZQ== X-Gm-Message-State: AOAM533lD+225B7Fv4d7YWT7blCWl/i9JIg/thEmdqHZpcrrP0j8Lkqv 6R+9CbPMZUBzCqHcpjZDNZOKGfSgw0jexh9Myw+pg/E3TQ== X-Google-Smtp-Source: ABdhPJwFaD1YKzPPA8CC2b3BxMxru7YXErqAtHIrdAe4CWNVSx62dXK6Eo9OAFskJo0VozvQD0Y/8J1NUvQ6fVjzW3c= X-Received: by 2002:a5b:10:: with SMTP id a16mr14325504ybp.262.1590880669778; Sat, 30 May 2020 16:17:49 -0700 (PDT) MIME-Version: 1.0 From: Colton Lewis Date: Sat, 30 May 2020 18:17:23 -0500 Message-ID: Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::b44; envelope-from=colton.w.lewis@gmail.com; helo=mail-yb1-xb44.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: 0.4 (/) X-Mailman-Approved-At: Sat, 30 May 2020 19:22:10 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) When I ran make check after building the master branch commit aefd434e, I got a compilation error. test-explicit_bzero.c:132:1: error: no previous declaration for 'do_secret_stuff' [-Werror=missing-declarations] 132 | do_secret_stuff (volatile int pass) | ^~~~~~~~~~~~~~~ test-explicit_bzero.c:148:1: error: no previous declaration for 'test_stack' [-Werror=missing-declarations] 148 | test_stack (void) | ^~~~~~~~~~ I noticed the gnulib repo had a detached HEAD at b3c04ecec. I tried switching the gnulib repo to master and running make check again. I got a different error. test-sameacls.c: In function 'main': test-sameacls.c:58:17: error: too many arguments to function 'read_file' 58 | contents1 = read_file (file1, 0, &size1); | ^~~~~~~~~ In file included from test-sameacls.c:36: ../lib/read-file.h:29:14: note: declared here 29 | extern char *read_file (const char *filename, size_t * length); | ^~~~~~~~~ test-sameacls.c:65:17: error: too many arguments to function 'read_file' 65 | contents2 = read_file (file2, 0, &size2); | ^~~~~~~~~ In file included from test-sameacls.c:36: ../lib/read-file.h:29:14: note: declared here 29 | extern char *read_file (const char *filename, size_t * length); | ^~~~~~~~~ Here, coreutils and gnulib having conflicting declarations of read_file and the wrong one is included. This may require future changes. Poking around in the git logs for gnulib, I found commit a305580f, which fixes the first problem before introducing the second. File test-explicit_bzero.c now declares do_secret_stuff and test_stack static to appease -Werror=missing-declarations. --- gnulib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnulib b/gnulib index b3c04ecec..a305580f0 160000 --- a/gnulib +++ b/gnulib @@ -1 +1 @@ -Subproject commit b3c04ecec58ea687423f5c709410e6ecee4abd9b +Subproject commit a305580f09ada2674c0509389b1674c7b32dce67 -- 2.26.2 From unknown Sat Jun 21 12:34:55 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Colton Lewis Subject: bug#41622: closed (Re: bug#41622: [PATCH] tests: Change gnulib commit to compile make check) Message-ID: References: <4f363ddd-bfc9-e758-60a1-b55df07c3b95@cs.ucla.edu> X-Gnu-PR-Message: they-closed 41622 X-Gnu-PR-Package: coreutils X-Gnu-PR-Keywords: patch Reply-To: 41622@debbugs.gnu.org Date: Mon, 01 Jun 2020 06:33:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1590993183-18806-1" This is a multi-part message in MIME format... ------------=_1590993183-18806-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #41622: [PATCH] tests: Change gnulib commit to compile make check which was filed against the coreutils package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 41622@debbugs.gnu.org. --=20 41622: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D41622 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1590993183-18806-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 41622-done) by debbugs.gnu.org; 1 Jun 2020 06:32:32 +0000 Received: from localhost ([127.0.0.1]:34358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfdzs-0004sK-CL for submit@debbugs.gnu.org; Mon, 01 Jun 2020 02:32:32 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:55424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfdzq-0004s7-9L for 41622-done@debbugs.gnu.org; Mon, 01 Jun 2020 02:32:31 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E8EFF16004F; Sun, 31 May 2020 23:32:23 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id zsIgyRm6lcKt; Sun, 31 May 2020 23:32:23 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 4E516160059; Sun, 31 May 2020 23:32:23 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 27Mq10Ep063t; Sun, 31 May 2020 23:32:23 -0700 (PDT) Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 2B56916004F; Sun, 31 May 2020 23:32:23 -0700 (PDT) Subject: Re: bug#41622: [PATCH] tests: Change gnulib commit to compile make check To: Colton Lewis , 41622-done@debbugs.gnu.org References: From: Paul Eggert Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= LS0tLS1CRUdJTiBQR1AgUFVCTElDIEtFWSBCTE9DSy0tLS0tCgptUUlOQkV5QWNtUUJFQURB QXlIMnhvVHU3cHBHNUQzYThGTVpFb243NGRDdmM0K3ExWEEySjJ0QnkycHdhVHFmCmhweHhk R0E5Smo1MFVKM1BENGJTVUVnTjh0TFowc2FuNDdsNVhUQUZMaTI0NTZjaVNsNW04c0thSGxH ZHQ5WG0KQUF0bVhxZVpWSVlYL1VGUzk2ZkR6ZjR4aEVtbS95N0xiWUVQUWRVZHh1NDd4QTVL aFRZcDVibHRGM1dZRHoxWQpnZDdneDA3QXV3cDdpdzdlTnZub0RUQWxLQWw4S1lEWnpiRE5D UUdFYnBZM2VmWkl2UGRlSStGV1FONFcra2doCnkrUDZhdTZQcklJaFlyYWV1YTdYRGRiMkxT MWVuM1NzbUUzUWpxZlJxSS9BMnVlOEpNd3N2WGUvV0szOEV6czYKeDc0aVRhcUkzQUZINmls QWhEcXBNbmQvbXNTRVNORnQ3NkRpTzFaS1FNcjlhbVZQa25qZlBtSklTcWRoZ0IxRApsRWR3 MzRzUk9mNlY4bVp3MHhmcVQ2UEtFNDZMY0ZlZnpzMGtiZzRHT1JmOHZqRzJTZjF0azVlVThN Qml5Ti9iClowM2JLTmpOWU1wT0REUVF3dVA4NGtZTGtYMndCeHhNQWhCeHdiRFZadWR6eERa SjFDMlZYdWpDT0pWeHEya2wKakJNOUVUWXVVR3FkNzVBVzJMWHJMdzYrTXVJc0hGQVlBZ1Jy NytLY3dEZ0JBZndoUEJZWDM0blNTaUhsbUxDKwpLYUhMZUNMRjVaSTJ2S20zSEVlQ1R0bE9n N3haRU9OZ3d6TCtmZEtvK0Q2U29DOFJSeEpLczhhM3NWZkk0dDZDCm5yUXp2SmJCbjZneGRn Q3U1aTI5SjFRQ1lyQ1l2cWwyVXlGUEFLK2RvOTkvMWpPWFQ0bTI4MzZqMXdBUkFRQUIKdENC UVlYVnNJRVZuWjJWeWRDQThaV2RuWlhKMFFHTnpMblZqYkdFdVpXUjFQb2tDUGdRVEFRSUFL QVVDVElCeQpaQUliQXdVSkVzd0RBQVlMQ1FnSEF3SUdGUWdDQ1FvTEJCWUNBd0VDSGdFQ0Y0 QUFDZ2tRN1pmcERtS3FmalJSCkd3LytJajAzZGhZZllsL2dYVlJpdXpWMWdHcmJIayt0bmZy SS9DN2ZBZW9GelE1dFZnVmluU2hhUGtabzBIVFAKZjE4eDZJREVkQWlPOE1xbzF5cDBDdEht ekdNQ0o1MG80R3JnZmpscjZnLyt2dEVPS2JobGVzek4yWHBKdnB3TQoyUWdHdm4vbGFUTFV1 OFBIOWFSV1RzN3FKSlpLS0tBYjRzeFljOTJGZWhQdTZGT0QwZERpeWhsREFxNGxPVjJtCmRC cHpRYmlvam9aelFMTVF3anBnQ1RLMjU3MmVLOUVPRVF5U1VUaFhyU0l6NkFTZW5wNE5ZVEZI czl0dUpRdlgKazlnWkRkUFNsM2JwKzQ3ZEd4bHhFV0xwQklNN3pJT053NGtzNGF6Z1Q4bnZE WnhBNUlaSHR2cUJsSkxCT2JZWQowTGU2MVdwMHkzVGxCRGgycWRLOGVZTDQyNlc0c2NFTVN1 aWc1Z2I4T0F0UWlCVzZrMnNHVXh4ZWl2OG92V3U4CllBWmdLSmZ1b1dJK3VSbk1FZGRydVk4 SnNvTTU0S2FLdlppa2tLczJiZzFuZHRMVnpIcEo2cUZaQzdRVmplSFUKaDYvQm1ndmRqV1Ba WUZUdE4rS0E5Q1dYM0dRS0tnTjN1dTk4OHl6bkQ3TG5COThUNEVVSDFIQS9HbmZCcU1WMQpn cHpUdlBjNHFWUWluQ21Ja0VGcDgzemwrRzVmQ2pKSjNXN2l2ekNuWW80S2hLTHBGVW05N29r VEtSMkxXM3haCnpFVzRjTFNXTzM4N01USzNDekRPeDVxZTZzNGE5MVp1Wk0vai9UUWRUTERh cU5uODNrQTRIcTQ4VUhYWXhjSWgKK05kOGsvM3c2bEZ1b0swd3JPRml5d2pMeCswdXI1am1t YmVjQkdIYzF4ZGhBRkc1QWcwRVRJQnlaQUVRQUthRgo2NzhUOXd5SDR3alRyVjFQejNjREVv U25WLzBaVXJPVDM3cDFkY0d5ai9JWHExeDY3MEhSVmFoQW1rMHNacFljCjI1UEY5RDVHUFlI RldsTmp1UFU5NnJEbmRYQjNoZWRtQlJoTGRDNGJBWGpJNERWK2JtZFZlK3EvSU1ubFpSYVYK bG05RWlNQ1ZBUjZ3MTNzUmV1N3FYa1c5cjNSd1kyQXpYc2twL3RBZTRCUktyMVptYnZpMm5i blE2ZXBFQzQycgpSYngwQjFFaGpiSVFaNUpIR2syNGlQVDdMZEJnbk5tb3M1d1lqendObGtN UUQ1VDBZZHpoazdKK1V4d0E1bTQ2Cm1PaFJEQzJyRlYvQTBnbTVUTHk4RFhqdi9Fc2M0Z1lu WWFpNlNRcW5VRVZoNUx1VjhZQ0pCbmlqcytUaXc3MXgKMWljbW42eEdJNDVFdWdKT2dlYyty THlwWWdwVnA0eDBISTVUODhxQlJZQ2t4SDNLZzhRbytFV05BOUE0TFJROQpEWDhuam9uYTBn ZjBzMDN0b2NLOGtCTjY2VW9xcVB0SEJuYzRlTWdCeW1DZmxLMTJlS2ZkMllZeG55ZzljWmF6 CldBNVZzbHZUeHBtNzZoYmc1b2lBRUgvVmcvOE14SHlBblBoZnJnd3lQcm1KRWNWQmFmZHNw Sm5ZUXhCWU5jbzIKTEZQSWhsT3ZXaDhyNGF0K3MrTTNMYjI2b1VUY3psZ2RXMVNmM1NEQTc3 Qk1SbkYwRlF5RSs3QXpWNzlNQk40eQpraXFhZXpReHRhRjFGeS90dmtoZmZTbzh1K2R3RzBF Z0poK3RlMzhnVGNJU1ZyMEdJUHBsTHo2WWhqcmJIclBSCkYxQ041VXVMOURCR2p4dU4zNVJM TlZFZnRhNlJVRmxSNk5jdFRqdnJBQkVCQUFHSkFpVUVHQUVDQUE4RkFreUEKY21RQ0d3d0ZD UkxNQXdBQUNna1E3WmZwRG1LcWZqU3JIQS8rS3pBS3ZUeFJoQTlNV05MeEl5SjdTNXVKMTZn cwpUM29DalpyQktHRWhLTU9HWDRPMEdBNlZPRXJ5TzdRUkNDWWFoM294U0czOElBbk5laXdK WGdVOUJ6a2s4NVVHCmJQRWQ3SEdGL1ZTZUhDUXdXb3U2anFVRFRTRHZuOVloTlRkRzBLWFBN NzRhQyt4cjJab3cxTzJtaFhpaGdXS0QKMER3KzBMWVBuVU9zUTBLT0Z4SFhYWUhtUnJTMU9a UFU1OUJMdmMrVFJoSWhhZlNIS0x3YlhLKzZja2t4Qng2aAo4ejVjY3BHMFFzNGJGaGRGWW5G ckVpZURMb0dtbkUyWUxoZFY2c3dKOVZOQ1M2cExpRW9oVDNmbTdhWG0xNXRaCk9JeXpNWmhI UlNBUGJsWHhRMFpTV2pxOG9ScmNZTkZ4YzRXMVVScEFrQkNPWUpvWHZRZkQ1TDNscUFsOFRD cUQKVXpZeGhIL3RKaGJEZEhycUhINzY3amFEYVRCMStUYWxwLzJBTUt3Y1hOT2Rpa2xHeGJt SFZHNllHbDZnOExyYgpzdTlOWkVJNHlMbEh6dWlrdGhKV2d6KzN2WmhWR3lObHQrSE5Jb0Y2 Q2pETDJvbXU1Y0VxNFJESE00NFFxUGs2Cmw3TzBwVXZOMW1UNEIrUzFiMDhSS3BxbS9mZjAx NUUzN0hOVi9waUl2Smx4R0FZejhQU2Z1R0NCMXRoTVlxbG0KZ2RoZDkvQmFiR0ZiR0dZSEE2 VTQvVDV6cVUrZjZ4SHkxU3NBUVoxTVNLbEx3ZWtCSVQrNC9jTFJHcUNIam5WMApxNUgvVDZh N3Q1bVBrYnpTck9MU280cHVqK0lUb05qWXlZSURCV3pobEExOWF2T2ErcnZVam1IdEQzc0ZO N2NYCld0a0dvaThidU5jYnk0VT0KPUFMNm8KLS0tLS1FTkQgUEdQIFBVQkxJQyBLRVkgQkxP Q0stLS0tLQo= Organization: UCLA Computer Science Department Message-ID: <4f363ddd-bfc9-e758-60a1-b55df07c3b95@cs.ucla.edu> Date: Sun, 31 May 2020 23:32:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41622-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 5/30/20 4:17 PM, Colton Lewis wrote: > When I ran make check after building the master branch commit > aefd434e, I got a compilation error. Thanks for reporting the problem. I updated the Gnulib version while fixing some other stuff, and am closing the bug report. ------------=_1590993183-18806-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 30 May 2020 23:22:12 +0000 Received: from localhost ([127.0.0.1]:59417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfAnr-0005mt-QN for submit@debbugs.gnu.org; Sat, 30 May 2020 19:22:12 -0400 Received: from lists.gnu.org ([209.51.188.17]:44118) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfAjg-0005gK-CS for submit@debbugs.gnu.org; Sat, 30 May 2020 19:17:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52638) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jfAjg-0004e9-6Z for bug-coreutils@gnu.org; Sat, 30 May 2020 19:17:52 -0400 Received: from mail-yb1-xb44.google.com ([2607:f8b0:4864:20::b44]:35561) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jfAjf-0004Mu-Dc for bug-coreutils@gnu.org; Sat, 30 May 2020 19:17:51 -0400 Received: by mail-yb1-xb44.google.com with SMTP id v15so3177248ybk.2 for ; Sat, 30 May 2020 16:17:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=BwjyR5d40hhx1GJJekN1CyQhXrhZzdFJb1pl6GV3HRw=; b=fj3+WJGLGfGA+aEEVwJHkc8loQIEqCPxH4gTfgiB89Eeqx1XoLGcoSi2GzWNDaai2l 7h6ePpd2WgmLSIgvl/lOZTpz6yNHHquv2HECI66+LjvLFESInFZRhhmbWKkQrw2C8/at 4uf8Ny9vhR4Q7quSMwQR4f492ZXPiAVONhK3pePe0hy5d7Qqp7OEN9KFZoo8w69hV35d Sq0D1846+qANrqNzRIn5hCtMs/F+edx3dnL0qghscsjJVh+NEc9UApOZ1ifnKoTzpGkv 4HGupqVrEgzvemLf7SgVdbKscCW1IOoE1htt6oPoAoHZWU0FcFAbaK7oZgwzMvDNjGXv gAag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=BwjyR5d40hhx1GJJekN1CyQhXrhZzdFJb1pl6GV3HRw=; b=gfRdKyVVg+r/N2NnSZPUpleS1O4W9pjUIEg+Axwx7P+KSzSYnspURBRYIxeEgZ7Or/ tMHTuJGZLBCVW/9JauMDYRg6GpRhNlKay5VHj4xecIbKrH+bVlaB8RddP8tWh8XaUMZc y6KKmLW1oQ+MgAPV9C2a5v7i4ApnMl4X+GiQaBgDss3i863c2RApFwFsdML/LdWy6mlL /MLrN7BEl7UGooDGVJqnyA51eq+bgSigK6N7QAWniImJPPZ8MGUZaO27yECJoM59jOfR KeJrGOmMSKS56aCvkXwftGLH6gNM5+GrOlfmbDdgUM2l2g2+d90jpvGtgutEBlvCpNQ9 T6ZQ== X-Gm-Message-State: AOAM533lD+225B7Fv4d7YWT7blCWl/i9JIg/thEmdqHZpcrrP0j8Lkqv 6R+9CbPMZUBzCqHcpjZDNZOKGfSgw0jexh9Myw+pg/E3TQ== X-Google-Smtp-Source: ABdhPJwFaD1YKzPPA8CC2b3BxMxru7YXErqAtHIrdAe4CWNVSx62dXK6Eo9OAFskJo0VozvQD0Y/8J1NUvQ6fVjzW3c= X-Received: by 2002:a5b:10:: with SMTP id a16mr14325504ybp.262.1590880669778; Sat, 30 May 2020 16:17:49 -0700 (PDT) MIME-Version: 1.0 From: Colton Lewis Date: Sat, 30 May 2020 18:17:23 -0500 Message-ID: Subject: [PATCH] tests: Change gnulib commit to compile make check To: bug-coreutils@gnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::b44; envelope-from=colton.w.lewis@gmail.com; helo=mail-yb1-xb44.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 30 May 2020 19:22:10 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) When I ran make check after building the master branch commit aefd434e, I got a compilation error. test-explicit_bzero.c:132:1: error: no previous declaration for 'do_secret_stuff' [-Werror=missing-declarations] 132 | do_secret_stuff (volatile int pass) | ^~~~~~~~~~~~~~~ test-explicit_bzero.c:148:1: error: no previous declaration for 'test_stack' [-Werror=missing-declarations] 148 | test_stack (void) | ^~~~~~~~~~ I noticed the gnulib repo had a detached HEAD at b3c04ecec. I tried switching the gnulib repo to master and running make check again. I got a different error. test-sameacls.c: In function 'main': test-sameacls.c:58:17: error: too many arguments to function 'read_file' 58 | contents1 = read_file (file1, 0, &size1); | ^~~~~~~~~ In file included from test-sameacls.c:36: ../lib/read-file.h:29:14: note: declared here 29 | extern char *read_file (const char *filename, size_t * length); | ^~~~~~~~~ test-sameacls.c:65:17: error: too many arguments to function 'read_file' 65 | contents2 = read_file (file2, 0, &size2); | ^~~~~~~~~ In file included from test-sameacls.c:36: ../lib/read-file.h:29:14: note: declared here 29 | extern char *read_file (const char *filename, size_t * length); | ^~~~~~~~~ Here, coreutils and gnulib having conflicting declarations of read_file and the wrong one is included. This may require future changes. Poking around in the git logs for gnulib, I found commit a305580f, which fixes the first problem before introducing the second. File test-explicit_bzero.c now declares do_secret_stuff and test_stack static to appease -Werror=missing-declarations. --- gnulib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnulib b/gnulib index b3c04ecec..a305580f0 160000 --- a/gnulib +++ b/gnulib @@ -1 +1 @@ -Subproject commit b3c04ecec58ea687423f5c709410e6ecee4abd9b +Subproject commit a305580f09ada2674c0509389b1674c7b32dce67 -- 2.26.2 ------------=_1590993183-18806-1--