GNU bug report logs - #41610
[PATCH] gnu: glade3: Enable tests.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#41610: closed ([PATCH] gnu: glade3: Enable tests.)
Date: Mon, 15 Jun 2020 18:41:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 16 Jun 2020 00:10:21 +0530
with message-id <87eeqgnpey.fsf <at> systemreboot.net>
and subject line Re: [bug#41610] [PATCH] gnu: glade3: Enable tests.
has caused the debbugs.gnu.org bug report #41610,
regarding [PATCH] gnu: glade3: Enable tests.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
41610: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41610
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: guix-patches <at> gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH] gnu: glade3: Enable tests.
Date: Sat, 30 May 2020 03:01:10 +0530

* gnu/packages/gnome.scm (glade3)[arguments]: Enable tests. Add custom
pre-check phase.
[native-inputs]: Add hicolor-icon-theme and xorg-server-for-tests.
---
 gnu/packages/gnome.scm | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 1745bf7906..02e14233d1 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -2102,8 +2102,7 @@ API add-ons to make GTK+ widgets OpenGL-capable.")
                 "023gx8rj51njn8fsb6ma5kz1irjpxi4js0n8rwy22inc4ysldd8r"))))
     (build-system glib-or-gtk-build-system)
     (arguments
-     `(#:tests? #f ; needs X, GL, and software rendering
-       #:phases
+     `(#:phases
        (modify-phases %standard-phases
          (add-before 'configure 'fix-docbook
            (lambda* (#:key inputs #:allow-other-keys)
@@ -2113,18 +2112,27 @@ API add-ons to make GTK+ widgets OpenGL-capable.")
                                "/xml/xsl/docbook-xsl-"
                                ,(package-version docbook-xsl)
                                "/manpages/docbook.xsl")))
+             #t))
+         (add-before 'check 'pre-check
+           (lambda _
+             (setenv "HOME" "/tmp")
+             ;; Tests require a running X server.
+             (system "Xvfb :1 &")
+             (setenv "DISPLAY" ":1")
              #t)))))
     (inputs
      `(("gtk+" ,gtk+)
        ("libxml2" ,libxml2)))
     (native-inputs
-     `(("intltool" ,intltool)
+     `(("hicolor-icon-theme" ,hicolor-icon-theme)
+       ("intltool" ,intltool)
        ("itstool" ,itstool)
        ("libxslt" ,libxslt) ;for xsltproc
        ("docbook-xml" ,docbook-xml-4.2)
        ("docbook-xsl" ,docbook-xsl)
        ("python" ,python-2)
-       ("pkg-config" ,pkg-config)))
+       ("pkg-config" ,pkg-config)
+       ("xorg-server" ,xorg-server-for-tests)))
     (home-page "https://glade.gnome.org")
     (synopsis "GTK+ rapid application development tool")
     (description "Glade is a rapid application development (RAD) tool to
-- 
2.26.2

[Message part 3 (message/rfc822, inline)]

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 41610-done <at> debbugs.gnu.org
Subject: Re: [bug#41610] [PATCH] gnu: glade3: Enable tests.
Date: Tue, 16 Jun 2020 00:10:21 +0530

[Message part 4 (text/plain, inline)]

Pushed, thanks for the review!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.