GNU bug report logs - #41606
[PATCH] tests: Allow passing on systems without support for swap devices.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41606 in the body.
You can then email your comments to 41606 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Simon South <simon <at> simonsouth.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] tests: Allow passing on systems without support for swap
 devices.
Date: Fri, 29 May 2020 14:24:46 -0400

[Message part 1 (text/plain, inline)]

The attached patch allows Guix's test suite to pass (and thus, the
"guix" package to be built) on systems that lack support for swap
devices; that is, systems that not only do not have a swap device
enabled but do not have even support for memory paging built into the
kernel (e.g. Linux built without CONFIG_SWAP). This might be the case
for a small home server, for example, on which the workload is
predictable but memory is otherwise at a premium.

On these systems the "swapon" and "swapoff" syscalls return ENOSYS
("Function not implemented"). The patch modifies the relevant tests in
tests/syscalls.scm to accept this as a valid return value.

--
Simon South
simon <at> simonsouth.net

[0001-tests-Allow-passing-on-systems-without-support-for-s.patch (text/x-patch, attachment)]

Message #10 received at 41606-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Simon South <simon <at> simonsouth.net>
Cc: 41606-done <at> debbugs.gnu.org
Subject: Re: [bug#41606] [PATCH] tests: Allow passing on systems without
 support for swap devices.
Date: Tue, 02 Jun 2020 10:28:16 +0200

Hello Simon,

> On these systems the "swapon" and "swapoff" syscalls return ENOSYS
> ("Function not implemented"). The patch modifies the relevant tests in
> tests/syscalls.scm to accept this as a valid return value.

This looks good to me. I added a copyright line for you and pushed.

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.