From unknown Sun Jul 27 00:55:57 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#41601] [PATCH] doc: Make 'sudo -E ./pre-inst-env guix-daemon' example less prominent. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 29 May 2020 15:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 41601 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 41601@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159076441014291 (code B ref -1); Fri, 29 May 2020 15:01:02 +0000 Received: (at submit) by debbugs.gnu.org; 29 May 2020 15:00:10 +0000 Received: from localhost ([127.0.0.1]:55782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jegUT-0003iQ-HG for submit@debbugs.gnu.org; Fri, 29 May 2020 11:00:09 -0400 Received: from lists.gnu.org ([209.51.188.17]:34254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jegUR-0003iH-3Q for submit@debbugs.gnu.org; Fri, 29 May 2020 11:00:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40790) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jegUQ-0004XZ-Nm for guix-patches@gnu.org; Fri, 29 May 2020 11:00:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40629) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jegUQ-0004tY-BN for guix-patches@gnu.org; Fri, 29 May 2020 11:00:06 -0400 Received: from ti0006q161-2604.bb.online.no ([84.202.68.75]:59020 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jegUP-000609-LN for guix-patches@gnu.org; Fri, 29 May 2020 11:00:06 -0400 From: Marius Bakke Date: Fri, 29 May 2020 17:00:03 +0200 Message-Id: <20200529150003.4560-1-marius@gnu.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * doc/contributing.texi (Running Guix Before It Is Installed): Move './pre-inst-env guix-daemon' example after the mention of GUILE_LOAD_PATH & co, because running the daemon from the checkout frequently trips new users. Additionally clarify that sudo must be setuid. --- doc/contributing.texi | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/doc/contributing.texi b/doc/contributing.texi index 88128e5498..d9e54dd23b 100644 --- a/doc/contributing.texi +++ b/doc/contributing.texi @@ -161,13 +161,8 @@ with all the dependencies available (@pxref{Building from Git}), and then simply prefix each command with @command{./pre-inst-env} (the @file{pre-inst-env} script lives in the top build tree of Guix; it is generated by @command{./configure}). -An example@footnote{The @option{-E} flag to -@command{sudo} guarantees that @code{GUILE_LOAD_PATH} is correctly set -such that @command{guix-daemon} and the tools it uses can find the Guile -modules they need.}: @example -$ sudo -E ./pre-inst-env guix-daemon --build-users-group=guixbuild $ ./pre-inst-env guix build hello @end example @@ -205,6 +200,16 @@ $1 = 361 The @command{pre-inst-env} script sets up all the environment variables necessary to support this, including @env{PATH} and @env{GUILE_LOAD_PATH}. +When root privileges are required, use the @option{-E} argument to +@command{sudo} to preserve the environment@footnote{Additionally, make sure +to use the installed @command{sudo} such as @file{/run/setuid-programs/sudo} +instead of the @code{sudo} package, otherwise sudo won't be able to elevate +privileges}. E.g. if you are testing changes to @command{guix-daemon}: + +@example +$ sudo -E ./pre-inst-env guix-daemon --build-users-group=guixbuild +@end example + Note that @command{./pre-inst-env guix pull} does @emph{not} upgrade the local source tree; it simply updates the @file{~/.config/guix/current} symlink (@pxref{Invoking guix pull}). Run @command{git pull} instead if -- 2.26.2 From unknown Sun Jul 27 00:55:57 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#41601] [PATCH] doc: Make 'sudo -E ./pre-inst-env guix-daemon' example less prominent. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 29 May 2020 15:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41601 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke Cc: 41601@debbugs.gnu.org Received: via spool by 41601-submit@debbugs.gnu.org id=B41601.159076650626092 (code B ref 41601); Fri, 29 May 2020 15:36:02 +0000 Received: (at 41601) by debbugs.gnu.org; 29 May 2020 15:35:06 +0000 Received: from localhost ([127.0.0.1]:55844 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jeh2I-0006mm-2S for submit@debbugs.gnu.org; Fri, 29 May 2020 11:35:06 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:55055) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jeh2G-0006m8-MC for 41601@debbugs.gnu.org; Fri, 29 May 2020 11:35:05 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id D287D20008; Fri, 29 May 2020 15:34:57 +0000 (UTC) From: Nicolas Goaziou References: <20200529150003.4560-1-marius@gnu.org> Date: Fri, 29 May 2020 17:34:55 +0200 In-Reply-To: <20200529150003.4560-1-marius@gnu.org> (Marius Bakke's message of "Fri, 29 May 2020 17:00:03 +0200") Message-ID: <87h7vywy8w.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Marius Bakke writes: > +privileges}. E.g. if you are testing changes to @command{guix-daemon}: ^^^^ Beware the dot above. You could write E.g.@: if you=E2=80=A6 or E.g., if you=E2=80=A6 =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 instead. Regards, --=20 Nicolas Goaziou From unknown Sun Jul 27 00:55:57 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#41601] [PATCH] doc: Make 'sudo -E ./pre-inst-env guix-daemon' example less prominent. Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 29 May 2020 15:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41601 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke ,41601@debbugs.gnu.org Received: via spool by 41601-submit@debbugs.gnu.org id=B41601.159076659826247 (code B ref 41601); Fri, 29 May 2020 15:37:02 +0000 Received: (at 41601) by debbugs.gnu.org; 29 May 2020 15:36:38 +0000 Received: from localhost ([127.0.0.1]:55851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jeh3l-0006pG-Md for submit@debbugs.gnu.org; Fri, 29 May 2020 11:36:37 -0400 Received: from lepiller.eu ([89.234.186.109]:51684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jeh3h-0006ox-2J for 41601@debbugs.gnu.org; Fri, 29 May 2020 11:36:33 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 7e2518d8; Fri, 29 May 2020 15:36:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date :in-reply-to:references:mime-version:content-type :content-transfer-encoding:subject:to:from:message-id; s=dkim; bh=s05gjssyn+DCL8f5vQ2cRXnjZ/oUlL/ctO04rX5ualM=; b=oAlhYMtA8964 1AG8hTPnLrRIUhw+A2S2C/6T3h8Vx6vvEG1/lu897kMn0WUgrGFVlswH8e4bjfay a9ekL6DOUksnNKuDGbMBAsKuWJntoTnimIOEerx0NFD/qeB/O2DpD80qe5BMaV41 nHneZgHh9e2z7HkZcHOBmr8Mmg+QG7UM7h8kKI9QosNlsshWAzlBTXp+4udvMBlL ZFgjUDnRQVhtWX/43u8Ji9ocrlsAvQyROVKyvVocRDMddBl8vNpqrP7+imcRrp83 iiFhTDtlZUONPzviIzxzg9Wj8euzFNWGFyiqrp3OqcTTMjo57uq0aDsa4WsJ7M4b awt8uke+4Q== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 52f003d6 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Fri, 29 May 2020 15:36:30 +0000 (UTC) Date: Fri, 29 May 2020 11:36:15 -0400 User-Agent: K-9 Mail for Android In-Reply-To: <20200529150003.4560-1-marius@gnu.org> References: <20200529150003.4560-1-marius@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Julien Lepiller Message-ID: X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Le 29 mai 2020 11:00:03 GMT-04:00, Marius Bakke a =C3=A9= crit : >* doc/contributing=2Etexi (Running Guix Before It Is Installed): Move >'=2E/pre-inst-env guix-daemon' example after the mention of >GUILE_LOAD_PATH & >co, because running the daemon from the checkout frequently trips new >users=2E >Additionally clarify that sudo must be setuid=2E >--- > doc/contributing=2Etexi | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > >diff --git a/doc/contributing=2Etexi b/doc/contributing=2Etexi >index 88128e5498=2E=2Ed9e54dd23b 100644 >--- a/doc/contributing=2Etexi >+++ b/doc/contributing=2Etexi >@@ -161,13 +161,8 @@ with all the dependencies available >(@pxref{Building from Git}), and then > simply prefix each command with > @command{=2E/pre-inst-env} (the @file{pre-inst-env} script lives in the > top build tree of Guix; it is generated by @command{=2E/configure})=2E >-An example@footnote{The @option{-E} flag to >-@command{sudo} guarantees that @code{GUILE_LOAD_PATH} is correctly set >-such that @command{guix-daemon} and the tools it uses can find the >Guile >-modules they need=2E}: >=20 > @example >-$ sudo -E =2E/pre-inst-env guix-daemon --build-users-group=3Dguixbuild > $ =2E/pre-inst-env guix build hello > @end example >=20 >@@ -205,6 +200,16 @@ $1 =3D 361 >The @command{pre-inst-env} script sets up all the environment variables >necessary to support this, including @env{PATH} and >@env{GUILE_LOAD_PATH}=2E >=20 >+When root privileges are required, use the @option{-E} argument to >+@command{sudo} to preserve the environment@footnote{Additionally, make >sure >+to use the installed @command{sudo} such as >@file{/run/setuid-programs/sudo} >+instead of the @code{sudo} package, otherwise sudo won't be able to >elevate >+privileges}=2E E=2Eg=2E if you are testing changes to >@command{guix-daemon}: >+ >+@example >+$ sudo -E =2E/pre-inst-env guix-daemon --build-users-group=3Dguixbuild >+@end example >+ >Note that @command{=2E/pre-inst-env guix pull} does @emph{not} upgrade >the > local source tree; it simply updates the @file{~/=2Econfig/guix/current} >symlink (@pxref{Invoking guix pull})=2E Run @command{git pull} instead >if Looks good, but you should mention that, before running the daemon that wa= y, the one running on the system must be stopped (herd stop guix-daemon or = whatever init system is installed)=2E From unknown Sun Jul 27 00:55:57 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#41601] [PATCH] doc: Make 'sudo -E ./pre-inst-env guix-daemon' example less prominent. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 29 May 2020 15:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41601 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: 41601@debbugs.gnu.org, Marius Bakke Received: via spool by 41601-submit@debbugs.gnu.org id=B41601.15907678664118 (code B ref 41601); Fri, 29 May 2020 15:58:02 +0000 Received: (at 41601) by debbugs.gnu.org; 29 May 2020 15:57:46 +0000 Received: from localhost ([127.0.0.1]:55871 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jehOE-00014M-5C for submit@debbugs.gnu.org; Fri, 29 May 2020 11:57:46 -0400 Received: from mail-qk1-f193.google.com ([209.85.222.193]:44850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jehOC-000147-M0 for 41601@debbugs.gnu.org; Fri, 29 May 2020 11:57:45 -0400 Received: by mail-qk1-f193.google.com with SMTP id c14so1596058qka.11 for <41601@debbugs.gnu.org>; Fri, 29 May 2020 08:57:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=7xZV61FJCjvyuD7fhrfOOypB3Z7qJ5LXjeqk6K3dkfw=; b=lVckjAepwjEqf1iq8VRY4LXfPRsf5w347ZoOztlu0yUNIWcg7eSOroc1dbyeDoBQKK Y3Ag/SuROziZ15nY0tUdXnHxloy8i2DXUNqvKWT5uQtpsXTcyCb3WN8YeINWh3JqMuCZ M+LyheNYWoQgBU8rf/8UXDoqxPwGur/nakep3PnRhrsCgBku+9T1W5gsoVbXIf4eQZAl ANuGtQwTil98rjj22RZpRjTDcvMVhNtBmHGoAD2mxi2UX+Z1nAnRf/1ExFUhI0PQrrJA g3zEg6uqIT2Ldr4dc+W0J/EN67H4XOp/nAOwHkanzlhwSPy7kruz0JaH8O2OD93pVHpe xErw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=7xZV61FJCjvyuD7fhrfOOypB3Z7qJ5LXjeqk6K3dkfw=; b=NTfTMIrQOcdZqKm5BnQ5LeDi/G/BVC3L/eApGorXGXYZ528r6rpyiYcGnDR7Jqobp0 Wwlc1/or9/L/PmJx67zhmYDZBSjoCq803sQRe5VUM06PWf4ZXWI+rmTy3sPjjDRB4unA /9TLeJH4erGty8Mus4l9OmiR7dZRU3P5/Xtuhv/3r1cymxv8JYCSYR8bODUM6P/QhxKq 8S2MsujyGwuV5ecYqTQVcWTFn7901o/Hg2U0SdAFu/mxBpTln+3RGlH//f2PbKPvwkDG gW0YHd9qcmbZofaV8RFJw3JkCf1y0L1nzEC00GRH8VVLcPUIhJCryV9w6qf95QHcEt0A 8gHQ== X-Gm-Message-State: AOAM530af5tfEd78ok8YUQh3oe1w5KJCd4PWYA7TJjeMo7VfGBxZOLrW qARYFc6mxKhGNdnA6caSG2gvVBOaXt95l/fN1Rw= X-Google-Smtp-Source: ABdhPJw3Z2TcOmg1jMQus8ZKiCT1IQOntU4XzY/r6kOwh/5RLnywVyBVhidaoasEWGwDWCPNWKiWbaKCZ/TIEvlFtLY= X-Received: by 2002:ae9:f214:: with SMTP id m20mr8475670qkg.232.1590767859025; Fri, 29 May 2020 08:57:39 -0700 (PDT) MIME-Version: 1.0 References: <20200529150003.4560-1-marius@gnu.org> <87h7vywy8w.fsf@nicolasgoaziou.fr> In-Reply-To: <87h7vywy8w.fsf@nicolasgoaziou.fr> From: zimoun Date: Fri, 29 May 2020 17:57:27 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Nicolas, On Fri, 29 May 2020 at 17:36, Nicolas Goaziou wrot= e: > > +privileges}. E.g. if you are testing changes to @command{guix-daemon}= : > ^^^^ > Beware the dot above. You could write > > E.g.@: if you=E2=80=A6 > > or > > E.g., if you=E2=80=A6 I am not native speaker but last time I have checked the rule for Latin abbreviation, if I remember well, it says: it depends. :-) In general, the style guides says always a comma before, i.e. like that. However, the comma after depends on U.S. vs U.K.: - U.S., i.e., comma after the abbreviation; - U.K., i.e. no command after the abbreviation. Cheers, simon From unknown Sun Jul 27 00:55:57 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#41601] [PATCH] doc: Make 'sudo -E ./pre-inst-env guix-daemon' example less prominent. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 29 May 2020 17:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41601 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun Cc: 41601@debbugs.gnu.org, Marius Bakke Received: via spool by 41601-submit@debbugs.gnu.org id=B41601.15907742407612 (code B ref 41601); Fri, 29 May 2020 17:44:01 +0000 Received: (at 41601) by debbugs.gnu.org; 29 May 2020 17:44:00 +0000 Received: from localhost ([127.0.0.1]:56166 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jej32-0001yi-I1 for submit@debbugs.gnu.org; Fri, 29 May 2020 13:44:00 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:42345) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jej31-0001yW-8U for 41601@debbugs.gnu.org; Fri, 29 May 2020 13:43:59 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id EF4CCFF804; Fri, 29 May 2020 17:43:52 +0000 (UTC) From: Nicolas Goaziou References: <20200529150003.4560-1-marius@gnu.org> <87h7vywy8w.fsf@nicolasgoaziou.fr> Date: Fri, 29 May 2020 19:43:52 +0200 In-Reply-To: (zimoun's message of "Fri, 29 May 2020 17:57:27 +0200") Message-ID: <87h7vyy6uf.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, zimoun writes: > I am not native speaker but last time I have checked the rule for > Latin abbreviation, if I remember well, it says: it depends. :-) I was talking about Texinfo syntax, where "E.g. if" is misleading. Sorry if that was not clear. Regards, -- Nicolas Goaziou From unknown Sun Jul 27 00:55:57 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Marius Bakke Subject: bug#41601: closed (Re: [bug#41601] [PATCH] doc: Make 'sudo -E ./pre-inst-env guix-daemon' example less prominent.) Message-ID: References: <87eem8rv24.fsf@gmail.com> <20200529150003.4560-1-marius@gnu.org> X-Gnu-PR-Message: they-closed 41601 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 41601@debbugs.gnu.org Date: Fri, 09 Oct 2020 02:30:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1602210602-8383-1" This is a multi-part message in MIME format... ------------=_1602210602-8383-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #41601: [PATCH] doc: Make 'sudo -E ./pre-inst-env guix-daemon' example less= prominent. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 41601@debbugs.gnu.org. --=20 41601: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D41601 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1602210602-8383-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 41601-done) by debbugs.gnu.org; 9 Oct 2020 02:29:34 +0000 Received: from localhost ([127.0.0.1]:33705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQiA2-0002AG-Ib for submit@debbugs.gnu.org; Thu, 08 Oct 2020 22:29:34 -0400 Received: from mail-qk1-f195.google.com ([209.85.222.195]:46426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQi9z-0002A1-6M for 41601-done@debbugs.gnu.org; Thu, 08 Oct 2020 22:29:33 -0400 Received: by mail-qk1-f195.google.com with SMTP id a23so9132339qkg.13 for <41601-done@debbugs.gnu.org>; Thu, 08 Oct 2020 19:29:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=9NkQEbkwcU8IGpUFDtryA0f2HKp+rUcOgZcaFOxygcE=; b=gX7OH3Mw1yHR9bvP9A6Qa92Mngh4AqyI9AslQl0j18Si2MkEwjbB8hH1Trrzhv+vZK gVDS2PDQrt843/DD+gxl778nIpMrRpU7GNCd0iOp0BqxDq4p0eA1sHz4013azB3aodHd BTAN1a5Qk3tC08mzIkwowxTrfc+CUpA/tXSWQUeiDGLxGKEahjKb1TZF9pkD6xZ2myQo PEQfz/+1HRTYmhNcBV6YsDJ6KZZuduqWIvwQjHO+HQzCQyeG+U5CdJFvgHXFpynUJpaF TWj4Sqx4lHCKZLqPI0LOxcwOlBEOBexELAf26LZ6Gt8cNnsQTrXj14AiiDsSwEVscR2x 3IGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=9NkQEbkwcU8IGpUFDtryA0f2HKp+rUcOgZcaFOxygcE=; b=ixH4sM+UiXUzRCqB0wOYLe8QCIWR1z1t4zZaIyPK8pFXuhH7YLnGpMvVHTN66ujVWo TxZj5Jbv1VyUtBQ5MhBJFFuTD3rGQeYlGTmTsveO/qirBIVWz/OmBDkuRm3+QUmGhkSh Jzm9HMPMN2MCfFF94xTD56JzBDAB/xESDU7iYwN+yEOQWlS/iWrNgw9HxxSmZiLFOaAd tWjimuW264fUhhupupovs2Fb/z0iFFEl5XAC1FuBL6PVKA31Voy5E8onKp/2rCKTxP/h jMo9FHpsF3LSFtuy4Eq1gwD+pZw9k5z8EW/1BX2Tf3pGgwkRuIOiXCIo/UhJ4eWcAUQx 4eBQ== X-Gm-Message-State: AOAM530PmwJxwmkyonK/cwbXqdGzZiAHGJzw71/zHzUO6v/0NyEzblKz hkWZi8gwG1IjBRSqURzdFNJyQpRoN8KWyQ== X-Google-Smtp-Source: ABdhPJwItKUapJGt3a6NAm0COkxP/XX+SjxjY5S9EJeW5H/7Dzc15pDaQKCz6yMUSdUpr+Q9fqPKlg== X-Received: by 2002:ae9:eb97:: with SMTP id b145mr4010691qkg.60.1602210565515; Thu, 08 Oct 2020 19:29:25 -0700 (PDT) Received: from hurd (dsl-10-135-56.b2b2c.ca. [72.10.135.56]) by smtp.gmail.com with ESMTPSA id h68sm5446175qkf.30.2020.10.08.19.29.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2020 19:29:24 -0700 (PDT) From: Maxim Cournoyer To: Marius Bakke Subject: Re: [bug#41601] [PATCH] doc: Make 'sudo -E ./pre-inst-env guix-daemon' example less prominent. References: <20200529150003.4560-1-marius@gnu.org> Date: Thu, 08 Oct 2020 22:29:23 -0400 In-Reply-To: <20200529150003.4560-1-marius@gnu.org> (Marius Bakke's message of "Fri, 29 May 2020 17:00:03 +0200") Message-ID: <87eem8rv24.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41601-done Cc: 41601-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Marius, Marius Bakke writes: > * doc/contributing.texi (Running Guix Before It Is Installed): Move > './pre-inst-env guix-daemon' example after the mention of GUILE_LOAD_PATH & > co, because running the daemon from the checkout frequently trips new users. > Additionally clarify that sudo must be setuid. Ludovic today pushed a changed very similar in commit 9022861dc028e99fab930721fe991a682c497bbb, obsoleting this one. Closing. Thank you, Maxim ------------=_1602210602-8383-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 29 May 2020 15:00:10 +0000 Received: from localhost ([127.0.0.1]:55782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jegUT-0003iQ-HG for submit@debbugs.gnu.org; Fri, 29 May 2020 11:00:09 -0400 Received: from lists.gnu.org ([209.51.188.17]:34254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jegUR-0003iH-3Q for submit@debbugs.gnu.org; Fri, 29 May 2020 11:00:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40790) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jegUQ-0004XZ-Nm for guix-patches@gnu.org; Fri, 29 May 2020 11:00:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40629) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jegUQ-0004tY-BN for guix-patches@gnu.org; Fri, 29 May 2020 11:00:06 -0400 Received: from ti0006q161-2604.bb.online.no ([84.202.68.75]:59020 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jegUP-000609-LN for guix-patches@gnu.org; Fri, 29 May 2020 11:00:06 -0400 From: Marius Bakke To: guix-patches@gnu.org Subject: [PATCH] doc: Make 'sudo -E ./pre-inst-env guix-daemon' example less prominent. Date: Fri, 29 May 2020 17:00:03 +0200 Message-Id: <20200529150003.4560-1-marius@gnu.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * doc/contributing.texi (Running Guix Before It Is Installed): Move './pre-inst-env guix-daemon' example after the mention of GUILE_LOAD_PATH & co, because running the daemon from the checkout frequently trips new users. Additionally clarify that sudo must be setuid. --- doc/contributing.texi | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/doc/contributing.texi b/doc/contributing.texi index 88128e5498..d9e54dd23b 100644 --- a/doc/contributing.texi +++ b/doc/contributing.texi @@ -161,13 +161,8 @@ with all the dependencies available (@pxref{Building from Git}), and then simply prefix each command with @command{./pre-inst-env} (the @file{pre-inst-env} script lives in the top build tree of Guix; it is generated by @command{./configure}). -An example@footnote{The @option{-E} flag to -@command{sudo} guarantees that @code{GUILE_LOAD_PATH} is correctly set -such that @command{guix-daemon} and the tools it uses can find the Guile -modules they need.}: @example -$ sudo -E ./pre-inst-env guix-daemon --build-users-group=guixbuild $ ./pre-inst-env guix build hello @end example @@ -205,6 +200,16 @@ $1 = 361 The @command{pre-inst-env} script sets up all the environment variables necessary to support this, including @env{PATH} and @env{GUILE_LOAD_PATH}. +When root privileges are required, use the @option{-E} argument to +@command{sudo} to preserve the environment@footnote{Additionally, make sure +to use the installed @command{sudo} such as @file{/run/setuid-programs/sudo} +instead of the @code{sudo} package, otherwise sudo won't be able to elevate +privileges}. E.g. if you are testing changes to @command{guix-daemon}: + +@example +$ sudo -E ./pre-inst-env guix-daemon --build-users-group=guixbuild +@end example + Note that @command{./pre-inst-env guix pull} does @emph{not} upgrade the local source tree; it simply updates the @file{~/.config/guix/current} symlink (@pxref{Invoking guix pull}). Run @command{git pull} instead if -- 2.26.2 ------------=_1602210602-8383-1--