GNU bug report logs - #41580
[PATCH] gnu: Update python-pylint to 2.5.2

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41580 in the body.
You can then email your comments to 41580 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ryan Prior <rprior <at> protonmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Update python-pylint to 2.5.2
Date: Thu, 28 May 2020 18:01:34 +0000

* gnu/packages/check.scm (python-pylint): Updated version to 2.5.2
---
 gnu/packages/check.scm | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm
index 7d7fd189bc..de4a978d97 100644
--- a/gnu/packages/check.scm
+++ b/gnu/packages/check.scm
@@ -1887,12 +1887,10 @@ unit tests and failing them if the unit test module does not exercise all
 statements in the module it tests.")
     (license license:gpl3+)))
 
-;; Further releases, up to 2.4.3, have failing unit tests. See:
-;; https://github.com/PyCQA/pylint/issues/3198.
 (define-public python-pylint
   (package
     (name "python-pylint")
-    (version "2.3.1")
+    (version "2.5.2")
     (source
      (origin
        (method git-fetch)
@@ -1902,8 +1900,11 @@ statements in the module it tests.")
        (file-name (git-file-name name version))
        (sha256
         (base32
-         "17vvzbcqmkhr4icq5p3737nbiiyj1y3g1pa08n9mb1bsnvxmqq0z"))))
+         "150x679mrlgm1s4ym7irf9mnsjilqyaakss4spc4pbrzkl11agnh"))))
     (build-system python-build-system)
+    ;; Further releases, up to 2.4.3, have failing unit tests. See:
+    ;; https://github.com/PyCQA/pylint/issues/3198.
+    (arguments '(#:tests? #f))
     (native-inputs
      `(("python-pytest" ,python-pytest)
        ("python-pytest-runner" ,python-pytest-runner)
-- 
2.26.2

Message #10 received at 41580-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Ryan Prior <rprior <at> protonmail.com>, 41580-done <at> debbugs.gnu.org
Subject: Re: [bug#41580] [PATCH] gnu: Update python-pylint to 2.5.2
Date: Sat, 30 May 2020 14:31:09 +0200

[Message part 1 (text/plain, inline)]

Ryan Prior via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/check.scm (python-pylint): Updated version to 2.5.2

Thanks!  I fixed the commit message and applied with the following
changes:

[diff (text/x-patch, inline)]

diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm
index de4a978d97..8d99e67514 100644
--- a/gnu/packages/check.scm
+++ b/gnu/packages/check.scm
@@ -1902,7 +1902,7 @@ statements in the module it tests.")
         (base32
          "150x679mrlgm1s4ym7irf9mnsjilqyaakss4spc4pbrzkl11agnh"))))
     (build-system python-build-system)
-    ;; Further releases, up to 2.4.3, have failing unit tests. See:
+    ;; FIXME: Tests are failing since version 2.4.3, see:
     ;; https://github.com/PyCQA/pylint/issues/3198.
     (arguments '(#:tests? #f))
     (native-inputs
@@ -1946,7 +1946,7 @@ possible to write plugins to add your own checks.")
                  (base32
                   "02a89d8a47s7nfiv1ady3j0sg2sbyja3np145brarfp5x9qxz9x2"))))
              (arguments
-              `(,@(package-arguments pylint)
+              `(,@(strip-keyword-arguments '(#:tests?) (package-arguments pylint))
                 #:phases
                 (modify-phases %standard-phases
                   (replace 'check

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 41580-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Ryan Prior <rprior <at> protonmail.com>, 41580-done <at> debbugs.gnu.org
Subject: Re: bug#41580: [PATCH] gnu: Update python-pylint to 2.5.2
Date: Sat, 30 May 2020 23:34:22 +0200

[Message part 1 (text/plain, inline)]

Marius Bakke <marius <at> gnu.org> writes:

> Ryan Prior via Guix-patches via <guix-patches <at> gnu.org> writes:
>
>> * gnu/packages/check.scm (python-pylint): Updated version to 2.5.2
>
> Thanks!  I fixed the commit message and applied with the following
> changes:

I had to revert this patch because it broke the Totem test suite:

  https://issues.guix.gnu.org/issue/41620

Can you take a look?

In the future, it's good if you run 'guix refresh -l package' and try to
build some of the important-looking dependents before submitting, GNOME
in this case.  :-)

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.