From unknown Sun Aug 17 09:10:27 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#41578 <41578@debbugs.gnu.org> To: bug#41578 <41578@debbugs.gnu.org> Subject: Status: [PATCH] gnu: Add opendoas. Reply-To: bug#41578 <41578@debbugs.gnu.org> Date: Sun, 17 Aug 2025 16:10:27 +0000 retitle 41578 [PATCH] gnu: Add opendoas. reassign 41578 guix-patches submitter 41578 Morgan.J.Smith@outlook.com severity 41578 normal tag 41578 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu May 28 11:41:35 2020 Received: (at submit) by debbugs.gnu.org; 28 May 2020 15:41:36 +0000 Received: from localhost ([127.0.0.1]:52857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jeKf1-0004HV-6a for submit@debbugs.gnu.org; Thu, 28 May 2020 11:41:35 -0400 Received: from lists.gnu.org ([209.51.188.17]:51504) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jeKZB-000489-3w for submit@debbugs.gnu.org; Thu, 28 May 2020 11:35:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60612) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeKZA-00026B-QU for guix-patches@gnu.org; Thu, 28 May 2020 11:35:32 -0400 Received: from mail-mw2nam12olkn2096.outbound.protection.outlook.com ([40.92.23.96]:46535 helo=NAM12-MW2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeKZ8-0002Jp-RP for guix-patches@gnu.org; Thu, 28 May 2020 11:35:32 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZCR/pcSgxKX2gyqur105AG6olKE1UGaWcGxjBVPEKiUBz/p6joZUMwQ3RZN/HbY8OstyhFxnu1A6YnMfR1AUDV+xbugarP53arlvbH4Wez9XmvwFfTAiF2Gue+0dZP2bxYB6gKQE/3iMf/WO/nkDd2TiJBxS/a1Bfvzfq/kFYkYX15vTK4Gt7cf376cqaG4B7+Ef9aNwI+BvZB7fH70wJlj4vRHIjWu9XzW1ISjsGmQMCk7+IjMKmS76q8Yv0XoPW9acYPGqjVnWKp8SqNEv9e/Zr6RnekAQFBdrNz+DjqkQJar/1fHUsYHsb390LguyG1s+LkSusPxf+aYoaBe3uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5nNxyN62Swb0/FBDEs3eLQD4Iqyf7JcPCz7TXR/qLgw=; b=LhvBOffKeNAptPPMoek/dkH6J7BCV6ECLluKh6wGKfQ5QX0x9uZJkwX01cLUdv6QwBbrO6mB0iS+k3jE7D9qvOqJw/JgFmRZrn+gyy7GlVRvTSpwxnNZ0x4JuPgS2VYKoRuuJ22M32ISg/vt+03EtdEWBXoz2cIEiU4Liw0QVmWta3kXabzPRkXZzFXfzUk1fEeTsaOPP3NCUTEwEo2bnephlK18bbSNRHKvhb5Y3hkRJ79gjy77+RBMfBMcxQ7RpcaPwTyC8TsyVO5S+TChINXMye8uqeUrezGqNZhYLuulcGXaZo1vzOMERZQBoAtmWFj70O7ZZegKZwrQmYqsVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5nNxyN62Swb0/FBDEs3eLQD4Iqyf7JcPCz7TXR/qLgw=; b=bePYxBes09g0qXG+7ujq2qEBBQ8xL1KJ0riQgyLWksiLCQsBq7q3mMKAa0/vY08U/j+9vT8NViR3dttcgfox/YgoAjenDYXEY5vyw/ADaLQt24g0Yg4UHSagM91UY6HRGeEbC4kgQq0dALEGi2e242VcQM+Z8RmVHc368g25AkTn59D8xwFzHuPbgrpkV/2S8QdEk9Ppy01uHfHkDOC6XbDZ7GvRGd1O9KUmJeCgGZw/JHs4nRRNuIesXgyCXHPFwn7/f36cyGP5oaTkTsVsN+wLKzRzb3GiO/P4kN3c331GY6+ro2d5D5E5yl5Gexgd+DuwekDzuHZyvjx9S7e6gw== Received: from DM6NAM12FT016.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc64::41) by DM6NAM12HT218.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc64::361) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.10; Thu, 28 May 2020 15:35:27 +0000 Received: from DM5PR1001MB2105.namprd10.prod.outlook.com (2a01:111:e400:fc64::46) by DM6NAM12FT016.mail.protection.outlook.com (2a01:111:e400:fc64::217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.10 via Frontend Transport; Thu, 28 May 2020 15:35:27 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:FBD75ACC5FDD62AEC5137AC5B3CFBB2E4C2E25E9E04F76C4512BF0F5F36D632F; UpperCasedChecksum:0A92F05F25649AE64678292BC0C2659A492DAB534944E2080EA2FE61A26A9B5A; SizeAsReceived:7439; Count:48 Received: from DM5PR1001MB2105.namprd10.prod.outlook.com ([fe80::d1eb:1b79:777f:92d0]) by DM5PR1001MB2105.namprd10.prod.outlook.com ([fe80::d1eb:1b79:777f:92d0%7]) with mapi id 15.20.3021.029; Thu, 28 May 2020 15:35:26 +0000 From: Morgan.J.Smith@outlook.com To: guix-patches@gnu.org Subject: [PATCH] gnu: Add opendoas. Date: Thu, 28 May 2020 11:35:07 -0400 Message-ID: X-Mailer: git-send-email 2.26.2 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: YQBPR01CA0077.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:3::13) To DM5PR1001MB2105.namprd10.prod.outlook.com (2603:10b6:4:2b::24) X-Microsoft-Original-Message-ID: <20200528153507.21785-1-Morgan.J.Smith@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from guix.gateway.2wire.net (70.27.158.64) by YQBPR01CA0077.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.17 via Frontend Transport; Thu, 28 May 2020 15:35:26 +0000 X-Mailer: git-send-email 2.26.2 X-Microsoft-Original-Message-ID: <20200528153507.21785-1-Morgan.J.Smith@outlook.com> X-TMN: [nfe9e8Y+1M0E91j0priehAkJ51i5pURf] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 48 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: e821fcdb-db3d-4d3a-2e98-08d8031cbe95 X-MS-Exchange-SLBlob-MailProps: 3R77UsUWwWd5NDbMcjGjRSUjDGUUo30rYP74aMIyzLIn1Shr6CrKbknUmBj9i3IYxfC5QZihXJl5V0ZE2enHE1RV55U5EvM9slzvP/IaPwi0APP0i5/2YCeeAUUbQg3FO/OUkGzrA4qznqlXH/wMaBZkH1u0LNouA7UXshDx0/wQOzLH8s8PhMhcVs5Ovh0BB2ZGOuc4T5fKTI8AoGYGPxGaKyqWopUCg8zHYsYEyF1bPKcrRFRNCLq+hXSYQ4aUBq1JsHY9kEzDuwQy6ePZd28UcA+zZMjxlxKSfFDTffE8IeM6MrZLI+gC+jspkUbP2izv6A5KymYrIpyVLNCGqNi1uKZkehHZss4kVrXgEJcYM/Gb/QcG8dM6sSsbgKmpBL8LkGb/CF84F9RICaKPUWXgaSRR5ao0kKST0yLC5bKTUAGYLCvUZ4KjSsgCp7IX6j2AlcGVZZ9t4nrwyF0updRIKMFLc19czTUfjXuwi+dDvmf+02NV5pAQ6r884zz1GUxf9yESpkSPTLyQ9A30ky2jjmwkdZ3NLnbR1QqZl3J53QVrv+saNnb3NhyUH/WI5XtV4sqgaRaTUCQRb+F3HnsWQS9ptQcfUXQvzxv9Y1B6BhrNzV1eKo1PT7OhqHGHuLkGyeaUAexvuUSwlYowi+0Mc+QMWfPY6uYHnX4gcLYpCPq7++x+6i4QJphEE3U9ke228XuaOtxa6r2tM02cZ36FJZdW/wFcVfCFEMP2g/3Q0stGH/gV5p8tpmwai4im/EeK684LE+jiHY69Ff+OUa7n4aXm2N8GMzB9OiBTT98dN8aylhMYwRQiO87DX3dtbSKE2+udbwqqGRUCtUW8gMgTXGd0iJkcO8ISa2hLza9eGgOaHGUsJY4+e39r1+KWaD4xm6bH7hOMbfWG3nhwgA== X-MS-TrafficTypeDiagnostic: DM6NAM12HT218: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 06sNk/7GjeNT2z2uS3DlqVs1Rg+DYiVm6fKgqj4MFFow+ENE01qorlx4vpMDnNKJMlHv6Mc65ZDdO5QnInPURfzmKEsAa68SnkTTIopqxK9B7rKZ4+DJRrMUfuGKsIK6ZctOaSMRVTXIxb4kJZPoZ1PDYOQFhlebhSs1J8I1dAdJZgyRjMTgwzFxvqaAF0Z5bt9U+HQ8J4VRIgeb8xJq/QKlXwFRZpPMpW+rx0qh2pRexJFkzuALgUwOERYrPe5x X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:0; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1001MB2105.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:; DIR:OUT; SFP:1901; X-MS-Exchange-AntiSpam-MessageData: ai091FHwZTG2phrQDHQYzAb13C1KVcol2hL4RUfYAyUapuB2N40a8PsC0xd7Lfpg7+LhFnNKJZbzU2Tu1rQykWPsJZX9azEkgAuZDDQ/f4oA4yW8UXq9aCCoZ0KXiRVv26c8E9PiSqisdOJeec5MQQ== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e821fcdb-db3d-4d3a-2e98-08d8031cbe95 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2020 15:35:26.7139 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6NAM12HT218 Received-SPF: pass client-ip=40.92.23.96; envelope-from=Morgan.J.Smith@outlook.com; helo=NAM12-MW2-obe.outbound.protection.outlook.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/28 11:35:27 X-ACL-Warn: Detected OS = Windows NT kernel [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 28 May 2020 11:41:33 -0400 Cc: Morgan Smith X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) From: Morgan Smith * gnu/packages/admin.scm (opendoas): New variable. --- gnu/packages/admin.scm | 51 ++++++++++++++++++++++++++++++++++++++++++ gnu/system.scm | 1 + 2 files changed, 52 insertions(+) diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm index b0a43d9644..594ec62c1d 100644 --- a/gnu/packages/admin.scm +++ b/gnu/packages/admin.scm @@ -1389,6 +1389,57 @@ commands and their arguments.") ;; See . (license license:x11))) +(define-public opendoas + (package + (name "opendoas") + (version "6.6.1") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/Duncaen/OpenDoas.git") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "07kkc5729p654jrgfsc8zyhiwicgmq38yacmwfvay2b3gmy728zn")))) + (build-system gnu-build-system) + (arguments (let* ((target (%current-target-system)) + (compiler (if target + (string-append target "-gcc") + "gcc"))) + `(#:phases + (modify-phases %standard-phases + ;; We replace the configure phase in order to remove all the + ;; default flags. The configure script doesn't accept most + ;; of the default flags + (replace 'configure + (lambda* (#:key configure-flags #:allow-other-keys) + ;; The configure script can only be told which + ;; compiler to use through environment variables + (setenv "CC" ,compiler) + (apply invoke "./configure" configure-flags))) + (add-before 'install 'fix-makefile + (lambda* (#:key outputs #:allow-other-keys) + ;; We can't chown to root as the chroot doesn't have + ;; this user. Also the store is owned by root so this + ;; isn't necessary. + (substitute* "bsd.prog.mk" + (("^\tchown.*$") ""))))) + #:configure-flags (list (string-append "--prefix=" %output) + (string-append "--target=" (or ,target "")) + "--with-timestamp") + ;; Compiler choice is not carried over from the configure script + #:make-flags (list (string-append "CC=" ,compiler)) + ;; There are no tests provided + #:tests? #f))) + (native-inputs `(("bison" ,bison))) + (home-page "https://github.com/Duncaen/OpenDoas") + (synopsis "Portable version of OpenBSD's doas command") + (description "Doas is a minimal replacement for the venerable sudo. It was +initially written by Ted Unangst of the OpenBSD project to provide 95% of the +features of sudo with a fraction of the codebase.") + (license license:isc))) + (define-public wpa-supplicant-minimal (package (name "wpa-supplicant-minimal") diff --git a/gnu/system.scm b/gnu/system.scm index d929187695..d5fd0979a1 100644 --- a/gnu/system.scm +++ b/gnu/system.scm @@ -896,6 +896,7 @@ use 'plain-file' instead~%") (file-append inetutils "/bin/ping6") (file-append sudo "/bin/sudo") (file-append sudo "/bin/sudoedit") + (file-append opendoas "/bin/doas") (file-append fuse "/bin/fusermount") ;; To allow mounts with the "user" option, "mount" and "umount" must -- 2.26.2 From debbugs-submit-bounces@debbugs.gnu.org Thu May 28 13:57:12 2020 Received: (at submit) by debbugs.gnu.org; 28 May 2020 17:57:12 +0000 Received: from localhost ([127.0.0.1]:52973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jeMmG-0007cI-3R for submit@debbugs.gnu.org; Thu, 28 May 2020 13:57:12 -0400 Received: from lists.gnu.org ([209.51.188.17]:38620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jeMmF-0007cB-0O for submit@debbugs.gnu.org; Thu, 28 May 2020 13:57:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55126) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeMmE-0006zJ-H5 for guix-patches@gnu.org; Thu, 28 May 2020 13:57:10 -0400 Received: from tobias.gr ([2a02:c205:2020:6054::1]:35508) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeMmC-0006Zi-F9 for guix-patches@gnu.org; Thu, 28 May 2020 13:57:09 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id b59f4b3a; Thu, 28 May 2020 17:57:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc :subject:references:in-reply-to:date:message-id:mime-version :content-type; s=2018; i=me@tobias.gr; bh=N5/sAt/1TkqvD3Rq+wkkJC +dAz9Zquld5ofMl7f41t4=; b=ARZ9s/+efcRxJpVAkp7s/YnvM3dDY/8PYMX5Z8 MdRyrDGuFoyprwb+C+XC/Prja9HUjF9M+18lgLBPjq/jpj6QXSMrsRW+0+W6F7UN e0sr/qXaE0KVV4FjbpuCNCBoBDi1xtLvX51/GmbZOW34G3HwkFUtDzgCzHtyCbt1 PBfyBWsFMXBI3bjas4LygG5TRe0ivGfm/oYag0JbFVzE0qK7Nu6o4Wn06fbwhXWq a+0vqURH0Q93JUjzEcJUxuDjw+klHLzS0sgDkLiDV4iBvIaNis0FDbXYanVdjpBA xk3aFolgOHnC6eydb2nX19fiUcV+vxSp+fO/I479qSfvOpxQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 1ecea122 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Thu, 28 May 2020 17:57:06 +0000 (UTC) From: Tobias Geerinckx-Rice To: Morgan.J.Smith@outlook.com Subject: Re: [bug#41578] [PATCH] gnu: Add opendoas. References: In-reply-to: Date: Thu, 28 May 2020 19:57:03 +0200 Message-ID: <875zcg3pu8.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: 41578@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Morgan, Morgan.J.Smith@outlook.com =E5=86=99=E9=81=93=EF=BC=9A > * gnu/packages/admin.scm (opendoas): New variable. Thank you! It looks good to me. I've queued it locally with the=20 (minor) changes below, but will wait a few days for=20 to land if that's all right=20 with you. I also need to test it as a proper setuid programme. > +(define-public opendoas > + (package > + (name "opendoas") > + (version "6.6.1") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url=20 > "https://github.com/Duncaen/OpenDoas.git") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > +=20 > "07kkc5729p654jrgfsc8zyhiwicgmq38yacmwfvay2b3gmy728zn")))) > + (build-system gnu-build-system) > + (arguments (let* ((target (%current-target-system)) I've added a newline after =E2=80=98arguments=E2=80=99 to give your phases = (and=20 helpful comments) some room to breathe and keep lines from=20 exceeding 80 characters. It's mainly a matter of preference.=20 Since I'm reviewing this so you're stuck with my preference. > + (compiler (if target > + (string-append target=20 > "-gcc") > + "gcc"))) > + `(#:phases > + (modify-phases %standard-phases > + ;; We replace the configure phase in order=20 > to remove all the > + ;; default flags. The configure script=20 > doesn't accept most > + ;; of the default flags I shortened this to the last sentence and added a full stop here=E2=80=A6 > + (replace 'configure > + (lambda* (#:key configure-flags=20 > #:allow-other-keys) > + ;; The configure script can only be=20 > told which > + ;; compiler to use through environment=20 > variables =E2=80=A6and here. ;;-style comments are full sentences, unlike ;-ones. > + (add-before 'install 'fix-makefile > + (lambda* (#:key outputs=20 > #:allow-other-keys) > + ;; We can't chown to root as the=20 > chroot doesn't have > + ;; this user. Also the store is owned=20 > by root so this > + ;; isn't necessary. All true, but so common a change in Guix that it's not worth a=20 comment. > + (substitute* "bsd.prog.mk" > + (("^\tchown.*$") ""))))) Phases need to end in truth so I've added a #t here. We get away=20 without one in the previous phase because INVOKE itself is=20 guaranteed to return #t. > + #:configure-flags (list (string-append=20 > "--prefix=3D" %output) > + (string-append=20 > "--target=3D" (or ,target "")) It didn't look to me like this was used for anything, and quoting=20 Morgan on IRC: ya, the configure script really doesn't do a damn=20 thing with target. But in the future it might save someone some=20 time. > + ;; Compiler choice is not carried over from=20 > the configure script. > + #:make-flags (list (string-append "CC=3D"=20 > ,compiler)) I agree that it's nice to save future maintainers the trouble of=20 retracing your steps but don't like the idea of sleeper code.=20 I'll keep them as comments. > + ;; There are no tests provided > + #:tests? #f))) Changed to the equivalent but more conventional #:tests? #f))) ; no test suite > + (native-inputs `(("bison" ,bison))) Added a trivial newline before `. > + (home-page "https://github.com/Duncaen/OpenDoas") > + (synopsis "Portable version of OpenBSD's doas command") > + (description "Doas is a minimal replacement for the=20 > venerable sudo. It was > +initially written by Ted Unangst of the OpenBSD project to=20 > provide 95% of the > +features of sudo with a fraction of the codebase.") Thanks for including a multi-line description! Won't stop me from=20 trying to expand it some more. > + (license license:isc))) Not surprisingly, libbsd/ is under a 3-clause BSD licence. I=20 added it. > --- a/gnu/system.scm > +++ b/gnu/system.scm > @@ -896,6 +896,7 @@ use 'plain-file' instead~%") > (file-append inetutils "/bin/ping6") > (file-append sudo "/bin/sudo") > (file-append sudo "/bin/sudoedit") > + (file-append opendoas "/bin/doas") > (file-append fuse "/bin/fusermount") >=20=20 > ;; To allow mounts with the "user" option, "mount"=20 > and "umount" must This would be a separate patch. However, this would install doas=20 on almost all systems. I think the default list should contain=20 only the minimal defaults, and I don't see doas being a must-have=20 %base-package any time soon. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXs/7bwAKCRANsP+IT1Vt eTPcAQDYdGslHS5kjbGlUFnIn91e6PaL1o7ZXa64OKl3txZqDQEAqoAQQQ9pUWr/ gNuPToBQiaqCyBj6x30jhoMfVUGFSQY= =PZ67 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 28 15:32:43 2020 Received: (at submit) by debbugs.gnu.org; 28 May 2020 19:32:43 +0000 Received: from localhost ([127.0.0.1]:53103 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jeOGg-0001XV-B2 for submit@debbugs.gnu.org; Thu, 28 May 2020 15:32:43 -0400 Received: from lists.gnu.org ([209.51.188.17]:45414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jeNra-0000tY-7c for submit@debbugs.gnu.org; Thu, 28 May 2020 15:06:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36438) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeNra-0001dK-2h for guix-patches@gnu.org; Thu, 28 May 2020 15:06:46 -0400 Received: from mail-oln040092009100.outbound.protection.outlook.com ([40.92.9.100]:44356 helo=NAM04-BN3-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeNrY-0005un-A7 for guix-patches@gnu.org; Thu, 28 May 2020 15:06:45 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ow4q4FRu1urZDhrjWbMfOpby5gAV/ZIp7mfgsL9kTqzYTjHPPJUbmAfOKLi+fa5nF6qmICu6vTViHawHhldzM6KfNgZ72GRZ1M57zVYOBXyxdQz8dkwT+ClHACyP+UqYKUeIMkHwJvkHGmYCG3YHEiv0jQ205yMSpYgWPR3Z29lu1Z6hmiXnvBd7J4ugIZ03bgDA5rD2m5ISSHBsvGHWWAEcBBNqmnCi298OBgfODGnRPqvI408t+46drsjxWg0UUIoNTPbTk7yAe2xF9x9YEFIwcTQKsY5kcQ1Q+6c302ahTxiJG68FvyLFgBYWLVZejS3AJhsSA1sbsCdsuoHwJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TLOyTo6TMrJy7OwnCg4sFFbwTG/tjHF6VU3dxy2vqS0=; b=KoCRGfK39C0yApGtbhHAhhMRnA+9muVfjqY488tvRlWyjohrcIcpHn4p5iJuoGdIIKuCJpbaCzn0jZ30UU+npohV3hvEI5sKFAmH8/bjgQVQkpleND11MssnO+GA7lUB4YwddCq4CVkBL3NV8jBaBduTTgRENy/ob4YNWshlogpdzKXgTVWfPJyidxmwNc7ffWP6AkJ6AS4oRGrtQOltcB3RnHVaKzuf49ovNjcTjcHJNxAkyV9lQMjW267Jy8yqYbaDUx4IxRajaSlUPwtbBvX0J2wXCI3Nr4TZQV9ByK1Z+jROhxHxr0ijx6BBhFnc1anlt8bexqZvAN3urY+RQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=outlook.com; dmarc=pass action=none header.from=outlook.com; dkim=pass header.d=outlook.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TLOyTo6TMrJy7OwnCg4sFFbwTG/tjHF6VU3dxy2vqS0=; b=svRouHac1tbPqjMGFmp4PkRFAtuwLgfwNc8UjBskaow9dJaLcfcJvLAYAgjhbCDbB1swhXwX0WJQgqW/gDdoBRn48mUNVUKDGI665URUAa12J/rlOMNm0eu3HGPZIBRDhroVNlEFsNC8s4EBfH7HNRkBIqrdVogXjNaDCpRN4I7nmyD1SNagqLXDeXcOjTWW32/z+nVZwQuYlfS3c0hITaWGfedsP6xYIxYRloXVNWlZKieZfQWUDa83MmwoRTYuf4jNouo4Pa6IUiht6J0IadGNdwt6fMDcYha/+GZuLTAoMcOt4c0HVy/wmQdim/7PWnDiC2a3LFqSYEcfO5rNOg== Received: from CO1NAM04FT017.eop-NAM04.prod.protection.outlook.com (10.152.90.52) by CO1NAM04HT013.eop-NAM04.prod.protection.outlook.com (10.152.90.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.23; Thu, 28 May 2020 18:51:41 +0000 Received: from DM5PR1001MB2105.namprd10.prod.outlook.com (2a01:111:e400:7e4d::53) by CO1NAM04FT017.mail.protection.outlook.com (2a01:111:e400:7e4d::127) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.23 via Frontend Transport; Thu, 28 May 2020 18:51:40 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:1A96DDE97ABA2B4B272ACFBBEA76A2AE2A4C97F6B4CA4E7A0A8EF7F623BCF327; UpperCasedChecksum:8496C0A02D70AA245456747917600690CAFBCAA5371204FED106448754DCC700; SizeAsReceived:10593; Count:51 Received: from DM5PR1001MB2105.namprd10.prod.outlook.com ([fe80::d1eb:1b79:777f:92d0]) by DM5PR1001MB2105.namprd10.prod.outlook.com ([fe80::d1eb:1b79:777f:92d0%7]) with mapi id 15.20.3021.029; Thu, 28 May 2020 18:51:40 +0000 To: Tobias Geerinckx-Rice References: <875zcg3pu8.fsf@nckx> From: Morgan Smith Autocrypt: addr=Morgan.J.Smith@outlook.com; keydata= mQENBFwIaPkBCAC0ftYeut16x9zh8J7PCe+yVncNdhql5kmTPReny9l1kJ8OJRjBtgbhnS/j gImuOkSYJng4jc0PflEf+WoozLznLCHoM0DYHZwX0ThfUvgVMJ+eJEobSpX0n6A5zWdQm2NN zy05+iVNi5Bld8779kP1pLqBwbDR/Z4ohnGIrTyHjYNRa9w0xwJ6wytgiTtpgoqeRwEDA3dZ teuFD8BM4DDyFJ3Gcr1iAp9geS/PaNKNg0V2o0hGA29LVRqT7IKY9WHgXG7nWcJpL9rUlBXO G35NINYB4eAiQrR6CvJbsj6m0Vp39lMXcb5jYqLfZcXLAxKn93oP1srlpD6c0oj5avuhABEB AAG0I21vcmdhbiA8bW9yZ2FuLmouc21pdGhAb3V0bG9vay5jb20+iQFOBBMBCAA4FiEEF3oH h1HcS/5V5sbnUtk0Fu6qRaYFAlwIaPkCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQ Utk0Fu6qRabAuQf6Ahi++Fq8XmjjsIuM7K39ArSOpDBMV3kjUeJxOg9gUQKNT8k+CKI/jzd8 B0oALvM0O7yW06qHXqrkTf9XB7tM8mGP+HxHP0BAM9aL0oeq3deKN2Mt1ghhkv1r/ZbmNP+Z ZbKhDV98liZhvnDdwPLQfIGPBNpNz5RDSb55XFHEIV8Il36YYHLBVID2TzT5gWUaoqzmZn0R DCrVAoR2lqZxStoYR3g2dDZeFbJoAtyl5n2lpO5fQvNG4pbPjiPSfScKBoZLS2R+ExAjTc46 ed6na5uplzM1Hx+vGl450p4mZkzP12Jj8s0Z7x3yKJbJzbrWK2d2eu+emAuc9uJOHyqFiLkB DQRcCGj5AQgAxiMI2Atxw7TUTuIE9+AJ29zxkTfB+UUDCuc/SMx8jB6fE7HMQH1+PecQgMrX p1v1II1u13iHj2k0JiET3lBOz7Z7ZSCKnGajkamDH2rWP5au0BuM65EkeYaMQnFZgXNl0zVj SdYwrp1RlNntdy5dflDqg49uiYQZAuvQ9r7i8gBwVYc+7Chhrim2zh5sMz+tGam2CggJUe/o nxBs0WqV4v0lLxi3GEMmPzkEfDCd7KypOiNmZF5WwabtfAgivHbByyMfvqqLe5mwDkh0GPkZ VLDLEnlsdiSKgnRhSNq/RC86+AecwWeJXUuvMAXTHt+2+l7gSHTpJ0nuMtuIhQUU7wARAQAB iQE2BBgBCAAgFiEEF3oHh1HcS/5V5sbnUtk0Fu6qRaYFAlwIaPkCGwwACgkQUtk0Fu6qRaZW Twf+KU7qiZSJoAvX5HmD4ZF0hHHyUBFA9LzxSjQbD0eaFnkfKOe3iP6VQQd6bLnIMOVNVS7m AUFclFS8pa8c/Rilbi3C9T7J3JzES2S4+k3LHYDBINOc2RmeQYI/FnmupCCtcFiVC85huMAU /xAsUKRtX6uLRSkhWbkZoFjpXcnHccLZmxXVoynLChySZw6obGsWbN039Da7pdqRL+7PFpCD pmrQOKB/FARZKjbblq8GEpv1yJPvv9SxuzQpuQ56MMNMFix3gkM72+lyNs4f2hAFwExTMw2m 8xcSbieC39Erg54j96CgMCgcmxrORCcgSljZ+58UECBHsXIpRckfEugRUg== Subject: Re: [bug#41578] [PATCH] gnu: Add opendoas. Message-ID: Date: Thu, 28 May 2020 14:51:38 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 In-Reply-To: <875zcg3pu8.fsf@nckx> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: YQBPR01CA0131.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:1::31) To DM5PR1001MB2105.namprd10.prod.outlook.com (2603:10b6:4:2b::24) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.71] (70.27.158.64) by YQBPR01CA0131.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:1::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.19 via Frontend Transport; Thu, 28 May 2020 18:51:40 +0000 X-Microsoft-Original-Message-ID: X-TMN: [xWTewOPdsrlbZRvAFeJrL7bY1NRFOYfa] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 51 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: eed346ce-973b-4c80-f6d2-08d803382880 X-MS-TrafficTypeDiagnostic: CO1NAM04HT013: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TIxw+c1Obcs1t0hpQEiooIkCZ4ATPIsUfal6asljgIBG11GgU0jOqu73wgYfoBRbrNJNJx5eY1HgTujJmSqlXwrdBk8a+aRL+pgKUWpvYXGKn3JnMhMUGJ0032RS+cZnGDr5ethMBbe7bs7z7oQ96Om5v5ruJcN6P26codJrxF1jOu3l7JJMLR5vorDfGlk1K3DzBfmRtiWGjf12O0ZLceoW5bIvGbrBjm3tZgEYM1FarsGGdLDJh58inO0ARwVE X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:0; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1001MB2105.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:; DIR:OUT; SFP:1901; X-MS-Exchange-AntiSpam-MessageData: Tb2kQPWoWLTTaIW9hSYhwahlmG9a5mdRSTV3/N6Fd82n1RAuaWH8M7c6eE9bxuAVuZiM3Gl695PoxRoWJseZ866XFCJDdg3Wh8bz2uQ3VPf5y9XYf3Im1lOUwOFQIt6l3W5eb5eHj0ac54npS5fggA== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: eed346ce-973b-4c80-f6d2-08d803382880 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2020 18:51:40.8905 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1NAM04HT013 Received-SPF: pass client-ip=40.92.9.100; envelope-from=Morgan.J.Smith@outlook.com; helo=NAM04-BN3-obe.outbound.protection.outlook.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/28 15:06:43 X-ACL-Warn: Detected OS = Windows NT kernel [generic] [fuzzy] X-Spam_score_int: 2 X-Spam_score: 0.2 X-Spam_bar: / X-Spam_report: (0.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FROM=0.001, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 28 May 2020 15:32:40 -0400 Cc: 41578@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Thanks so much for the review Tobias! I went back to figure out exactly what --target did in the configure script. Now there is a bunch of logic that doesn't go anywhere so at first glance it doesn't look like this, but I'm fairly certain that all it does is check if it's Linux. If it is Linux, than it will add some cflags in the configure script. These flags never make their way out of the configure script. Honestly, the configure script is so bad I'm tempted to make a pull request. I'm a little sad I didn't get torn apart more for technical reasons. I learned that phases must end in #t and a few style points. Maybe next time I'll throw in some terrible mistakes. Also I realize that I totally forgot to put the copyright notice in! Could you throw ";;; Copyright © 2020 Morgan Smith " in there somewhere? I'm excited to get my name in this project! Thanks, Morgan On 2020-05-28 13:57, Tobias Geerinckx-Rice wrote: > Morgan, > > Morgan.J.Smith@outlook.com 写道： >> * gnu/packages/admin.scm (opendoas): New variable. > > Thank you!  It looks good to me.  I've queued it locally with the > (minor) changes below, but will wait a few days for > to land if that's all right with > you.  I also need to test it as a proper setuid programme. > >> +(define-public opendoas >> +  (package >> +    (name "opendoas") >> +    (version "6.6.1") >> +    (source (origin >> +              (method git-fetch) >> +              (uri (git-reference >> +                    (url "https://github.com/Duncaen/OpenDoas.git") >> +                    (commit (string-append "v" version)))) >> +              (file-name (git-file-name name version)) >> +              (sha256 >> +               (base32 >> + "07kkc5729p654jrgfsc8zyhiwicgmq38yacmwfvay2b3gmy728zn")))) >> +    (build-system gnu-build-system) >> +    (arguments (let* ((target (%current-target-system)) > > I've added a newline after ‘arguments’ to give your phases (and helpful > comments) some room to breathe and keep lines from exceeding 80 > characters.  It's mainly a matter of preference. Since I'm reviewing > this so you're stuck with my preference. > >> +                      (compiler (if target >> +                                    (string-append target "-gcc") >> +                                    "gcc"))) >> +                 `(#:phases >> +                   (modify-phases %standard-phases >> +                     ;; We replace the configure phase in order to >> remove all the >> +                     ;; default flags. The configure script doesn't >> accept most >> +                     ;; of the default flags > > I shortened this to the last sentence and added a full stop here… > >> +                     (replace 'configure >> +                       (lambda* (#:key configure-flags >> #:allow-other-keys) >> +                         ;; The configure script can only be told which >> +                         ;; compiler to use through environment >> variables > > …and here.  ;;-style comments are full sentences, unlike ;-ones. > >> +                     (add-before 'install 'fix-makefile >> +                       (lambda* (#:key outputs #:allow-other-keys) >> +                         ;; We can't chown to root as the chroot >> doesn't have >> +                         ;; this user. Also the store is owned by >> root so this >> +                         ;; isn't necessary. > > All true, but so common a change in Guix that it's not worth a comment. > >> +                         (substitute* "bsd.prog.mk" >> +                           (("^\tchown.*$") ""))))) > > Phases need to end in truth so I've added a #t here.  We get away > without one in the previous phase because INVOKE itself is guaranteed to > return #t. > >> +                   #:configure-flags (list (string-append "--prefix=" >> %output) >> +                                           (string-append "--target=" >> (or ,target "")) > > It didn't look to me like this was used for anything, and quoting Morgan > on IRC: > > ya, the configure script really doesn't do a damn thing > with target. But in the future it might save someone some time. > >> +                   ;; Compiler choice is not carried over from the >> configure script. >> +                   #:make-flags (list (string-append "CC=" ,compiler)) > > I agree that it's nice to save future maintainers the trouble of > retracing your steps but don't like the idea of sleeper code. I'll keep > them as comments. > >> +                   ;; There are no tests provided >> +                   #:tests? #f))) > > Changed to the equivalent but more conventional > >         #:tests? #f)))                 ; no test suite > >> +    (native-inputs `(("bison" ,bison))) > > Added a trivial newline before `. > >> +    (home-page "https://github.com/Duncaen/OpenDoas") >> +    (synopsis "Portable version of OpenBSD's doas command") >> +    (description "Doas is a minimal replacement for the venerable >> sudo.  It was >> +initially written by Ted Unangst of the OpenBSD project to provide >> 95% of the >> +features of sudo with a fraction of the codebase.") > > Thanks for including a multi-line description!  Won't stop me from > trying to expand it some more. > >> +    (license license:isc))) > > Not surprisingly, libbsd/ is under a 3-clause BSD licence.  I added it. > >> --- a/gnu/system.scm >> +++ b/gnu/system.scm >> @@ -896,6 +896,7 @@ use 'plain-file' instead~%") >>            (file-append inetutils "/bin/ping6") >>            (file-append sudo "/bin/sudo") >>            (file-append sudo "/bin/sudoedit") >> +          (file-append opendoas "/bin/doas") >>            (file-append fuse "/bin/fusermount") >>   >>            ;; To allow mounts with the "user" option, "mount" >>            and "umount" must > > This would be a separate patch.  However, this would install doas on > almost all systems.  I think the default list should contain only the > minimal defaults, and I don't see doas being a must-have %base-package > any time soon. > > Kind regards, > > T G-R From debbugs-submit-bounces@debbugs.gnu.org Sat May 30 19:57:43 2020 Received: (at 41578-done) by debbugs.gnu.org; 30 May 2020 23:57:43 +0000 Received: from localhost ([127.0.0.1]:59424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfBMF-0006aO-Js for submit@debbugs.gnu.org; Sat, 30 May 2020 19:57:43 -0400 Received: from tobias.gr ([80.241.217.52]:46338) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfBMD-0006aE-GH for 41578-done@debbugs.gnu.org; Sat, 30 May 2020 19:57:42 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id 627e5130; Sat, 30 May 2020 23:57:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc :subject:references:in-reply-to:date:message-id:mime-version :content-type; s=2018; i=me@tobias.gr; bh=aVuPFNhWJ9EzdQVxyOl2Xp rGpckUdjfpg5O9xEMklBI=; b=Db68zoLNPTXd6MCowAFP5V9jtZNTQJ23T5rEpT qzErRqJPherlXJpSOiSbpyk1lFkDRAOvQyYWpNf5FygjCl9p3/35uaEKQmY77I0L WxvrzLIIwIOifrS1TvW1uGKKOLksMWSTBDmbCm1+opt702vAKnZ+yFf/VjNCVxRO pT10in+vCOG3Zf8at4kYxlTakKDyNDGDYwnZ6ef1F0dK+Gavj4OB++h1yL0lBWaC h17gO4XYiTgEAVD0hveQEln5gxjS3G2ZJG5YsfstnzL8g4YBW1oE7lDQY1KueAjg HucVuTPdU4htlVzucFBafVBQXkxitmp6QAcCWuKJykeHu7lA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 8b7c3b48 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Sat, 30 May 2020 23:57:43 +0000 (UTC) From: Tobias Geerinckx-Rice To: Morgan Smith Subject: Re: [bug#41578] [PATCH] gnu: Add opendoas. References: <875zcg3pu8.fsf@nckx> In-reply-to: Date: Sun, 31 May 2020 01:57:38 +0200 Message-ID: <87k10tyo0d.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41578-done Cc: 41578-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Morgan, Morgan Smith =E5=86=99=E9=81=93=EF=BC=9A > I'm a little sad I didn't get torn apart more for technical=20 > reasons. I > learned that phases must end in #t and a few style points. Maybe=20 > next > time I'll throw in some terrible mistakes. Don't give up! > Also I realize that I totally forgot to put the copyright notice=20 > in! > Could you throw > ";;; Copyright =C2=A9 2020 Morgan Smith " > in there somewhere? I'm excited to get my name in this project! Well, Marius stole my thunder with your other patch, but welcome=20 aboard! Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXtLy8gAKCRANsP+IT1Vt eUvaAP9Hm7aBcR1qlXuDIN+JEFO1juBrQycKhGdNoG7jAsJqdQEA7Gp9Uh6Vwt8n /nkki1yRuFBWgHCQUu6MOGIP1km1Wg0= =LDLB -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Aug 17 09:10:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 28 Jun 2020 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator