GNU bug report logs - #41574
gnu: Add xed.

Previous Next

Full log

Message #26 received at 41574 <at> debbugs.gnu.org (full text, mbox):

From: elaexuotee <at> wilsonb.com
To: Marius Bakke <marius <at> gnu.org>
Cc: 41574 <at> debbugs.gnu.org
Subject: Re: [bug#41574] gnu: Add intel-xev.
Date: Thu, 25 Jun 2020 11:50:48 +0900

[Message part 1 (text/plain, inline)]

> Please also mention the new patch and change to local.mk in the commit
> message.

Looks like I also forgot to mention the patch itself. Thanks.

> Use the "11.2.0" tag here instead of the commit hash.

Done. As you mentioned in a follow-up email, I replaced the commit string with
the `version' token which happily happens to match the name of the version tag
we want.

> Can you add a comment about where you got that version number from?
> Also, would it make sense to package this separately?  Can be done later
> though.

I went ahead and added a comment explaining both of these decisions. The reason
for including mbuild in this way instead of packaging it separately is simply
that it seems to be a home-grown build system just for XED (I have no idea
why). There are other projects called "mbuild" and I didn't want to pollute the
package namespace unnecessarily.

> > +    (outputs '("out" "lib" "src"))
> 
> As mentioned before, the 'src' output can go.

Argh. Completely missed that. Nice catch.

> Apart from these minor issues, I think it's good to go.  \o/
> 
> Can you send an updated patch?  TIA!  :-)

Here you go!

[0001-gnu-Add-intel-xed.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.