GNU bug report logs - #41573
[PATCH Shepherd] shepherd: service: Add #:supplementary-groups.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Subject: bug#41573: closed (Re: [bug#41573] [PATCH Shepherd] shepherd:
 service: Add #:supplementary-groups.)
Date: Fri, 19 Jun 2020 07:57:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#41573: [PATCH Shepherd] shepherd: service: Add #:supplementary-groups.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 41573 <at> debbugs.gnu.org.

-- 
41573: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41573
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 41573-done <at> debbugs.gnu.org
Subject: Re: [bug#41573] [PATCH Shepherd] shepherd: service: Add
 #:supplementary-groups.
Date: Fri, 19 Jun 2020 09:56:22 +0200

[Message part 3 (text/plain, inline)]

Hi,

Oleg Pykhalov <go.wigust <at> gmail.com> skribis:

> From 20a08c750c4d6126d36835c64fed211299cb03e3 Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust <at> gmail.com>
> Date: Sun, 24 May 2020 20:30:27 +0300
> Subject: [PATCH] service: Add #:supplementary-groups.
>
> * modules/shepherd/service.scm (format-supplementary-groups): New procedure.
> (exec-command, fork+exec-command, make-forkexec-constructor): Add
> '#:supplementary-groups'.
> * doc/shepherd.texi (Service De- and Constructors): Document this.

Applied with the change below, thanks!

Ludo’.

[Message part 4 (text/x-patch, inline)]

diff --git a/doc/shepherd.texi b/doc/shepherd.texi
index 18f1a4d..696477e 100644
--- a/doc/shepherd.texi
+++ b/doc/shepherd.texi
@@ -967,7 +967,7 @@ immediately before invoking @var{command}.  @var{user} may be a string,
 indicating a user name, or a number, indicating a user ID.  Likewise,
 @var{command} will be run under the current group, unless the
 @var{group} keyword argument is present and not false, and
-supplementary-groups is not '().
+@var{supplementary-groups} is not @code{'()}.
 
 @code{fork+exec-command} does the same as @code{exec-command}, but in
 a separate process whose PID it returns.

[Message part 5 (message/rfc822, inline)]

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH Shepherd] shepherd: service: Add #:supplementary-groups.
Date: Thu, 28 May 2020 08:19:27 +0300

[Message part 6 (text/plain, inline)]

Hello Guix,

This patch provides a way to specify supplementary groups for services.
It's useful for services which could be used with a Docker group,
e.g. Jenkins.

‘shepherd’ package in Guix succeeded to build with current patch.  And I
succeeded to pull and reconfigure my Guix system with it.  Also ‘make
check’ in Shepherd's Git repository passes tests.

[0001-service-Add-supplementary-groups.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.