GNU bug report logs - #41573
[PATCH Shepherd] shepherd: service: Add #:supplementary-groups.

Previous Next

Full log

Message #11 received at 41573 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 41573 <at> debbugs.gnu.org
Subject: Re: [bug#41573] [PATCH Shepherd] shepherd: service: Add
 #:supplementary-groups.
Date: Fri, 19 Jun 2020 04:28:57 +0300

[Message part 1 (text/plain, inline)]

Hello,

Ludovic Courtès <ludo <at> gnu.org> writes:

> Oleg Pykhalov <go.wigust <at> gmail.com> skribis:
>
>> From 5718eb5f4130530b48df896d7f7e4a126e08428a Mon Sep 17 00:00:00 2001
>> From: Oleg Pykhalov <go.wigust <at> gmail.com>
>> Date: Sun, 24 May 2020 20:30:27 +0300
>> Subject: [PATCH] service: Add #:supplementary-groups.
>>
>> * modules/shepherd/service.scm (format-supplementary-groups): New procedure.
>> (exec-command, fork+exec-command, make-forkexec-constructor): Add
>> '#:supplementary-groups'.
>> * doc/shepherd.texi (Service De- and Constructors): Document this.
>
> [...]
>
>> +(define (format-supplementary-groups supplementary-groups)
>> +  (if (vector? supplementary-groups)
>> +      supplementary-groups
>> +      (list->vector (map (lambda (group) (group:gid (getgr group)))
>> +                         supplementary-groups))))
>
> Perhaps we should remove the ‘vector?’ case, no?  I find it clearer when
> the interface accepts just one single data type.

OK.

> Apart from that, it LGTM!
>
> Note that for compatibility reasons we’ll have to wait before using it
> in Guix System.

No problem.

I updated the patch and tested it again with make check and
reconfiguring my system.

[0001-service-Add-supplementary-groups.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.