From debbugs-submit-bounces@debbugs.gnu.org Wed May 27 07:26:01 2020 Received: (at submit) by debbugs.gnu.org; 27 May 2020 11:26:01 +0000 Received: from localhost ([127.0.0.1]:48391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jduC8-0001IK-U4 for submit@debbugs.gnu.org; Wed, 27 May 2020 07:26:01 -0400 Received: from lists.gnu.org ([209.51.188.17]:60056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jduC7-0001ID-6U for submit@debbugs.gnu.org; Wed, 27 May 2020 07:25:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jduC5-0001oV-UQ for guix-patches@gnu.org; Wed, 27 May 2020 07:25:58 -0400 Received: from mx.kolabnow.com ([95.128.36.41]:45992) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jduC1-0007Rn-9v for guix-patches@gnu.org; Wed, 27 May 2020 07:25:57 -0400 Received: from localhost (unknown [127.0.0.1]) by ext-mx-out002.mykolab.com (Postfix) with ESMTP id D4A36B97 for ; Wed, 27 May 2020 13:25:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freedommail.ch; h=content-transfer-encoding:content-type:content-type :mime-version:message-id:date:date:subject:subject:from:from :received:received:received; s=dkim20160331; t=1590578747; x= 1592393148; bh=C2wVRmAWMlmHiwUwBqC0pcZ5HPLk549mjeip7PCCr4o=; b=0 Zn+QgbiZR2Jak3GVeDmrB5VczRIfB9pOlpOtjOuY54EX2jaQcmurwoxuXa737XP8 8l2E46/dbnICxCHwW9dMzhqXaMeTKfesfsxvETP8xnbTL/IWUUc3WpjV/z/dmxUx VgVdg1x8enjegXzt0xVh3YJvWF8NkmZWVHJakpHVxDvShENt9Sxryd3iBbeVz1R8 EOUeQuBojPg/2BwYKjd0Z2QDalkEZR5RI7zabMx0uWGOh18vcL062gqFQ6ZJUuKR nMPz4oo1ymv+N4wNp+Wtv0b9v6sBFCt3t52nbgyMkOcbbRNOyc558Qgti0AsC4N8 n/AFqrPfLedLaQHXFSsqz5uwdUVRXce7+soQ2RG/YhzJx+tj30O+nAoNyNPX+CLY e7TzFeS+qHh0zvw0e7kPhza81BmXlGIHAn1yiPhSbIOzqZgGqNAFjaz3dLkediXq IpCBKyMVAAQUevHaiDxiXzxPmBJcnmU7rFnH4uiKdnLxnfQE8kFdT/jviY7Mxtwl lHHp7RNTeTcDpqaQH02yfjlV5aq9OqqYz6E8PLioWH6nNX82ImJhopJ5wneCj5/F ckt/gisPdeLTfROuMgEPPdLZP4RTd4+UqgQwEEdwAbUvoXzeiDRNQI9hp0nsLhDl pD0sJjAVBgf7diTz20xWOk9kjDikjzFJlOWtrt4e7M= X-Virus-Scanned: amavisd-new at mykolab.com X-Spam-Flag: NO X-Spam-Score: -1.9 X-Spam-Level: X-Spam-Status: No, score=-1.9 tagged_above=-10 required=5 tests=[BAYES_00=-1.9] autolearn=ham autolearn_force=no Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out002.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aQrr5_uySj5Y for ; Wed, 27 May 2020 13:25:47 +0200 (CEST) Received: from int-mx001.mykolab.com (unknown [10.9.13.1]) by ext-mx-out002.mykolab.com (Postfix) with ESMTPS id 3BCDD4F7 for ; Wed, 27 May 2020 13:25:47 +0200 (CEST) Received: from ext-subm001.mykolab.com (unknown [10.9.6.1]) by int-mx001.mykolab.com (Postfix) with ESMTPS id E8182B85 for ; Wed, 27 May 2020 13:25:46 +0200 (CEST) From: Tom Zander To: guix-patches@gnu.org Subject: fix tests failing on flowee package Date: Wed, 27 May 2020 13:25:45 +0200 Message-ID: <5645574.lOV4Wx5bFT@cherry> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart4602477.31r3eYUQgx" Content-Transfer-Encoding: 7Bit Received-SPF: pass client-ip=95.128.36.41; envelope-from=tomz@freedommail.ch; helo=mx.kolabnow.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/27 07:25:48 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) This is a multi-part message in MIME format. --nextPart4602477.31r3eYUQgx Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" The comment to disable it is there, but only one of the two CMake lines that enables this test was removed. So now really disable it. -- Tom Zander --nextPart4602477.31r3eYUQgx Content-Disposition: attachment; filename="0001-gnu-flowee-Disable-unpredictable-test.patch" Content-Transfer-Encoding: 7Bit Content-Type: text/x-patch; charset="UTF-8"; name="0001-gnu-flowee-Disable-unpredictable-test.patch" >From bc9a3faa045579f48804cf42f958409e51cdfbf6 Mon Sep 17 00:00:00 2001 From: TomZ Date: Wed, 27 May 2020 13:21:58 +0200 Subject: [PATCH] gnu: flowee: Disable unpredictable test. * gnu/packages/finance.scm (flowee): The test 'api' has some timeouts which fail half the time in a build, so disable the test. --- gnu/packages/finance.scm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm index f182057bb4..d176ac0660 100644 --- a/gnu/packages/finance.scm +++ b/gnu/packages/finance.scm @@ -1531,7 +1531,7 @@ like Flowee the Hub, which Fulcrum connects to over RPC.") (base32 "1vwvaxm3b71pfx8l4rrv06wqks6xdf2333w856b36s1bzvj53rhc")))) (build-system cmake-build-system) (arguments - `(#:configure-flags '("-Dbuild_tests=ON" "-Denable_gui=OFF") + `(#:configure-flags '("-Dbuild_tests=ON" "-Denable_gui=OFF" "-Denable_gui=false") #:phases (modify-phases %standard-phases (add-before 'configure 'make-qt-deterministic @@ -1546,6 +1546,8 @@ like Flowee the Hub, which Fulcrum connects to over RPC.") (lambda _ (substitute* "testing/CMakeLists.txt" (("test_api") "")) + (substitute* "testing/CMakeLists.txt" + (("add_subdirectory\\(api\\)") "")) #t)) (add-after 'configure 'set-build-info ;; Their genbuild.sh to generate a build.h fails in guix (no .git dir) . -- 2.25.1 --nextPart4602477.31r3eYUQgx-- From debbugs-submit-bounces@debbugs.gnu.org Fri May 29 09:28:13 2020 Received: (at 41562) by debbugs.gnu.org; 29 May 2020 13:28:13 +0000 Received: from localhost ([127.0.0.1]:54115 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jef3K-0002xZ-2w for submit@debbugs.gnu.org; Fri, 29 May 2020 09:28:13 -0400 Received: from mx.kolabnow.com ([95.128.36.40]:14772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jef3I-0002xD-6D for 41562@debbugs.gnu.org; Fri, 29 May 2020 09:28:01 -0400 Received: from localhost (unknown [127.0.0.1]) by ext-mx-out003.mykolab.com (Postfix) with ESMTP id D700140E97 for <41562@debbugs.gnu.org>; Fri, 29 May 2020 15:27:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freedommail.ch; h=content-transfer-encoding:content-type:content-type :mime-version:message-id:date:date:subject:subject:from:from :received:received:received; s=dkim20160331; t=1590758873; x= 1592573274; bh=WVNVZ/0zpRU/3/SlZU8yXg/DWVvFkABIeFKgELmb3NM=; b=3 lFueyeiR5AvMbe/4ku1Rn5Rj6Cm8nwgzokzSzNVmcm85ezjlSAzCrDbtgrYlqfUh Zlq24ZklsENqw/fgAaSf1N6BJZU41svclr51e1bvAZnDDQChStVry7tQk49JNey3 QobqBdv12i8ifS3+2Cxufp57kgEB965I2vgYc1qI2uvE0QKEPQ/jDMpwA8ScJdH4 hTeBNHynX08r3z6XRi3PcvQ24I1/efVbd2kY+r42ZrWSrJQQHUPlus6le3xeVANf fYkr4Ngt41wy3xdGuC+Vi7q/G98MCqeMWHB4CshPFXBqyE2rzhZsV1NeRBGSXhn+ igdS2Ta5JBe1fOBYP1kpNYhfoMApRtlYlCc8g9agItiG5KuhVCwUI7GY4+cX+esL IrmrvhxmseTeqoJ/D2bnfxifDq9+Nm3BqUoxTCFdhHt/rVaDoL7YqFn/CThkx6O+ qCkXv117cd4dwGKFY/daEtelR7MKEvSE+vUVquxshN73ZpYZTwyYAhtm3yLGTGuf mtgSe+4cwxm9NgPc7xxzt2SfeE7G93uSaUY89PSnnx12+UpmhLP71XzL+KZyXljH ou465nbpE5rihpNauvs9R3fZvNIDFjpWfETPkxJG16bN+nuu55c0ZPgNLXz4qeZ9 edW1tQQbIY7TtcPl2viPUvvLajHBAoknSb5BeRP0ro= X-Virus-Scanned: amavisd-new at mykolab.com X-Spam-Flag: NO X-Spam-Score: -1.9 X-Spam-Level: X-Spam-Status: No, score=-1.9 tagged_above=-10 required=5 tests=[BAYES_00=-1.9] autolearn=ham autolearn_force=no Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out003.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kVK2pI2QJILI for <41562@debbugs.gnu.org>; Fri, 29 May 2020 15:27:53 +0200 (CEST) Received: from int-mx001.mykolab.com (unknown [10.9.13.1]) by ext-mx-out003.mykolab.com (Postfix) with ESMTPS id 2586A40E34 for <41562@debbugs.gnu.org>; Fri, 29 May 2020 15:27:52 +0200 (CEST) Received: from ext-subm001.mykolab.com (unknown [10.9.6.1]) by int-mx001.mykolab.com (Postfix) with ESMTPS id D4F60A9C for <41562@debbugs.gnu.org>; Fri, 29 May 2020 15:27:52 +0200 (CEST) From: Tom Zander To: 41562@debbugs.gnu.org Subject: use consistent arguments. Date: Fri, 29 May 2020 15:27:49 +0200 Message-ID: <3098426.mvXUDI8C0e@cherry> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart12096636.O9o76ZdvQC" Content-Transfer-Encoding: 7Bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41562 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --nextPart12096636.O9o76ZdvQC Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" As suggested on IRC -- Tom Zander --nextPart12096636.O9o76ZdvQC Content-Disposition: attachment; filename="0001-gnu-flowee-Disable-unpredictable-test.patch" Content-Transfer-Encoding: 7Bit Content-Type: text/x-patch; charset="UTF-8"; name="0001-gnu-flowee-Disable-unpredictable-test.patch" >From bc9a3faa045579f48804cf42f958409e51cdfbf6 Mon Sep 17 00:00:00 2001 From: TomZ Date: Wed, 27 May 2020 13:21:58 +0200 Subject: [PATCH] gnu: flowee: Disable unpredictable test. * gnu/packages/finance.scm (flowee): The test 'api' has some timeouts which fail half the time in a build, so disable the test. --- gnu/packages/finance.scm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm index f182057bb4..d176ac0660 100644 --- a/gnu/packages/finance.scm +++ b/gnu/packages/finance.scm @@ -1531,7 +1531,7 @@ like Flowee the Hub, which Fulcrum connects to over RPC.") (base32 "1vwvaxm3b71pfx8l4rrv06wqks6xdf2333w856b36s1bzvj53rhc")))) (build-system cmake-build-system) (arguments - `(#:configure-flags '("-Dbuild_tests=ON" "-Denable_gui=OFF") + `(#:configure-flags '("-Dbuild_tests=ON" "-Denable_gui=OFF" "-Denable_gui=OFF") #:phases (modify-phases %standard-phases (add-before 'configure 'make-qt-deterministic @@ -1546,6 +1546,8 @@ like Flowee the Hub, which Fulcrum connects to over RPC.") (lambda _ (substitute* "testing/CMakeLists.txt" (("test_api") "")) + (substitute* "testing/CMakeLists.txt" + (("add_subdirectory\\(api\\)") "")) #t)) (add-after 'configure 'set-build-info ;; Their genbuild.sh to generate a build.h fails in guix (no .git dir) . -- 2.25.1 --nextPart12096636.O9o76ZdvQC-- From debbugs-submit-bounces@debbugs.gnu.org Fri May 29 16:56:31 2020 Received: (at 41562) by debbugs.gnu.org; 29 May 2020 20:56:31 +0000 Received: from localhost ([127.0.0.1]:56342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jem3L-00070C-CT for submit@debbugs.gnu.org; Fri, 29 May 2020 16:56:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jem3J-0006zw-PA for 41562@debbugs.gnu.org; Fri, 29 May 2020 16:56:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48457) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jem3D-0001Qj-GR; Fri, 29 May 2020 16:56:23 -0400 Received: from ti0006q161-2604.bb.online.no ([84.202.68.75]:35624 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jem3B-0008GL-VQ; Fri, 29 May 2020 16:56:22 -0400 From: Marius Bakke To: Tom Zander , 41562@debbugs.gnu.org Subject: Re: [bug#41562] use consistent arguments. In-Reply-To: <3098426.mvXUDI8C0e@cherry> References: <5645574.lOV4Wx5bFT@cherry> <3098426.mvXUDI8C0e@cherry> Date: Fri, 29 May 2020 22:56:18 +0200 Message-ID: <874kry4g0d.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41562 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Tom Zander via Guix-patches via writes: > As suggested on IRC > --=20 > Tom Zander >>>From bc9a3faa045579f48804cf42f958409e51cdfbf6 Mon Sep 17 00:00:00 2001 > From: TomZ > Date: Wed, 27 May 2020 13:21:58 +0200 > Subject: [PATCH] gnu: flowee: Disable unpredictable test. > > * gnu/packages/finance.scm (flowee): The test 'api' has some timeouts > which fail half the time in a build, so disable the test. Can you move this piece of information to a comment in the code? Also, this should say (flowee)[arguments]: ... > diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm > index f182057bb4..d176ac0660 100644 > --- a/gnu/packages/finance.scm > +++ b/gnu/packages/finance.scm > @@ -1531,7 +1531,7 @@ like Flowee the Hub, which Fulcrum connects to over= RPC.") > (base32 "1vwvaxm3b71pfx8l4rrv06wqks6xdf2333w856b36s1bzvj53rhc")= ))) > (build-system cmake-build-system) > (arguments > - `(#:configure-flags '("-Dbuild_tests=3DON" "-Denable_gui=3DOFF") > + `(#:configure-flags '("-Dbuild_tests=3DON" "-Denable_gui=3DOFF" "-D= enable_gui=3DOFF") This should probably not be here? > #:phases > (modify-phases %standard-phases > (add-before 'configure 'make-qt-deterministic > @@ -1546,6 +1546,8 @@ like Flowee the Hub, which Fulcrum connects to over= RPC.") > (lambda _ > (substitute* "testing/CMakeLists.txt" > (("test_api") "")) Can this be removed? It looks like it tries to do the same as your new substitution below. > + (substitute* "testing/CMakeLists.txt" > + (("add_subdirectory\\(api\\)") "")) > #t)) > (add-after 'configure 'set-build-info > ;; Their genbuild.sh to generate a build.h fails in guix (no= .git dir) . > --=20 > 2.25.1 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl7RdvIACgkQoqBt8qM6 VPrj0Qf/UB7zSebDzKVLzH6XTxllF8LKu5Sz6e2amsgLJ9iMRBQwQEXPLV68x/we nfS6RGZpQWmKyrgECTWKaA/bXpqFiVPSscmUKo8OqvHzMy62T8UMYsrZ8ANbela0 S3bNle2cIHwBViotsugLFvJNMJh2ecT/JcnN5CoWDa0/niMbdGWQOMPHZgOFBzG1 GlBY8d8akfOoq8p81eaP1n3JbR0MNDs2MvzFYUlQzUYJ9qjfyETfp5dHMChKt8HF AFFSlY1PFS5LxHICB5EDQw0Z0uP4jLSm8c3YpRcE1FBpXegWvAL/VoNA/ohGs3Sj q5JgHsCL7RFxKSyu8XWGYKyb2qKdjg== =5lI6 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat May 30 03:40:16 2020 Received: (at 41562) by debbugs.gnu.org; 30 May 2020 07:40:16 +0000 Received: from localhost ([127.0.0.1]:56877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jew6J-0007jz-Ml for submit@debbugs.gnu.org; Sat, 30 May 2020 03:40:15 -0400 Received: from mx.kolabnow.com ([95.128.36.40]:34438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jew6H-0007jp-FM for 41562@debbugs.gnu.org; Sat, 30 May 2020 03:40:13 -0400 Received: from localhost (unknown [127.0.0.1]) by ext-mx-out003.mykolab.com (Postfix) with ESMTP id CF9D340D57; Sat, 30 May 2020 09:40:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freedommail.ch; h=content-type:content-type:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:date :subject:subject:from:from:received:received:received; s= dkim20160331; t=1590824407; x=1592638808; bh=UuHqCx3xUEwgm9vs6eP yEBILb3kWsjBZFasqz0u08cA=; b=h8YoMEbTXUaEbDH8R2qP6ROiQFcK02gfHZX uOJvbOCLW4CPCQZt7nUcoaJdmvHdT8sMOODJNs/YqQgrOKFc3mJjrY3ozA36y1le oFgmVsSmffigVpDSKozwuDSUsYxlidG55RTqXchMJDB2NSBVk1rUC7quLkerWiCX lugws78yl3O4sFUJocYQTaH06dEIYMyclT6dBsj4ZErcvVzfgxd5ln0ogVLmu/IT gDPHXUbUOR81blMEQkvgoeoA3uMc/AuF5VIzeON2elaYicCjpUHN6RgXZdOh6NTj M8+tzpoERdw7LpX9anBG6a7Pj9I8Ufo2nQKS/A2SlIZJP492//81Ks/j6qpeiCrv rikuffm0exiekollrn2YlpT51YYZ9ipLdPOk46wpyZp+TpeTyYt7Irx7m/T+NDVm tupBYd4+BmGrWXdCyO9xPphrWohPHXBsx0NuYelu35GE3HKMbvBmybVgTS4yYXRY +vqx+ri2HXs+k/4EDHMPcPke6bsMWecz2mNrx9eFsz5pQu6E/RJ/VFQvos+LMRfP p0ZyN71sDkfpWk8XB1vTPqgWEAeRqdSdev1kqtK1f3BJq/2M8ta6zVZ+YTTcqmZl nySlZhbTM57WqO4mvWAt56+25Z0c4k3GwajVd9lcnRpLlZayplSmK/IROzU0kokp ozxy23nw= X-Virus-Scanned: amavisd-new at mykolab.com X-Spam-Flag: NO X-Spam-Score: -1.899 X-Spam-Level: X-Spam-Status: No, score=-1.899 tagged_above=-10 required=5 tests=[BAYES_00=-1.9, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out003.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id roDEirhY0ATC; Sat, 30 May 2020 09:40:07 +0200 (CEST) Received: from int-mx001.mykolab.com (unknown [10.9.13.1]) by ext-mx-out003.mykolab.com (Postfix) with ESMTPS id C9F4F40D33; Sat, 30 May 2020 09:40:06 +0200 (CEST) Received: from ext-subm001.mykolab.com (unknown [10.9.6.1]) by int-mx001.mykolab.com (Postfix) with ESMTPS id 71EA751E; Sat, 30 May 2020 09:40:06 +0200 (CEST) From: Tom Zander To: 41562@debbugs.gnu.org, Marius Bakke Subject: Re: [bug#41562] use consistent arguments. Date: Sat, 30 May 2020 09:40:04 +0200 Message-ID: <2590775.irdbgypaU6@cherry> In-Reply-To: <874kry4g0d.fsf@gnu.org> References: <5645574.lOV4Wx5bFT@cherry> <3098426.mvXUDI8C0e@cherry> <874kry4g0d.fsf@gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41562 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On vrijdag 29 mei 2020 22:56:18 CEST Marius Bakke wrote: > Tom Zander via Guix-patches via writes: > > As suggested on IRC > > > >>From bc9a3faa045579f48804cf42f958409e51cdfbf6 Mon Sep 17 00:00:00 2001 > >> > > From: TomZ > > Date: Wed, 27 May 2020 13:21:58 +0200 > > Subject: [PATCH] gnu: flowee: Disable unpredictable test. > > > > * gnu/packages/finance.scm (flowee): The test 'api' has some timeouts > > > > which fail half the time in a build, so disable the test. > > Can you move this piece of information to a comment in the code? Can you point to the file I find the code in, to add this to? In case you mean the package description, its already there. > Also, this should say (flowee)[arguments]: ... > > > diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm > > index f182057bb4..d176ac0660 100644 > > --- a/gnu/packages/finance.scm > > +++ b/gnu/packages/finance.scm > > @@ -1531,7 +1531,7 @@ like Flowee the Hub, which Fulcrum connects to over > > RPC.")> > > (base32 > > "1vwvaxm3b71pfx8l4rrv06wqks6xdf2333w856b36s1bzvj53rhc")))) > > > > (build-system cmake-build-system) > > (arguments > > > > - `(#:configure-flags '("-Dbuild_tests=ON" "-Denable_gui=OFF") > > + `(#:configure-flags '("-Dbuild_tests=ON" "-Denable_gui=OFF" > > "-Denable_gui=OFF") > This should probably not be here? Why not? > > #:phases > > > > (modify-phases %standard-phases > > > > (add-before 'configure 'make-qt-deterministic > > > > @@ -1546,6 +1546,8 @@ like Flowee the Hub, which Fulcrum connects to over > > RPC.")> > > (lambda _ > > > > (substitute* "testing/CMakeLists.txt" > > > > (("test_api") "")) > > Can this be removed? It looks like it tries to do the same as your new > substitution below. Same file, two substitutes because there are two lines that need changing. CMake blocks for 1) the actual subdir and 2) a build-dependency for 'make- check' > > + (substitute* "testing/CMakeLists.txt" > > + (("add_subdirectory\\(api\\)") "")) > > > > #t)) > > > > (add-after 'configure 'set-build-info > > > > ;; Their genbuild.sh to generate a build.h fails in guix (no > > .git dir) . -- Tom Zander From debbugs-submit-bounces@debbugs.gnu.org Sat May 30 04:07:21 2020 Received: (at 41562) by debbugs.gnu.org; 30 May 2020 08:07:21 +0000 Received: from localhost ([127.0.0.1]:56908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jewWX-0008NN-5T for submit@debbugs.gnu.org; Sat, 30 May 2020 04:07:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jewWU-0008NA-QW for 41562@debbugs.gnu.org; Sat, 30 May 2020 04:07:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58480) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jewWP-0002z1-09; Sat, 30 May 2020 04:07:13 -0400 Received: from ti0006q161-2604.bb.online.no ([84.202.68.75]:53296 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jewWO-0004q1-3A; Sat, 30 May 2020 04:07:12 -0400 From: Marius Bakke To: Tom Zander , 41562@debbugs.gnu.org Subject: Re: [bug#41562] use consistent arguments. In-Reply-To: <2590775.irdbgypaU6@cherry> References: <5645574.lOV4Wx5bFT@cherry> <3098426.mvXUDI8C0e@cherry> <874kry4g0d.fsf@gnu.org> <2590775.irdbgypaU6@cherry> Date: Sat, 30 May 2020 10:07:09 +0200 Message-ID: <87o8q53kya.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41562 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Tom Zander writes: > On vrijdag 29 mei 2020 22:56:18 CEST Marius Bakke wrote: >> Tom Zander via Guix-patches via writes: >> > As suggested on IRC >> >=20 >> >>From bc9a3faa045579f48804cf42f958409e51cdfbf6 Mon Sep 17 00:00:00 2001 >> >> >> > From: TomZ >> > Date: Wed, 27 May 2020 13:21:58 +0200 >> > Subject: [PATCH] gnu: flowee: Disable unpredictable test. >> >=20 >> > * gnu/packages/finance.scm (flowee): The test 'api' has some timeouts >> >=20 >> > which fail half the time in a build, so disable the test. >>=20 >> Can you move this piece of information to a comment in the code? > > Can you point to the file I find the code in, to add this to? > > In case you mean the package description, its already there. Oh you're right. In that case it would be clearer to change the commit message to something like "really disable the black box tests". >> Also, this should say (flowee)[arguments]: ... >>=20 >> > diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm >> > index f182057bb4..d176ac0660 100644 >> > --- a/gnu/packages/finance.scm >> > +++ b/gnu/packages/finance.scm >> > @@ -1531,7 +1531,7 @@ like Flowee the Hub, which Fulcrum connects to o= ver >> > RPC.")>=20 >> > (base32 >> > "1vwvaxm3b71pfx8l4rrv06wqks6xdf2333w856b36s1bzvj53rhc")))) >> >=20=20=20=20=20=20 >> > (build-system cmake-build-system) >> > (arguments >> >=20 >> > - `(#:configure-flags '("-Dbuild_tests=3DON" "-Denable_gui=3DOFF") >> > + `(#:configure-flags '("-Dbuild_tests=3DON" "-Denable_gui=3DOFF" >> > "-Denable_gui=3DOFF") >> This should probably not be here? > > Why not? I don't think passing -Denable_gui=3DOFF twice makes a difference. Does it? >> > #:phases >> >=20=20=20=20=20=20=20=20=20 >> > (modify-phases %standard-phases >> >=20=20=20=20=20=20=20=20=20=20 >> > (add-before 'configure 'make-qt-deterministic >> >=20 >> > @@ -1546,6 +1546,8 @@ like Flowee the Hub, which Fulcrum connects to o= ver >> > RPC.")>=20 >> > (lambda _ >> >=20=20=20=20=20=20=20=20=20=20=20=20=20=20 >> > (substitute* "testing/CMakeLists.txt" >> >=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 >> > (("test_api") "")) >>=20 >> Can this be removed? It looks like it tries to do the same as your new >> substitution below. > > Same file, two substitutes because there are two lines that need changing= .=20 > CMake blocks for 1) the actual subdir and 2) a build-dependency for 'make- > check' Makes sense, thanks for the explanation. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl7SFC0ACgkQoqBt8qM6 VPqvOQf+Jjwp3HCAFL/vUDFgqognlAd8sTnEroOFTp80GOPVoDsIWnBndb2TvtFD 1ZP3gaMDcY/gyYVntQNqBp7JdI8OeFSxWC/BbtInem2OPhZX06ocpFagatrSMv3X CfW+i+jGq15IliDyoaoYtKYy/HbxOkcSTWR+yxdeCO5/A8IlZg4VwpQDsyOhSkhy hZKpgv39fcW1gdQX59sTCvT1OZD88LYJtse8uivj9KyLwqzOqvSDbBczVZqehDPS z40iCfnkZjNyhhnrhNcAlv4JfIvqAqwCy0LpiI3AxbSWN9DtPHdy/V3MJE/4qcim /ST+O3RqTRPB2hmtkZDb2QzmIXIyxg== =H1jA -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat May 30 08:21:31 2020 Received: (at 41562) by debbugs.gnu.org; 30 May 2020 12:21:31 +0000 Received: from localhost ([127.0.0.1]:57094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jf0UV-0008Ak-L1 for submit@debbugs.gnu.org; Sat, 30 May 2020 08:21:31 -0400 Received: from mx.kolabnow.com ([95.128.36.42]:59732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jf0UT-0008AW-Og for 41562@debbugs.gnu.org; Sat, 30 May 2020 08:21:30 -0400 Received: from localhost (unknown [127.0.0.1]) by ext-mx-out002.mykolab.com (Postfix) with ESMTP id 3F8BDAB3; Sat, 30 May 2020 14:21:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freedommail.ch; h=content-transfer-encoding:content-type:content-type :mime-version:references:in-reply-to:message-id:date:date :subject:subject:from:from:received:received:received; s= dkim20160331; t=1590841282; x=1592655683; bh=FuT8RVihDz1KF1gIzmH PfOOHbwBFurk4DDFNYcvqfeA=; b=RcEVQGEj5/SmtJqBoxNMieH8RuVX0w09Uy+ +TygALnRi80IyoYkPLBl6Fs7/+1OOt4Q6b4JMUx9wqvTOLmZpC+066YCvErX+2u6 6i5k1ByuG68RaatnOHLaBhypp1kdPh+X69QdswqdZzrcYJDXHKaD9TIl42udSxkW u1isqwdsiceNhJRfHvzyVNGZawKT3sztT8dj5JAn9qHn2+ctQe+yqmKeYcS7udw1 skBPVvm9WgY4d2FH6cSaWfAmjMReu7ibBYnJzrOXJzSu59BV72CWEIFieyjMDW4O ANKrWbfqKQrTSqaATboafc0rlS1wQFBJp88o5ZJlebi25/DuR7yGFmHMMyOk2kkF wTQHaoLWrCQgQeS+kCRecPWYCN5eaCiIL6zu2Md28zoOSBxxnuFSpdXZd61fRV8s WopCEky7CVF4lIN59j4GXUbUKX7HQuWOxTeL2zZXbM2j9eJBDWUrR6KsstGJqmZs zMuqrHLk91ahI//XHlqbvoI+lZBeUaHHAuH1kZbII+BxeZKUzGKLrgvmUr4uprx2 9NTCMdEueeGUvmhUFiQkknAujXlDEjhxTeyTMM/23qipZ74SNk+or/gBYnp/NYeM HR7QVFcRPHjSz9zhKiVTa+Ifqa4fmDcgEIh+EygXQS/n6sowuWva+n2HxguTxrF6 noB0nmUU= X-Virus-Scanned: amavisd-new at mykolab.com X-Spam-Flag: NO X-Spam-Score: -1.899 X-Spam-Level: X-Spam-Status: No, score=-1.899 tagged_above=-10 required=5 tests=[BAYES_00=-1.9, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out002.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fTPy9fJJJytN; Sat, 30 May 2020 14:21:22 +0200 (CEST) Received: from int-mx001.mykolab.com (unknown [10.9.13.1]) by ext-mx-out002.mykolab.com (Postfix) with ESMTPS id 953443D8; Sat, 30 May 2020 14:21:22 +0200 (CEST) Received: from ext-subm003.mykolab.com (unknown [10.9.6.3]) by int-mx001.mykolab.com (Postfix) with ESMTPS id 43EE8A61; Sat, 30 May 2020 14:21:22 +0200 (CEST) From: Tom Zander To: 41562@debbugs.gnu.org, Marius Bakke Subject: Re: [bug#41562] use consistent arguments. Date: Sat, 30 May 2020 14:21:20 +0200 Message-ID: <3288784.e9J7NaK4W3@cherry> In-Reply-To: <87o8q53kya.fsf@gnu.org> References: <5645574.lOV4Wx5bFT@cherry> <2590775.irdbgypaU6@cherry> <87o8q53kya.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart3616986.aeNJFYEL58" Content-Transfer-Encoding: 7Bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41562 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --nextPart3616986.aeNJFYEL58 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On zaterdag 30 mei 2020 10:07:09 CEST Marius Bakke wrote: > I don't think passing -Denable_gui=OFF twice makes a difference. Does > it? LOL, yeah, you are right. It doesn't. Here is a new patch. -- Tom Zander --nextPart3616986.aeNJFYEL58 Content-Disposition: attachment; filename="0001-gnu-flowee-Really-disable-black-box-test.patch" Content-Transfer-Encoding: 7Bit Content-Type: text/x-patch; charset="UTF-8"; name="0001-gnu-flowee-Really-disable-black-box-test.patch" >From 093cb41d3dbef752b9f53ea410dc49fbba64fb95 Mon Sep 17 00:00:00 2001 From: TomZ Date: Wed, 27 May 2020 13:21:58 +0200 Subject: [PATCH] gnu: flowee: Really disable black-box test. * gnu/packages/finance.scm (flowee): The test 'api' has some timeouts which fail half the time in a build, so really disable the test. --- gnu/packages/finance.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm index f182057bb4..28789c02d7 100644 --- a/gnu/packages/finance.scm +++ b/gnu/packages/finance.scm @@ -1546,6 +1546,8 @@ like Flowee the Hub, which Fulcrum connects to over RPC.") (lambda _ (substitute* "testing/CMakeLists.txt" (("test_api") "")) + (substitute* "testing/CMakeLists.txt" + (("add_subdirectory\\(api\\)") "")) #t)) (add-after 'configure 'set-build-info ;; Their genbuild.sh to generate a build.h fails in guix (no .git dir) . -- 2.25.1 --nextPart3616986.aeNJFYEL58-- From debbugs-submit-bounces@debbugs.gnu.org Sat May 30 08:34:13 2020 Received: (at 41562-done) by debbugs.gnu.org; 30 May 2020 12:34:13 +0000 Received: from localhost ([127.0.0.1]:57111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jf0gn-0008VK-75 for submit@debbugs.gnu.org; Sat, 30 May 2020 08:34:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jf0gl-0008V8-Jj for 41562-done@debbugs.gnu.org; Sat, 30 May 2020 08:34:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33982) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jf0gf-0000sR-NT; Sat, 30 May 2020 08:34:05 -0400 Received: from ti0006q161-2604.bb.online.no ([84.202.68.75]:42688 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jf0gd-0005GH-A1; Sat, 30 May 2020 08:34:04 -0400 From: Marius Bakke To: Tom Zander , 41562-done@debbugs.gnu.org Subject: Re: [bug#41562] use consistent arguments. In-Reply-To: <3288784.e9J7NaK4W3@cherry> References: <5645574.lOV4Wx5bFT@cherry> <2590775.irdbgypaU6@cherry> <87o8q53kya.fsf@gnu.org> <3288784.e9J7NaK4W3@cherry> Date: Sat, 30 May 2020 14:34:01 +0200 Message-ID: <87y2p91u12.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41562-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Tom Zander writes: > On zaterdag 30 mei 2020 10:07:09 CEST Marius Bakke wrote: >> I don't think passing -Denable_gui=3DOFF twice makes a difference. Does >> it? > > LOL, yeah, you are right. It doesn't.=20 :-) > Here is a new patch. I fixed the missing [arguments] in the commit message and applied. Thank you! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl7SUrkACgkQoqBt8qM6 VPrB2QgAxu4S97ynQ9FBiBptf3bW+XLEWn0VqkobZM6VLI8FYHACZTYqTr7vBoMZ i2Mbn+PIWEcBAxpssyYuBb4gEYQbFhxf6UVnAAsTSYNcjaEnwFsr05FcpIyMywFp Vm2e6lZXUPJ+dyrVLhwkA+Z/oKh2BjxuKqW6RuRKd1NfTkhn/jFHrbywIiW6fti+ ZQzH2A+fFJDHNxZMCHUxJY5HQayW0O0U/4y8x0EmXHWEq3RYJhAFw2SfWzFn1PlC wjdAt2yPRDj+RNj10MY9X4moAY5fsSA+wevecEuOIDzI2AWQo0Hzql3FGMLsAM2+ d1LnDne/8vbP+grKmmm1y1Nm3TWVkg== =ZZck -----END PGP SIGNATURE----- --=-=-=-- From unknown Thu Aug 14 22:18:59 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 28 Jun 2020 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator