GNU bug report logs - #41562
fix tests failing on flowee package

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 41562 in the body.
You can then email your comments to 41562 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tom Zander <tomz <at> freedommail.ch>
To: guix-patches <at> gnu.org
Subject: fix tests failing on flowee package
Date: Wed, 27 May 2020 13:25:45 +0200

[Message part 1 (text/plain, inline)]

The comment to disable it is there, but only one of the two CMake lines that 
enables this test was removed. So now really disable it.
-- 
Tom Zander

[0001-gnu-flowee-Disable-unpredictable-test.patch (text/x-patch, attachment)]

Message #8 received at 41562 <at> debbugs.gnu.org (full text, mbox):

From: Tom Zander <tomz <at> freedommail.ch>
To: 41562 <at> debbugs.gnu.org
Subject: use consistent arguments.
Date: Fri, 29 May 2020 15:27:49 +0200

[Message part 1 (text/plain, inline)]

As suggested on IRC
-- 
Tom Zander

[0001-gnu-flowee-Disable-unpredictable-test.patch (text/x-patch, attachment)]

Message #11 received at 41562 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Tom Zander <tomz <at> freedommail.ch>, 41562 <at> debbugs.gnu.org
Subject: Re: [bug#41562] use consistent arguments.
Date: Fri, 29 May 2020 22:56:18 +0200

[Message part 1 (text/plain, inline)]

Tom Zander via Guix-patches via <guix-patches <at> gnu.org> writes:

> As suggested on IRC
> -- 
> Tom Zander
>>From bc9a3faa045579f48804cf42f958409e51cdfbf6 Mon Sep 17 00:00:00 2001
> From: TomZ <tomz <at> freedommail.ch>
> Date: Wed, 27 May 2020 13:21:58 +0200
> Subject: [PATCH] gnu: flowee: Disable unpredictable test.
>
> * gnu/packages/finance.scm (flowee): The test 'api' has some timeouts
>   which fail half the time in a build, so disable the test.

Can you move this piece of information to a comment in the code?

Also, this should say (flowee)[arguments]: ...

> diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
> index f182057bb4..d176ac0660 100644
> --- a/gnu/packages/finance.scm
> +++ b/gnu/packages/finance.scm
> @@ -1531,7 +1531,7 @@ like Flowee the Hub, which Fulcrum connects to over RPC.")
>           (base32 "1vwvaxm3b71pfx8l4rrv06wqks6xdf2333w856b36s1bzvj53rhc"))))
>      (build-system cmake-build-system)
>      (arguments
> -     `(#:configure-flags '("-Dbuild_tests=ON" "-Denable_gui=OFF")
> +     `(#:configure-flags '("-Dbuild_tests=ON" "-Denable_gui=OFF" "-Denable_gui=OFF")

This should probably not be here?

>         #:phases
>          (modify-phases %standard-phases
>            (add-before 'configure 'make-qt-deterministic
> @@ -1546,6 +1546,8 @@ like Flowee the Hub, which Fulcrum connects to over RPC.")
>              (lambda _
>                (substitute* "testing/CMakeLists.txt"
>                  (("test_api") ""))

Can this be removed?  It looks like it tries to do the same as your new
substitution below.

> +              (substitute* "testing/CMakeLists.txt"
> +                (("add_subdirectory\\(api\\)") ""))
>                #t))
>            (add-after 'configure 'set-build-info
>              ;; Their genbuild.sh to generate a build.h fails in guix (no .git dir) .
> -- 
> 2.25.1

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 41562 <at> debbugs.gnu.org (full text, mbox):

From: Tom Zander <tomz <at> freedommail.ch>
To: 41562 <at> debbugs.gnu.org, Marius Bakke <marius <at> gnu.org>
Subject: Re: [bug#41562] use consistent arguments.
Date: Sat, 30 May 2020 09:40:04 +0200

On vrijdag 29 mei 2020 22:56:18 CEST Marius Bakke wrote:
> Tom Zander via Guix-patches via <guix-patches <at> gnu.org> writes:
> > As suggested on IRC
> > 
> >>From bc9a3faa045579f48804cf42f958409e51cdfbf6 Mon Sep 17 00:00:00 2001
> >>
> > From: TomZ <tomz <at> freedommail.ch>
> > Date: Wed, 27 May 2020 13:21:58 +0200
> > Subject: [PATCH] gnu: flowee: Disable unpredictable test.
> > 
> > * gnu/packages/finance.scm (flowee): The test 'api' has some timeouts
> > 
> >   which fail half the time in a build, so disable the test.
> 
> Can you move this piece of information to a comment in the code?

Can you point to the file I find the code in, to add this to?

In case you mean the package description, its already there.

> Also, this should say (flowee)[arguments]: ...
> 
> > diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
> > index f182057bb4..d176ac0660 100644
> > --- a/gnu/packages/finance.scm
> > +++ b/gnu/packages/finance.scm
> > @@ -1531,7 +1531,7 @@ like Flowee the Hub, which Fulcrum connects to over
> > RPC.")> 
> >           (base32
> >           "1vwvaxm3b71pfx8l4rrv06wqks6xdf2333w856b36s1bzvj53rhc"))))
> >      
> >      (build-system cmake-build-system)
> >      (arguments
> > 
> > -     `(#:configure-flags '("-Dbuild_tests=ON" "-Denable_gui=OFF")
> > +     `(#:configure-flags '("-Dbuild_tests=ON" "-Denable_gui=OFF"
> > "-Denable_gui=OFF")
> This should probably not be here?

Why not?

 
> >         #:phases
> >         
> >          (modify-phases %standard-phases
> >          
> >            (add-before 'configure 'make-qt-deterministic
> > 
> > @@ -1546,6 +1546,8 @@ like Flowee the Hub, which Fulcrum connects to over
> > RPC.")> 
> >              (lambda _
> >              
> >                (substitute* "testing/CMakeLists.txt"
> >                
> >                  (("test_api") ""))
> 
> Can this be removed?  It looks like it tries to do the same as your new
> substitution below.

Same file, two substitutes because there are two lines that need changing. 
CMake blocks for 1) the actual subdir and 2) a build-dependency for 'make-
check'
 
> > +              (substitute* "testing/CMakeLists.txt"
> > +                (("add_subdirectory\\(api\\)") ""))
> > 
> >                #t))
> >            
> >            (add-after 'configure 'set-build-info
> >            
> >              ;; Their genbuild.sh to generate a build.h fails in guix (no
> >              .git dir) .


-- 
Tom Zander

Message #17 received at 41562 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Tom Zander <tomz <at> freedommail.ch>, 41562 <at> debbugs.gnu.org
Subject: Re: [bug#41562] use consistent arguments.
Date: Sat, 30 May 2020 10:07:09 +0200

[Message part 1 (text/plain, inline)]

Tom Zander <tomz <at> freedommail.ch> writes:

> On vrijdag 29 mei 2020 22:56:18 CEST Marius Bakke wrote:
>> Tom Zander via Guix-patches via <guix-patches <at> gnu.org> writes:
>> > As suggested on IRC
>> > 
>> >>From bc9a3faa045579f48804cf42f958409e51cdfbf6 Mon Sep 17 00:00:00 2001
>> >>
>> > From: TomZ <tomz <at> freedommail.ch>
>> > Date: Wed, 27 May 2020 13:21:58 +0200
>> > Subject: [PATCH] gnu: flowee: Disable unpredictable test.
>> > 
>> > * gnu/packages/finance.scm (flowee): The test 'api' has some timeouts
>> > 
>> >   which fail half the time in a build, so disable the test.
>> 
>> Can you move this piece of information to a comment in the code?
>
> Can you point to the file I find the code in, to add this to?
>
> In case you mean the package description, its already there.

Oh you're right.  In that case it would be clearer to change the commit
message to something like "really disable the black box tests".

>> Also, this should say (flowee)[arguments]: ...
>> 
>> > diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
>> > index f182057bb4..d176ac0660 100644
>> > --- a/gnu/packages/finance.scm
>> > +++ b/gnu/packages/finance.scm
>> > @@ -1531,7 +1531,7 @@ like Flowee the Hub, which Fulcrum connects to over
>> > RPC.")> 
>> >           (base32
>> >           "1vwvaxm3b71pfx8l4rrv06wqks6xdf2333w856b36s1bzvj53rhc"))))
>> >      
>> >      (build-system cmake-build-system)
>> >      (arguments
>> > 
>> > -     `(#:configure-flags '("-Dbuild_tests=ON" "-Denable_gui=OFF")
>> > +     `(#:configure-flags '("-Dbuild_tests=ON" "-Denable_gui=OFF"
>> > "-Denable_gui=OFF")
>> This should probably not be here?
>
> Why not?

I don't think passing -Denable_gui=OFF twice makes a difference.  Does
it?

>> >         #:phases
>> >         
>> >          (modify-phases %standard-phases
>> >          
>> >            (add-before 'configure 'make-qt-deterministic
>> > 
>> > @@ -1546,6 +1546,8 @@ like Flowee the Hub, which Fulcrum connects to over
>> > RPC.")> 
>> >              (lambda _
>> >              
>> >                (substitute* "testing/CMakeLists.txt"
>> >                
>> >                  (("test_api") ""))
>> 
>> Can this be removed?  It looks like it tries to do the same as your new
>> substitution below.
>
> Same file, two substitutes because there are two lines that need changing. 
> CMake blocks for 1) the actual subdir and 2) a build-dependency for 'make-
> check'

Makes sense, thanks for the explanation.

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 41562 <at> debbugs.gnu.org (full text, mbox):

From: Tom Zander <tomz <at> freedommail.ch>
To: 41562 <at> debbugs.gnu.org, Marius Bakke <marius <at> gnu.org>
Subject: Re: [bug#41562] use consistent arguments.
Date: Sat, 30 May 2020 14:21:20 +0200

[Message part 1 (text/plain, inline)]

On zaterdag 30 mei 2020 10:07:09 CEST Marius Bakke wrote:
> I don't think passing -Denable_gui=OFF twice makes a difference.  Does
> it?

LOL, yeah, you are right. It doesn't. 

Here is a new patch.
-- 
Tom Zander

[0001-gnu-flowee-Really-disable-black-box-test.patch (text/x-patch, attachment)]

Message #25 received at 41562-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Tom Zander <tomz <at> freedommail.ch>, 41562-done <at> debbugs.gnu.org
Subject: Re: [bug#41562] use consistent arguments.
Date: Sat, 30 May 2020 14:34:01 +0200

[Message part 1 (text/plain, inline)]

Tom Zander <tomz <at> freedommail.ch> writes:

> On zaterdag 30 mei 2020 10:07:09 CEST Marius Bakke wrote:
>> I don't think passing -Denable_gui=OFF twice makes a difference.  Does
>> it?
>
> LOL, yeah, you are right. It doesn't. 

:-)

> Here is a new patch.

I fixed the missing [arguments] in the commit message and applied.
Thank you!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.