GNU bug report logs - #41556
[PATCH] gnu: aegis: Update homepage link and fix build failure

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#41556: closed ([PATCH]     gnu: aegis: Update homepage link
 and fix build failure)
Date: Wed, 27 May 2020 11:35:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 27 May 2020 13:34:28 +0200
with message-id <874ks1627v.fsf <at> nckx>
and subject line Re: [bug#41556] [PATCH] gnu: aegis: Update homepage link and fix build failure
has caused the debbugs.gnu.org bug report #41556,
regarding [PATCH]     gnu: aegis: Update homepage link and fix build failure
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
41556: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=41556
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Josh Marshall <joshua.r.marshall.1991 <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Josh Marshall <joshua.r.marshall.1991 <at> gmail.com>
Subject: [PATCH]     gnu: aegis: Update homepage link and fix build failure
Date: Tue, 26 May 2020 23:12:26 -0400

    * gnu/packages/version-control.scm (aegis): Update homepage link and fix build failure
---
 gnu/packages/version-control.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 09ffd8f271..deb746db26 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -1885,7 +1885,10 @@ accessed and migrated on modern systems.")
        ("ed" ,ed)))
     (arguments
      `(#:configure-flags (list "--with-no-aegis-configured"
-                               "--sharedstatedir=/var/com/aegis")
+                               "--sharedstatedir=/var/com/aegis"
+			       ;; Uses the old 'throw()' specifier with 'new'
+			       ;; which changed in C++11.
+			       "CXXFLAGS=-std=c++03")
        #:parallel-build? #f ; There are some nasty racy rules in the Makefile.
        #:phases
        (modify-phases %standard-phases
@@ -1928,7 +1931,7 @@ accessed and migrated on modern systems.")
 
                ;; The author decided to call the check rule "sure".
                (invoke "make" "sure")))))))
-    (home-page "http://aegis.sourceforge.net")
+    (home-page "https://sourceforge.net/projects/aegis/")
     (synopsis "Project change supervisor")
     (description "Aegis is a project change supervisor, and performs some of
 the Software Configuration Management needed in a CASE environment.  Aegis
-- 
2.26.2

[Message part 3 (message/rfc822, inline)]

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Josh Marshall <joshua.r.marshall.1991 <at> gmail.com>
Cc: 41556-done <at> debbugs.gnu.org
Subject: Re: [bug#41556] [PATCH] gnu: aegis: Update homepage link and fix
 build failure
Date: Wed, 27 May 2020 13:34:28 +0200

[Message part 4 (text/plain, inline)]

Josh,

Josh Marshall 写道：
>     * gnu/packages/version-control.scm (aegis):
 ^^^^

‘git log’ adds 4 leading spaces to commit message bodies but you 
don't need to add (or, I presume, copy/paste :-) them yourself.

> Update homepage link and fix build failure

Thanks!  I've split these two unrelated changes into two commits.

SF project pages aren't goot home pages but this project looks 
very dead indeed.  Are you fixing this because you use it?

> @@ -1885,7 +1885,10 @@ accessed and migrated on modern 
> systems.")
>         ("ed" ,ed)))
>      (arguments
>       `(#:configure-flags (list "--with-no-aegis-configured"
> - 
> "--sharedstatedir=/var/com/aegis")
> + 
> "--sharedstatedir=/var/com/aegis"
> +			       ;; Uses the old 'throw()' specifier 
> with 'new'
> +			       ;; which changed in C++11.
> +			       "CXXFLAGS=-std=c++03")
   ^^^^…

It's worth running ‘guix lint’ even after trivial changes: these 
are tabs & we're a spaces family.  Changed and pushed as 
812dad08764af5ae4d80394732dcc1481742db3a et al.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.