GNU bug report logs - #41556
[PATCH] gnu: aegis: Update homepage link and fix build failure

Previous Next

Package: guix-patches;

Reported by: Josh Marshall <joshua.r.marshall.1991 <at> gmail.com>

Date: Wed, 27 May 2020 03:13:01 UTC

Severity: normal

Tags: patch

Done: Tobias Geerinckx-Rice <me <at> tobias.gr>

Bug is archived. No further changes may be made.

Full log


Message #10 received at 41556-done <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Josh Marshall <joshua.r.marshall.1991 <at> gmail.com>
Cc: 41556-done <at> debbugs.gnu.org
Subject: Re: [bug#41556] [PATCH] gnu: aegis: Update homepage link and fix
 build failure
Date: Wed, 27 May 2020 13:34:28 +0200
[Message part 1 (text/plain, inline)]
Josh,

Josh Marshall 写道:
>     * gnu/packages/version-control.scm (aegis):
 ^^^^

‘git log’ adds 4 leading spaces to commit message bodies but you 
don't need to add (or, I presume, copy/paste :-) them yourself.

> Update homepage link and fix build failure

Thanks!  I've split these two unrelated changes into two commits.

SF project pages aren't goot home pages but this project looks 
very dead indeed.  Are you fixing this because you use it?

> @@ -1885,7 +1885,10 @@ accessed and migrated on modern 
> systems.")
>         ("ed" ,ed)))
>      (arguments
>       `(#:configure-flags (list "--with-no-aegis-configured"
> - 
> "--sharedstatedir=/var/com/aegis")
> + 
> "--sharedstatedir=/var/com/aegis"
> +			       ;; Uses the old 'throw()' specifier 
> with 'new'
> +			       ;; which changed in C++11.
> +			       "CXXFLAGS=-std=c++03")
   ^^^^…

It's worth running ‘guix lint’ even after trivial changes: these 
are tabs & we're a spaces family.  Changed and pushed as 
812dad08764af5ae4d80394732dcc1481742db3a et al.

Kind regards,

T G-R
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 5 years and 80 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.